Amir-Zouerami

Amir-Zouerami

Full Stack developer.

Member Since 2 years ago

Experience Points
1
follower
Lessons Completed
1
follow
Lessons Completed
18
stars
Best Reply Awards
2
repos

39 contributions in the last year

Pinned
⚡ 🤖 A simple Script to scrape Telegram group members using Telegram API and Telethon
⚡ 🧱 A suite of React components .
Activity
Nov
21
1 week ago
Activity icon
delete
deleted time in 1 week ago
Oct
22
1 month ago
open pull request

Amir-Zouerami wants to merge rsuite/rsuite

Amir-Zouerami
Amir-Zouerami

Introduce alternate way of using RSuite in Next.js

Newer developers might run into problems trying to use RSuite in Next.js. This edit makes it more developer friendly and usable. I believe that the simple usage (compiled less) should be mentioned and will be preferred by some developers (I personally was not aware of it and spent a lot of time tuning Webpack and less-loader to get what I want).

This is just a simple suggestion from me to make the docs better.

Amir-Zouerami
Amir-Zouerami
pull request

Amir-Zouerami merge to rsuite/rsuite

Amir-Zouerami
Amir-Zouerami

Introduce alternate way of using RSuite in Next.js

Newer developers might run into problems trying to use RSuite in Next.js. This edit makes it more developer friendly and usable. I believe that the simple usage (compiled less) should be mentioned and will be preferred by some developers (I personally was not aware of it and spent a lot of time tuning Webpack and less-loader to get what I want).

This is just a simple suggestion from me to make the docs better.

open pull request

Amir-Zouerami wants to merge rsuite/rsuite

Amir-Zouerami
Amir-Zouerami

Introduce alternate way of using RSuite in Next.js

Newer developers might run into problems trying to use RSuite in Next.js. This edit makes it more developer friendly and usable. I believe that the simple usage (compiled less) should be mentioned and will be preferred by some developers (I personally was not aware of it and spent a lot of time tuning Webpack and less-loader to get what I want).

This is just a simple suggestion from me to make the docs better.

Amir-Zouerami
Amir-Zouerami

I thought the same, compiled css should be the default. I just thought you guys really liked Less for some reason because it was mentioned as the default in the docs so I did not want to change a lot. I'll fix this soon.

pull request

Amir-Zouerami merge to rsuite/rsuite

Amir-Zouerami
Amir-Zouerami

Introduce alternate way of using RSuite in Next.js

Newer developers might run into problems trying to use RSuite in Next.js. This edit makes it more developer friendly and usable. I believe that the simple usage (compiled less) should be mentioned and will be preferred by some developers (I personally was not aware of it and spent a lot of time tuning Webpack and less-loader to get what I want).

This is just a simple suggestion from me to make the docs better.

Oct
21
1 month ago
pull request

Amir-Zouerami pull request rsuite/rsuite

Amir-Zouerami
Amir-Zouerami

Introduce alternate way of using RSuite in Next.js

Newer developers might run into problems trying to use RSuite in Next.js. This edit makes it more developer friendly and usable. I believe that the simple usage (compiled less) should be mentioned and will be preferred by some developers (I personally was not aware of it and spent a lot of time tuning Webpack and less-loader to get what I want).

This is just a simple suggestion from me to make the docs better.

push

Amir-Zouerami push Amir-Zouerami/rsuite

Amir-Zouerami
Amir-Zouerami

Introduce alternate way of using RSuite in Next.js

Newer developers might run into problems trying to use RSuite in Next.js. This edit makes it more developer friendly and usable. I believe that the simple usage (compiled less) should be mentioned and will be preferred by some developers (I personally was not aware of it and spent a lot of time tuning Webpack and less-loader to get what I want).

This is just a simple suggestion from me to make the docs better.

commit sha: 2ad42e500052a46af78408a22937acdbc976a7a4

push time in 1 month ago
Activity icon
fork

Amir-Zouerami forked rsuite/rsuite

⚡ 🧱 A suite of React components .
Amir-Zouerami MIT License Updated
fork time in 1 month ago
Oct
13
1 month ago
Activity icon
issue

Amir-Zouerami issue geist-org/react

Amir-Zouerami
Amir-Zouerami

"overflow: hidden" is not removed from <body> after <Drawer> closes

Bug report 🐞

Version & Environment

  • Chrome 94 & Firefox 93
  • "@geist-ui/react": "^2.2.0",

Expected Behaviour

If I click on a link inside the <Drawer> component, I'll go to another page. Before going to another page the overflow: hidden should be automatically removed from <body> but this does not happen.

Actual results (or Errors)

Because the overflow: hidden persists on the body, the content on the next page is not scrollable and the entire app is now without scroll ability. For me, the content on the next page is stuck outside of the viewport:

https://user-images.githubusercontent.com/53701884/137165550-c7dba1bb-f888-4ab0-97ee-19c62acbf723.mp4

Hacky Solution for Now

I can manually remove the overflow by using the onClose prop on the <Drawer> component but I think it should do it automatically because it creates a lot of confusion. It took me a good amount of time to understand what was wrong.