Axnyff

Axnyff

Member Since 7 years ago

Experience Points
2
follower
Lessons Completed
0
follow
Lessons Completed
14
stars
Best Reply Awards
8
repos

1971 contributions in the last year

Pinned
⚡ mal - Make a Lisp
Activity
Oct
15
1 month ago
Activity icon
issue

Axnyff issue comment remix-run/react-router

Axnyff
Axnyff

[Bug]: Wrong proptype for from in Redirect component

What version of React Router are you using?

5.3.0

Steps to Reproduce

https://codesandbox.io/s/react-router-v5-forked-pqsli if we use an array of string as the from prop we have a warning that the propTypes is wrong. However, the code looks like it's working fine.

I've checked inside the code how computedMatch is calculated and it looks like an array won't cause any problems to it.

Expected Behavior

There should'nt be any warning if we give the component an array of string.

Actual Behavior

There is a warning if we supply an array of string.

Thanks for your help, I can write a fix for this if we agree this is an issue

Axnyff
Axnyff

Ok, thanks for the answer!

have a great day

Activity icon
issue

Axnyff issue remix-run/react-router

Axnyff
Axnyff

[Bug]: Wrong proptype for from in Redirect component

What version of React Router are you using?

5.3.0

Steps to Reproduce

https://codesandbox.io/s/react-router-v5-forked-pqsli if we use an array of string as the from prop we have a warning that the propTypes is wrong. However, the code looks like it's working fine.

I've checked inside the code how computedMatch is calculated and it looks like an array won't cause any problems to it.

Expected Behavior

There should'nt be any warning if we give the component an array of string.

Actual Behavior

There is a warning if we supply an array of string.

Thanks for your help, I can write a fix for this if we agree this is an issue