Can-Sahin

Can-Sahin

fullstack stuff, mostly with AWS

Member Since 3 years ago

Dormakaba, Zurich, Switzerland

Experience Points
38
follower
Lessons Completed
1
follow
Lessons Completed
196
stars
Best Reply Awards
9
repos

82 contributions in the last year

Pinned
⚡ :fire: Setup Create React App with React Boilerplate. Highly scalable & Best DX & Performance Focused & Best practices.
⚡ :fire: A highly scalable, offline-first foundation with the best developer experience and a focus on performance and best practices.
⚡ Server-side client of ISA Rankings (Serverless, NestJS, DynamoDB)
⚡ Web Application of ISA Rankings
Activity
Sep
16
1 month ago
Activity icon
issue

Can-Sahin issue react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

[Question] Why does this template add `.env.local` to source control?

According to the Create React App documentation, .env*.local files should not be checked into source control:

.env files should be checked into source control (with the exclusion of .env*.local).

This recommendation is also reflected in the default cra-template.

Why does react-boilerplate-cra-template add .env.local to source control? Is this not contradictory to the official CRA docs? I'm not saying it's wrong... I'm working with a team that is discussing different approaches for managing .env* files within a project, and we'd like to understand the thought process behind the design decision that was made for react-boilerplate-cra-template to determine if it is right for us.

Activity icon
issue

Can-Sahin issue comment react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

[Question] Why does this template add `.env.local` to source control?

According to the Create React App documentation, .env*.local files should not be checked into source control:

.env files should be checked into source control (with the exclusion of .env*.local).

This recommendation is also reflected in the default cra-template.

Why does react-boilerplate-cra-template add .env.local to source control? Is this not contradictory to the official CRA docs? I'm not saying it's wrong... I'm working with a team that is discussing different approaches for managing .env* files within a project, and we'd like to understand the thought process behind the design decision that was made for react-boilerplate-cra-template to determine if it is right for us.

Can-Sahin
Can-Sahin

It belongs to the template, not the local settings for this repo development. That's the catch. Just name is confusing because this is a starter template and should include all the settings initially. CRA is not a template but a bootstrap tool

Sep
7
1 month ago
Activity icon
issue

Can-Sahin issue react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

[react-i18next] Interpolation & React nodes translations

Description

Hello,

I would like to know if it's possible to use Trans Components from react-i18next because I did not succeed. (https://react.i18next.com/legacy-v9/trans-component)

I am asking to you this question because I noticed that you are not talking about it in your documentation (https://cansahin.gitbook.io/react-boilerplate-cra-template/building-blocks/i18n) and you are only using t() function.

If it's compatible with your helper yarn run extract-messages can you provide us an exemple ?

Thank you, best regards,

Versions

  • react-boilerplate-cra-template: v1.2.2
Activity icon
issue

Can-Sahin issue comment react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

[react-i18next] Interpolation & React nodes translations

Description

Hello,

I would like to know if it's possible to use Trans Components from react-i18next because I did not succeed. (https://react.i18next.com/legacy-v9/trans-component)

I am asking to you this question because I noticed that you are not talking about it in your documentation (https://cansahin.gitbook.io/react-boilerplate-cra-template/building-blocks/i18n) and you are only using t() function.

If it's compatible with your helper yarn run extract-messages can you provide us an exemple ?

Thank you, best regards,

Versions

  • react-boilerplate-cra-template: v1.2.2
Can-Sahin
Can-Sahin

It's not compatible sorry. Only the translation hooks are supported. It's fairly simple actually if you look at the code. You should modify according to your needs.

Aug
23
1 month ago
pull request

Can-Sahin pull request react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore(deps): bump dependencies

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
Activity icon
issue

Can-Sahin issue comment react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore(deps): bump dependencies

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
Can-Sahin
Can-Sahin

I am opening it back again just as a reminder to me. But for the next couple weeks, I don't have time for this repo sorry.

Activity icon
issue

Can-Sahin issue comment react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore(deps): bump dependencies

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
Can-Sahin
Can-Sahin

ok then cool. Most people think it's easy to just bump the version. I should write a list of what to verify manually even though the tests are passing. There are some checks as well, tests cannot cover everything. It has to wait a bit because I am quite busy in august. I also did a version bump commit lately. It's not super important to keep up-to-date always.

I don't remember where it's written but I remember seeing 'using ts version xxx and cra supports yyy' when you 'yarn start'. And typescript is quite problematic with CRA. Had so many issues in the past. I decided to run keep at least 3 months for typescript and core libraries like redux, react, react-dom, etc. I have been in react and the boilerplate world for 4 years and I believe it's best for the majority. Anybody can update after installation anyway.

Aug
22
1 month ago
Aug
19
1 month ago
pull request

Can-Sahin pull request react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore(deps): bump dependencies

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
Activity icon
issue

Can-Sahin issue comment react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore(deps): bump dependencies

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
Can-Sahin
Can-Sahin

This is ABSOLUTELY no go. You can't bump things to versions released only 5 hours ago. Dependency management is an extremely hard task. CRA doesn't support recent versions of typescript on top of it. You need to read every changelog and bump one by one checking if they break something. It takes hours when I do version bumps ;)

I can understand your motivation but slow down with PR, please. It's not always good to update and aggressively fix things. Maybe open an issue if you want to suggest something and we can talk before you implement it.

Read this maybe: https://github.com/react-boilerplate/react-boilerplate-cra-template/issues/131

Aug
18
1 month ago
pull request

Can-Sahin pull request International-Slackline-Association/Rankings-Backend

Can-Sahin
Can-Sahin

Bump path-parse from 1.0.6 to 1.0.7

Bumps path-parse from 1.0.6 to 1.0.7.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Aug
17
1 month ago
push

Can-Sahin push react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore: 🔧 add support of scoped package name (#145)

Сhanges simplify the code and add support for scope in the package name (e.g. @react-boilerplate/cra-template-rb)

commit sha: 9e5ec7722634c92476f7ba443140a8f77d4afab0

push time in 1 month ago
pull request

Can-Sahin pull request react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore: 🔧 add support of scoped package name

Сhanges simplify the code and add support for scope in the package name (e.g. @react-boilerplate/cra-template-rb)

I added a comment and replaced the non-obvious regex. This changes will add the ability to rename the package to scoped package in the fork and publish user's templates based on react-boilerplate-cra-template.

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
pull request

Can-Sahin merge to react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore: 🔧 add support of scoped package name

Сhanges simplify the code and add support for scope in the package name (e.g. @react-boilerplate/cra-template-rb)

I added a comment and replaced the non-obvious regex. This changes will add the ability to rename the package to scoped package in the fork and publish user's templates based on react-boilerplate-cra-template.

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
Activity icon
issue

Can-Sahin issue comment react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore: 🔧 add support of scoped package name

Сhanges simplify the code and add support for scope in the package name (e.g. @react-boilerplate/cra-template-rb)

I added a comment and replaced the non-obvious regex. This changes will add the ability to rename the package to scoped package in the fork and publish user's templates based on react-boilerplate-cra-template.

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
Can-Sahin
Can-Sahin

ok i will merge this but repeating myself again. Internal template changes should only happen with respect to a bug or to really obvious problems. They are hard to test, can vary in environments, can be forgotten in the future(coz they are not updated at all once they work) so on...

Anybody wishing to publish their own template could easily do it and I surely don't prioritize modifying the template to make this specific thing easier for instance ;)

If you want to help with the template it's definitely most appreciated. Rather than internal changes, we should focus on the real template changes. See what's new in react world, what has changed, what's better etc. I am having a hard time keeping up with this.

Aug
10
2 months ago
pull request

Can-Sahin pull request react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore: 🔧 refactor create npm package script

Сhanges simplify the code and add support for namespaces in the package name (e.g. @react-boilerplate/cra-template-rb)

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
Activity icon
issue

Can-Sahin issue comment react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore: 🔧 refactor create npm package script

Сhanges simplify the code and add support for namespaces in the package name (e.g. @react-boilerplate/cra-template-rb)

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
Can-Sahin
Can-Sahin

Thanks for the effort but these are not the things to change. It's already quite explicit what the code is there and I want to have minimal changes in internal stuff because they are already working work 1+ year and I don't have too much time to maintain new changes

open pull request

Can-Sahin wants to merge react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore: 🔧 refactor create npm package script

Сhanges simplify the code and add support for namespaces in the package name (e.g. @react-boilerplate/cra-template-rb)

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
Can-Sahin
Can-Sahin

I am really trying to ignore such coding where its NOT obvious at first. This project needs to be maintained over time and anything not explicit makes it hard for me considering that I dont have much time.

pull request

Can-Sahin merge to react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore: 🔧 refactor create npm package script

Сhanges simplify the code and add support for namespaces in the package name (e.g. @react-boilerplate/cra-template-rb)

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
Aug
9
2 months ago
pull request

Can-Sahin pull request International-Slackline-Association/Rankings-UI

Can-Sahin
Can-Sahin

Bump lodash from 4.17.11 to 4.17.21

Bumps lodash from 4.17.11 to 4.17.21.

Commits
  • f299b52 Bump to v4.17.21
  • c4847eb Improve performance of toNumber, trim and trimEnd on large input strings
  • 3469357 Prevent command injection through _.template's variable option
  • ded9bc6 Bump to v4.17.20.
  • 63150ef Documentation fixes.
  • 00f0f62 test.js: Remove trailing comma.
  • 846e434 Temporarily use a custom fork of lodash-cli.
  • 5d046f3 Re-enable Travis tests on 4.17 branch.
  • aa816b3 Remove /npm-package.
  • d7fbc52 Bump to v4.17.19
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by bnjmnt4n, a new releaser for lodash since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Aug
8
2 months ago
push

Can-Sahin push react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore: 🔧 bumped node version to 14 LTS

Can-Sahin
Can-Sahin

chore: 🔧 removed obsolete 'replace-in-file' deps

commit sha: 84abbc739796949f223edadf062a3f9b31081d30

push time in 2 months ago
push

Can-Sahin push react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

perf(deps): ⚡️remove replace-in-file from template

Remove unused template's dependency to reduce initialization time.

Can-Sahin
Can-Sahin

chore: 🔧 removed obsolete 'replace-in-file' deps

commit sha: 71801d2f342a9d64df0475bf8745fd676a11082b

push time in 2 months ago
pull request

Can-Sahin pull request react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

perf(deps): ⚡️remove replace-in-file from template

Remove unused template's dependency to reduce initialization time.

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
pull request

Can-Sahin merge to react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

perf(deps): ⚡️remove replace-in-file from template

Remove unused template's dependency to reduce initialization time.

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
Aug
7
2 months ago
push

Can-Sahin push react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore: 🔧 bumped node version to 14 LTS

Can-Sahin
Can-Sahin

chore: 🔧 bumped node version to 14 LTS in template.json

Can-Sahin
Can-Sahin

chore: 🔧 bumped node version to 14 LTS

commit sha: 9cf6e9eba202101cc8c39f1306941e87e4167962

push time in 2 months ago
pull request

Can-Sahin pull request react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore: 🔧 bumped node version to 14 LTS

Change node version to Active LTS for nvm (lts/fermium) and package(v14.15.0 or greater). https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
pull request

Can-Sahin merge to react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore: 🔧 bumped node version to 14 LTS

Change node version to Active LTS for nvm (lts/fermium) and package(v14.15.0 or greater). https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
pull request

Can-Sahin merge to react-boilerplate/react-boilerplate-cra-template

Can-Sahin
Can-Sahin

chore: 🔧 bumped node version to 14 LTS

Change node version to Active LTS for nvm (lts/fermium) and package(v14.15.0 or greater). https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md

  • You have followed our contributing guidelines
  • Double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
Can-Sahin
Can-Sahin

you have to update the 'template.json' as well

Jul
22
2 months ago
started
started time in 2 months ago
Previous