CrutchTheClutch

CrutchTheClutch

I am a recent graduate (B.Sc. in Computer Science) with a love for frontend design and full stack web development.

Member Since 5 years ago

Tech Wizards, Inc., La Plata, MD

Experience Points
18
follower
Lessons Completed
11
follow
Lessons Completed
274
stars
Best Reply Awards
44
repos

812 contributions in the last year

Pinned
⚡ A Nextjs starter project that utilizes Typescript, and Tailwind CSS
⚡ A React component library built for Vercel, designed by Clutchd.
⚡ A todo list webapp!
⚡ This repo contains all of my personal HackerRank solutions.
⚡ This repo contains all of my personal LeetCode solutions.
Activity
Dec
1
5 days ago
Nov
25
1 week ago
started
started time in 1 week ago
Nov
22
2 weeks ago
Nov
15
3 weeks ago
Nov
11
3 weeks ago
Activity icon
issue

CrutchTheClutch issue comment supabase/gotrue

CrutchTheClutch
CrutchTheClutch

Azure single tenant support - tenant name as parameter in auth endpoint

Feature request

When authenticating against AD in Azure I get the following error:

Application [My application name] is not configured as a multi-tenant application. Usage of the common endpoint is not supported for such applications created after 10-15-2018. Use a tenant-specific endpoint or configure the application to be multi-tenant.

Since I want this to be an internal-only application and all our users are in our AD in Azure, I do not want to configure this to be multi-tenant.

Describe the solution you'd like

This StackOverflow issue suggests that the endpoint needs to be specific to my application:

(...) the following line: let kAuthority = "https://login.microsoftonline.com/common" needed to be changed to: let kAuthority = "https://login.microsoftonline.com/MY_TENANT_NAME"

This endpoint configuration is found in the Azure provider API:

	Endpoint: oauth2.Endpoint{
		AuthURL:  authHost + "/common/oauth2/v2.0/authorize",
		TokenURL: authHost + "/common/oauth2/v2.0/token",
	},

I am not sure if the tenant name needs to be in one or both of these endpoints.

One way of supplying this tenant name would be to include this as a parameter in SupabaseClientOptions, and another could be to use it in the auth.signIn-method. The first seems to me a bit cleaner, while the latter would potentially more easily allow more than one tenant (not sure if that even makes sense).

Any feedback on this request would be greatly appreciated!

PS: A million thanks to the Supabase team, you are doing a fantastic job! Thank you so much for this service! :heart:

CrutchTheClutch
CrutchTheClutch

Attempted to get this started with the above draft pull request. I'm very inexperienced with golang but I think I'm heading in the right direction. I believe all we need is to allow the "common" part of the url to be replaceable with a config value (tenant id)

pull request

CrutchTheClutch pull request supabase/gotrue

CrutchTheClutch
CrutchTheClutch

adds support for azure single tenant

What kind of change does this PR introduce?

The goal is to add Azure single tenant support to supabase. I wanted to get this started as it's a big blocker for utilizing supabase for internal tools through Azure.

What is the current behavior?

Currently this feature is completely unsupported : #179

What is the new behavior?

Adds tenant_id parameter to Azure oauth provider that defaults to "common". Should support the possibility for single tenancy with Azure

Additional context

This pull request is not complete as I am very inexperienced in golang and have not had time to fully flesh this out. I was hoping this would at least help get it started!

pull request

CrutchTheClutch pull request netlify/gotrue

CrutchTheClutch
CrutchTheClutch

Azure single tenant support

- Summary

This pull request is not complete as I am very inexperienced in golang and have not had time to fully flesh this out. But, I wanted to get it started as it's a big blocker for utilizing supabase for internal tools through Azure.

- Test plan

N/A - Incomplete pull request

- Description for the changelog

Adds tenant_id parameter to azure oauth provider that defaults to "common". Should support the possibility for single tenancy with azure

- A picture of a cute animal (not mandatory but encouraged)

Activity icon
issue

CrutchTheClutch issue comment netlify/gotrue

CrutchTheClutch
CrutchTheClutch

Azure single tenant support

- Summary

This pull request is not complete as I am very inexperienced in golang and have not had time to fully flesh this out. But, I wanted to get it started as it's a big blocker for utilizing supabase for internal tools through Azure.

- Test plan

N/A - Incomplete pull request

- Description for the changelog

Adds tenant_id parameter to azure oauth provider that defaults to "common". Should support the possibility for single tenancy with azure

- A picture of a cute animal (not mandatory but encouraged)

CrutchTheClutch
CrutchTheClutch

Well, I feel silly! I meant to merge this into https://github.com/supabase/gotrue 😅 Apologies!

pull request

CrutchTheClutch pull request netlify/gotrue

CrutchTheClutch
CrutchTheClutch

Azure single tenant support

- Summary

This pull request is not complete as I am very inexperienced in golang and have not had time to fully flesh this out. But, I wanted to get it started as it's a big blocker for utilizing supabase for internal tools through Azure.

- Test plan

N/A - Incomplete pull request

- Description for the changelog

Adds tenant_id parameter to azure oauth provider that defaults to "common". Should support the possibility for single tenancy with azure

- A picture of a cute animal (not mandatory but encouraged)

Activity icon
created branch

CrutchTheClutch in city-mechanical/gotrue create branch azure-single-tenant

createdAt 3 weeks ago
Nov
10
3 weeks ago
Activity icon
issue

CrutchTheClutch issue comment supabase/gotrue

CrutchTheClutch
CrutchTheClutch

Azure single tenant support - tenant name as parameter in auth endpoint

Feature request

When authenticating against AD in Azure I get the following error:

Application [My application name] is not configured as a multi-tenant application. Usage of the common endpoint is not supported for such applications created after 10-15-2018. Use a tenant-specific endpoint or configure the application to be multi-tenant.

Since I want this to be an internal-only application and all our users are in our AD in Azure, I do not want to configure this to be multi-tenant.

Describe the solution you'd like

This StackOverflow issue suggests that the endpoint needs to be specific to my application:

(...) the following line: let kAuthority = "https://login.microsoftonline.com/common" needed to be changed to: let kAuthority = "https://login.microsoftonline.com/MY_TENANT_NAME"

This endpoint configuration is found in the Azure provider API:

	Endpoint: oauth2.Endpoint{
		AuthURL:  authHost + "/common/oauth2/v2.0/authorize",
		TokenURL: authHost + "/common/oauth2/v2.0/token",
	},

I am not sure if the tenant name needs to be in one or both of these endpoints.

One way of supplying this tenant name would be to include this as a parameter in SupabaseClientOptions, and another could be to use it in the auth.signIn-method. The first seems to me a bit cleaner, while the latter would potentially more easily allow more than one tenant (not sure if that even makes sense).

Any feedback on this request would be greatly appreciated!

PS: A million thanks to the Supabase team, you are doing a fantastic job! Thank you so much for this service! :heart:

CrutchTheClutch
CrutchTheClutch

Any progress on this? Would love to start using supabase but this is currently a blocker for my organization. Any way around this?

Oct
20
1 month ago
Oct
18
1 month ago
Oct
6
2 months ago
pull request

CrutchTheClutch pull request Airtable/airtable.js

CrutchTheClutch
CrutchTheClutch

Remove attachment requirements for typescript

Related to #277

push

CrutchTheClutch push CrutchTheClutch/airtable.js

CrutchTheClutch
CrutchTheClutch

Remove attachment requirements for typescript

Related to #277

commit sha: 43c0fdff6e5e66617aa45ccd257ee352e7f91c11

push time in 1 month ago
Activity icon
fork

CrutchTheClutch forked Airtable/airtable.js

⚡ Airtable javascript client
CrutchTheClutch MIT License Updated
fork time in 1 month ago
started
started time in 2 months ago
Oct
3
2 months ago
push

CrutchTheClutch push city-mechanical/city-mechanical-website

CrutchTheClutch
CrutchTheClutch

Revert "Bump bootstrap from 4.4.1 to 5.1.1"

This reverts commit 4ca79795370487c69f9f4e462a87ee1f90845ad6.

CrutchTheClutch
CrutchTheClutch
CrutchTheClutch
CrutchTheClutch

Merge pull request #65 from city-mechanical/dev

Update Employee Titles

commit sha: 3c18d6d102d5ed20ad07a4e1b8394d8ae9df5265

push time in 2 months ago
push

CrutchTheClutch push city-mechanical/city-mechanical-website

CrutchTheClutch
CrutchTheClutch

Revert "Bump bootstrap from 4.4.1 to 5.1.1"

This reverts commit 4ca79795370487c69f9f4e462a87ee1f90845ad6.

commit sha: 0412c652f41d5ed951c9d94b66767b94821b3ba7

push time in 2 months ago
push

CrutchTheClutch push city-mechanical/city-mechanical-website

CrutchTheClutch
CrutchTheClutch

Revert "Merge branch 'dev'"

This reverts commit 32ecedc22007da87b54a6865a7605b9606a10a67.

commit sha: bebab214dca3d60a7e284205c7b4affdec6c283f

push time in 2 months ago
Previous