Daniel-K-Ivanov

Daniel-K-Ivanov

Blockchain Solutions Architect @ LimeChain

Member Since 6 years ago

Sofia, Bulgaria

Experience Points
18
follower
Lessons Completed
4
follow
Lessons Completed
7
stars
Best Reply Awards
22
repos

1228 contributions in the last year

Pinned
⚡ Repository containing a reference implementation of the ERC721 Consumer extension
⚡ Hedera Services - crypto, consensus services, files & smart contract
⚡ Framework for building AssemblyScript Substrate Runtimes
⚡ AssemblyScript implementation of the SCALE codec used in the Parity Substrate framework.
Activity
Jan
24
16 hours ago
Activity icon
issue

Daniel-K-Ivanov issue EnterDAO/ENTER-DAO-GOV-YF-Frontend

Daniel-K-Ivanov
Daniel-K-Ivanov

Add APY for LandWorks NFTs

Show the APY in the LandWorks YF tile and in the details (when clicking Deposit) The APY should be calculated based on the number of parcels in the LandWorks NFT and the floor price of LAND/ESTATE. Use the computeAmount method in the LandWorksDecentralandYieldFarming

Activity icon
issue

Daniel-K-Ivanov issue EnterDAO/ENTER-DAO-GOV-YF-Frontend

Daniel-K-Ivanov
Daniel-K-Ivanov

The list with NFTs is broken

Notice that there are gray lines in the bottom and the right of the component. They should not be there image

pull request

Daniel-K-Ivanov merge to hashgraph/hethers.js

Daniel-K-Ivanov
Daniel-K-Ivanov

Feature/implement verify message

Description:

  • add verifyMessage method in the Wallet class, and remove that outside class

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)
pull request

Daniel-K-Ivanov merge to hashgraph/hethers.js

Daniel-K-Ivanov
Daniel-K-Ivanov

Feature/implement verify message

Description:

  • add verifyMessage method in the Wallet class, and remove that outside class

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)
Daniel-K-Ivanov
Daniel-K-Ivanov
open pull request

Daniel-K-Ivanov wants to merge hashgraph/hethers.js

Daniel-K-Ivanov
Daniel-K-Ivanov

`LocalCall` v2

Description:

This PR provides implementation of the signer.call method in the Wallet class. Added:

  • getHederaClient() in provider
  • call() in Wallet

Deprecated call in abstract signer - now throws

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)
Daniel-K-Ivanov
Daniel-K-Ivanov
open pull request

Daniel-K-Ivanov wants to merge hashgraph/hethers.js

Daniel-K-Ivanov
Daniel-K-Ivanov

`LocalCall` v2

Description:

This PR provides implementation of the signer.call method in the Wallet class. Added:

  • getHederaClient() in provider
  • call() in Wallet

Deprecated call in abstract signer - now throws

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)
Daniel-K-Ivanov
Daniel-K-Ivanov

AccountLike can be:

0x0000000000000000000000000000000000000001
 0.0.1
 Account{shard:0, realm:0, num: 1}

From what I see, if someone sends adsas as string you are going to return that directly. I think that we should

  • parse the string to account in order to verify that it is indeed account
  • if it is not string, verify that it is Account object and only then return the shard, realm and num
  • If it is not account nor string, throw unsupported error?
open pull request

Daniel-K-Ivanov wants to merge hashgraph/hethers.js

Daniel-K-Ivanov
Daniel-K-Ivanov

`LocalCall` v2

Description:

This PR provides implementation of the signer.call method in the Wallet class. Added:

  • getHederaClient() in provider
  • call() in Wallet

Deprecated call in abstract signer - now throws

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)
Daniel-K-Ivanov
Daniel-K-Ivanov

can't we use this.account instead of the getAddress promise?

open pull request

Daniel-K-Ivanov wants to merge hashgraph/hethers.js

Daniel-K-Ivanov
Daniel-K-Ivanov

`LocalCall` v2

Description:

This PR provides implementation of the signer.call method in the Wallet class. Added:

  • getHederaClient() in provider
  • call() in Wallet

Deprecated call in abstract signer - now throws

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)
Daniel-K-Ivanov
Daniel-K-Ivanov

Shouldn't we place this logic inside the signer in order to have the same interface as ethers?

open pull request

Daniel-K-Ivanov wants to merge hashgraph/hethers.js

Daniel-K-Ivanov
Daniel-K-Ivanov

`LocalCall` v2

Description:

This PR provides implementation of the signer.call method in the Wallet class. Added:

  • getHederaClient() in provider
  • call() in Wallet

Deprecated call in abstract signer - now throws

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)
Daniel-K-Ivanov
Daniel-K-Ivanov

This was alredy implemented and merged in the develop branch. It seems that you are reverting the change with this PR

open pull request

Daniel-K-Ivanov wants to merge hashgraph/hethers.js

Daniel-K-Ivanov
Daniel-K-Ivanov

`LocalCall` v2

Description:

This PR provides implementation of the signer.call method in the Wallet class. Added:

  • getHederaClient() in provider
  • call() in Wallet

Deprecated call in abstract signer - now throws

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)
Daniel-K-Ivanov
Daniel-K-Ivanov

contract.example does not seem clean like provider or wallet examples

open pull request

Daniel-K-Ivanov wants to merge hashgraph/hethers.js

Daniel-K-Ivanov
Daniel-K-Ivanov

`LocalCall` v2

Description:

This PR provides implementation of the signer.call method in the Wallet class. Added:

  • getHederaClient() in provider
  • call() in Wallet

Deprecated call in abstract signer - now throws

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)
Daniel-K-Ivanov
Daniel-K-Ivanov

Lets delete this commented code

open pull request

Daniel-K-Ivanov wants to merge hashgraph/hethers.js

Daniel-K-Ivanov
Daniel-K-Ivanov

`LocalCall` v2

Description:

This PR provides implementation of the signer.call method in the Wallet class. Added:

  • getHederaClient() in provider
  • call() in Wallet

Deprecated call in abstract signer - now throws

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)
Daniel-K-Ivanov
Daniel-K-Ivanov

I think that we should revert this code change right?

open pull request

Daniel-K-Ivanov wants to merge hashgraph/hethers.js

Daniel-K-Ivanov
Daniel-K-Ivanov

`LocalCall` v2

Description:

This PR provides implementation of the signer.call method in the Wallet class. Added:

  • getHederaClient() in provider
  • call() in Wallet

Deprecated call in abstract signer - now throws

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)
Daniel-K-Ivanov
Daniel-K-Ivanov

This should be defined in the signer abstraction and not the wallet

pull request

Daniel-K-Ivanov merge to hashgraph/hethers.js

Daniel-K-Ivanov
Daniel-K-Ivanov

`LocalCall` v2

Description:

This PR provides implementation of the signer.call method in the Wallet class. Added:

  • getHederaClient() in provider
  • call() in Wallet

Deprecated call in abstract signer - now throws

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)
pull request

Daniel-K-Ivanov merge to hashgraph/hethers.js

Daniel-K-Ivanov
Daniel-K-Ivanov

`LocalCall` v2

Description:

This PR provides implementation of the signer.call method in the Wallet class. Added:

  • getHederaClient() in provider
  • call() in Wallet

Deprecated call in abstract signer - now throws

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)
pull request

Daniel-K-Ivanov merge to hashgraph/hethers.js

Daniel-K-Ivanov
Daniel-K-Ivanov

Feature/implement verify message

Description:

  • add verifyMessage method in the Wallet class, and remove that outside class

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)
Daniel-K-Ivanov
Daniel-K-Ivanov
pull request

Daniel-K-Ivanov merge to hashgraph/hethers.js

Daniel-K-Ivanov
Daniel-K-Ivanov

Feature/Wallet getChainId method

Description:

  • Add Wallet.getChainId method

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)
pull request

Daniel-K-Ivanov pull request LimeChain/hedera-services

Daniel-K-Ivanov
Daniel-K-Ivanov

Refactoring of `ScheduleCreateTransitionLogic`

Description:

This PR provides several improvements to the Schedule service. Introduced:

  • ScheduleModelStore - a store, which interacts with the schedules MerkleMap.
  • Schedule - model schedule, encapsulating all the properties of a MerkleSchedule, as well as the business loggic executed upon it.
  • ScheduleConversion - utility class, responsible of mapping properties between MerkleSchedule and Schedule model

Notable changes on:

  • TransitionRunner
  • SignatoryUtils
  • ScheduleSignTransitionLogic - this transition logic is already being refactored in TODO PR LINK

Progress so far: schedules_e2e

Unit tests are being created for:

  • ScheduleStore
  • ScheduleConversion

Checklist:

  • No failing E2E
  • Unit tests with no less coverage than the previous implementation
  • Documented
pull request

Daniel-K-Ivanov pull request LimeChain/hedera-services

Daniel-K-Ivanov
Daniel-K-Ivanov

Refactoring: Scheduled Sign

The Scheduled Sign Transition Logic refactoring concluded in using the new refactored infrastructure, along with the Schedule model class. Unit tests were updated. E2E tests are passing.

Signed-off-by: Georgi Yazovaliyski [email protected]

pull request

Daniel-K-Ivanov pull request LimeChain/hedera-services

Daniel-K-Ivanov
Daniel-K-Ivanov

Refactoring: Scheduled Delete

The Scheduled Delete Transition Logic refactoring concluded in using the new refactored infrastructure, along with the Schedule model class. Unit tests were updated. E2E tests are passing.

Signed-off-by: Georgi Yazovaliyski [email protected]

Activity icon
issue

Daniel-K-Ivanov issue LimeChain/hedera-services

Daniel-K-Ivanov
Daniel-K-Ivanov

Add GitHub Actions CI/CD

Add GitHub Actions so that we are building and running Unit Test coverage against PR

IMPORTANT: We must not change the source code of hedera-services

GitHub Actions for running code cov & E2E is desired by Hedera Services as well. They want to migrate to GitHub actions

Activity icon
issue

Daniel-K-Ivanov issue LimeChain/hedera-services

Daniel-K-Ivanov
Daniel-K-Ivanov

File Service [Refactoring]

This Epic consists of the refactoring effort for the Hedera File service operations - Create, Update, Delete, Append, SysDel, SysUndel

Activity icon
issue

Daniel-K-Ivanov issue LimeChain/hedera-services

Daniel-K-Ivanov
Daniel-K-Ivanov

Crypto Service [Refactoring]

Refactoring of the Hedera Ledger. Additional information on the refactoring plan and process: https://www.notion.so/limechain/HederaLedger-Refactoring-Potential-Issues-and-Their-Solvability-459299a5855d420fb8f9a57db32ba8d8

Previous