Merge branch 'latest' into WSTEAM1-49-recommendation-translations
Pinned
Activity
DarioR01 in bbc/simorgh delete branch WSTEAM1-49-recommendation-translations
DarioR01 push bbc/simorgh
commit sha: fb72885888ff983bcbda83bbed9b15b8eb13b77b
push time in 1 hour agoDarioR01 pull request bbc/simorgh
Replace Translations For Recommendation Title
Resolves WSTEAM1-49
Overall change: Replace translations for recommendation titles in:
- Mundo
- Brazil
- Turkish
- Arabic
Adds recommendation titles' translation in:
- Russian
- Indonesian
- Persian
- Thai
Code changes:
- Updated service files
- I have assigned myself to this PR and the corresponding issues
- I have added the
cross-team
label to this PR if it requires visibility across World Service teams - I have assigned this PR to the Simorgh project
- (BBC contributors only) This PR follows the repository use guidelines
Testing:
- Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
- If necessary, I have run the local E2E non-smoke tests relevant to my changes (
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive
) - This PR requires manual testing
DarioR01 push bbc/simorgh
commit sha: f4094357939d93dd68cc1176664e5eeced7e5c01
push time in 1 hour agoDarioR01 push bbc/simorgh
commit sha: f0f6c727fb0a2f8ad4d91c453b40720ede5b5d1d
push time in 21 hours agoDarioR01 push bbc/simorgh
commit sha: bffadb63d2f929b63d5edb57045a8b90b7713c53
push time in 22 hours agoDarioR01 pull request bbc/simorgh
Remove Line From Recommendation Label On Mobile Breakpoints
Resolves #NUMBER
Overall change: A very high-level summary of easily-reproducible changes that can be understood by non-devs.
Code changes:
- A bullet point list of key code changes that have been made.
- When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.
- I have assigned myself to this PR and the corresponding issues
- I have added the
cross-team
label to this PR if it requires visibility across World Service teams - I have assigned this PR to the Simorgh project
- (BBC contributors only) This PR follows the repository use guidelines
Testing:
- Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
- If necessary, I have run the local E2E non-smoke tests relevant to my changes (
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive
) - This PR requires manual testing
DarioR01 in bbc/simorgh create branch WSTEAM1-68-mobile-recommendation-line
DarioR01 push bbc/simorgh
commit sha: 3d9fd70604345537632d29e837e3ebb82c4d5c2c
push time in 22 hours agoDarioR01 push bbc/simorgh
commit sha: f519632a1f55cc3a0052837e71a30e67e0417238
push time in 22 hours agoDarioR01 pull request bbc/simorgh
Replace Translations For Recommendation Title
Resolves #NUMBER
Overall change: Replace translations for recommendation titles in:
- Mundo
- Brazil
- Turkish
- Arabic
Adds recommendation titles' translation for:
- Russian
- Indonesian
- Persian
- Thai
Code changes:
- Updated service files
- I have assigned myself to this PR and the corresponding issues
- I have added the
cross-team
label to this PR if it requires visibility across World Service teams - I have assigned this PR to the Simorgh project
- (BBC contributors only) This PR follows the repository use guidelines
Testing:
- Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
- If necessary, I have run the local E2E non-smoke tests relevant to my changes (
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive
) - This PR requires manual testing
DarioR01 in bbc/simorgh create branch WSTEAM1-49-recommendation-translations
DarioR01 push bbc/simorgh
commit sha: 638f52bb476a04eaf0d4c88a930abcaaaf80f93e
push time in 1 day agoDarioR01 push bbc/simorgh
commit sha: 541752541a7b05ea659897dcf6cc55b69e819d46
push time in 1 day agoDarioR01 pull request bbc/simorgh
Add unique identifier to Bulletin aria-labelledby
Overall change: Includes unique variable for aria ID's as part of talkback bug fix.
Code changes:
- A bullet point list of key code changes that have been made.
- When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.
- I have assigned myself to this PR and the corresponding issues
- I have added the
cross-team
label to this PR if it requires visibility across World Service teams - I have assigned this PR to the Simorgh project
- (BBC contributors only) This PR follows the repository use guidelines
Testing:
- Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
- If necessary, I have run the local E2E non-smoke tests relevant to my changes (
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive
) - This PR requires manual testing
DarioR01 push bbc/simorgh
commit sha: c2960a6f4a1a1c2c198e35cae57a0f84eeac5543
push time in 1 day agoDarioR01 merge to bbc/simorgh
Add unique identifier to Bulletin aria-labelledby
Overall change: Includes unique variable for aria ID's as part of talkback bug fix.
Code changes:
- A bullet point list of key code changes that have been made.
- When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.
- I have assigned myself to this PR and the corresponding issues
- I have added the
cross-team
label to this PR if it requires visibility across World Service teams - I have assigned this PR to the Simorgh project
- (BBC contributors only) This PR follows the repository use guidelines
Testing:
- Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
- If necessary, I have run the local E2E non-smoke tests relevant to my changes (
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive
) - This PR requires manual testing
DarioR01 pull request bbc/simorgh
fix: webpack bundle size
Resolves #NUMBER
Overall change: A very high-level summary of easily-reproducible changes that can be understood by non-devs.
Code changes:
- A bullet point list of key code changes that have been made.
- When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.
- I have assigned myself to this PR and the corresponding issues
- I have added the
cross-team
label to this PR if it requires visibility across World Service teams - I have assigned this PR to the Simorgh project
- (BBC contributors only) This PR follows the repository use guidelines
Testing:
- Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
- If necessary, I have run the local E2E non-smoke tests relevant to my changes (
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive
) - This PR requires manual testing
DarioR01 in bbc/simorgh delete branch WSTEAMA-51-Psammead-Migration-Webpack
DarioR01 in bbc/simorgh create branch WSTEAMA-51-psammead-migration-webpack
DarioR01 push bbc/simorgh
commit sha: 4fddbb7add3ad455b04eff14e106556ccbe60db0
push time in 2 days agoDarioR01 in bbc/simorgh create branch WSTEAMA-51-Psammead-Migration-Webpack
DarioR01 in bbc/simorgh delete branch WSTEAMA-51-Psammead-Migration-Webpack
DarioR01 pull request bbc/simorgh
Wsteama 51 psammead migration webpack
Resolves #NUMBER
Overall change: A very high-level summary of easily-reproducible changes that can be understood by non-devs.
Code changes:
- A bullet point list of key code changes that have been made.
- When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.
- I have assigned myself to this PR and the corresponding issues
- I have added the
cross-team
label to this PR if it requires visibility across World Service teams - I have assigned this PR to the Simorgh project
- (BBC contributors only) This PR follows the repository use guidelines
Testing:
- Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
- If necessary, I have run the local E2E non-smoke tests relevant to my changes (
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive
) - This PR requires manual testing
DarioR01 pull request bbc/simorgh
Wsteama 51 psammead migration webpack
Resolves #NUMBER
Overall change: A very high-level summary of easily-reproducible changes that can be understood by non-devs.
Code changes:
- A bullet point list of key code changes that have been made.
- When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.
- I have assigned myself to this PR and the corresponding issues
- I have added the
cross-team
label to this PR if it requires visibility across World Service teams - I have assigned this PR to the Simorgh project
- (BBC contributors only) This PR follows the repository use guidelines
Testing:
- Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
- If necessary, I have run the local E2E non-smoke tests relevant to my changes (
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive
) - This PR requires manual testing
DarioR01 in bbc/simorgh create branch WSTEAMA-51-Psammead-Migration-Webpack
DarioR01 push bbc/simorgh
commit sha: a06ca9421c88dd62cdd29a195c0d31bfa9bb68ee
push time in 2 days agoDarioR01 push bbc/simorgh
commit sha: 12502b9bb49b06e7e65b1232f0bd056393ce5768
push time in 5 days agoDarioR01 push bbc/simorgh
commit sha: ff7de15fc6253e408a789e354f87466946b4df68
push time in 5 days ago
feat: Replace Translations For Recommendation Title