DavidIAm

DavidIAm

Member Since 10 years ago

Rocket Partners, Columbus, OH

Experience Points
21
follower
Lessons Completed
9
follow
Lessons Completed
9
stars
Best Reply Awards
43
repos

27 contributions in the last year

Pinned
⚡ Perl implimentation of Replay idea
⚡ Perl module for testing REST style integrations
⚡ Perl module for fast-loadable and O(log n) Segment tree lookup
⚡ JSON Schema validator
⚡ Helps me test the replay service
⚡ Sinatra inspired web development framework for node.js -- insanely fast, flexible, and simple
Activity
Jan
14
1 week ago
Activity icon
issue

DavidIAm issue comment facebook/create-react-app

DavidIAm
DavidIAm

yarn build failed with a fresh created react ts app

Describe the bug

After creating a fresh new app using yarn create react-app my-app --template typescript the build process failed with an error from my_project/node_modules/react-scripts/config/webpack.config.js:664

Based on last releases of all componants inside node 16.13.0

Error is:

yarn build
yarn run v1.22.17
$ react-scripts build
/workspace/my_app/node_modules/react-scripts/config/webpack.config.js:664
        new MiniCssExtractPlugin({
        ^

TypeError: MiniCssExtractPlugin is not a constructor
    at module.exports (/workspace/my_app//node_modules/react-scripts/config/webpack.config.js:664:9)
    at Object.<anonymous> (/workspace/my_app/node_modules/react-scripts/scripts/build.js:58:16)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Did you try recovering your dependencies?

Yes, getting de fresh project from git or from scratch, see "Steps to reproduce"

Environment

  • Gitpod
  • Node 16.13.0

Steps to reproduce

Easy to reproduce craete a fresh new project like this :

yarn create react-app my-app --template typescript
cd my-app
yarn install
yarn build

Using yarn start, the dev mode is working fine.

Expected behavior

A built app.

Actual behavior

Build failed and the app is not ready for production.

DavidIAm
DavidIAm

Problem is a change in the api coming from mini-css-extract-plugin which is versioned at ^2.4.5 in the react-scripts package. It resolves to 2.5.0 at react-scripts install time which isn't good. You can patch around this with this in your package.json temporarily. { "resolutions": { "mini-css-extract-plugin": "2.4.5" } } I suspect mini-css-extract-plugin should have major-version-bumped if they're going to change their api that much.

that didn't fix the error for me

Just try to edit /node_modules/react-scripts/config/webpack.config.js in line 19: const MiniCssExtractPlugin = require('mini-css-extract-plugin').default;

It works for me :)

You're not wrong, but you're also hacking edits into node_modules which is not a sustainable path for deployable software.

Activity icon
issue

DavidIAm issue comment facebook/create-react-app

DavidIAm
DavidIAm

yarn build failed with a fresh created react ts app

Describe the bug

After creating a fresh new app using yarn create react-app my-app --template typescript the build process failed with an error from my_project/node_modules/react-scripts/config/webpack.config.js:664

Based on last releases of all componants inside node 16.13.0

Error is:

yarn build
yarn run v1.22.17
$ react-scripts build
/workspace/my_app/node_modules/react-scripts/config/webpack.config.js:664
        new MiniCssExtractPlugin({
        ^

TypeError: MiniCssExtractPlugin is not a constructor
    at module.exports (/workspace/my_app//node_modules/react-scripts/config/webpack.config.js:664:9)
    at Object.<anonymous> (/workspace/my_app/node_modules/react-scripts/scripts/build.js:58:16)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Did you try recovering your dependencies?

Yes, getting de fresh project from git or from scratch, see "Steps to reproduce"

Environment

  • Gitpod
  • Node 16.13.0

Steps to reproduce

Easy to reproduce craete a fresh new project like this :

yarn create react-app my-app --template typescript
cd my-app
yarn install
yarn build

Using yarn start, the dev mode is working fine.

Expected behavior

A built app.

Actual behavior

Build failed and the app is not ready for production.

DavidIAm
DavidIAm

Problem is a change in the api coming from mini-css-extract-plugin which is versioned at ^2.4.5 in the react-scripts package. It resolves to 2.5.0 at react-scripts install time which isn't good. You can patch around this with this in your package.json temporarily. { "resolutions": { "mini-css-extract-plugin": "2.4.5" } } I suspect mini-css-extract-plugin should have major-version-bumped if they're going to change their api that much.

that didn't fix the error for me

... you do need to do a 'yarn install' or the like to re-resolve and make sure that the current jq .version < node_modules/mini-css-extract-plugin/package.json is 2.4.5 before the error will disappear.

Activity icon
issue

DavidIAm issue comment facebook/create-react-app

DavidIAm
DavidIAm

yarn build failed with a fresh created react ts app

Describe the bug

After creating a fresh new app using yarn create react-app my-app --template typescript the build process failed with an error from my_project/node_modules/react-scripts/config/webpack.config.js:664

Based on last releases of all componants inside node 16.13.0

Error is:

yarn build
yarn run v1.22.17
$ react-scripts build
/workspace/my_app/node_modules/react-scripts/config/webpack.config.js:664
        new MiniCssExtractPlugin({
        ^

TypeError: MiniCssExtractPlugin is not a constructor
    at module.exports (/workspace/my_app//node_modules/react-scripts/config/webpack.config.js:664:9)
    at Object.<anonymous> (/workspace/my_app/node_modules/react-scripts/scripts/build.js:58:16)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Did you try recovering your dependencies?

Yes, getting de fresh project from git or from scratch, see "Steps to reproduce"

Environment

  • Gitpod
  • Node 16.13.0

Steps to reproduce

Easy to reproduce craete a fresh new project like this :

yarn create react-app my-app --template typescript
cd my-app
yarn install
yarn build

Using yarn start, the dev mode is working fine.

Expected behavior

A built app.

Actual behavior

Build failed and the app is not ready for production.

DavidIAm
DavidIAm

Problem is a change in the api coming from mini-css-extract-plugin which is versioned at ^2.4.5 in the react-scripts package. It resolves to 2.5.0 at react-scripts install time which isn't good. You can patch around this with this in your package.json temporarily.

{ "resolutions": { "mini-css-extract-plugin": "2.4.5" } }

Jan
5
2 weeks ago
open pull request

DavidIAm wants to merge cypress-io/cypress

DavidIAm
DavidIAm

fix: Inability to download with redirects through a proxy

User facing changelog

Use recursive redirect handling to be compatible with proxies that reset the connection Made tests for download cli more resilient to random environment variables set in the execution environment.

Additional details

Certain proxies result in a ECONNRESET or Write error being thrown when trying to handle redirects through them using the request package. This alters the strategy to only open the pipe on the final connection, and makes another connection for handling the redirect url

How has the user experience changed?

Download works even if you're using a proxy and redirecting.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?
DavidIAm
DavidIAm
pull request

DavidIAm merge to cypress-io/cypress

DavidIAm
DavidIAm

fix: Inability to download with redirects through a proxy

User facing changelog

Use recursive redirect handling to be compatible with proxies that reset the connection Made tests for download cli more resilient to random environment variables set in the execution environment.

Additional details

Certain proxies result in a ECONNRESET or Write error being thrown when trying to handle redirects through them using the request package. This alters the strategy to only open the pipe on the final connection, and makes another connection for handling the redirect url

How has the user experience changed?

Download works even if you're using a proxy and redirecting.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?
push

DavidIAm push DavidIAm/cypress

DavidIAm
DavidIAm

Remove environment config option for now

commit sha: f6ec5bdb871bbc1a6eb4c4a1014e75195d0a3611

push time in 2 weeks ago
Jan
4
2 weeks ago
open pull request

DavidIAm wants to merge cypress-io/cypress

DavidIAm
DavidIAm

fix: Inability to download with redirects through a proxy

User facing changelog

Use recursive redirect handling to be compatible with proxies that reset the connection Made tests for download cli more resilient to random environment variables set in the execution environment.

Additional details

Certain proxies result in a ECONNRESET or Write error being thrown when trying to handle redirects through them using the request package. This alters the strategy to only open the pipe on the final connection, and makes another connection for handling the redirect url

How has the user experience changed?

Download works even if you're using a proxy and redirecting.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?
DavidIAm
DavidIAm

Sure, I can understand that. Hows this?

    return Promise.reject(new Error(
      stripIndent`
          Failed downloading the Cypress binary.
          There were too many redirects. The default allowance is ${defaultMaxRedirects}.
          If you need more, use environment variable CYPRESS_DOWNLOAD_REDIRECT_TTL
        `,
    ))
pull request

DavidIAm merge to cypress-io/cypress

DavidIAm
DavidIAm

fix: Inability to download with redirects through a proxy

User facing changelog

Use recursive redirect handling to be compatible with proxies that reset the connection Made tests for download cli more resilient to random environment variables set in the execution environment.

Additional details

Certain proxies result in a ECONNRESET or Write error being thrown when trying to handle redirects through them using the request package. This alters the strategy to only open the pipe on the final connection, and makes another connection for handling the redirect url

How has the user experience changed?

Download works even if you're using a proxy and redirecting.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?
push

DavidIAm push DavidIAm/cypress

DavidIAm
DavidIAm

chore: Update Chrome (beta) to 97.0.4692.71 (#19503)

Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com>

DavidIAm
DavidIAm

fix: Use CYPRESS_VERIFY_TIMEOUT as integer. (#19517)

Co-authored-by: Emily Rohrbough [email protected]

DavidIAm
DavidIAm

Merge remote-tracking branch 'upstream/develop' into issue-19133-proxy-redirect-download

DavidIAm
DavidIAm

Make informative error message

commit sha: ff5ed561b97f54897f1c3e13706b43672d2bf740

push time in 2 weeks ago
open pull request

DavidIAm wants to merge cypress-io/cypress

DavidIAm
DavidIAm

fix: Inability to download with redirects through a proxy

User facing changelog

Use recursive redirect handling to be compatible with proxies that reset the connection Made tests for download cli more resilient to random environment variables set in the execution environment.

Additional details

Certain proxies result in a ECONNRESET or Write error being thrown when trying to handle redirects through them using the request package. This alters the strategy to only open the pipe on the final connection, and makes another connection for handling the redirect url

How has the user experience changed?

Download works even if you're using a proxy and redirecting.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?
DavidIAm
DavidIAm

Sure it was... couldn't you pass an option to agentOptions that would indicate the max redirects? (in the object its at request._redirect.maxRedirects if you ignore encapsulation constraints) And wouldn't it be easier to just leave it as an undocumented/stealth feature, that could be removed if it offended rather than going through a whole nother release cycle to add an eminently predictable configuration point? At least this way, if you went in and looked at the code you'd be like, OH! I can set that environment variable - instead of having to comprehend anything about the code and how it works in order to change it...

pull request

DavidIAm merge to cypress-io/cypress

DavidIAm
DavidIAm

fix: Inability to download with redirects through a proxy

User facing changelog

Use recursive redirect handling to be compatible with proxies that reset the connection Made tests for download cli more resilient to random environment variables set in the execution environment.

Additional details

Certain proxies result in a ECONNRESET or Write error being thrown when trying to handle redirects through them using the request package. This alters the strategy to only open the pipe on the final connection, and makes another connection for handling the redirect url

How has the user experience changed?

Download works even if you're using a proxy and redirecting.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?
Jan
3
3 weeks ago
push

DavidIAm push DavidIAm/cypress

DavidIAm
DavidIAm

Add tests and mechanism for redirect loop error

commit sha: 76e58fad300e46a14204411a656bc8ce8729f90e

push time in 2 weeks ago
push

DavidIAm push DavidIAm/cypress

DavidIAm
DavidIAm

a test with multiple layers of redirects

commit sha: 0a51e0e9c961fec003d8d32751692e2fa862e4a7

push time in 2 weeks ago
Activity icon
issue

DavidIAm issue comment cypress-io/cypress

DavidIAm
DavidIAm

fix: Inability to download with redirects through a proxy

User facing changelog

Use recursive redirect handling to be compatible with proxies that reset the connection Made tests for download cli more resilient to random environment variables set in the execution environment.

Additional details

Certain proxies result in a ECONNRESET or Write error being thrown when trying to handle redirects through them using the request package. This alters the strategy to only open the pipe on the final connection, and makes another connection for handling the redirect url

How has the user experience changed?

Download works even if you're using a proxy and redirecting.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?
DavidIAm
DavidIAm

I'd like to see a test that does multiple redirects, can be similar to this one: https://github.com/cypress-io/cypress/blob/develop/cli/test/lib/tasks/download_spec.js#L246-L264

I know technically you do cover the code you've written with one but this issue is around multiple so it would be nice to ensure that works.

Well, its not actually about multiple so much as its about the interaction of the (deprecated) request object here with redirect-reconnecting that happens through certain proxies that throw IO errors out of abrupt socket connection changes... the problem happens without even there being multiple redirects, just any redirects that are happening while certain proxies are active.

I'll look at making a test that covers redirect chain though. Maybe should have a defense against redirect loops too?

open pull request

DavidIAm wants to merge cypress-io/cypress

DavidIAm
DavidIAm

fix: Inability to download with redirects through a proxy

User facing changelog

Use recursive redirect handling to be compatible with proxies that reset the connection Made tests for download cli more resilient to random environment variables set in the execution environment.

Additional details

Certain proxies result in a ECONNRESET or Write error being thrown when trying to handle redirects through them using the request package. This alters the strategy to only open the pipe on the final connection, and makes another connection for handling the redirect url

How has the user experience changed?

Download works even if you're using a proxy and redirecting.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?
DavidIAm
DavidIAm

Actually, I think you're missing there are two different resolve calls -one here in the '200 success downloaded' point and one which is in the .then(resolve) from the downloadFromUrl in the redirect recursion point.

when there is a success we DO have the right version - Because downloadFromUrl has been called with the redirectVersion as the version field in the argument list at that point, that version gets returned from the 200 handle block which then gets resolved in the .then in the caller instance of the function.

pull request

DavidIAm merge to cypress-io/cypress

DavidIAm
DavidIAm

fix: Inability to download with redirects through a proxy

User facing changelog

Use recursive redirect handling to be compatible with proxies that reset the connection Made tests for download cli more resilient to random environment variables set in the execution environment.

Additional details

Certain proxies result in a ECONNRESET or Write error being thrown when trying to handle redirects through them using the request package. This alters the strategy to only open the pipe on the final connection, and makes another connection for handling the redirect url

How has the user experience changed?

Download works even if you're using a proxy and redirecting.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?
open pull request

DavidIAm wants to merge cypress-io/cypress

DavidIAm
DavidIAm

fix: Inability to download with redirects through a proxy

User facing changelog

Use recursive redirect handling to be compatible with proxies that reset the connection Made tests for download cli more resilient to random environment variables set in the execution environment.

Additional details

Certain proxies result in a ECONNRESET or Write error being thrown when trying to handle redirects through them using the request package. This alters the strategy to only open the pipe on the final connection, and makes another connection for handling the redirect url

How has the user experience changed?

Download works even if you're using a proxy and redirecting.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?
DavidIAm
DavidIAm

Hm. In the clear light of morning, a good point. Rearranged.

pull request

DavidIAm merge to cypress-io/cypress

DavidIAm
DavidIAm

fix: Inability to download with redirects through a proxy

User facing changelog

Use recursive redirect handling to be compatible with proxies that reset the connection Made tests for download cli more resilient to random environment variables set in the execution environment.

Additional details

Certain proxies result in a ECONNRESET or Write error being thrown when trying to handle redirects through them using the request package. This alters the strategy to only open the pipe on the final connection, and makes another connection for handling the redirect url

How has the user experience changed?

Download works even if you're using a proxy and redirecting.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?
open pull request

DavidIAm wants to merge cypress-io/cypress

DavidIAm
DavidIAm

fix: Inability to download with redirects through a proxy

User facing changelog

Use recursive redirect handling to be compatible with proxies that reset the connection Made tests for download cli more resilient to random environment variables set in the execution environment.

Additional details

Certain proxies result in a ECONNRESET or Write error being thrown when trying to handle redirects through them using the request package. This alters the strategy to only open the pipe on the final connection, and makes another connection for handling the redirect url

How has the user experience changed?

Download works even if you're using a proxy and redirecting.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?
DavidIAm
DavidIAm
pull request

DavidIAm merge to cypress-io/cypress

DavidIAm
DavidIAm

fix: Inability to download with redirects through a proxy

User facing changelog

Use recursive redirect handling to be compatible with proxies that reset the connection Made tests for download cli more resilient to random environment variables set in the execution environment.

Additional details

Certain proxies result in a ECONNRESET or Write error being thrown when trying to handle redirects through them using the request package. This alters the strategy to only open the pipe on the final connection, and makes another connection for handling the redirect url

How has the user experience changed?

Download works even if you're using a proxy and redirecting.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?
open pull request

DavidIAm wants to merge cypress-io/cypress

DavidIAm
DavidIAm

fix: Inability to download with redirects through a proxy

User facing changelog

Use recursive redirect handling to be compatible with proxies that reset the connection Made tests for download cli more resilient to random environment variables set in the execution environment.

Additional details

Certain proxies result in a ECONNRESET or Write error being thrown when trying to handle redirects through them using the request package. This alters the strategy to only open the pipe on the final connection, and makes another connection for handling the redirect url

How has the user experience changed?

Download works even if you're using a proxy and redirecting.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?
pull request

DavidIAm merge to cypress-io/cypress

DavidIAm
DavidIAm

fix: Inability to download with redirects through a proxy

User facing changelog

Use recursive redirect handling to be compatible with proxies that reset the connection Made tests for download cli more resilient to random environment variables set in the execution environment.

Additional details

Certain proxies result in a ECONNRESET or Write error being thrown when trying to handle redirects through them using the request package. This alters the strategy to only open the pipe on the final connection, and makes another connection for handling the redirect url

How has the user experience changed?

Download works even if you're using a proxy and redirecting.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?
push

DavidIAm push DavidIAm/cypress

DavidIAm
DavidIAm

address comments on pull request

commit sha: 13e58c93bf9a40bd86ee6a0d0b1335af701a2a49

push time in 2 weeks ago
Dec
27
4 weeks ago
push

DavidIAm push DavidIAm/cypress

DavidIAm
DavidIAm

feat: support create-react-app v5 (#19434)

DavidIAm
DavidIAm

chore: Update release-process document [skip ci] (#19459)

DavidIAm
DavidIAm

chore(deps): update dependency axios to v0.21.2 [security] (#19021)

Co-authored-by: Renovate Bot [email protected] Co-authored-by: Emily Rohrbough [email protected]

DavidIAm
DavidIAm

Merge branch 'develop' into issue-19133-proxy-redirect-download

commit sha: 68f01edf15c032624d3aecc116219ad6c25b375a

push time in 3 weeks ago
push

DavidIAm push DavidIAm/cypress

DavidIAm
DavidIAm

feat: support create-react-app v5 (#19434)

DavidIAm
DavidIAm

chore: Update release-process document [skip ci] (#19459)

DavidIAm
DavidIAm

chore(deps): update dependency axios to v0.21.2 [security] (#19021)

Co-authored-by: Renovate Bot [email protected] Co-authored-by: Emily Rohrbough [email protected]

commit sha: 797002f0ff95b04bd8b8b1096b5bbb39a431dbc0

push time in 3 weeks ago
Dec
21
1 month ago
Activity icon
issue

DavidIAm issue comment cypress-io/cypress

DavidIAm
DavidIAm

fix: Inability to download with redirects through a proxy

User facing changelog

Use recursive redirect handling to be compatible with proxies that reset the connection Made tests for download cli more resilient to random environment variables set in the execution environment.

Additional details

Certain proxies result in a ECONNRESET or Write error being thrown when trying to handle redirects through them using the request package. This alters the strategy to only open the pipe on the final connection, and makes another connection for handling the redirect url

How has the user experience changed?

Download works even if you're using a proxy and redirecting.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?
DavidIAm
DavidIAm

@jennifer-shehane thanks for the update - this is currently failing on github actions though :(

@mmahalwy

Well, yes... but on a test marked flaky - but required - I can't hit the retry button because I don't have privileges. What action should I take in this regards?

push

DavidIAm push DavidIAm/cypress

DavidIAm
DavidIAm

chore: release create-cypress-tests-v1.3.0

[skip ci]

DavidIAm
DavidIAm

chore: release @cypress/eslint-plugin-dev-v5.2.0

[skip ci]

DavidIAm
DavidIAm

chore: release @cypress/react-v5.11.0

[skip ci]

DavidIAm
DavidIAm

chore: release @cypress/vite-dev-server-v2.2.2

[skip ci]

DavidIAm
DavidIAm

chore: release @cypress/vue-v3.1.0

[skip ci]

DavidIAm
DavidIAm

chore: release @cypress/webpack-dev-server-v1.8.0

[skip ci]

DavidIAm
DavidIAm

chore: release @cypress/webpack-preprocessor-v5.11.0

[skip ci]

DavidIAm
DavidIAm

fix: add CYPRESS_VERIFY_TIMEOUT param and a test for it (#19282)

Co-authored-by: Matt Henkes [email protected] Co-authored-by: Emily Rohrbough [email protected]

DavidIAm
DavidIAm

chore: Remove pkg/driver @ts-nocheck part 1 (#19353)

Co-authored-by: Matt Henkes [email protected] Co-authored-by: Ryan Manuel [email protected]

DavidIAm
DavidIAm

fix: No unnecessary snapshotting (#19311)

Co-authored-by: Brian Mann [email protected]

DavidIAm
DavidIAm

chore: add types for Cypress.session.clearAllSavedSessions (#19412)

Co-authored-by: Emily Rohrbough [email protected]

DavidIAm
DavidIAm

chore: Fix the broken codeowners automation (#19431)

DavidIAm
DavidIAm

fix: cy.contains() ignores <style> and <script> without removing them. (#19424)

  • fix

  • Merge tests.

  • fix

  • Apply suggestions from code review

Co-authored-by: Emily Rohrbough [email protected]

  • kick off build again

Co-authored-by: Emily Rohrbough [email protected].noreply.github.com Co-authored-by: Matt Henkes [email protected]

DavidIAm
DavidIAm

Merge branch 'master' into develop

DavidIAm
DavidIAm

feat: add quotes to guide env credentials guide

DavidIAm
DavidIAm
DavidIAm
DavidIAm

Merge remote-tracking branch 'origin/develop' into issue-19133-proxy-redirect-download

commit sha: 0fc616d72fd8675ed9e607f15d67bab55df4e20f

push time in 1 month ago
push

DavidIAm push DavidIAm/cypress

DavidIAm
DavidIAm

fix: close chrome when closing electron (#19322)

DavidIAm
DavidIAm

fix: throw when writing to 'read only' properties of config (#18896)

Co-authored-by: Emily Rohrbough [email protected]

DavidIAm
DavidIAm

fix (#19262)

Co-authored-by: Emily Rohrbough [email protected] Co-authored-by: Matt Henkes [email protected]

DavidIAm
DavidIAm

fix: Do not screenshot or trigger the failed event when tests are skipped (#19331)

DavidIAm
DavidIAm

fix: Add more precise types to Cypress.Commands (#19003)

Co-authored-by: Matt Henkes [email protected]

DavidIAm
DavidIAm

chore: Fix server unit tests running on mac by using actual tmp dir (#19350)

DavidIAm
DavidIAm

chore(deps): update dependency ssri to 6.0.2 [security] (#19351)

Co-authored-by: Emily Rohrbough [email protected]

DavidIAm
DavidIAm

chore: Update Chrome (stable) to 96.0.4664.110 and Chrome (beta) to 97.0.4692.45 (#18996)

Co-authored-by: Chris Breiding [email protected] Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Emily Rohrbough [email protected] Co-authored-by: Emily Rohrbough [email protected]

DavidIAm
DavidIAm

fix: Update electron-packager to support development on M1 Macs (#19366)

DavidIAm
DavidIAm

chore: Update Chrome (beta) to 97.0.4692.56 (#19388)

Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com>

DavidIAm
DavidIAm

fix: check the port is avail on all local hosts (#19402)

DavidIAm
DavidIAm

Merge branch 'master' into develop

DavidIAm
DavidIAm

chore: release create-cypress-tests-v1.3.0

[skip ci]

DavidIAm
DavidIAm

chore: release @cypress/eslint-plugin-dev-v5.2.0

[skip ci]

DavidIAm
DavidIAm

chore: release @cypress/react-v5.11.0

[skip ci]

DavidIAm
DavidIAm

chore: release @cypress/vite-dev-server-v2.2.2

[skip ci]

DavidIAm
DavidIAm

chore: release @cypress/vue-v3.1.0

[skip ci]

DavidIAm
DavidIAm

chore: release @cypress/webpack-dev-server-v1.8.0

[skip ci]

DavidIAm
DavidIAm

chore: release @cypress/webpack-preprocessor-v5.11.0

[skip ci]

DavidIAm
DavidIAm

fix(cy.intercept): allow fixtures to define null encoding when used in static response (#19379)

commit sha: 7453c1d61d68f6f448ae8f2d43951f6cfa334b01

push time in 1 month ago
push

DavidIAm push DavidIAm/cypress

DavidIAm
DavidIAm

Fix race condition in verify code

DavidIAm
DavidIAm

Merge branch 'issue-19133-proxy-redirect-download' of github.com:DavidIAm/cypress into issue-19133-proxy-redirect-download

commit sha: 34ee5d1d251ede69ad668b8fa2ab969db10e09be

push time in 1 month ago
Previous