Gaelan

Gaelan

any pronouns

Member Since 8 years ago

Gig Harbor, WA | St Andrews, Scotland

Experience Points
25
follower
Lessons Completed
18
follow
Lessons Completed
202
stars
Best Reply Awards
146
repos

410 contributions in the last year

Pinned
⚡ Git blame for Wikipedia.
⚡ Quickly import student assignments from Schoology into Eclipse.
Activity
Nov
25
5 days ago
push

Gaelan push AgoraNomic/ruleset-viewer

Gaelan
Gaelan

Bump @types/react from 17.0.36 to 17.0.37

Bumps @types/react from 17.0.36 to 17.0.37.


updated-dependencies:

  • dependency-name: "@types/react" dependency-type: direct:production update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] [email protected]

Gaelan
Gaelan

Merge pull request #29 from AgoraNomic/dependabot/npm_and_yarn/types/react-17.0.37

Bump @types/react from 17.0.36 to 17.0.37

commit sha: 42024990d6924f0ff90ce225f81c61db91ae1230

push time in 4 days ago
pull request

Gaelan pull request AgoraNomic/ruleset-viewer

Gaelan
Gaelan

Bump @types/react from 17.0.36 to 17.0.37

Bumps @types/react from 17.0.36 to 17.0.37.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Nov
23
1 week ago
push

Gaelan push AgoraNomic/ruleset-viewer

Gaelan
Gaelan

Bump @types/react from 17.0.35 to 17.0.36

Bumps @types/react from 17.0.35 to 17.0.36.


updated-dependencies:

  • dependency-name: "@types/react" dependency-type: direct:production update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] [email protected]

Gaelan
Gaelan

Merge pull request #28 from AgoraNomic/dependabot/npm_and_yarn/types/react-17.0.36

Bump @types/react from 17.0.35 to 17.0.36

commit sha: 79313607ef4ed69184a631653329b9758e336ec0

push time in 6 days ago
pull request

Gaelan pull request AgoraNomic/ruleset-viewer

Gaelan
Gaelan

Bump @types/react from 17.0.35 to 17.0.36

Bumps @types/react from 17.0.35 to 17.0.36.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Nov
21
1 week ago
Activity icon
issue

Gaelan issue comment rust-vmm/vhost-device

Gaelan
Gaelan

Initial vhost-user-scsi implementation

Here's an initial implementation of vhost-user-scsi, as part of my GSoC project with @slp. Currently, it supports reading from up to 256 raw images.

For usage documentation and plans for future improvements, see the README; for architectural documentation, see ARCHITECTURE.md and comments in the code.

Although a read-only disk driver is of limited usefulness, I believe this code should be more-or-less production-ready. I've left some TODO comments in the code; these are either for features we'll want to add in the future, or places I want feedback from code reviewers (especially who are familiar with SCSI).

Gaelan
Gaelan

Alright, I've done a rebase and fixed some breaking changes. I should note that I've run the tests and they pass, but I haven't actually tried to run a real VM with the rebased code—I should have some free time in the next few days to give that a shot.

Sorry for the long delay—I've been busy with school.

push

Gaelan push Gaelan/vhost-device

Gaelan
Gaelan

build(deps): bump rust-vmm-ci from 8901e77 to 1311bfa

Bumps rust-vmm-ci from 8901e77 to 1311bfa.


updated-dependencies:

  • dependency-name: rust-vmm-ci dependency-type: direct:production ...

Signed-off-by: dependabot[bot] [email protected]

Gaelan
Gaelan

update dependabot formatting

Gaelan
Gaelan

i2c: Fix dependency to a working commit of backend

To avoid breaking the crate with a newer version of the vhost-user-backend crate, fix the dependency to a known good version of the crate.

Signed-off-by: Viresh Kumar [email protected]

Gaelan
Gaelan

Merge pull request #16 from vireshk/i2c-breakage

i2c: Fix dependency to a working commit of backend

Gaelan
Gaelan

build(deps): bump rust-vmm-ci from 1311bfa to ae7db2d

Bumps rust-vmm-ci from 1311bfa to ae7db2d.


updated-dependencies:

  • dependency-name: rust-vmm-ci dependency-type: direct:production ...

Signed-off-by: dependabot[bot] [email protected]

Gaelan
Gaelan

dependabot: Allow updating dependencies

Remove the incorrect file dependabot.yaml and edit the correct one to allow crate updates on weekly basis.

Signed-off-by: Viresh Kumar [email protected]

Gaelan
Gaelan

Merge pull request #19 from rust-vmm/dependabot/submodules/rust-vmm-ci-ae7db2d

build(deps): bump rust-vmm-ci from 1311bfa to ae7db2d

Gaelan
Gaelan

Merge branch 'main' into dependabot-update

Gaelan
Gaelan

Merge pull request #20 from vireshk/dependabot-update

dependabot: Allow updating crate dependencies automatically

Gaelan
Gaelan

i2c: Upgrade to new version of backend

Signed-off-by: Viresh Kumar [email protected]

Gaelan
Gaelan

i2c: Separate out start_daemon() and remove dryrun

Separate out daemon's handling and remove the ugly dryrun parameter.

Signed-off-by: Viresh Kumar [email protected]

Gaelan
Gaelan

i2c: Add tests to cover basic backend operations

This still doesn't emulate the descriptors and descriptor chains over the vrings. That will be added later.

Signed-off-by: Viresh Kumar [email protected]

Gaelan
Gaelan

[i2c] move parsing of bus id outside of trait impl

This is a first change in a series meant for moving all the parsing of strings in a single place, with the goal of separating parsing from the device operation. This helps with separating concerns, mocking, and writing unit tests.

Signed-off-by: Andreea Florescu [email protected]

Gaelan
Gaelan

[i2c] rename bus to adapter_no

This seems to be the way that it is defined & used in other examples written for i2c.

Signed-off-by: Andreea Florescu [email protected]

Gaelan
Gaelan

[i2c] separate imports

We've typically separated imports in 3 categories:

  • Rust standard library
  • external crates
  • project internal imports (such as imports from user defined modules)

Signed-off-by: Andreea Florescu [email protected]

Gaelan
Gaelan

[i2c] remove get_func from I2cAdapter trait

This function does not need to be in the trait. Having it as a public function also makes the code hard to use because the return of the is_smbus function is only valid after an initial call to get_func.

To get rid of this behavior, we can make the get_func a private function in the I2cAdapter implementation, and call this function on new.

The function was renamed to read_func to make the name more "mutable" compatible (the function needs a mutable reference, but it was called get; get functions don't typically need mutable references).

Signed-off-by: Andreea Florescu [email protected]

Gaelan
Gaelan

[i2c] reworked the abstractions

The I2cAdapterTrait was introduced because of a need to test the i2c implementation without having access to a physical device on the host running the tests. This abstraction though still made the tests pretty hard to write, so it is now replaced by another abstractions: I2cDevice.

This abstraction is written working backwards from what we DO NOT have access to on the host where we want to run the tests. This is the i2c device. So, this abstraction is just abstracting the way all the ioctl calls that need to be handled by an i2c device. This way, we can test all the other wrappers that are implemented in this crate.

The abstraction is implemented for a physical device to keep backwards compatibility with existing code.

This abstraction still needs improvements such as marking the functions as unsafe. For now the tests are commented out because they need to be re-written with this abstraction. Since we still have refactoring work to do (i.e. separate the parsing from the device operation), writing tests is postponed so that it does not involve duplicated work.

Signed-off-by: Andreea Florescu [email protected]

Gaelan
Gaelan

[i2c] separate parsing of strings from device

This separation is needed so we can easily write unit tests for parsing without needing to create full blown objects. (as a side note, before this is possible, we also need to get rid of errno, and replace it with custom Errors, so that we can also write the much needed negative tests).

This separation is achieved through creating configuration structures that can be either programatically initialized, or initialized through parsing the command line parameters.

This commit is still WIP because we also need to make sure that configuration objects can only be created valid (to reduce some risks for future extensions where parameters might be passed some other way rather than yaml). Also, we need to move the check for uniquness of device addresses in the DeviceConfig instead of the I2cMap.

Signed-off-by: Andreea Florescu [email protected]

Gaelan
Gaelan

[i2c] fix formatting

Signed-off-by: Andreea Florescu [email protected]

Gaelan
Gaelan

[i2c] disallow invalid configurations of I2cMap

This helps with simplifying the code by keeping all checks at init time. In practice it means that invalid objects can no longer be created, which simplifies the testing.

All objects are created through either new, or TryFrom, and they can only be updated (outside of test functions) via functions that are checking the validity of the resulting object.

Signed-off-by: Andreea Florescu [email protected]

commit sha: 1effcf83f5e578a97bc4afd050f689b8bd6385ec

push time in 1 week ago
Nov
20
1 week ago
push

Gaelan push AgoraNomic/ruleset-viewer

Gaelan
Gaelan

Bump glob-parent from 5.1.0 to 5.1.2

Bumps glob-parent from 5.1.0 to 5.1.2.


updated-dependencies:

  • dependency-name: glob-parent dependency-type: indirect ...

Signed-off-by: dependabot[bot] [email protected]

Gaelan
Gaelan

Merge pull request #27 from AgoraNomic/dependabot/npm_and_yarn/glob-parent-5.1.2

Bump glob-parent from 5.1.0 to 5.1.2

commit sha: e5ef71f97513857ba1f744f14a34095081810eb3

push time in 1 week ago
pull request

Gaelan pull request AgoraNomic/ruleset-viewer

Gaelan
Gaelan

Bump glob-parent from 5.1.0 to 5.1.2

Bumps glob-parent from 5.1.0 to 5.1.2.

Release notes

Sourced from glob-parent's releases.

v5.1.2

Bug Fixes

v5.1.1

Bug Fixes

Changelog

Sourced from glob-parent's changelog.

5.1.2 (2021-03-06)

Bug Fixes

6.0.2 (2021-09-29)

Bug Fixes

6.0.1 (2021-07-20)

Bug Fixes

  • Resolve ReDoS vulnerability from CVE-2021-35065 (#49) (3e9f04a)

6.0.0 (2021-05-03)

⚠ BREAKING CHANGES

  • Correct mishandled escaped path separators (#34)
  • upgrade scaffold, dropping node <10 support

Bug Fixes

  • Correct mishandled escaped path separators (#34) (32f6d52), closes #32

Miscellaneous Chores

  • upgrade scaffold, dropping node <10 support (e83d0c5)

5.1.1 (2021-01-27)

Bug Fixes

Commits
  • eb2c439 chore: update changelog
  • 12bcb6c chore: release 5.1.2
  • f923116 fix: eliminate ReDoS (#36)
  • 0b014a7 chore: add JSDoc returns information (#33)
  • 2b24ebd chore: generate initial changelog
  • 9b6e874 chore: release 5.1.1
  • 749c35e ci: try wrapping the JOB_ID in a string
  • 5d39def ci: attempt to switch to published coveralls
  • 0b5b37f ci: put the npm step back in for only Windows
  • 473f5d8 ci: update azure build images
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the Security Alerts page.
push

Gaelan push AgoraNomic/ruleset-viewer

Gaelan
Gaelan

Bump minimist from 1.2.0 to 1.2.5

Bumps minimist from 1.2.0 to 1.2.5.


updated-dependencies:

  • dependency-name: minimist dependency-type: indirect ...

Signed-off-by: dependabot[bot] [email protected]

Gaelan
Gaelan

Merge pull request #23 from AgoraNomic/dependabot/npm_and_yarn/minimist-1.2.5

Bump minimist from 1.2.0 to 1.2.5

commit sha: bce9381eff6cc7f56da9f0e1375492316c367ad4

push time in 1 week ago
pull request

Gaelan pull request AgoraNomic/ruleset-viewer

Gaelan
Gaelan

Bump minimist from 1.2.0 to 1.2.5

Bumps minimist from 1.2.0 to 1.2.5.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the Security Alerts page.
push

Gaelan push AgoraNomic/ruleset-viewer

Gaelan
Gaelan

big round o' package updates

Gaelan
Gaelan

Merge pull request #26 from AgoraNomic/next-upgrade

big round o' package updates

commit sha: 61d034bec99f638703f54395a0d953d8a8823be2

push time in 1 week ago
Activity icon
created branch

Gaelan in AgoraNomic/ruleset-viewer create branch next-upgrade

createdAt 1 week ago
push

Gaelan push AgoraNomic/ruleset-viewer

Gaelan
Gaelan

Bump tar from 6.1.0 to 6.1.11

Bumps tar from 6.1.0 to 6.1.11.


updated-dependencies:

  • dependency-name: tar dependency-type: indirect ...

Signed-off-by: dependabot[bot] [email protected]

Gaelan
Gaelan

Merge pull request #16 from AgoraNomic/dependabot/npm_and_yarn/tar-6.1.11

Bump tar from 6.1.0 to 6.1.11

commit sha: 8deb1497e0260d79ab72817018b155504844aba4

push time in 1 week ago
pull request

Gaelan pull request AgoraNomic/ruleset-viewer

Gaelan
Gaelan

Bump tar from 6.1.0 to 6.1.11

Bumps tar from 6.1.0 to 6.1.11.

Commits
  • e573aee 6.1.11
  • edb8e9a fix: perf regression on hot string munging path
  • a9d9b05 chore(test): Avoid spurious failures packing node_modules/.cache
  • 24b8bda fix(test): use posix path for testing path reservations
  • e5a223c fix(test): make unpack test pass on case-sensitive fs
  • 188badd 6.1.10
  • 23312ce drop dirCache for symlink on all platforms
  • 4f1f4a2 6.1.9
  • 875a37e fix: prevent path escape using drive-relative paths
  • b6162c7 fix: reserve paths properly for unicode, windows
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

push

Gaelan push AgoraNomic/ruleset-viewer

Gaelan
Gaelan

Implement tarball-based rule fetching.

Gaelan
Gaelan

Merge pull request #17 from AgoraNomic/tar

Implement tarball-based rule fetching.

commit sha: 63a23ea2daad1126652a4c4210e427655dc4975e

push time in 1 week ago
pull request

Gaelan pull request AgoraNomic/ruleset-viewer

Gaelan
Gaelan

Implement tarball-based rule fetching.

pull request

Gaelan pull request AgoraNomic/ruleset-viewer

Gaelan
Gaelan

Implement tarball-based rule fetching.

Activity icon
created branch
createdAt 1 week ago
pull request

Gaelan merge to DefinitelyTyped/DefinitelyTyped

Gaelan
Gaelan

Fix spelling of GeneratorType "octogons" in GeoPattern types

The GeoPattern library misspells octagon as "octogon" (on-brand for Github). "Octagons" is not a pattern option.

See https://github.com/btmills/geopattern/blob/master/lib/pattern.js#L14 for the definition of the available patterns.

Gaelan
Gaelan

Good catch, thanks!

Nov
1
4 weeks ago
started
started time in 4 weeks ago
Oct
31
4 weeks ago
Activity icon
issue

Gaelan issue microsoft/TypeScript-Website

Gaelan
Gaelan

Playground: Uses (very old) express-serve-static-core/index.d.ts instead of @types/express-serve-static-core

As a workaround for a circular dependency, most of the typings for Express are actually in @types/express-serve-static-core, which @types/express depends on. Note that there's not really a express-serve-static-core package at runtime—it's purely invented by DefinitelyTyped to make typings work.

However, there is an express-serve-static-core package on NPM, with an index.d.ts that's a 5-year-old copy of the DefinitelyTyped typings. For some reason, the playground is picking up that package, instead of @types/express-serve-static-core, so it's missing features that have been added to the typings since then—for example, the template-string-literal-based parsing of route parameters.

Repro: https://www.typescriptlang.org/play?#9gTgLgBAbwEoQK4wKZQL5wGZQQhwDkGAHmFBgM40kDcAUEwMYQB2N8h6WcAXjgo+UABQBKZk16YoAOgDmGGGJIB6AFzAAJiQA0cMdQCOh6jQmCAfIiZwHcdergABGDQC0FMBlYxvKEIoe0dTeTAAQyhIkBp5EGA6YA5FADFgDAAbHTgmbAkgA

In the playground, write TypeScript code that imports express.

Expected behavior:

The playground uses the current typings from @types/express-serve-static-core—the ones that get installed when you run npm i -D @types/express.

Actual behavior:

The playground uses the ancient typings from express-serve-static-core.

Oct
30
1 month ago
Activity icon
issue

Gaelan issue helmetjs/helmet

Gaelan
Gaelan

Consider disabling hidePoweredBy in next major release

As the docs say, disabling X-Powered-By has little to no security benefit. I'd argue that, in fact, including hidePoweredBy by default does more harm than good:

  • It contributes to the belief that it's a useful security change ("see, helmet does it!")
  • It makes helmet look bad to people know what they're doing ("if this thing disables X-Powered-By, how many of its other features are pointless?")

It seems to me that it's worth at least considering no longer including hidePoweredBy by default—thoughts?

Oct
25
1 month ago
started
started time in 1 month ago
Oct
22
1 month ago
Activity icon
issue

Gaelan issue microsoft/TypeScript

Gaelan
Gaelan

Breaking at the end of a case shouldn't be an error, even if unreachable

Bug Report

🔎 Search Terms

switch, unreachable, break

🕗 Version & Regression Information

  • This changed between versions 3.6.3 and 3.7.5

⏯ Playground Link

Playground link with relevant code

💻 Code

declare function exit(): never;

function handleFoo(foo: 'a' | 'b') {
    switch(foo) {
    case 'a':
        console.log("handling a");
        break;
    case 'b':
        console.error("b is unsupported");
        exit();
        break;
    }
}

🙁 Actual behavior

The break after exit() is flagged as unreachable code. This is technically true, but I'm not sure it's a good idea to remove it: many bugs have resulted from missing break statements, and people may want to make sure all cases end in a break, regardless of any functions that are called (either as a formalized code-style guideline, or just that little "this looks wrong" voice in your head).

🙂 Expected behavior

A break at the end of a switch statement shouldn't never be treated as unreachable code.


I'm not quite sure if this qualifies as a bug report or a feature request; sorry if I made the wrong call.

Oct
15
1 month ago
started
started time in 1 month ago
Previous