Jack-Works

Jack-Works

Member Since 8 years ago

Web

Experience Points
361
follower
Lessons Completed
54
follow
Lessons Completed
3
stars
Best Reply Awards
42
repos

2239 contributions in the last year

Pinned
⚡ A proposal for ECMAScript to add a built-in Number.range()
⚡ A custom transformer that can be used with ttypescript to transform ts imports to browser style imports
⚡ A lightweight JSON RPC client & server
⚡ React Refresh transformers for tooling authors
⚡ Language service for efml
Activity
Dec
7
11 hours ago
pull request

Jack-Works merge to DimensionDev/Maskbook

Jack-Works
Jack-Works

fix: replace wallet name with provider name when connect 3rd wallet

closes MASK-355

Activity icon
commit_comment

DimensionDev/Maskbook

pull request

Jack-Works merge to DimensionDev/Maskbook

Jack-Works
Jack-Works

fix: replace wallet name with provider name when connect 3rd wallet

closes MASK-355

push

Jack-Works push DimensionDev/Maskbook

Jack-Works
Jack-Works

feat: plugin contribute hint when disabled. close #4918

commit sha: 4328fe0357f739f757bdb1e514d5cdb502ad4652

push time in 3 hours ago
push

Jack-Works push DimensionDev/Maskbook

Jack-Works
Jack-Works

chore: add contribution field

Jack-Works
Jack-Works

chore: declare contributions for all plugin

commit sha: 6f1bbbd3b32a712e5899a975af760f3e8bf04ca0

push time in 5 hours ago
push

Jack-Works push DimensionDev/Maskbook

Jack-Works
Jack-Works

feat: new encryption infra (part 1: encode and decode payload) (#4687)

  • docs: add document to empty package

  • chore: add encryption package

  • feat: add encryption package

  • feat: implement parser for v37 payload

  • chore: revisit

  • fix: typo

  • feat: add encoder for v38

  • feat: add encoder for v37

  • refactor: move signature container out

  • docs: update doc

  • merge

  • chore: patch ts-results

  • chore: patch kit

  • temp

  • chore: upgrade tiny-secp256k1

  • chore: patch packages

  • chore: patch packages

  • chore: patch packages

  • chore: add test

  • chore: make snapshot better

  • fix: type error

  • fix: typo

  • fix: part of test cases

  • fix: parse of v38 payload

  • fix: support K-256 in test env

  • fix: test serializer

  • chore: upgrade swc

  • fix: type error

  • refactor: rename and move types

  • refactor: rename and move types

  • fix: co-op with current standard

  • fix: interoperability with current version

  • test: add test cases

  • fix: ephemeralPublicKey encoding and decoding

  • fix: typo

Jack-Works
Jack-Works

chore: upgrade pnpm to 6.23.1

Jack-Works
Jack-Works
Jack-Works
Jack-Works
Jack-Works
Jack-Works
Jack-Works
Jack-Works

feat: implement getFungibleAssets of flow chain (#4879)

  • fix: to earily to switch network

  • chore: assets list of flow chain

Jack-Works
Jack-Works

fix: dialog ui issues (#4881)

  • feat: change luckydrop img & hide ITO entry

  • style: kill unused code

  • fix: issue# 4877

  • fix: only dashboard wallet dialog ui change

  • fix: post dialog title border color change

  • style: change `` to classNames

  • Revert "style: change `` to classNames"

This reverts commit 21ece001990449d7900f87f47b8d30682a2b284e.

  • style: kill lock

  • style: kill unused img sendluckydrop.png

Co-authored-by: billy [email protected]

Jack-Works
Jack-Works

feat: remove swap settings in labs page (#4890)

Jack-Works
Jack-Works

fix: select wallet page is empty (#4883)

Jack-Works
Jack-Works

fix: nft cache name (#4901)

  • fix: typo

  • fix: cache name

Jack-Works
Jack-Works

chore: introduce @masknet/web3-providers (#4903)

  • chore: introduce @masknet/web3-providers

  • refactor: migrate rarible apis

Jack-Works
Jack-Works

refactor: remove unused code (#4905)

  • refactor: remove unused code

  • chore: useMyProfiles

Jack-Works
Jack-Works

fix: add variant: constained to some buttons (#4911)

  • feat: change luckydrop img & hide ITO entry

  • style: kill unused code

  • fix: issue# 4877

  • fix: only dashboard wallet dialog ui change

  • fix: post dialog title border color change

  • style: change `` to classNames

  • Revert "style: change `` to classNames"

This reverts commit 21ece001990449d7900f87f47b8d30682a2b284e.

  • style: kill lock

  • style: kill unused img sendluckydrop.png

  • fix: change some buttons variant => contained

  • fix: fix loading animation & place contacts loading center

  • fix: remove height on persona tabs container to align scroll bar

  • fix: rename the variable & remove unused code

Co-authored-by: billy [email protected] Co-authored-by: Lantt [email protected]

Jack-Works
Jack-Works
Jack-Works
Jack-Works

fix: fb snackbar position (#4910)

  • chore: mv custom ui helper

  • fix: fb snackbar position

Jack-Works
Jack-Works
Jack-Works
Jack-Works

fix: insertBefore failed, close #4916 (#4920)

commit sha: 3a734d56859340acd8bfad4de2e719089ed8daf0

push time in 5 hours ago
pull request

Jack-Works merge to DimensionDev/Maskbook

Jack-Works
Jack-Works

fix: pancakeswap can't display

closes MASK-363 MASK-368

push

Jack-Works push Jack-Works-forks/DefinitelyTyped

Jack-Works
Jack-Works

Update types/ethereum-blockies/index.d.ts

Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) [email protected]

commit sha: b7a14280b62be120c44ba6a5f212a613fcc131e7

push time in 8 hours ago
push

Jack-Works push DimensionDev/Maskbook

Jack-Works
Jack-Works

fix: append recivers broken (#5075)

  • fix: append recivers broken

  • fix: lockfile

commit sha: fa9dae545e2b9ebad601759de05025f78a1e6ae5

push time in 8 hours ago
push

Jack-Works push DimensionDev/Maskbook

Jack-Works
Jack-Works

fix: append recivers broken (#5075)

  • fix: append recivers broken

  • fix: lockfile

commit sha: 7bf678f72e1bf9042871e06b4de6b3ea1e66af56

push time in 8 hours ago
Activity icon
delete

Jack-Works in DimensionDev/Maskbook delete branch fix/5060

deleted time in 8 hours ago
pull request

Jack-Works pull request DimensionDev/Maskbook

Jack-Works
Jack-Works

fix: append recivers broken

closes #5060

push

Jack-Works push DimensionDev/Maskbook

Jack-Works
Jack-Works

fix: the visiblity of hero image (#5077)

Jack-Works
Jack-Works
Jack-Works
Jack-Works

refactor: move application entrance definition to app-plugin (#5083)

Jack-Works
Jack-Works

fix: show compose dialog (#5085)

This reverts commit e3e3606955e54f33b92af81630e261e1180dc939.

Jack-Works
Jack-Works

fix: remove deprecated plugins (#5081)

  • fix: remove deprecated plugins

  • refactor: remove unused code

Co-authored-by: guanbinrui [email protected]

Jack-Works
Jack-Works

feat: new encryption infra (part 2: decryption) (#5039)

  • docs: add doc

  • refactor: split files

  • chore: add ephemeral pub key in return result

  • chore: add ephemeral pub key to append result

  • feat: implement public decryption

  • refactor: move logic to shared-base

  • chore: remove getCache

  • feat: impl decrypt as author

  • feat: v40 e2e decryption

  • refactor: move logic out

  • refactor: rename vars

  • feat: progress

  • feat: upgrade ts

  • feat: support v37 decryption

  • refactor: split files

  • refactor: rename files

  • refactor: reorder things

  • chore: remove es2022 types, use ts version

  • fix: ci

  • fix: ci

  • fix: ci

Jack-Works
Jack-Works

chore: add encryption pkg as dep

Jack-Works
Jack-Works

docs(i18n): sync i18n files from Crowdin (#5096)

  • New translations en-US.json (Chinese Simplified) docs(i18n): sync translation en-US.json for Chinese Simplified

  • New translations en-US.json (Quenya) docs(i18n): sync translation en-US.json for Quenya

Jack-Works
Jack-Works

Merge branch 'main' into fix/5060

commit sha: edab79e54819f26d2e686faf86dd8c2a58e6283d

push time in 8 hours ago
push

Jack-Works push DimensionDev/Maskbook

Jack-Works
Jack-Works

docs(i18n): sync i18n files from Crowdin (#5096)

  • New translations en-US.json (Chinese Simplified) docs(i18n): sync translation en-US.json for Chinese Simplified

  • New translations en-US.json (Quenya) docs(i18n): sync translation en-US.json for Quenya

commit sha: be4e4cdf342c9a701dd201a4abe27eeb7b1e2b74

push time in 8 hours ago
Activity icon
delete

Jack-Works in DimensionDev/Maskbook delete branch l10n_develop

deleted time in 8 hours ago
pull request

Jack-Works pull request DimensionDev/Maskbook

Jack-Works
Jack-Works

docs(i18n): sync i18n files from Crowdin

pull request

Jack-Works pull request DimensionDev/Maskbook

Jack-Works
Jack-Works

docs(i18n): sync i18n files from Crowdin

push

Jack-Works push DimensionDev/Maskbook

Jack-Works
Jack-Works

New translations en-US.json (Quenya) docs(i18n): sync translation en-US.json for Quenya

commit sha: afdedfd54191319a733e468c216f31fb51121a35

push time in 8 hours ago
push

Jack-Works push DimensionDev/Maskbook

Jack-Works
Jack-Works

New translations en-US.json (Chinese Simplified) docs(i18n): sync translation en-US.json for Chinese Simplified

commit sha: a5d510cc8866d7c16d7f9fbff3a3b22265547dd5

push time in 8 hours ago
Dec
6
1 day ago
Activity icon
issue

Jack-Works issue tc39/proposal-pattern-matching

Jack-Works
Jack-Works

New bindings from RegExp literal w/ the JS ecosystem

I really like the design of creating new bindings from the RegExp named capture group. I think it's an excellent combination of the language features. But I'd like to raise some toolchain perspective concerns.

Nowadays all bindings defined by an Identifier but this new feature breaks that assumption (the binding comes from the RegExp literal).

Babel AST:

TypeScript AST:

As you can see two of the most popular AST format didn't handle the inner structure of a RegExp, I'm worried it might cost much work for the whole ecosystem (e.g. webpack, rollup, code compressor, babel/typescript plugins) to handle this kind of new declaration source correctly.

Activity icon
issue

Jack-Works issue comment webpack/webpack

Jack-Works
Jack-Works

Optional chain is incorrectly removed when used on import

Bug report

What is the current behavior?

Webpack incorrectly compiles x?.value to (something).value when x is something that's been imported.

If the current behavior is a bug, please provide the steps to reproduce.

webpack.config.js:

module.exports = {
    entry: "./index.js",
    target: "web",
};

index.js:

import x from './x.js';
console.log(`optional value is: ${x?.value}`);

x.js:

export default undefined;

Produces dist/main.js:

(()=>{"use strict";console.log(`optional value is: ${(void 0).value}`)})();

which leads to TypeError: Cannot read property 'value' of undefined at runtime.

What is the expected behavior?

The ? should be retained or converted to a ternary operator.

When import x from './x.js'; is removed and replaced with const x = (() => void console)(); (something complicated enough that webpack doesn't completely constant-fold it), the output is:

(()=>{const o=void console;console.log(`optional value is: ${o?.value}`)})();

which is as expected (the ? is retained).

Other relevant information: webpack version: latest, 5.27.2 Node.js version: v15.9.0 Operating System: macOS 11.2.2

Jack-Works
Jack-Works

to produce optional chain in output we need outputOptions.environment.supportOptionalChaining

If webpack encountered ?. (which means not transpiled by babel), we should emit an error if outputOptions.environment.supportOptionalChaining is not true because webpack will not do any transpiling.

pull request

Jack-Works pull request DefinitelyTyped/DefinitelyTyped

Jack-Works
Jack-Works

[ethereum-blockies]: new package

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.
push

Jack-Works push Jack-Works-forks/DefinitelyTyped

Jack-Works
Jack-Works

🤖 Merge PR #56085 [forge-viewer] update for version 7.52 by @liskaj

  • added new methods, flagging deprecated methods.

  • updated to versio 7.52

  • added properties

  • updated tests

Jack-Works
Jack-Works

🤖 Merge PR #56114 K6 0.34 by @ppcano

  • Fix non-redundant-undefined error

  • k6: add Metric.name property

  • k6: Add k6/execution module

  • k6: set version 0.34

  • k6: project maintainers changes

Jack-Works
Jack-Works

🤖 Merge PR #56175 [@types/ioredis] - fix missing type for xautoclaim (related to Stream and Redis v6.x) by @Rossb0b

  • fix(ioredis): added type definition for xautoclaim

  • test(ioredis): test for xautoclaim command

Jack-Works
Jack-Works

🤖 Merge PR #55751 update(svgo): update to 2.6 by @peterblazejewicz

Thanks!

Jack-Works
Jack-Works

🤖 Merge PR #56117 [@types/react-native] - Update react-native AccessibilityInfo listeners by @Aure77

  • fix lint / codestyle

  • AccessibilityInfo listeners return event sub

addEventListener return EmitterSubscription removeEventListener is deprecated

  • add tests

Co-authored-by: A389216 [email protected]

Jack-Works
Jack-Works

🤖 Merge PR #56183 d3: add tickSubdivide type to Axis and allow null comparator for pie.sort by @yolandaz

  • d3: add tickSubdivide type to Axis

  • d3: allow null comparator for pie.sort

  • d3: add test for tickSubdivide

Jack-Works
Jack-Works

🤖 Merge PR #56143 Add @primer/octicons by @vBread

  • add @primer/octicons

  • fix ci

  • fix wdith & height types

Jack-Works
Jack-Works

🤖 Merge PR #56190 Add typescript support for luxonLocalizer in react-big-calendar by @olafur164

  • Add luxonLocalizer typescript support to react-big-calendar types

  • Update react-big-calendar version at the top of the type definition

  • Removing patch version in header as it is not allowed

Co-authored-by: Ólafur Hólm Eyþórsson [email protected]

Jack-Works
Jack-Works

🤖 Merge PR #56174 [@types/react-native] - update types for 0.65 by @grgr-dkrk

Jack-Works
Jack-Works

🤖 Merge PR #56098 Microsoft Graph - Upgrade to 2.7 by @nikithauc

  • Adding updates for version 1.20

  • microsoftgraph updating for v 1.21

  • Updating microsoft-graph version 1.22

  • Version 1.23

  • Upgrade to 1.24

  • upgrade to version 1.25

  • Upgrade to version 1.26

  • Updating to version 1.27

  • Update to 1.28

  • Updating to version 1.29

  • updating version 3.0.0

  • Update to 1.30

  • Update to version 1.31

  • Update to 1.32

  • Upgrade to version 1.33

  • Update to version 1.34

  • Update to version 1.35

  • update to 1.36 version

  • update to 1.37

  • Updating to 1.38

  • Update to version 1.39

  • upgrade to 1.40

  • update to 1.41

  • updating to 2.0

  • update to 2.1

  • upgrade to 2.2

  • Upgrade to 2.3

  • update to 2.4

  • upgrade to 2.5

  • reset and upgrade to 2.6

  • upgrade to 2.7

Jack-Works
Jack-Works

🤖 Merge PR #56177 Add types for node-turn by @garzj

Jack-Works
Jack-Works

🤖 Merge PR #56198 [k6] Add types for http.url method by @EdvinasDaugirdas

Jack-Works
Jack-Works

add types for crypto-pouch (#56093)

  • add: new type definition for crypto-pouch

  • removed unneccesary rule

  • Updated definiton file with newer syntax which eliminated need for specialized linting rules

Co-authored-by: RambleOnRose [email protected]

Jack-Works
Jack-Works

🤖 Merge PR #56069 remove(ng-cordova): remove unmaintained package by @peterblazejewicz

The package is obsolate and marked as archived: https://github.com/ionic-team/ng-cordova#this-library-is-obsolete

We cannot move other stuff forward until we remove those sources from DT: #55881

As this package was marked as obsolate, this is removal, not 'no longer needed' path.

Thanks!

Jack-Works
Jack-Works

🤖 Merge PR #56213 Add DOM to axios-curlirize dependencies by @sandersn

It is (temporarily?) required by [email protected].

Jack-Works
Jack-Works

🤖 Merge PR #56189 fix(markdown-it): remove highlight-js direct dependency by @peterblazejewicz

highlight-js is dev type dependency and is external to core features and there is no dependency (imports) in package itself.

This change reflects this removing depndency on highlight.js from markdown-it types.

https://github.com/markdown-it/markdown-it/blob/master/package.json#L39-L45

/cc @Lemmingh

Fixes #56187

Jack-Works
Jack-Works

🤖 Merge PR #56137 update(concurrently): support for Chalk colors by @peterblazejewicz

v2.3 added support for Chalk's (direct dependency) colors. This change reflect this adding typed colors support to new prefixColors options:

https://github.com/open-cli-tools/concurrently/pull/286/files

Thanks!

Jack-Works
Jack-Works

🤖 Merge PR #56094 url-format-lax: initial definition by @yoursunny

Jack-Works
Jack-Works

🤖 Merge PR #55881 fix(angular): remove obsolete $compileProvider.preAssignBindingsEnabled() method by @gkalpak

The $compileProvider.preAssignBindingsEnabled() method has been removed from AngularJS since version 1.7.0 (see [email protected]). The latest version (which the types are targeting) is v1.8.2, where the method is long gone.

This commit removes the method from the typings as well.

Jack-Works
Jack-Works

add(cypress-recurse): definition file (#56162)

Slightly modified types for inline JSDocs for cypress-recurse: https://github.com/bahmutov/cypress-recurse

Thanks!

commit sha: dfb6c69cc0b67630e67391dcabdfc06fcc41ed81

push time in 1 day ago
Previous