Justintime50

Justintime50

Developer Experience Lead & Software Engineer @EasyPost, IT Pro, Tech Enthusiast.

Member Since 3 years ago

@easypost, Utah, USA

Experience Points
516
follower
Lessons Completed
178
follow
Lessons Completed
780
stars
Best Reply Awards
51
repos

2486 contributions in the last year

Pinned
⚡ A powerful tool to concurrently clone or pull user and org repos and gists to create a GitHub archive.
⚡ A Python project template to save you time and energy.
⚡ The lightweight Docker Compose deployment platform.
⚡ Get the dependency tree of your Python virtual environment via Pip.
⚡ Dummy Address Data (DAD) - Retrieve real addresses from all around the world. (Node Client Library)
⚡ Minimalist blog featuring syntax highlighting, images, comments, themes, RSS, and SEO out of the box.
Activity
May
18
13 hours ago
pull request

Justintime50 merge to EasyPost/easypost-csharp

Justintime50
Justintime50

add if statement to make sure an API key is required before making li…

Description

Add if statement to check if there is an API key before making any live API calls.

Testing

E2E test with no API key, an error is thrown. Screen Shot 2022-05-17 at 5 16 18 PM

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
May
17
1 day ago
open pull request

Justintime50 wants to merge EasyPost/easypost-csharp

Justintime50
Justintime50

add if statement to make sure an API key is required before making li…

Description

Add if statement to check if there is an API key before making any live API calls.

Testing

E2E test with no API key, an error is thrown. Screen Shot 2022-05-17 at 5 16 18 PM

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
Justintime50
Justintime50

Hmm, if it's public there's a possibility users could be accessing these no? And if so, making it internal would suddenly make them unaccessible

pull request

Justintime50 merge to EasyPost/easypost-csharp

Justintime50
Justintime50

add if statement to make sure an API key is required before making li…

Description

Add if statement to check if there is an API key before making any live API calls.

Testing

E2E test with no API key, an error is thrown. Screen Shot 2022-05-17 at 5 16 18 PM

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
pull request

Justintime50 merge to EasyPost/easypost-csharp

Justintime50
Justintime50

add if statement to make sure an API key is required before making li…

Description

Add if statement to check if there is an API key before making any live API calls.

Testing

E2E test with no API key, an error is thrown. Screen Shot 2022-05-17 at 5 16 18 PM

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
open pull request

Justintime50 wants to merge EasyPost/easypost-csharp

Justintime50
Justintime50

add if statement to make sure an API key is required before making li…

Description

Add if statement to check if there is an API key before making any live API calls.

Testing

E2E test with no API key, an error is thrown. Screen Shot 2022-05-17 at 5 16 18 PM

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
Justintime50
Justintime50

Why were these made internal, this is a breaking change

open pull request

Justintime50 wants to merge EasyPost/easypost-csharp

Justintime50
Justintime50

add if statement to make sure an API key is required before making li…

Description

Add if statement to check if there is an API key before making any live API calls.

Testing

E2E test with no API key, an error is thrown. Screen Shot 2022-05-17 at 5 16 18 PM

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
Justintime50
Justintime50

Hmmm... we shouldn't need to invoke VCR here at all. We should really be making a new client with an empty API key.

open pull request

Justintime50 wants to merge EasyPost/easypost-csharp

Justintime50
Justintime50

add if statement to make sure an API key is required before making li…

Description

Add if statement to check if there is an API key before making any live API calls.

Testing

E2E test with no API key, an error is thrown. Screen Shot 2022-05-17 at 5 16 18 PM

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
Justintime50
Justintime50

This needs a line break after the header

## Next Release

Requests will now fail fast with an error if an API key is not provided instead of making a live API call with no key.
open pull request

Justintime50 wants to merge EasyPost/easypost-csharp

Justintime50
Justintime50

add if statement to make sure an API key is required before making li…

Description

Add if statement to check if there is an API key before making any live API calls.

Testing

E2E test with no API key, an error is thrown. Screen Shot 2022-05-17 at 5 16 18 PM

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
Justintime50
Justintime50
      EASYPOST_TEST_API_KEY: "123"
      EASYPOST_PROD_API_KEY: "123"
pull request

Justintime50 merge to EasyPost/easypost-csharp

Justintime50
Justintime50

add if statement to make sure an API key is required before making li…

Description

Add if statement to check if there is an API key before making any live API calls.

Testing

E2E test with no API key, an error is thrown. Screen Shot 2022-05-17 at 5 16 18 PM

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
Activity icon
issue

Justintime50 issue comment EasyPost/easypost-csharp

Justintime50
Justintime50

add if statement to make sure an API key is required before making li…

…ving API calls.:

Description

Add if statement to check if there is an API key before making any live API calls.

Testing

E2E test with no API key, an error is thrown. Screen Shot 2022-05-17 at 5 16 18 PM

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
Justintime50
Justintime50

Code looks good. We able to add a simple unit test to make sure this works too? I meant to do this on the others and will add it in the future.

pull request

Justintime50 pull request EasyPost/easypost-go

Justintime50
Justintime50

refactor: consolidate struct location to top of files

Description

Moves structs to the top of the file so they are all next to each other. Ensures structs appear first followed by functions for easier maintenance and grouping.

Testing

NA

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
Activity icon
created branch

Justintime50 in EasyPost/easypost-go create branch consolidate_structs

createdAt 16 hours ago
pull request

Justintime50 merge to EasyPost/easypost-php

Justintime50
Justintime50

- Adds the EndShipper beta class

Description

Adds the new EndShipper beta class with create, retrieve, all, and save functions. This is the fully-qualified address object that the USPS will start requiring shortly.

Testing

Add unit tests

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
open pull request

Justintime50 wants to merge EasyPost/easypost-php

Justintime50
Justintime50

- Adds the EndShipper beta class

Description

Adds the new EndShipper beta class with create, retrieve, all, and save functions. This is the fully-qualified address object that the USPS will start requiring shortly.

Testing

Add unit tests

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
Justintime50
Justintime50

Nit: We could have reassigned these to the individual fixture values for each field so we didn't need to reuse these values.

pull request

Justintime50 merge to EasyPost/easypost-php

Justintime50
Justintime50

- Adds the EndShipper beta class

Description

Adds the new EndShipper beta class with create, retrieve, all, and save functions. This is the fully-qualified address object that the USPS will start requiring shortly.

Testing

Add unit tests

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
pull request

Justintime50 merge to EasyPost/easypost-php

Justintime50
Justintime50

- Adds the EndShipper beta class

Description

Adds the new EndShipper beta class with create, retrieve, all, and save functions. This is the fully-qualified address object that the USPS will start requiring shortly.

Testing

Add unit tests

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
pull request

Justintime50 pull request EasyPost/easypost-ruby

Justintime50
Justintime50

feat: adds EndShipper beta class

Description

Adds the new EndShipper beta class with create, retrieve, all, and update functions. This is the fully-qualified address object that the USPS will start requiring shortly.

Testing

  • Added unit tests for all added functions

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
push

Justintime50 push EasyPost/easypost-ruby

Justintime50
Justintime50

feat: adds EndShipper beta class

Justintime50
Justintime50

Merge pull request #172 from EasyPost/endshipper

feat: adds EndShipper beta class

commit sha: 5536584678fabfd815d890d5a67a27ebdffe8297

push time in 18 hours ago
Activity icon
delete

Justintime50 in EasyPost/easypost-ruby delete branch endshipper

deleted time in 18 hours ago
push

Justintime50 push EasyPost/easypost-ruby

Justintime50
Justintime50

feat: scrubs sensitive data from cassettes

Justintime50
Justintime50

feat: filter credit card query params

Justintime50
Justintime50

Merge pull request #173 from EasyPost/scrub_cassettes

feat: scrubs sensitive data from cassettes

Justintime50
Justintime50
Justintime50
Justintime50

fix: throw error if no API key provided

Justintime50
Justintime50

Merge pull request #175 from EasyPost/require_api_key

fix: throw error if no API key provided

Justintime50
Justintime50

Merge pull request #174 from EasyPost/empty_body_json_parsing

fix: empty body JSON parsing

Justintime50
Justintime50

feat: adds EndShipper beta class

commit sha: 9e3a649017badc2ef342fe207d9f4471a5ae7e1b

push time in 18 hours ago
started
started time in 18 hours ago
pull request

Justintime50 merge to EasyPost/easypost-node

Justintime50
Justintime50

Add EndShipper beta class.

Description

Adds the new EndShipper beta class with retrieve, all, and save functions. This is the fully-qualified address object that the USPS will start requiring shortly. Add BaseAddress propTypes that Address and EndShipper can use

Testing

Add unit tests

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
May
16
2 days ago
pull request

Justintime50 merge to EasyPost/easypost-node

Justintime50
Justintime50

Add EndShipper beta class.

Description

Adds the new EndShipper beta class with retrieve, all, and save functions. This is the fully-qualified address object that the USPS will start requiring shortly.

Testing

Add unit tests

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
pull request

Justintime50 merge to EasyPost/easypost-node

Justintime50
Justintime50

Add EndShipper beta class.

Description

Adds the new EndShipper beta class with retrieve, all, and save functions. This is the fully-qualified address object that the USPS will start requiring shortly.

Testing

Add unit tests

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
open pull request

Justintime50 wants to merge EasyPost/easypost-node

Justintime50
Justintime50

Add EndShipper beta class.

Description

Adds the new EndShipper beta class with retrieve, all, and save functions. This is the fully-qualified address object that the USPS will start requiring shortly.

Testing

Add unit tests

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)
Justintime50
Justintime50

We can directly assign baseAddressPropTypes here to propTypes probably.

Previous