KennethKinLum

KennethKinLum

Member Since 5 years ago

Experience Points
2
follower
Lessons Completed
0
follow
Lessons Completed
9
stars
Best Reply Awards
54
repos

122 contributions in the last year

Pinned
⚡ 🏭 The most lightweight, customizable React markdown component.
⚡ Using the native Mac Github app
⚡ Pro Git Book Content, 1st Edition - See 2nd edition at progit2
⚡ Pro Git 2nd Edition
⚡ a package manager for javascript
Activity
Oct
27
1 month ago
push

KennethKinLum push KennethKinLum/webdriverio

KennethKinLum
KennethKinLum

Update website/docs/Options.md

Co-authored-by: Christian Bromann [email protected]

commit sha: 91a57f54a4ba70938818361360b29f2555353de1

push time in 1 month ago
pull request

KennethKinLum merge to webdriverio/webdriverio

KennethKinLum
KennethKinLum

add comments for maxInstances default value

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

open pull request

KennethKinLum wants to merge webdriverio/webdriverio

KennethKinLum
KennethKinLum

add comments for maxInstances default value

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Activity icon
issue

KennethKinLum issue comment webdriverio/webdriverio

KennethKinLum
KennethKinLum

[📖 Docs]: maxInstances

Pre-check

  • I know I can edit the docs but prefer to file this issue

Describe the improvement

Other

Description of the improvement / report

the maxInstances is said to be defaulted to 100 https://webdriver.io/docs/options/#maxinstances but I wonder, how can it be so big?

In our system, if it is defaulted to 25, then if I run the test locally, I saw 12 Chrome browsers all popping up at the same time, and then I can click on other app, and the MacBook Pro 16 (Intel) is just non-responsive. I am wondering why only about 12... could the computer not able to handle 25 so it only did 12? (there are, say, more than 40 tests altogether).

How come we push the computer to the brink of running out of memory, etc... I'd imagine if it is 6 running all at the same time, it'd be pushing the computer to quite a heavy load. (with other apps running on our computer too... sometimes a few Visual Studio Code windows and perhaps 25 tabs on our usual Google Chrome).

If it is headless, it may be able to support more, but how much would be too much?

If it is 100, would it be too much?

Also, we had issues about race conditions, which is, if we clone a single user account and run the tests, because some test may "add a row", and then remove it later, but if another test happens to also add a row, and then 3 steps later, click on that row on the screen and assert it is that row's name, it might get the name of the first test and therefore fail the test. So it seems, if it is 12 tests running at the same time, or 9, or 16 (if headless), they do run into race condition issues... so Jenkins may success, or fail, and it can be random...

Can the docs mention about the default number 100, and if any, some past insight about the tests having race conditions?

Code of Conduct

  • I agree to follow this project's Code of Conduct
pull request

KennethKinLum pull request webdriverio/webdriverio

KennethKinLum
KennethKinLum

add comments for maxInstances default value

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Activity icon
created branch

KennethKinLum in KennethKinLum/webdriverio create branch add_comments_for_maxInstances_default_value

createdAt 1 month ago
push

KennethKinLum push KennethKinLum/webdriverio

KennethKinLum
KennethKinLum

wording fixes

closes #7501 closes #7499 closes #7503 closes #7504 closes #7505

KennethKinLum
KennethKinLum

add more docs on capabilities - closes #7498

KennethKinLum
KennethKinLum

Bump @octokit/rest from 18.11.1 to 18.11.4 (#7518)

Bumps @octokit/rest from 18.11.1 to 18.11.4.


updated-dependencies:

  • dependency-name: "@octokit/rest" dependency-type: direct:development update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] [email protected]

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

KennethKinLum
KennethKinLum

Bump aws-sdk from 2.995.0 to 2.999.0 (#7517)

Bumps aws-sdk from 2.995.0 to 2.999.0.


updated-dependencies:

  • dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] [email protected]

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

KennethKinLum
KennethKinLum

Bump mime-types from 2.1.32 to 2.1.33 (#7516)

Bumps mime-types from 2.1.32 to 2.1.33.


updated-dependencies:

  • dependency-name: mime-types dependency-type: direct:development update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] [email protected]

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

KennethKinLum
KennethKinLum

Bump devtools-protocol from 0.0.925217 to 0.0.927104 (#7515)

Bumps devtools-protocol from 0.0.925217 to 0.0.927104.


updated-dependencies:

  • dependency-name: devtools-protocol dependency-type: direct:production update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] [email protected]

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

KennethKinLum
KennethKinLum

Bump jest-circus from 27.2.0 to 27.2.4 (#7514)

Bumps jest-circus from 27.2.0 to 27.2.4.


updated-dependencies:

  • dependency-name: jest-circus dependency-type: direct:development update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] [email protected]

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

KennethKinLum
KennethKinLum

Bump @typescript-eslint/eslint-plugin from 4.31.2 to 4.32.0 (#7512)

Bumps @typescript-eslint/eslint-plugin from 4.31.2 to 4.32.0.


updated-dependencies:

  • dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] [email protected]

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

KennethKinLum
KennethKinLum

Bump aria-query from 4.2.2 to 5.0.0 (#7511)

Bumps aria-query from 4.2.2 to 5.0.0.


updated-dependencies:

  • dependency-name: aria-query dependency-type: direct:production update-type: version-update:semver-major ...

Signed-off-by: dependabot[bot] [email protected]

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

KennethKinLum
KennethKinLum

Bump @cucumber/gherkin from 19.0.3 to 22.0.0 (#7509)

Bumps @cucumber/gherkin from 19.0.3 to 22.0.0.


updated-dependencies:

  • dependency-name: "@cucumber/gherkin" dependency-type: direct:production update-type: version-update:semver-major ...

Signed-off-by: dependabot[bot] [email protected]

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

KennethKinLum
KennethKinLum

Ignore errors in releaseActions click command (#7508)

KennethKinLum
KennethKinLum

fix status type in afterScenario hook of BS service (#7507)

KennethKinLum
KennethKinLum

feat(shared-store-service): export set and get value globally (#7519)

  • feat(shared-store-service): export set and get value globally

  • review comments

KennethKinLum
KennethKinLum

feat(wdio-junit-reporter): allow to override className format (#7525)

  • feat(wdio-junit-reporter): allow to override className format

  • review

KennethKinLum
KennethKinLum

7324 - added support for #3rdparty readme's and to support different branches (#7529)

KennethKinLum
KennethKinLum

Bump aws-sdk from 2.999.0 to 2.1004.0 (#7542)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

KennethKinLum
KennethKinLum

Bump @typescript-eslint/parser from 4.31.1 to 4.33.0 (#7538)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

KennethKinLum
KennethKinLum

Bump devtools-protocol from 0.0.927104 to 0.0.928170 (#7535)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit sha: e3dd323e71ed8c37b16f835bbdce41526837a4aa

push time in 1 month ago
Activity icon
issue

KennethKinLum issue comment webdriverio/webdriverio

KennethKinLum
KennethKinLum

[📖 Docs]: maxInstances

Pre-check

  • I know I can edit the docs but prefer to file this issue

Describe the improvement

Other

Description of the improvement / report

the maxInstances is said to be defaulted to 100 https://webdriver.io/docs/options/#maxinstances but I wonder, how can it be so big?

In our system, if it is defaulted to 25, then if I run the test locally, I saw 12 Chrome browsers all popping up at the same time, and then I can click on other app, and the MacBook Pro 16 (Intel) is just non-responsive. I am wondering why only about 12... could the computer not able to handle 25 so it only did 12? (there are, say, more than 40 tests altogether).

How come we push the computer to the brink of running out of memory, etc... I'd imagine if it is 6 running all at the same time, it'd be pushing the computer to quite a heavy load. (with other apps running on our computer too... sometimes a few Visual Studio Code windows and perhaps 25 tabs on our usual Google Chrome).

If it is headless, it may be able to support more, but how much would be too much?

If it is 100, would it be too much?

Also, we had issues about race conditions, which is, if we clone a single user account and run the tests, because some test may "add a row", and then remove it later, but if another test happens to also add a row, and then 3 steps later, click on that row on the screen and assert it is that row's name, it might get the name of the first test and therefore fail the test. So it seems, if it is 12 tests running at the same time, or 9, or 16 (if headless), they do run into race condition issues... so Jenkins may success, or fail, and it can be random...

Can the docs mention about the default number 100, and if any, some past insight about the tests having race conditions?

Code of Conduct

  • I agree to follow this project's Code of Conduct
KennethKinLum
KennethKinLum

If it is 100, would it be too much?

I was able to run 100 remote tests using Sauce Labs on my MacBook Pro. Such number is of course not possible if you want to run them locally.

You mean, Sauce Labs have machine that is powerful enough to run 100 Google Chrome app at the same time? Is it headed or headless? And I mean... what kind of machine is that... when even a US$3500 MacBook Pro may not be able to run 20 at a time... if they are all headless, I guess it is more possible. But still... just think about spawning 100 text apps (like Ruby or Python) on a MacBook Pro, that's heavy too.

Can the docs mention about the default number 100, and if any, some past insight about the tests having race conditions?

I think a general advise here is to keep your tests isolated. Have one session that deals with these rows (e.g. adding and removing them) and other sessions that test something else.

The number 100 was chosen arbitrarily. Not sure if this is an information that would be useful in the docs? What do you think?

Maybe you can add 100 is for when using Sauce Labs, and what might be a range of reasonable numbers when developer run it locally on their machines?

Activity icon
issue

KennethKinLum issue webdriverio/webdriverio

KennethKinLum
KennethKinLum

[📖 Docs]: maxInstances

Pre-check

  • I know I can edit the docs but prefer to file this issue

Describe the improvement

Other

Description of the improvement / report

the maxInstances is said to be defaulted to 100 https://webdriver.io/docs/options/#maxinstances but I wonder, how can it be so big?

In our system, if it is defaulted to 25, then if I run the test locally, I saw 12 Chrome browsers all popping up at the same time, and then I can click on other app, and the MacBook Pro 16 (Intel) is just non-responsive. I am wondering why only about 12... could the computer not able to handle 25 so it only did 12? (there are, say, more than 40 tests altogether).

How come we push the computer to the brink of running out of memory, etc... I'd imagine if it is 6 running all at the same time, it'd be pushing the computer to the limit.

If it is headless, it may be able to support more, but how much would be too much?

  1. If it is 100, would it be too much?

Also, we had issues about race conditions, which is, if we clone a single user account and run the tests, because some test may "add a row", and then remove it later, but if another test happens to also add a row, and then 3 steps later, click on that row on the screen and assert it is that row's name, it might get the name of the first test and therefore fail the test. So it seems, if it is 12 tests running at the same time, or 9, or 16 (if headless), they do run into race condition issues...

Can the docs mention about the default number 100, and if any, some past insight about the tests having race conditions?

Code of Conduct

  • I agree to follow this project's Code of Conduct
Oct
26
1 month ago
Activity icon
issue

KennethKinLum issue comment microsoft/playwright

KennethKinLum
KennethKinLum

I don't even know what Hacktoberfest and I don't want any T-shirt. I am already too busy with work. If it is any more clear, I can wait until Nov 1 to do it. But I think

  1. This is a valid PR
  2. You made an assumption based on your own thinking
  3. You outright closed a valid PR, claiming that it must be for a purpose that you think must be the reason

I can wait until Nov 1, but it just wasted my effort

Activity icon
issue

KennethKinLum issue comment microsoft/playwright

KennethKinLum
KennethKinLum

Making testProject more clear

as per https://github.com/microsoft/playwright/issues/9733#issuecomment-951428289 If it is testProject, why not name it testProject? Why name it config to add an extra confusion?

KennethKinLum
KennethKinLum

I don't even know what Hacktoberfest and I don't want any T-shirt. I am already too busy with work. If it is any more clear, I can wait until Nov 1 to do it. But I think

  1. This is a valid PR
  2. You made an assumption based on your own thinking
  3. You outright closed a valid PR, claiming that it must be for a purpose that you think must be the reason

I can wait until Nov 1, but it just wasted my effort

pull request

KennethKinLum pull request microsoft/playwright

KennethKinLum
KennethKinLum

Making testProject more clear

as per https://github.com/microsoft/playwright/issues/9733#issuecomment-951428289 If it is testProject, why not name it testProject? Why name it config to add an extra confusion?

Activity icon
issue

KennethKinLum issue comment microsoft/playwright

KennethKinLum
KennethKinLum

Making testProject more clear

as per https://github.com/microsoft/playwright/issues/9733#issuecomment-951428289 If it is testProject, why not name it testProject? Why name it config to add an extra confusion?

KennethKinLum
KennethKinLum

I used the GitHub website to do the PR instead of git CLI... it was messy... so re-doing it using git CLI in https://github.com/microsoft/playwright/pull/9775

pull request

KennethKinLum pull request microsoft/playwright

KennethKinLum
KennethKinLum

Making testProject more clear

as per https://github.com/microsoft/playwright/issues/9733#issuecomment-951428289 If it is testProject, why not name it testProject? Why name it config to add an extra confusion?

Activity icon
created branch

KennethKinLum in KennethKinLum/playwright create branch make_testProject_more_clear

createdAt 1 month ago
Activity icon
created branch

KennethKinLum in KennethKinLum/playwright create branch fix_typo_the_expect_library

createdAt 1 month ago
push

KennethKinLum push KennethKinLum/playwright

KennethKinLum
KennethKinLum

Making testProject more clear

as per https://github.com/microsoft/playwright/issues/9733#issuecomment-951428289 If it is testProject, why not name it testProject? Why name it config to add an extra confusion?

commit sha: ff658f3ef51f20a131140084286168e593f17b02

push time in 1 month ago
Activity icon
created branch

KennethKinLum in KennethKinLum/playwright create branch typo_the_expect_library

createdAt 1 month ago
pull request

KennethKinLum pull request microsoft/playwright

KennethKinLum
KennethKinLum

add the general rule to expect the opposite of the matchers

Activity icon
issue

KennethKinLum issue comment microsoft/playwright

KennethKinLum
KennethKinLum

add the general rule to expect the opposite of the matchers

KennethKinLum
KennethKinLum

It was done on the GitHub website and it was a bit messy. Now it is done using git CLI: https://github.com/microsoft/playwright/pull/9772

pull request

KennethKinLum pull request microsoft/playwright

KennethKinLum
KennethKinLum

add the general rule to expect the opposite of the matchers

Activity icon
created branch

KennethKinLum in KennethKinLum/playwright create branch expect_the_opposite

createdAt 1 month ago
Activity icon
issue

KennethKinLum issue comment microsoft/playwright

KennethKinLum
KennethKinLum

Making testProject more clear

as per https://github.com/microsoft/playwright/issues/9733#issuecomment-951428289 If it is testProject, why not name it testProject? Why name it config to add an extra confusion?

Previous