Maker-Mark

Maker-Mark

I am a curious full-stack engineer with experience developing and deploying applications on the web, App Store, and Play Store. Also on GitLab @ markgoldstein

Member Since 3 years ago

Brooklyn, NY

Experience Points
19
follower
Lessons Completed
40
follow
Lessons Completed
76
stars
Best Reply Awards
87
repos

1107 contributions in the last year

Pinned
⚡ Local Roasters is a location based, personalized coffee experience.
⚡ Contact Keeper is a MERN (MongoDB,Express,React,NodeJS) full stack application. Deployed @ https://contactkeeper1337.herokuapp.com/
⚡ UnderDog is a post wall web app that allows Brooklyn College CS students to share helpful resources and vote on posts
⚡ A basic Rust-Wasm-JS Application that serves WebAssembly code in just a few steps! Feel free to look over the readme and try it yourself!
⚡ This is a basic demo of Implementing the Comparable interface into a class that builds a LinkedLists
⚡ Fullstack application that allows you to signup and track your stocks!
Activity
Nov
15
2 weeks ago
Oct
18
1 month ago
Activity icon
issue

Maker-Mark issue comment react-navigation/react-navigation

Maker-Mark
Maker-Mark

`index` option in navigation.reset does nothing

Current behavior

Calling navigation.reset with index 0 or 1 results in the same behavior. The stack always just focuses on the "top" screen, the one at the last index, here index 1 (when zero indexing for this array). I cant find any documentation on what the index actually does, except for in CommonActions (https://reactnavigation.org/docs/navigation-actions/#reset) where the index sets the focusing screen in the stack, but that's not what I'm seeing here.

  navigation.reset({
            index: 0,
            routes: [
               {
                name: 'Profile',
              },
              {
                name: 'Settings',
              }, 
            ],
          })

Expected behavior

The index param set's what screen is focused. Ie index: 1 would

Reproduction

https://snack.expo.dev/@markclair/navigation-reset-does-not-effect-focused-screen

Platform

  • Android
  • iOS
  • Web
  • Windows
  • MacOS

Packages

Environment

package version
@react-navigation/native 6.0.6
@react-navigation/stack 6.0.11
@react-navigation/native-stack 6.0.0
@react-navigation/bottom-tabs NA
@react-navigation/drawer NA
@react-navigation/material-bottom-tabs NA
@react-navigation/material-top-tabs NA
npm or yarn yarn
Maker-Mark
Maker-Mark

Valid index is 1 because the index of the last route is 1, however there's no need to pass an index here

@satya164 Okay, so I'm confused when it would be necessary to pass an index. If 1 is not needed since Settings is the last route in the stack anyway, why wouldn't 0 be valid, since 0 is the second screen in the stack?

It just seems not to make sense that 0 and 1 would have no effect. Can you link me a snack that shows how you can use index and it actually having an effect on the reset?

Thanks

Oct
15
1 month ago
Activity icon
issue

Maker-Mark issue comment react-navigation/react-navigation

Maker-Mark
Maker-Mark

`index` option in navigation.reset does nothing

Current behavior

Calling navigation.reset with index 0 or 1 results in the same behavior. The stack always just focuses on the "top" screen, the one at the last index, here index 1 (when zero indexing for this array). I cant find any documentation on what the index actually does, except for in CommonActions (https://reactnavigation.org/docs/navigation-actions/#reset) where the index sets the focusing screen in the stack, but that's not what I'm seeing here.

  navigation.reset({
            index: 0,
            routes: [
               {
                name: 'Profile',
              },
              {
                name: 'Settings',
              }, 
            ],
          })

Expected behavior

The index param set's what screen is focused. Ie index: 1 would

Reproduction

https://snack.expo.dev/@markclair/navigation-reset-does-not-effect-focused-screen

Platform

  • Android
  • iOS
  • Web
  • Windows
  • MacOS

Packages

Environment

package version
@react-navigation/native 6.0.6
@react-navigation/stack 6.0.11
@react-navigation/native-stack 6.0.0
@react-navigation/bottom-tabs NA
@react-navigation/drawer NA
@react-navigation/material-bottom-tabs NA
@react-navigation/material-top-tabs NA
npm or yarn yarn
Maker-Mark
Maker-Mark

@satya164 Hmm, so what would be a valid index? I'm having trouble connecting the stack order and index.

Thanks for the quick response! I saw your previous comment on another issue about the index, but it didn't clear this up.

Activity icon
issue

Maker-Mark issue comment react-native-webview/react-native-webview

Maker-Mark
Maker-Mark

Support React Native Web

Is your feature request related to a problem? If so, Please describe. You cannot use a full-featured webview in react native web (ie expo web). For example, there is no hook into if the page it loading, like there is on the react-native webview

Describe the solutions you came up with

Additional context

Maker-Mark
Maker-Mark

Used, but cannot call "injectedJavaScript"

What do you mean, you used it but cannot call it?

Activity icon
issue

Maker-Mark issue react-navigation/react-navigation

Maker-Mark
Maker-Mark

`index` option in navigation.reset does nothing

Current behavior

Calling navigation.reset with index 0 or 1 results in the same behavior. The stack always just focuses on the "top" screen, the one at the last index, here index 1 (when zero indexing for this array). I cant find any documentation on what the index actually does, except for in CommonActions (https://reactnavigation.org/docs/navigation-actions/#reset) where the index sets the focusing screen in the stack, but that's not what I'm seeing here.

  navigation.reset({
            index: 0,
            routes: [
               {
                name: 'Profile',
              },
              {
                name: 'Settings',
              }, 
            ],
          })

Expected behavior

The index param set's what screen is focused. Ie index: 1 would

Reproduction

https://snack.expo.dev/@markclair/navigation-reset-does-not-effect-focused-screen

Platform

  • Android
  • iOS
  • Web
  • Windows
  • MacOS

Packages

Environment

package version
@react-navigation/native 6
@react-navigation/stack 6
@react-navigation/native-stack 6
npm or yarn yarn
Oct
5
1 month ago
started
started time in 1 month ago
Sep
23
2 months ago
started
started time in 2 months ago
Sep
19
2 months ago
Activity icon
issue

Maker-Mark issue comment Maker-Mark/Stock-Portfolio-App

Maker-Mark
Maker-Mark

Error when trying to register

Hello @Maker-Mark ,

I just wanted to try out this App, but when I registered my account on this heroku link it claims, that the email-Adress is already in use.

This Error occurs regardless of which email I enter, so I guess it is an error with the database connection.

Maker-Mark
Maker-Mark

@JakobJBauer Yes I think I deleted the collection uri for the app. Feel free to fork it and set it up with your own mongo db, it should work fine!

push

Maker-Mark push Maker-Mark/Rust-WebAssembly-React-Adder

Maker-Mark
Maker-Mark

Bump path-parse from 1.0.6 to 1.0.7 in /wasm-test

Bumps path-parse from 1.0.6 to 1.0.7.


updated-dependencies:

  • dependency-name: path-parse dependency-type: indirect ...

Signed-off-by: dependabot[bot] [email protected]

Maker-Mark
Maker-Mark

Merge pull request #18 from Maker-Mark/dependabot/npm_and_yarn/wasm-test/path-parse-1.0.7

Bump path-parse from 1.0.6 to 1.0.7 in /wasm-test

commit sha: ebff178c523c9676af2164146ce8a2ed92c29aea

push time in 2 months ago
pull request

Maker-Mark pull request Maker-Mark/Rust-WebAssembly-React-Adder

Maker-Mark
Maker-Mark

Bump path-parse from 1.0.6 to 1.0.7 in /wasm-test

Bumps path-parse from 1.0.6 to 1.0.7.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

push

Maker-Mark push Maker-Mark/Rust-WebAssembly-React-Adder

Maker-Mark
Maker-Mark

Bump tar from 4.4.8 to 4.4.19 in /wasm-test

Bumps tar from 4.4.8 to 4.4.19.


updated-dependencies:

  • dependency-name: tar dependency-type: indirect ...

Signed-off-by: dependabot[bot] [email protected]

Maker-Mark
Maker-Mark

Merge pull request #19 from Maker-Mark/dependabot/npm_and_yarn/wasm-test/tar-4.4.19

Bump tar from 4.4.8 to 4.4.19 in /wasm-test

commit sha: 33a390c314c35f7b4cad85cf878228578e99b4b4

push time in 2 months ago
pull request

Maker-Mark pull request Maker-Mark/Rust-WebAssembly-React-Adder

Maker-Mark
Maker-Mark

Bump tar from 4.4.8 to 4.4.19 in /wasm-test

Bumps tar from 4.4.8 to 4.4.19.

Commits
  • 9a6faa0 4.4.19
  • 70ef812 drop dirCache for symlink on all platforms
  • 3e35515 4.4.18
  • 52b09e3 fix: prevent path escape using drive-relative paths
  • bb93ba2 fix: reserve paths properly for unicode, windows
  • 2f1bca0 fix: prune dirCache properly for unicode, windows
  • 9bf70a8 4.4.17
  • 6aafff0 fix: skip extract if linkpath is stripped entirely
  • 5c5059a fix: reserve paths case-insensitively
  • fd6accb 4.4.16
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Sep
18
2 months ago
Sep
16
2 months ago
open pull request

Maker-Mark wants to merge TheAlgorithms/Javascript

Maker-Mark
Maker-Mark

Sliding Window Algorithem

I have now used Standard.js Hope everything is to your satisfaction.

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • [ V] Add an algorithm?

Checklist:

  • [V] I have read CONTRIBUTING.md.
  • [V] This pull request is all my own work -- I have not plagiarized.
  • [V] I know that pull requests will not be merged if they fail the automated tests.
  • [V] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [V] All new JavaScript files are placed inside an existing directory.
  • [ V All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
Maker-Mark
Maker-Mark

This example won't work. Do you mean slidingWindow?

pull request

Maker-Mark merge to TheAlgorithms/Javascript

Maker-Mark
Maker-Mark

Sliding Window Algorithem

I have now used Standard.js Hope everything is to your satisfaction.

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • [ V] Add an algorithm?

Checklist:

  • [V] I have read CONTRIBUTING.md.
  • [V] This pull request is all my own work -- I have not plagiarized.
  • [V] I know that pull requests will not be merged if they fail the automated tests.
  • [V] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [V] All new JavaScript files are placed inside an existing directory.
  • [ V All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
started
started time in 2 months ago
started
started time in 2 months ago
Sep
8
2 months ago
Activity icon
issue

Maker-Mark issue react-native-webview/react-native-webview

Maker-Mark
Maker-Mark

Support React Native Web

Is your feature request related to a problem? If so, Please describe. You cannot use a full-featured webview in react native web (ie expo web). For example, there is no hook into if the page it loading, like there is on the react-native webview

Describe the solutions you came up with

Additional context

Sep
7
2 months ago
started
started time in 2 months ago