Maker-Mark

Maker-Mark

I am a curious software engineer with experience developing and deploying web and mobile applications. Also on GitLab @ markgoldstein

Member Since 3 years ago

Brooklyn, NY

Experience Points
22
follower
Lessons Completed
49
follow
Lessons Completed
104
stars
Best Reply Awards
89
repos

1634 contributions in the last year

Pinned
⚡ With this preview action, you can test changes made in pull requests via Expo Go or custom development client (created with expo-dev-client) just by scanning QR code.
⚡ UnderDog is a post wall web app that allows Brooklyn College CS students to share helpful resources and vote on posts
⚡ Class MyMap uses an ArrayList of LinkedLists(that have a Pair) to mimic a HashTable. Using the HashTable, class MyMap has inner class Pair that acts as the <key, value> pair.
⚡ Fullstack application that allows you to signup and track your stocks!
Activity
May
16
5 days ago
May
10
1 week ago
Activity icon
issue

Maker-Mark issue comment expo/eas-cli

Maker-Mark
Maker-Mark

EAS Build Only Failing for profiles with `developmentClient: true`

Build/Submit details page URL

https://expo.dev/accounts/markcodelet/projects/codelet-app/builds/28299482-9dc1-4a7d-b669-b1c7176aaaf8

Summary

I'm having a hard time making a development client for my app using EAS. The app builds fine for internal distribution and production, there just seems to be an issue when building the development client.

Update: I ran the build without expo-dev-client and the react-native-safe-area-contex and the build succeeded but the dev client downloaded would just crash. Then I re-installed each actual dependency, and now it WORKS. This makes no sense, I ran in multiple times, with the --clear-cache flag, so I have no idea what it was that was making this broken. I'd still like to leave this open in case there's an underlying bug. Here to helo.

Managed or bare?

Managed

Environment

Expo CLI 5.0.3 environment info: System: OS: macOS 11.6.2 Shell: 5.8 - /bin/zsh Binaries: Node: 16.13.1 - ~/.nvm/versions/node/v16.13.1/bin/node Yarn: 1.22.17 - ~/.nvm/versions/node/v16.13.1/bin/yarn npm: 8.1.2 - ~/.nvm/versions/node/v16.13.1/bin/npm Watchman: 2021.11.08.00 - /usr/local/bin/watchman Managers: CocoaPods: 1.11.2 - /usr/local/bin/pod SDKs: iOS SDK: Platforms: iOS 14.5, DriverKit 20.4, macOS 11.3, tvOS 14.5, watchOS 7.4 IDEs: Android Studio: 4.2 AI-202.7660.26.42.7486908 Xcode: 12.5.1/12E507 - /usr/bin/xcodebuild npmPackages: @expo/webpack-config: ~0.16.2 => 0.16.15 expo: ^44.0.0 => 44.0.4 react: 17.0.1 => 17.0.1 react-dom: 17.0.1 => 17.0.1 react-native: 0.64.3 => 0.64.3 react-native-web: 0.17.1 => 0.17.1 npmGlobalPackages: eas-cli: 0.43.0 Expo Workflow: managed

Error output

The output is best seen in context in the build URL. In short, it's happening in the "fastlane" section of the build where the app and there are a few warnings when it comes to linking expo dev client

Reproducible demo or steps to reproduce from a blank project

I cannot reproduce this, other managed projects I have been making a dev build fine and I can't reproduce it on a bare project.

Maker-Mark
Maker-Mark

Agreed, tripped me up too

Glad others are finding this. @dsokal Can we get an update if this can be communicated better? Thanks!

May
8
1 week ago
started
started time in 1 week ago
May
6
2 weeks ago
Activity icon
issue

Maker-Mark issue comment agoldis/react-native-mlkit-ocr

Maker-Mark
Maker-Mark

execution MlkitOcr.detectFromFile(path) or MlkitOcr.detectFromFile(path) produce an error

Hello , thanks for your help. i try to use this library and i have an error when a try to use the principal methods :

const resultFromUri = await MlkitOcr.detectFromUri(uri); const resultFromFile = await MlkitOcr.detectFromFile(path);

result : ---> error : [TypeError: null is not an object (evaluating 'MlkitOcr.detectFromFile')]

thanks for your help. i use expo .

Maker-Mark
Maker-Mark

@agoldis, thank you for making this package! There is no example using detectFromFile in this repository, there's only for detectFromUri. I'm getting "No image path provided" even though I absolutely am

No image path provided
at node_modules/react-native/Libraries/BatchedBridge/NativeModules.js:104:50 in promiseMethodWrapper
at node_modules/react-native-mlkit-ocr/src/index.tsx:76:18 in MLKit.detectFromFile
at node_modules/react-native-mlkit-ocr/src/index.tsx:76:18 in MLKit.detectFromFile

Activity icon
issue

Maker-Mark issue comment jhen0409/react-native-debugger

Maker-Mark
Maker-Mark

react-naive-debugger-start doesn't work with expo

  1. run yarn PASS Replace open debugger-ui with Chrome to open React Native Debugger message received
  2. run expo start and Enable Debug JS Remotely debugger-ui chrome is opened instead of the Native Debugger
  3. run find . -name "getDevToolsMiddleware.js"
  4. No results

Note : running $ REACT_DEBUGGER="rndebugger-open --open --expo" expo start does work.

Expo CLI 5.2.0 environment info: System: OS: macOS 12.1 Shell: 5.8 - /bin/zsh Binaries: Node: 16.13.2 - ~/.nvm/versions/node/v16.13.2/bin/node Yarn: 1.22.17 - /usr/local/bin/yarn npm: 8.5.1 - ~/.nvm/versions/node/v16.13.2/bin/npm Managers: CocoaPods: 1.11.2 - /usr/local/bin/pod SDKs: iOS SDK: Platforms: iOS 14.5, DriverKit 20.4, macOS 11.3, tvOS 14.5, watchOS 7.4 IDEs: Android Studio: 4.1 AI-201.8743.12.41.7199119 Xcode: 12.5/12E262 - /usr/bin/xcodebuild npmPackages: babel-preset-expo: 9.0.2 => 9.0.2 expo: ^44.0.0 => 44.0.6 react: 17.0.1 => 17.0.1 react-dom: 17.0.1 => 17.0.1 react-native: 0.64.3 => 0.64.3 react-native-web: 0.17.1 => 0.17.1 npmGlobalPackages: eas-cli: 0.47.0 expo-cli: 5.2.0 Expo Workflow: managed

Maker-Mark
Maker-Mark

It seems to specifically not work with development clients (EAS build)

Apr
29
3 weeks ago
Activity icon
issue

Maker-Mark issue comment expo/eas-cli

Maker-Mark
Maker-Mark

EAS Build Only Failing for profiles with `developmentClient: true`

Build/Submit details page URL

https://expo.dev/accounts/markcodelet/projects/codelet-app/builds/28299482-9dc1-4a7d-b669-b1c7176aaaf8

Summary

I'm having a hard time making a development client for my app using EAS. The app builds fine for internal distribution and production, there just seems to be an issue when building the development client.

Update: I ran the build without expo-dev-client and the react-native-safe-area-contex and the build succeeded but the dev client downloaded would just crash. Then I re-installed each actual dependency, and now it WORKS. This makes no sense, I ran in multiple times, with the --clear-cache flag, so I have no idea what it was that was making this broken. I'd still like to leave this open in case there's an underlying bug. Here to helo.

Managed or bare?

Managed

Environment

Expo CLI 5.0.3 environment info: System: OS: macOS 11.6.2 Shell: 5.8 - /bin/zsh Binaries: Node: 16.13.1 - ~/.nvm/versions/node/v16.13.1/bin/node Yarn: 1.22.17 - ~/.nvm/versions/node/v16.13.1/bin/yarn npm: 8.1.2 - ~/.nvm/versions/node/v16.13.1/bin/npm Watchman: 2021.11.08.00 - /usr/local/bin/watchman Managers: CocoaPods: 1.11.2 - /usr/local/bin/pod SDKs: iOS SDK: Platforms: iOS 14.5, DriverKit 20.4, macOS 11.3, tvOS 14.5, watchOS 7.4 IDEs: Android Studio: 4.2 AI-202.7660.26.42.7486908 Xcode: 12.5.1/12E507 - /usr/bin/xcodebuild npmPackages: @expo/webpack-config: ~0.16.2 => 0.16.15 expo: ^44.0.0 => 44.0.4 react: 17.0.1 => 17.0.1 react-dom: 17.0.1 => 17.0.1 react-native: 0.64.3 => 0.64.3 react-native-web: 0.17.1 => 0.17.1 npmGlobalPackages: eas-cli: 0.43.0 Expo Workflow: managed

Error output

The output is best seen in context in the build URL. In short, it's happening in the "fastlane" section of the build where the app and there are a few warnings when it comes to linking expo dev client

Reproducible demo or steps to reproduce from a blank project

I cannot reproduce this, other managed projects I have been making a dev build fine and I can't reproduce it on a bare project.

Maker-Mark
Maker-Mark

For some reason I totally missed the Xcode logs section, since it was below the message, and also didn't have a red ❌ on it. Perhaps this could be more obvious?

image

Hey Jamon, good to see you around (huge RNR podcast fan :) Glad this issue was not one that just stumped me. Can we get an issue to update the Xcode Logs error to be more obvious? This easily ate up many hours of my day digging into logs.

Apr
22
4 weeks ago
open pull request

Maker-Mark wants to merge necolas/react-native-web

Maker-Mark
Maker-Mark

Allow explicit target for Linking.openURL(), default to "_blank"

This PR extends on the work started by @Sharcoux in PR #1743 and relates to issues #162, #1544, and #1744.

The desire of those tickets was to open Linking.openURL(url) in a new tab, and the solution merged by @necolas in this commit hard-codes the "_blank" target to force a new tab. This is great for people who want new tabs, but inconvenient for people who want to use the same tab.

This PR reworks the method to accept a second argument, Linking.openURL(url, target) for an explicit target. Any value passed will be used as the target, including undefined. The ability to pass undefined allows users to maintain the same browser tab, while arbitrary values allow... well, anything.

For backwards compatibility, if Linking.openURL(url) is called without a target, the default value of "_blank" will be passed. Therefore this change should have zero impact on any code already written, only users henceforth who explicitly pass a target will get the new behavior.

Also, tests added!

Maker-Mark
Maker-Mark

Finally! Thanks for adding this :)

pull request

Maker-Mark merge to necolas/react-native-web

Maker-Mark
Maker-Mark

Allow explicit target for Linking.openURL(), default to "_blank"

This PR extends on the work started by @Sharcoux in PR #1743 and relates to issues #162, #1544, and #1744.

The desire of those tickets was to open Linking.openURL(url) in a new tab, and the solution merged by @necolas in this commit hard-codes the "_blank" target to force a new tab. This is great for people who want new tabs, but inconvenient for people who want to use the same tab.

This PR reworks the method to accept a second argument, Linking.openURL(url, target) for an explicit target. Any value passed will be used as the target, including undefined. The ability to pass undefined allows users to maintain the same browser tab, while arbitrary values allow... well, anything.

For backwards compatibility, if Linking.openURL(url) is called without a target, the default value of "_blank" will be passed. Therefore this change should have zero impact on any code already written, only users henceforth who explicitly pass a target will get the new behavior.

Also, tests added!

started
started time in 4 weeks ago
Apr
7
1 month ago
started
started time in 1 month ago
started
started time in 1 month ago
Apr
2
1 month ago
Activity icon
issue

Maker-Mark issue comment HackerPen/tech-interview-questions

Maker-Mark
Maker-Mark

Add leetcode questions

Array


Binary


Dynamic Programming


Graph


Interval


Linked List


Matrix


String


Tree


Heap

Maker-Mark
Maker-Mark
Activity icon
issue

Maker-Mark issue comment HackerPen/tech-interview-questions

Maker-Mark
Maker-Mark

Add leetcode questions

Array


Binary


Dynamic Programming


Graph


Interval


Linked List


Matrix


String


Tree


Heap

Mar
29
1 month ago
Mar
21
2 months ago
started
started time in 1 month ago
Mar
16
2 months ago
Activity icon
issue

Maker-Mark issue HackerPen/feedback

Maker-Mark
Maker-Mark

Bug: Turning off your camera still engages the camera

Start a session with you camera, turn the camera off, and notice the camera light is still on

Mar
14
2 months ago
Mar
7
2 months ago
started
started time in 2 months ago
Mar
3
2 months ago
Activity icon
issue

Maker-Mark issue comment HackerPen/rfcs

Maker-Mark
Maker-Mark

Bug: Selecting language many times nests comments with starter code for previous starting code

https://user-images.githubusercontent.com/40143016/156433758-62194ca7-a520-4f98-807d-12567a4d1cc1.mov

Maker-Mark
Maker-Mark

@marshallshen Ahh, what's the reasoning for that? If the goal is to have the logic preserve if you switch languages (personally I would not really see a need for this), then why don't you just store the IDE for the language in that session? So if you go back to python3, your old python3 code is there. But if you go to a new language, it's a new starter code.

My advice here would be to keep it as simple as possible. Maybe you can just clear it to avoid storage for each language and just have a passive warning message "changing language will reset you current code" before they switch languages. The current behavior feels very non-intended.

Activity icon
issue

Maker-Mark issue comment HackerPen/rfcs

Maker-Mark
Maker-Mark

Bug: Turning off your camera still engages the camera

Start a session with you camera, turn the camera off, and notice the camera light is still on

Maker-Mark
Maker-Mark

Let me know if you need stronger steps to reproduce!

Activity icon
issue

Maker-Mark issue comment HackerPen/rfcs

Maker-Mark
Maker-Mark

Bug: Turning off your camera still engages the camera

Start a session with you camera, turn the camera off, and notice the camera light is still on

Maker-Mark
Maker-Mark

@marshallshen The camera light was still on after I hit the "camera" button on my picture on the bottom right. Generally, as a user, if I hide my camera I expect the program to stop using my camera too. Also, another unexpected thing was that the camera always starts on. Generally, I like to turn it on. Maybe someone is opening the session but they are not ready to turn the camera on (I can imagine many reasons, ie background, eating, etc)

Mar
2
2 months ago
Activity icon
issue

Maker-Mark issue HackerPen/rfcs

Maker-Mark
Maker-Mark

Feature: Browse questions for interview instead of serving random question for a difficulty.

It's not very helpful to get a random question based on "difficulty". Many times, I have a question in mind I want to give (generally I can give better feedback on a question I'm familiar with). It could also be nice to generate a question based on topics too, or just allow the user to search or see results based off of difficulty + pattern + topic selection.

Activity icon
issue

Maker-Mark issue HackerPen/rfcs

Maker-Mark
Maker-Mark

Bug: Turning off your camera still engages the camera

Start a session with you camera, turn the camera off, and notice the camera light is still on

pull request

Maker-Mark pull request HackerPen/tech-interview-questions

Maker-Mark
Maker-Mark

Creates copy-graph question

Creates Copy graph question @marshallshen Would love a review!

Activity icon
created branch

Maker-Mark in CodeletApp/tech-interview-questions create branch question/copy-graph

createdAt 2 months ago
Previous