MatanYadaev

MatanYadaev

Software Engineer @Showdigs

Member Since 6 years ago

Showdigs, Tel Aviv, Israel

Experience Points
2
follower
Lessons Completed
3
follow
Lessons Completed
35
stars
Best Reply Awards
16
repos

219 contributions in the last year

Pinned
⚡ Laravel Eloquent spatial package.
⚡ Phone number functionality for Laravel 5
⚡ A helper to control the flow of time
⚡ A community-driven content aggregator
⚡ A Postmark adapter for Laravel
⚡ 🔐 JSON Web Token Authentication for Laravel & Lumen
Activity
Oct
12
2 weeks ago
open pull request

MatanYadaev wants to merge ortalYadayev/facebook-ui

MatanYadaev
MatanYadaev
MatanYadaev
MatanYadaev

If the user is logged in and trying to enter the register page - redirect him to the home page, not the 404 page

open pull request

MatanYadaev wants to merge ortalYadayev/facebook-ui

MatanYadaev
MatanYadaev
MatanYadaev
MatanYadaev

Put here a spinner/loading icon while the user is not yet loaded

open pull request

MatanYadaev wants to merge ortalYadayev/facebook-ui

MatanYadaev
MatanYadaev
MatanYadaev
MatanYadaev

Create a file called @types/entities/User.ts and export there a type with the properties that a user entity has. And here put type: Object as PropType<User> (read more here) This way you will have a perfect auto-complete when you type props.user.first_name for example

open pull request

MatanYadaev wants to merge ortalYadayev/facebook-ui

MatanYadaev
MatanYadaev
MatanYadaev
MatanYadaev

This style should be inside the Profile component file

open pull request

MatanYadaev wants to merge ortalYadayev/facebook-ui

MatanYadaev
MatanYadaev
MatanYadaev
MatanYadaev

getUser instead of showUser is a better choice for this method name. This method doesn't show any user, but it does fetch/get it

open pull request

MatanYadaev wants to merge ortalYadayev/facebook-ui

MatanYadaev
MatanYadaev
MatanYadaev
MatanYadaev

Vue recommends having a prefix to any component. Call it AppHeader or FbHeader (FB - Facebook) Same for footers, buttons, etc... FbButton

open pull request

MatanYadaev wants to merge ortalYadayev/facebook-ui

MatanYadaev
MatanYadaev
MatanYadaev
MatanYadaev

SCSS is slightly better than SASS - it's more readable and the syntax is closer to regular CSS. SCSS and SASS are the same engine, with just a different syntax. You just need to change the file extension from sass to scss

open pull request

MatanYadaev wants to merge ortalYadayev/facebook-ui

MatanYadaev
MatanYadaev
MatanYadaev
MatanYadaev

It's better that you will use lazy loading when it comes to page components (like Home). Read more about the concept of lazy loading here: https://vueschool.io/lessons/how-to-lazy-load-routes-with-vue-router

Sep
1
1 month ago
Activity icon
issue

MatanYadaev issue barryvdh/laravel-ide-helper

MatanYadaev
MatanYadaev

Fix return type of `user` method inside form requests

Summary

The return type of $this->user() inside a form request is mixed instead of User. When calling the same method from outside the form request the return type is correct $request->user() // User|null.

Code example

/**
 * @mixin IdeHelperUser
 */
class User extends Authenticatable
{
  //
}
class UserController
{
  public function index(GetUsersRequest $request)
  {
    $user = $request->user(); // User|null
    $user->id; // `id` is auto-completed
  }
}
class GetUsersRequest extends FormRequest
{
  public function authorize(): bool
  {
    $user = $this->user(); // mixed
    $user->id; // `id` isn't auto-completed
  }
}
Aug
31
1 month ago
Activity icon
issue

MatanYadaev issue comment MatanYadaev/laravel-eloquent-spatial

MatanYadaev
MatanYadaev

Package no longer provides a service provider

The composer.json of this package still tries to auto-discover a service provider, but there isn't one.

Proposed solution: remove the auto-discovery line from the composer.json:

https://github.com/MatanYadaev/laravel-eloquent-spatial/blob/c7098c0fb977e7ef0ed550ede164c9e6aec66a8e/composer.json#L50-L55

Activity icon
issue

MatanYadaev issue MatanYadaev/laravel-eloquent-spatial

MatanYadaev
MatanYadaev

Package no longer provides a service provider

The composer.json of this package still tries to auto-discover a service provider, but there isn't one.

Proposed solution: remove the auto-discovery line from the composer.json:

https://github.com/MatanYadaev/laravel-eloquent-spatial/blob/c7098c0fb977e7ef0ed550ede164c9e6aec66a8e/composer.json#L50-L55

Activity icon
published release v1.0.2
createdAt 1 month ago
push

MatanYadaev push MatanYadaev/laravel-eloquent-spatial

MatanYadaev
MatanYadaev

remove auto-discovery part from composer.json

MatanYadaev
MatanYadaev

Merge branch 'master' of github.com:MatanYadaev/laravel-eloquent-spatial

commit sha: f709e8fd4e811acb9b56da18a74b73de5fcffd5f

push time in 1 month ago
Aug
29
1 month ago
Previous