ReactiveCocoa/ReactiveSwift
NachoSoto/AsyncImageView
NachoSoto push RevenueCat/purchases-ios
commit sha： 68378e2316d579a2ce1b38d64e98569a82668633
push time in 10 hours agoNachoSoto pull request RevenueCat/purchases-ios
Fixes [CF-682], and probably #1528.
Looks like possibly something was broken demangling lazy properties with @available in iOS 15.0 (per the 2 bug reports).
This changes the approach to simply having Any? as the value, and making the exposed @available property a derived one.
NachoSoto in RevenueCat/purchases-ios create branch lazy-var-workaround-2
NachoSoto push RevenueCat/purchases-ios
Added String.asData to avoid dealing with Data? (#1566)
Turns out Data(string.utf8) is a much simpler way of converting String to Data that doesn't lead to an Optional.
UTF-8 can represent all valid Unicode code points, so this was always safe, but now we know at compile time.
The reason the old variant returned an Optional is because it accepts other encodings like .ascii which might not be able to represent everything in the String.
This simplifies several parts of the code that were dealing with an error that was impossible.
commit sha： a634e493f165211c79a7ac893b7b571de64d4711
push time in 10 hours ago
NachoSoto in RevenueCat/purchases-ios delete branch string-as-data
NachoSoto pull request RevenueCat/purchases-ios
Turns out Data(string.utf8) is a much simpler way of converting String to Data that doesn't lead to an Optional.
UTF-8 can represent all valid Unicode code points, so this was always safe, but now we know at compile time.
The reason the old variant returned an Optional is because it accepts other encodings like .ascii which might not be able to represent everything in the String.
This simplifies several parts of the code that were dealing with an error that was impossible.
NachoSoto pull request RevenueCat/purchases-ios
I tried adding tests for this, but because the listener is created internally, there is no time to override it with the mock before verifying if listenForTransactions is called.
Will at least prevent #1528 if SK2 is disabled.
NachoSoto push RevenueCat/purchases-ios
PurchasesOrchestrator: don't listen for StoreKit 2 transactions if it's disabled
I tried adding tests for this, but because the listener is created internally, there is no time to override it with the mock before verifying if listenForTransactions is called.
commit sha： b5af2c1436e19b38173d1389c0e9a5c7241d0b6b
push time in 10 hours ago
NachoSoto in RevenueCat/purchases-ios create branch lazy-var-workaround
NachoSoto push RevenueCat/purchases-ios
commit sha： 3ee1c6c092ea55b1b823e4d358bcf8404e7a00ed
push time in 11 hours ago
NachoSoto in RevenueCat/purchases-ios delete branch api-key-warnings
NachoSoto pull request RevenueCat/purchases-ios
NachoSoto push RevenueCat/purchases-ios
Short URL
commit sha： e623a8fa5ec6d1d80201dec9af824483e1a0e7ff
push time in 11 hours agoNachoSoto wants to merge RevenueCat/purchases-ios
Yay thanks!
NachoSoto merge to RevenueCat/purchases-ios
NachoSoto in RevenueCat/purchases-ios delete branch http-client-sandbox-header
NachoSoto pull request RevenueCat/purchases-ios
Fixes CF-649.
NachoSoto push RevenueCat/purchases-ios
commit sha： 4ee86185c6e7855507b428e8ed271e0249213440
push time in 11 hours agoNachoSoto push RevenueCat/purchases-ios
Removed variable
commit sha： 87ef6e470cedcc10566d7da2d2eaf98b0ce5f189
push time in 11 hours agoNachoSoto merge to RevenueCat/purchases-ios
Fixes CF-649.
NachoSoto wants to merge RevenueCat/purchases-ios
Fixes CF-649.
Changed.
NachoSoto push RevenueCat/purchases-ios
Prepare the codebase to listen to the Storefront changes (1/4) (#1557)
Listen changes via paymentQueueDidChangeStorefront method
Create StoreKit2StorefrontListener.swift to listen to Storefront changes for SK2
Update PurchasesOrchestrator to listen to the Storefront changes
Include StoreKit2StorefrontListenerTests in StoreKitTests
Co-authored-by: NachoSoto [email protected]
Remove force unwrap
Co-authored-by: NachoSoto [email protected]
Co-authored-by: NachoSoto [email protected]
Co-authored-by: NachoSoto [email protected]
Created AnyDecodable (#1568)
updated the description of storetransaction (#1584)
Update willRenew comment - will be false for lifetime (#1579)
CF-527 - Auto generate release changelog (#1585)
Auto generate changelog from diff and get PR titles and creator
Getting last tag version to get diff from
The final version
Remove empty lane and error if no generated content
And update fastlane
Add AmazonStore to Store enum
Rename AmazonStore to Amazon to match Android SDK naming conventions
Added tests for PeriodType/PurchaseOwnershipType/Store (#1558)
Follow up to #1551. Using Codable.encodeAndDecode we ensure that each value can be bidirectionally converted.
These tests exposed that unknown values were being encoded as null, but then failed to decode.
I've updated the implementation and added a few more tests to cover this behavior.
Configuration.builder.with(usesStoreKit2IfAvailable:): fixed docstring (#1590)
HTTPClient: added X-Is-Sandbox header
Fixes [CF-649]
Simplified Bool -> String conversion
commit sha： 9e974bbc057cefa81fd9afb2d3817c3643cb689d
push time in 11 hours agoNachoSoto wants to merge RevenueCat/purchases-hybrid-common
Auto release for iOS failed for a few reasons:
PurchasesHybridCommon.framework, which was a leftover from a complicated intermediate setup during the swift migration. I updated it so that it uses the project from xcode instead. This also means that you don't need to call pod install when modifying the API in order to test the API tester, which was annoying.fastlane gym.
NachoSoto merge to RevenueCat/purchases-hybrid-common
Auto release for iOS failed for a few reasons:
PurchasesHybridCommon.framework, which was a leftover from a complicated intermediate setup during the swift migration. I updated it so that it uses the project from xcode instead. This also means that you don't need to call pod install when modifying the API in order to test the API tester, which was annoying.fastlane gym.
Seems reasonable 👍🏻
NachoSoto merge to RevenueCat/purchases-hybrid-common
Auto release for iOS failed for a few reasons:
PurchasesHybridCommon.framework, which was a leftover from a complicated intermediate setup during the swift migration. I updated it so that it uses the project from xcode instead. This also means that you don't need to call pod install when modifying the API in order to test the API tester, which was annoying.fastlane gym.
Seems reasonable 👍🏻
NachoSoto issue comment RevenueCat/purchases-ios
This is ready, just waiting to update the URL with a short link.
NachoSoto wants to merge RevenueCat/purchases-ios
Posts the AdServices token to the backend.
opening this for review as the code shouldn't have to change, but i do still need to do a manual test after a minor backend change.
also pending: unsure why 6 snapshots were created. working with nacho on that.
but otherwise this is ready for review
I wonder if this was just a bad test run with a previous change. @beylmk I recommend removing the entire __Snapshots__ directory and running the tests again. I'm doing that locally (even on iOS 12) and I don't reproduce the issue, it's only making the appropriate number of requests now.
NachoSoto merge to RevenueCat/purchases-ios
Posts the AdServices token to the backend.
opening this for review as the code shouldn't have to change, but i do still need to do a manual test after a minor backend change.
also pending: unsure why 6 snapshots were created. working with nacho on that.
but otherwise this is ready for review
NachoSoto wants to merge RevenueCat/purchases-ios
Depends on https://github.com/RevenueCat/purchases-ios/pull/1589
Our snapshot testing sometimes needs regeneration and it requires regeneration of iOS 12. iOS 12 simulators only run on Intel machines and not all of us have them.
This PR will allow a CircleCI job to be manually triggered to regenerate snapshot tests
Run bundle exec fastlane generate_snapshots
This will start a series of jobs on CircleCI that will have the CIRCLECI_TESTS_GENERATE_SNAPSHOTS set to true that will regenerate new/updated snapshot test assets.
If there are any files changed, a new PR will be created against the base branch (set earlier in the generate_snapshots lane)
Example PR 👉 https://github.com/RevenueCat/purchases-ios/pull/1578
Awesome.
NachoSoto merge to RevenueCat/purchases-ios
Depends on https://github.com/RevenueCat/purchases-ios/pull/1589
Our snapshot testing sometimes needs regeneration and it requires regeneration of iOS 12. iOS 12 simulators only run on Intel machines and not all of us have them.
This PR will allow a CircleCI job to be manually triggered to regenerate snapshot tests
Run bundle exec fastlane generate_snapshots
This will start a series of jobs on CircleCI that will have the CIRCLECI_TESTS_GENERATE_SNAPSHOTS set to true that will regenerate new/updated snapshot test assets.
If there are any files changed, a new PR will be created against the base branch (set earlier in the generate_snapshots lane)
Example PR 👉 https://github.com/RevenueCat/purchases-ios/pull/1578
PurchasesOrchestrator: removedlazyhack for properties with@availableFixes [CF-682], and probably #1528. Looks like possibly something was broken demangling
lazyproperties with@availablein iOS 15.0 (per the 2 bug reports).This changes the approach to simply having
Any?as the value, and making the exposed@availableproperty a derived one.