If we can return productsWithIntroOffers for all productIds without asking the backend, we should. Otherwise, we should filter out the ids that we know about and only ask the backend for ones we don't. Fixes #982
Pinned
ReactiveCocoa/ReactiveSwift
2.8k
⚡ Streams of values over time
NachoSoto/AsyncImageView
76
⚡ UIImageView for rendering data asynchronously, with composable renderers and caches
Activity
Nov
30
15 hours ago
NachoSoto merge to RevenueCat/purchases-ios
NachoSoto
NachoSoto
CONTRIBUTOR
createdAt 12 hours ago
Check for productsWithIntroOffers first, before backend
NachoSoto
NachoSoto
COLLABORATOR
submittedAt 12 hours ago
NachoSoto wants to merge RevenueCat/purchases-ios
NachoSoto
NachoSoto
COLLABORATOR
createdAt 12 hours ago
DeviceCache: reduced cache duration on sandbox
Fixes #989 / [sc-11154].
NachoSoto
No worries!
NachoSoto merge to RevenueCat/purchases-ios
NachoSoto
NachoSoto
COLLABORATOR
createdAt 12 hours ago
DeviceCache: reduced cache duration on sandbox
Fixes #989 / [sc-11154].
NachoSoto
NachoSoto
COLLABORATOR
submittedAt 12 hours ago
NachoSoto issue comment RevenueCat/purchases-ios
NachoSoto
NachoSoto
@taquitos manually checked and Carthage integration is working. We'll assume the failure is a flaky test in the 3.x branch. We can look at it more closely if it happens again in 4.x
NachoSoto in NachoSoto/purchases-ios delete branch empty-app-user-id
deleted time in 12 hours ago
NachoSoto push RevenueCat/purchases-ios
NachoSoto
Don't allow empty string for appUserID during initialization (#995)
Fixes [sc-10159].
Based on top of #974 because it contains a significant simplification of IdentityManager that makes this a lot easier.
Note that Purchases.logIn will still fail with an error when trying to use an empty string. This PR does not change that behavior.
commit sha： 641e8b5cae19eddae48417b8665b49a81792f5c1
push time in 12 hours agoNachoSoto pull request RevenueCat/purchases-ios
NachoSoto
NachoSoto
COLLABORATOR
createdAt 12 hours ago
Don't allow empty string for `appUserID` during initialization
Fixes [sc-10159].
Based on top of #974 because it contains a significant simplification of IdentityManager that makes this a lot easier.
Note that Purchases.logIn will still fail with an error when trying to use an empty string. This PR does not change that behavior.
NachoSoto push RevenueCat/purchases-ios
NachoSoto
commit sha： 1c44d23b7c36847999f4963009a0dcc884e340a4
push time in 12 hours ago
NachoSoto in RevenueCat/purchases-ios delete branch cache-duration-sandbox
deleted time in 12 hours ago
NachoSoto pull request RevenueCat/purchases-ios
NachoSoto
NachoSoto
COLLABORATOR
createdAt 12 hours ago
DeviceCache: reduced cache duration on sandbox
Fixes #989 / [sc-11154].
NachoSoto issue RevenueCat/purchases-ios
NachoSoto
NachoSoto
MEMBER
createdAt 12 hours ago
Reduce cache duration in sandbox
Purchases in sandbox have a reduced duration, however, we’re still using the same cache duration as we do for production.
This leads to developer confusion, since they expect that the data will always be up-to-date.
We should reduce the cache duration for the sandbox environment, which will make testing a lot easier and less confusing.
Related issue: https://github.com/RevenueCat/purchases-ios/issues/853
The proposed cache duration for Sandbox is 5 minutes. We can use the isSandbox variable in SystemInfo to determine if we're running in the sandbox environment.
https://app.shortcut.com/revenuecat/story/11154/reduce-cache-duration-in-sandbox
NachoSoto issue comment RevenueCat/purchases-ios
NachoSoto
NachoSoto
COLLABORATOR
createdAt 12 hours ago
Replaced custom `DateFormatter` with new `ISO8601DateFormatter`
Fixes #988.
Unfortunately ISO8601DateFormatter inherits from Formatter, and not DateFormatter, so this introduces a new protocol DateFormatterType that both types can implement.
Another unfortunate difference with the new type compared to the old implementation is that milliseconds are either optional or mandatory.
For that reason, I added ISO8601DateFormatter.default which replicates the same behavior by deferring date(from: String) -> Date to one formatter or the other.
I added tests to cover this behavior directly, but it was only thanks to the existing ArraySlice tests that I became aware of this requirement.
Additionally, I made Transaction.init(with:productId:dateFormatter) not public and not @objc so it can take a new DateFormatterType.
The method didn't need to be public, it was just a pre-Swift-migration leftover.
As a bonus I changed some of the tests in DateFormatter+ExtensionsTests to use XCTUnwrap.
NachoSoto
This should be ready for review now :)
NachoSoto push RevenueCat/purchases-ios
NachoSoto
Fixed StoreKitUnitTests
commit sha： 392062144f2fd4a39a71009332f2c4925852d2ad
push time in 14 hours agoNachoSoto push RevenueCat/purchases-ios
NachoSoto
Lint fixes
commit sha： 9796a61308c2785a3caec948bc57b9c025033b0d
push time in 14 hours agoNachoSoto push RevenueCat/purchases-ios
NachoSoto
commit sha： a8de7e335439d1a5103eaee5eb148eccc261afd4
push time in 14 hours ago
NachoSoto in RevenueCat/purchases-ios delete branch product-details-empty-title
deleted time in 14 hours ago
NachoSoto pull request RevenueCat/purchases-ios
NachoSoto
NachoSoto
COLLABORATOR
createdAt 14 hours ago
ProductDetails: log warning when product title is empty
Fixes #624.
NachoSoto issue RevenueCat/purchases-ios
NachoSoto
NachoSoto
CONTRIBUTOR
createdAt 14 hours ago
Add log warning when product.title is empty string, nil, or just filled with spaces.
I think RevenueCat/purchases-flutter#212 could be debugged easier if we added some more logging around product fields that we expect to not be empty.
NachoSoto push NachoSoto/purchases-ios
NachoSoto
Obsoleted Purchases.createAlias/identify/reset and simplified IdentityManager implementation (#974)
- Obsoleted Purchases.createAlias/identify/reset and simplified IdentityManager implementation
Fixes #732. Instead of worrying about whether IdentityManager.configure was idempotent or if the implementation was correct, I realized that Purchases never called that method after its initialization
Therefore, to simplify the whole implementation, the configure part is now in the constructor. Subsequent logIn/logOut calls are the only way to change the identity.
Some of this code was tangled with some of the deprecations in IdentityManager, so to aid in this refactor, I obsoleted 3 methods that were already deprecated in version 3.13.0.
This allowed me to remove the associated tests instead of changing them to use the new API. Following #950, these methods are now separate in Obsoletions.swift, and they point to the new methods.
The remaining tests in PurchasesTests all pass, and the ones in IdentityManagerTests have been converted to initializing new IdentityManager instances. Those pass as well, so I feel confident in this refactor :muscle:
-
SwiftAPITester: removed calls to deprecated methods
-
ObjCAPITester: removed calls to deprecated methods
NachoSoto
Added String extensions
NachoSoto
IdentityManager: convert empty appUserIDs to anonymous users
Fixes [sc-10159]
NachoSoto
MockDeviceCache: removed ;
NachoSoto
IdentityManager: add test to check spaces aren't trimmed
NachoSoto
Improved docs
commit sha： 8f419667be32acc42abb69fe77de709e59ea6cfb
push time in 14 hours agoNachoSoto push RevenueCat/purchases-ios
NachoSoto
Fixed invalid project reference (#993)
NachoSoto
NachoSoto
Refactored DeviceCache to improve thread safety (#983)
Fixes #739.
Changes:
- Created
Atomic, based onLock, to abstract atomic access and modifications to values. - Simplified
InMemoryCachedObjectusingAtomic(tests still pass!). - Created
SynchronizedUserDefaultsusingAtomic, to enforce atomic access toUserDefaults. - Refactored
DeviceCacheusingAtomicto enforce all access toUserDefaultsare synchronized:-
DeviceCacheno longer stores aUserDefaultsinstance (onlySynchronizedUserDefaults), so we guarantee we don't do unsynchronized modifications. - The old
threadUnsafe_methods are nowstatic, which ensures they don't access any local state. Instead,UserDefaultsis injected, andDeviceCachecalls these methods usingSynchronizedUserDefaults.read/SynchronizedUserDefaults.write. - The combination of both of these things eliminates potential for programmer error within the class.
- There's still potential for what's described in #739, that a user of
DeviceCachereads data, and THEN writes it again, without synchronizing both operations. This PR doesn't address that, but I haven't found any examples of that being an issue, and if we do, we should move both operations into a single method inDeviceCachethat can enforce the semantics.
-
NachoSoto
NachoSoto
Add async alternative APIs (#987)
-
added async alternative to
logIn -
added availability check, fixed linting
-
added async / await alternative to logOut
-
added async / await alternative for getCustomerInfo, fixed api availability for presentCodeRedemptionSheet
-
updated a couple of references to purchaserInfo -> customer info
-
fixed a few more references to purchaserInfo
-
added async alternative to getProducts
-
added async alternative to
getOfferings -
added async alternative to
purchase(product:) -
added async alternative to
purchase(package:) -
removed the
getprefix for async alternatives -
added async alternative to
purchase(product:discount:) -
added async alternative to
purchase(package:discount:) -
added async alternative to
syncPurchases() -
added async alternative to
restoreTransactions -
added async alternative to
checkTrialOrIntroductoryPriceEligibility -
disabled swiftlint check
-
added async alternative to
paymentDiscount(forProductDiscount:product:) -
added async alternative to
showManageSubscriptionModal -
added async alternative to
beginRefundRequest, fixed availability for macOS -
added Purchases+async file, and moved implementation of a few async methods there
-
moved products to async file
-
reverted macOS API availability to prevent failing tests
-
added missing availability for macOS
-
moved a few more methods to async file
-
moved remaining async methods to async extension
-
fixed indentation
-
named values in return tuple from logIn async alternative
-
fixed issues with API availability by adding OS checks
-
fixed linting and API call on unavailable method for macOS
-
cleaned up api availability in a couple more places
NachoSoto
Obsoleted Purchases.createAlias/identify/reset and simplified IdentityManager implementation (#974)
- Obsoleted Purchases.createAlias/identify/reset and simplified IdentityManager implementation
Fixes #732. Instead of worrying about whether IdentityManager.configure was idempotent or if the implementation was correct, I realized that Purchases never called that method after its initialization
Therefore, to simplify the whole implementation, the configure part is now in the constructor. Subsequent logIn/logOut calls are the only way to change the identity.
Some of this code was tangled with some of the deprecations in IdentityManager, so to aid in this refactor, I obsoleted 3 methods that were already deprecated in version 3.13.0.
This allowed me to remove the associated tests instead of changing them to use the new API. Following #950, these methods are now separate in Obsoletions.swift, and they point to the new methods.
The remaining tests in PurchasesTests all pass, and the ones in IdentityManagerTests have been converted to initializing new IdentityManager instances. Those pass as well, so I feel confident in this refactor :muscle:
-
SwiftAPITester: removed calls to deprecated methods
-
ObjCAPITester: removed calls to deprecated methods
NachoSoto
Added String extensions
NachoSoto
IdentityManager: convert empty appUserIDs to anonymous users
Fixes [sc-10159]
NachoSoto
MockDeviceCache: removed ;
NachoSoto
IdentityManager: add test to check spaces aren't trimmed
NachoSoto
Improved docs
commit sha： 8f419667be32acc42abb69fe77de709e59ea6cfb
push time in 14 hours agoNachoSoto push RevenueCat/purchases-ios
NachoSoto
NachoSoto
Add async alternative APIs (#987)
-
added async alternative to
logIn -
added availability check, fixed linting
-
added async / await alternative to logOut
-
added async / await alternative for getCustomerInfo, fixed api availability for presentCodeRedemptionSheet
-
updated a couple of references to purchaserInfo -> customer info
-
fixed a few more references to purchaserInfo
-
added async alternative to getProducts
-
added async alternative to
getOfferings -
added async alternative to
purchase(product:) -
added async alternative to
purchase(package:) -
removed the
getprefix for async alternatives -
added async alternative to
purchase(product:discount:) -
added async alternative to
purchase(package:discount:) -
added async alternative to
syncPurchases() -
added async alternative to
restoreTransactions -
added async alternative to
checkTrialOrIntroductoryPriceEligibility -
disabled swiftlint check
-
added async alternative to
paymentDiscount(forProductDiscount:product:) -
added async alternative to
showManageSubscriptionModal -
added async alternative to
beginRefundRequest, fixed availability for macOS -
added Purchases+async file, and moved implementation of a few async methods there
-
moved products to async file
-
reverted macOS API availability to prevent failing tests
-
added missing availability for macOS
-
moved a few more methods to async file
-
moved remaining async methods to async extension
-
fixed indentation
-
named values in return tuple from logIn async alternative
-
fixed issues with API availability by adding OS checks
-
fixed linting and API call on unavailable method for macOS
-
cleaned up api availability in a couple more places
NachoSoto
Obsoleted Purchases.createAlias/identify/reset and simplified IdentityManager implementation (#974)
- Obsoleted Purchases.createAlias/identify/reset and simplified IdentityManager implementation
Fixes #732. Instead of worrying about whether IdentityManager.configure was idempotent or if the implementation was correct, I realized that Purchases never called that method after its initialization
Therefore, to simplify the whole implementation, the configure part is now in the constructor. Subsequent logIn/logOut calls are the only way to change the identity.
Some of this code was tangled with some of the deprecations in IdentityManager, so to aid in this refactor, I obsoleted 3 methods that were already deprecated in version 3.13.0.
This allowed me to remove the associated tests instead of changing them to use the new API. Following #950, these methods are now separate in Obsoletions.swift, and they point to the new methods.
The remaining tests in PurchasesTests all pass, and the ones in IdentityManagerTests have been converted to initializing new IdentityManager instances. Those pass as well, so I feel confident in this refactor :muscle:
-
SwiftAPITester: removed calls to deprecated methods
-
ObjCAPITester: removed calls to deprecated methods
NachoSoto
DeviceCache: reduced cache duration on sandbox
Fixes #989 / [sc-11154].
NachoSoto
Lint fixes
commit sha： 3ae238e9015d22c54754d3078923ad696d3b43e6
push time in 14 hours agoNachoSoto push RevenueCat/purchases-ios
NachoSoto
NachoSoto
Add async alternative APIs (#987)
-
added async alternative to
logIn -
added availability check, fixed linting
-
added async / await alternative to logOut
-
added async / await alternative for getCustomerInfo, fixed api availability for presentCodeRedemptionSheet
-
updated a couple of references to purchaserInfo -> customer info
-
fixed a few more references to purchaserInfo
-
added async alternative to getProducts
-
added async alternative to
getOfferings -
added async alternative to
purchase(product:) -
added async alternative to
purchase(package:) -
removed the
getprefix for async alternatives -
added async alternative to
purchase(product:discount:) -
added async alternative to
purchase(package:discount:) -
added async alternative to
syncPurchases() -
added async alternative to
restoreTransactions -
added async alternative to
checkTrialOrIntroductoryPriceEligibility -
disabled swiftlint check
-
added async alternative to
paymentDiscount(forProductDiscount:product:) -
added async alternative to
showManageSubscriptionModal -
added async alternative to
beginRefundRequest, fixed availability for macOS -
added Purchases+async file, and moved implementation of a few async methods there
-
moved products to async file
-
reverted macOS API availability to prevent failing tests
-
added missing availability for macOS
-
moved a few more methods to async file
-
moved remaining async methods to async extension
-
fixed indentation
-
named values in return tuple from logIn async alternative
-
fixed issues with API availability by adding OS checks
-
fixed linting and API call on unavailable method for macOS
-
cleaned up api availability in a couple more places
NachoSoto
Obsoleted Purchases.createAlias/identify/reset and simplified IdentityManager implementation (#974)
- Obsoleted Purchases.createAlias/identify/reset and simplified IdentityManager implementation
Fixes #732. Instead of worrying about whether IdentityManager.configure was idempotent or if the implementation was correct, I realized that Purchases never called that method after its initialization
Therefore, to simplify the whole implementation, the configure part is now in the constructor. Subsequent logIn/logOut calls are the only way to change the identity.
Some of this code was tangled with some of the deprecations in IdentityManager, so to aid in this refactor, I obsoleted 3 methods that were already deprecated in version 3.13.0.
This allowed me to remove the associated tests instead of changing them to use the new API. Following #950, these methods are now separate in Obsoletions.swift, and they point to the new methods.
The remaining tests in PurchasesTests all pass, and the ones in IdentityManagerTests have been converted to initializing new IdentityManager instances. Those pass as well, so I feel confident in this refactor :muscle:
-
SwiftAPITester: removed calls to deprecated methods
-
ObjCAPITester: removed calls to deprecated methods
NachoSoto
ProductDetails: log warning when product title is empty
Fixes #624.
NachoSoto
Extracted String to OfferingStrings
commit sha： d0619a75224228d10241b5cdda65c7e4661c3120
push time in 14 hours ago
NachoSoto in RevenueCat/purchases-ios delete branch bump/3.14.0-SNAPSHOT
deleted time in 14 hours ago
NachoSoto push RevenueCat/purchases-ios
NachoSoto
commit sha： d9d8c58858989ac3f140e48ffbb61bd98056bcd8
push time in 14 hours ago
NachoSoto in RevenueCat/purchases-ios delete branch SPM-resolved-file
deleted time in 14 hours ago
NachoSoto pull request RevenueCat/purchases-ios
NachoSoto
NachoSoto
COLLABORATOR
createdAt 14 hours ago
Updated Package.resolved
I keep getting Xcode automatically updating these 2. Looks like for 2 reasons:
- #946 got rid of SPM on the MagicWeatherProject
- The dependency got updated
NachoSoto push RevenueCat/purchases-ios
NachoSoto
Refactored DeviceCache to improve thread safety (#983)
Fixes #739.
Changes:
- Created
Atomic, based onLock, to abstract atomic access and modifications to values. - Simplified
InMemoryCachedObjectusingAtomic(tests still pass!). - Created
SynchronizedUserDefaultsusingAtomic, to enforce atomic access toUserDefaults. - Refactored
DeviceCacheusingAtomicto enforce all access toUserDefaultsare synchronized:-
DeviceCacheno longer stores aUserDefaultsinstance (onlySynchronizedUserDefaults), so we guarantee we don't do unsynchronized modifications. - The old
threadUnsafe_methods are nowstatic, which ensures they don't access any local state. Instead,UserDefaultsis injected, andDeviceCachecalls these methods usingSynchronizedUserDefaults.read/SynchronizedUserDefaults.write. - The combination of both of these things eliminates potential for programmer error within the class.
- There's still potential for what's described in #739, that a user of
DeviceCachereads data, and THEN writes it again, without synchronizing both operations. This PR doesn't address that, but I haven't found any examples of that being an issue, and if we do, we should move both operations into a single method inDeviceCachethat can enforce the semantics.
-
NachoSoto
NachoSoto
Add async alternative APIs (#987)
-
added async alternative to
logIn -
added availability check, fixed linting
-
added async / await alternative to logOut
-
added async / await alternative for getCustomerInfo, fixed api availability for presentCodeRedemptionSheet
-
updated a couple of references to purchaserInfo -> customer info
-
fixed a few more references to purchaserInfo
-
added async alternative to getProducts
-
added async alternative to
getOfferings -
added async alternative to
purchase(product:) -
added async alternative to
purchase(package:) -
removed the
getprefix for async alternatives -
added async alternative to
purchase(product:discount:) -
added async alternative to
purchase(package:discount:) -
added async alternative to
syncPurchases() -
added async alternative to
restoreTransactions -
added async alternative to
checkTrialOrIntroductoryPriceEligibility -
disabled swiftlint check
-
added async alternative to
paymentDiscount(forProductDiscount:product:) -
added async alternative to
showManageSubscriptionModal -
added async alternative to
beginRefundRequest, fixed availability for macOS -
added Purchases+async file, and moved implementation of a few async methods there
-
moved products to async file
-
reverted macOS API availability to prevent failing tests
-
added missing availability for macOS
-
moved a few more methods to async file
-
moved remaining async methods to async extension
-
fixed indentation
-
named values in return tuple from logIn async alternative
-
fixed issues with API availability by adding OS checks
-
fixed linting and API call on unavailable method for macOS
-
cleaned up api availability in a couple more places
NachoSoto
Obsoleted Purchases.createAlias/identify/reset and simplified IdentityManager implementation (#974)
- Obsoleted Purchases.createAlias/identify/reset and simplified IdentityManager implementation
Fixes #732. Instead of worrying about whether IdentityManager.configure was idempotent or if the implementation was correct, I realized that Purchases never called that method after its initialization
Therefore, to simplify the whole implementation, the configure part is now in the constructor. Subsequent logIn/logOut calls are the only way to change the identity.
Some of this code was tangled with some of the deprecations in IdentityManager, so to aid in this refactor, I obsoleted 3 methods that were already deprecated in version 3.13.0.
This allowed me to remove the associated tests instead of changing them to use the new API. Following #950, these methods are now separate in Obsoletions.swift, and they point to the new methods.
The remaining tests in PurchasesTests all pass, and the ones in IdentityManagerTests have been converted to initializing new IdentityManager instances. Those pass as well, so I feel confident in this refactor :muscle:
-
SwiftAPITester: removed calls to deprecated methods
-
ObjCAPITester: removed calls to deprecated methods
NachoSoto
Replaced custom DateFormatter with new ISO8601DateFormatter
Fixes #988.
Unfortunately ISO8601DateFormatter inherits from Formatter, and not DateFormatter, so this introduces a new protocol DateFormatterType that both types can implement.
Another unfortunate difference with the new type compared to the old implementation is that milliseconds are either optional or mandatory.
For that reason, I added ISO8601DateFormatter.default which replicates the same behavior by deferring date(from: String) -> Date to one formatter or the other.
I added tests to cover this behavior directly, but it was only thanks to the existing ArraySlice tests that I became aware of this requirement.
Additionally, I made Transaction.init(with:productId:dateFormatter) not public and not @objc so it can take a new DateFormatterType.
The method didn't need to be public, it was just a pre-Swift-migration leftover.
As a bonus I changed some of the tests in DateFormatter+ExtensionsTests to use XCTUnwrap.
NachoSoto
DateFormatterType doesn't need to be public
NachoSoto
Simplified DateFormatterType removing dateDecodingStrategy
commit sha： a6aa90172a007882ed31468f55a4c4718e7d736b
push time in 14 hours agoNachoSoto wants to merge RevenueCat/purchases-ios
NachoSoto
NachoSoto
COLLABORATOR
createdAt 14 hours ago
Replaced custom `DateFormatter` with new `ISO8601DateFormatter`
Fixes #988.
Unfortunately ISO8601DateFormatter inherits from Formatter, and not DateFormatter, so this introduces a new protocol DateFormatterType that both types can implement.
Another unfortunate difference with the new type compared to the old implementation is that milliseconds are either optional or mandatory.
For that reason, I added ISO8601DateFormatter.default which replicates the same behavior by deferring date(from: String) -> Date to one formatter or the other.
I added tests to cover this behavior directly, but it was only thanks to the existing ArraySlice tests that I became aware of this requirement.
Additionally, I made Transaction.init(with:productId:dateFormatter) not public and not @objc so it can take a new DateFormatterType.
The method didn't need to be public, it was just a pre-Swift-migration leftover.
As a bonus I changed some of the tests in DateFormatter+ExtensionsTests to use XCTUnwrap.
NachoSoto
Great find! I just refactored this by passing a strategy instead so the protocol is simpler. Thanks!
Previous
Next
Release/3.13.1