axic

axic

Works on decentralised stuff. eipnft:axic.eth

Member Since 13 years ago

@ethereum @ewasm @wasmx @ethereumjs, Dublin, Ireland

Experience Points
1k
follower
Lessons Completed
5
follow
Lessons Completed
63
stars
Best Reply Awards
121
repos

1800 contributions in the last year

Pinned
⚡ Mango: Git, completely decentralised.
⚡ EVM interpreter compatible with the evm2wasm interface
⚡ Yultsur is a Rust implementation of Yul.
⚡ Fizzy aims to be a fast, deterministic, and pedantic WebAssembly interpreter written in C++.
⚡ Solidity, the Smart Contract Programming Language
⚡ Utilities for handling Ethereum keys
Activity
Nov
27
1 day ago
Activity icon
issue

axic issue comment ethereum/go-ethereum

axic
axic

core/vm: Move interpreter.ReadOnly check into the opcode implementations

Fixes #23968.

I had trouble running tests locally, but go test -v ./tests passed (and displayed a lot of state tests lines). make test runs into various failures regarding "too many files open" or networking issues. In short: this change may be broken as I couldn't 100% verify with tests.

axic
axic

@axic can you add the diff above to this PR? You might have to rebase, because I think Sina recently moved the loggers a different location.

@holiman After the refactoring from @s1na I see the implementation in eth/tracers/logger/logger_json.go. Do any of the other tracers need to be updated?

Nov
26
2 days ago
pull request

axic merge to ethereum/yellowpaper

axic
axic

Implement EIP-2681: Limit account nonce to 2^64-1

Fixes #813. Please note that this applies from genesis, and geth implements it now.

I tried to implement this and I think I found the correct place for the external transaction validation. However I have no good idea where to describe the rules for CREATE/CREATE2.

open pull request

axic wants to merge ethereum/yellowpaper

axic
axic

Implement EIP-2681: Limit account nonce to 2^64-1

Fixes #813. Please note that this applies from genesis, and geth implements it now.

I tried to implement this and I think I found the correct place for the external transaction validation. However I have no good idea where to describe the rules for CREATE/CREATE2.

axic
axic

Perhaps the "64-bit" mention here is not entirely correct, as it is serialised via RLP, so it has no fixed size. However since the recipient field below states "160-bit address" I decided to include it.

Potentially the more clear way is to include these restrictions in the validation sections, which means the address should be just a scalar here, and a new rule would need to be added.

push

axic push axic/yellowpaper

axic
axic

Implement EIP-2681: Limit account nonce to 2^64-1

commit sha: bc64213ecd43f9fcd2c0b5dbaa1d60d588c89294

push time in 1 day ago
pull request

axic pull request ethereum/yellowpaper

axic
axic

Implement EIP-2681: Limit account nonce to 2^64-1

Fixes #813.

push

axic push axic/yellowpaper

axic
axic

Implement EIP-2681: Limit account nonce to 2^64-1

commit sha: 8d97ffa4abf6df982a82c2de96fd51f3344517ac

push time in 1 day ago
push

axic push axic/yellowpaper

axic
axic

Implement EIP-2681: Limit account nonce to 2^64-1

commit sha: 0e0ed66aae1e501e951ddf716f16b8135f559495

push time in 2 days ago
Activity icon
issue

axic issue comment ethereum/execution-specs

axic
axic

Handling Retroactive Changes (e.g. EIP-2681)

There was no dissent in moving EIP-2681 forward during ACD 101. The problem is, what does that mean? With the separation of EIPs and network upgrades, "Final" doesn't mean mainnet.

Typically this isn't a major issue, because we can use the upgrade tracker and once its scheduled in an upgrade it is recorded during that transition. But EIP-2681 sets a limit on account nonces retroactively from genesis. My guess is that a modification should be made to the Yellow Paper as it is the most canonical spec for Ethereum?

cc: @axic, @MadeofTin, @Souptacular

axic
axic
Activity icon
issue

axic issue ethereum/execution-specs

axic
axic

EIP-2681: Limit account nonce to 2^64-1

EIP-2681 applies from genesis. It was properly merged into Geth this week and also the state tests repository has it merged.

push

axic push axic/yellowpaper

axic
axic

Implement EIP-2681: Limit account nonce to 2^64-1

commit sha: 9db9c91be1abe973a4791fabb19c178e6dacf0f6

push time in 2 days ago
Activity icon
delete

axic in tempus-finance/tempus-protocol delete branch coinspect-audit-2

deleted time in 2 days ago
Activity icon
created branch
createdAt 2 days ago
push

axic push tempus-finance/tempus-protocol

axic
axic

pool: Exceptionally stop pool in case of a long negative yield period

axic
axic

Make long negative yield test 4-stages

commit sha: efdc643076fe020b9b3541f4edaf14ebd5f74b60

push time in 2 days ago
open pull request

axic wants to merge tempus-finance/tempus-protocol

axic
axic

pool: Exceptionally stop pool in case of a long negative yield period

This is mostly here for a discussion starter.

axic
axic

Based on #428 we may want to name this updateAndValidateInterestRate instead.

pull request

axic merge to tempus-finance/tempus-protocol

axic
axic

pool: Exceptionally stop pool in case of a long negative yield period

This is mostly here for a discussion starter.

pull request

axic merge to tempus-finance/tempus-protocol

axic
axic

pool: Exceptionally stop pool in case of a long negative yield period

This is mostly here for a discussion starter.

open pull request

axic wants to merge tempus-finance/tempus-protocol

axic
axic

pool: Exceptionally stop pool in case of a long negative yield period

This is mostly here for a discussion starter.

open pull request

axic wants to merge tempus-finance/tempus-protocol

axic
axic

pool: Exceptionally stop pool in case of a long negative yield period

This is mostly here for a discussion starter.

pull request

axic merge to tempus-finance/tempus-protocol

axic
axic

pool: Exceptionally stop pool in case of a long negative yield period

This is mostly here for a discussion starter.

push

axic push tempus-finance/tempus-protocol

axic
axic

utils: Create IOwnable interface

axic
axic

pool: Make ITempusFees/TempusPool properly ownable

axic
axic

Controller, Stats & LidoTempusPool deployment scripts;LidoTempusPool etherscan-verify script

axic
axic

pool: Move updateInterestRate as to be the first step in mintShares/burnShares

axic
axic

pool: Change finalize to use updateInterestRate

This avoids the problem of rate discrepancy in case of low volume pools

axic
axic

Merge pull request #334 from tempus-finance/deployment-scripts

utils: Adding scripts for deployment.

axic
axic

Merge pull request #438 from tempus-finance/ownable-pool

pool: Make ITempusFees/TempusPool properly ownable

axic
axic

Merge pull request #439 from tempus-finance/pool-rates

pool: Change finalize to use updateInterestRate

axic
axic

pool: Move transferFees to TempusPool from TempusController

axic
axic

Merge pull request #437 from tempus-finance/transfer-fees

pool: Move transferFees to TempusPool from TempusController

axic
axic

pool: Exceptionally stop pool in case of a long negative yield period

axic
axic

Make long negative yield test 4-stages

commit sha: 511c038e474b284622de3367e89bddcecf10ff0f

push time in 2 days ago
push

axic push tempus-finance/tempus-protocol

axic
axic

pool: Make ITempusFees/TempusPool properly ownable

axic
axic

Controller, Stats & LidoTempusPool deployment scripts;LidoTempusPool etherscan-verify script

axic
axic

pool: Move updateInterestRate as to be the first step in mintShares/burnShares

axic
axic

pool: Change finalize to use updateInterestRate

This avoids the problem of rate discrepancy in case of low volume pools

axic
axic

Merge pull request #334 from tempus-finance/deployment-scripts

utils: Adding scripts for deployment.

axic
axic

Merge pull request #438 from tempus-finance/ownable-pool

pool: Make ITempusFees/TempusPool properly ownable

axic
axic

Merge pull request #439 from tempus-finance/pool-rates

pool: Change finalize to use updateInterestRate

axic
axic

pool: Move transferFees to TempusPool from TempusController

commit sha: f5be39d77f308f97f3e051c3a745de7e8fc336f2

push time in 2 days ago
pull request

axic pull request tempus-finance/tempus-protocol

axic
axic

pool: Change finalize to use updateInterestRate

Activity icon
created branch

axic in tempus-finance/tempus-protocol create branch pool-rates

createdAt 2 days ago
push

axic push tempus-finance/tempus-protocol

axic
axic

pool: Make ITempusFees/TempusPool properly ownable

commit sha: b84dd8ac059d40555b0a0a8341984d79557a6ce6

push time in 2 days ago
open pull request

axic wants to merge tempus-finance/tempus-protocol

axic
axic

pool: Make ITempusFees/TempusPool properly ownable

This became more complicated than expected.

axic
axic

Yes, the next PR is the previous is number: #437.

pull request

axic merge to tempus-finance/tempus-protocol

axic
axic

pool: Make ITempusFees/TempusPool properly ownable

This became more complicated than expected.

Previous