barisusakli

barisusakli

Programmer, Gamer, Co-Founder of @NodeBB

Member Since 8 years ago

@NodeBB , Toronto, ON

Experience Points
109
follower
Lessons Completed
11
follow
Lessons Completed
185
stars
Best Reply Awards
101
repos

1551 contributions in the last year

Pinned
⚡ Node.js based forum software built for the modern web
⚡ A NodeBB Plugin to post topics using RSS feeds
⚡ A plugin that uploads images to imgur
⚡ A plugin that uses the database for search
⚡ Generate terrain images using fault line formation algorithm
⚡ icosphere planet
Activity
Oct
16
3 hours ago
Activity icon
issue

barisusakli issue comment socketio/socket.io-client

barisusakli
barisusakli

requiring socket.io-client no longer works in 4.3.0

On socket.io-client 4.2.0. I can require it and connect server side like this

const io = require('socket.io-client');
const socket = io(nconf.get('base_url'), {
	path: `/socket.io`,
	extraHeaders: {
		Origin: nconf.get('url'),
		Cookie: cookie,
	},
});

This stopped working with 4.3.0, with the following error. Uncaught TypeError: io is not a function

I have to modify the code to

const socket = io.io(nconf.get('base_url'), {
	path: `/socket.io`,
	extraHeaders: {
		Origin: nconf.get('url'),
		Cookie: cookie,
	},
});

To make it work, not sure if this is intended or a side effect of the changes in 4.3.0.

barisusakli
barisusakli
Oct
15
1 day ago
push

barisusakli push akhoury/nodebb-plugin-spam-be-gone

barisusakli
barisusakli

fix: get rid of warning

[plugins] filter:login.check already resolved in plugin nodebb-plugin-spam-be-gone

commit sha: f133d49168f7a12127dfbb9a1022796ca78e7d52

push time in 5 hours ago
Activity icon
issue

barisusakli issue comment NodeBB/NodeBB

barisusakli
barisusakli

fix(deps): update socket.io packages to v4.3.0

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
socket.io 4.2.0 -> 4.3.0 age adoption passing confidence
socket.io-client 4.2.0 -> 4.3.0 age adoption passing confidence

Release Notes

socketio/socket.io

v4.3.0

Compare Source

Bug Fixes
  • typings: add name field to cookie option (#8203;4099) (033c5d3)
  • send volatile packets with binary attachments (dc81fcf)
Features
socketio/socket.io-client

v4.3.0

Compare Source

An ESM bundle is now provided:

<script type="module">
  import { io } from "https://cdn.socket.io/4.3.0/socket.io.esm.min.js";

  const socket = io();

  socket.emit("hello", "world");
</script>
Features
  • typings: add missing types for some emitter methods (#8203;1502) (a9e5b85)
  • provide an ESM build with and without debug (16b6569)
  • migrate to rollup (0661564)

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

Activity icon
issue

barisusakli issue socketio/socket.io-client

barisusakli
barisusakli

requiring socket.io-client no longer works in 4.3.0

On socket.io-client 4.2.0. I can require it and connect server side like this

const io = require('socket.io-client');
const socket = io(nconf.get('base_url'), {
	path: `/socket.io`,
	extraHeaders: {
		Origin: nconf.get('url'),
		Cookie: cookie,
	},
});

This stopped working with 4.3.0, with the following error. Uncaught TypeError: io is not a function

I have to modify the code to

const socket = io.io(nconf.get('base_url'), {
	path: `/socket.io`,
	extraHeaders: {
		Origin: nconf.get('url'),
		Cookie: cookie,
	},
});

To make it work, not sure if this is intended or a side effect of the changes in 4.3.0.

push

barisusakli push NodeBB/nodebb-plugin-composer-default

barisusakli
barisusakli

feat: add helper to minimize active composer

commit sha: 7c15eeb85b6d702e0a4a3f6519e03af0208c3342

push time in 9 hours ago
Activity icon
issue

barisusakli issue NodeBB/NodeBB

barisusakli
barisusakli

Buy Microsoft Office Professional Plus 2019 CD Key Global

Product Manufacturer: Microsoft Media Type: Key and Download. Can be used internationally. Can get the instructions via email account. Platform: Windows 10; Windows Server 2019 License Time: Lifetime Category: Microsoft Office https://buffcom.net/product/buy-microsoft-office-professional-plus-2019-cd-key-globa office-2019-pp l/

push

barisusakli push NodeBB/NodeBB

barisusakli
barisusakli

fix: don't overwrite reloadRequired with false

  1. meta.settings.set('name', values); // reloadRequired is set to true
  2. meta.settings.set('otherName', values, false); // reloadRequired was set to false, even though it should stay true until restart due to step 1

commit sha: 9e0ce0272ca50c4c6275e25240500d0e13bdafed

push time in 12 hours ago
Oct
14
2 days ago
push

barisusakli push NodeBB/NodeBB

barisusakli
barisusakli

refactor: show full url on error log

commit sha: 8e6bd7e913b0afd624a99ef910a168df0551f627

push time in 1 day ago
push

barisusakli push NodeBB/nodebb-plugin-composer-default

barisusakli
barisusakli

fix: don't error if topicData.title is undefined/null

commit sha: 8dc20c843a94ae9a53ff2e38b8c82e1d7d8a28ed

push time in 1 day ago
push

barisusakli push julianlam/nodebb-plugin-markdown

barisusakli
barisusakli

fix: #160 prevent error if parsedSrc.pathname is null

commit sha: afae5b92c6aa0e2045f2848496307517cca9de0c

push time in 1 day ago
Activity icon
issue

barisusakli issue julianlam/nodebb-plugin-markdown

barisusakli
barisusakli

error in rules.image

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received null at validateString (internal/validators.js:124:11) at Object.basename (path.js:1156:5) at Object.parser.renderer.rules.image (/home/nodebb/nodebb/node_modules/nodebb-plugin-markdown/index.js:354:26) at Renderer.renderInline (/home/nodebb/nodebb/node_modules/markdown-it/lib/renderer.js:275:28) at Renderer.render (/home/nodebb/nodebb/node_modules/markdown-it/lib/renderer.js:330:22) at MarkdownIt.render (/home/nodebb/nodebb/node_modules/markdown-it/lib/index.js:544:24) at Object.parsePost [as method] (/home/nodebb/nodebb/node_modules/nodebb-plugin-markdown/index.js:163:35) at runMicrotasks () at processTicksAndRejections (internal/process/task_queues.js:93:5) at async fireMethod (/home/nodebb/nodebb/src/plugins/hooks.js:128:11)

Activity icon
issue

barisusakli issue julianlam/nodebb-plugin-markdown

barisusakli
barisusakli

error in rules.image

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received null at validateString (internal/validators.js:124:11) at Object.basename (path.js:1156:5) at Object.parser.renderer.rules.image (/home/nodebb/nodebb/node_modules/nodebb-plugin-markdown/index.js:354:26) at Renderer.renderInline (/home/nodebb/nodebb/node_modules/markdown-it/lib/renderer.js:275:28) at Renderer.render (/home/nodebb/nodebb/node_modules/markdown-it/lib/renderer.js:330:22) at MarkdownIt.render (/home/nodebb/nodebb/node_modules/markdown-it/lib/index.js:544:24) at Object.parsePost [as method] (/home/nodebb/nodebb/node_modules/nodebb-plugin-markdown/index.js:163:35) at runMicrotasks () at processTicksAndRejections (internal/process/task_queues.js:93:5) at async fireMethod (/home/nodebb/nodebb/src/plugins/hooks.js:128:11)

Activity icon
created tag
createdAt 1 day ago
Activity icon
issue

barisusakli issue NodeBB/NodeBB

barisusakli
barisusakli

Chat dropdown should have username attached

Add <username>: <message> or You: <message> in the chat dropdown to easily signal who is the latest respondent, especially in group chats

Oct
12
4 days ago
Activity icon
created tag
createdAt 3 days ago
push

barisusakli push NodeBB/NodeBB

barisusakli
barisusakli

perf: dont fs.open if plugin doesnt have language namespace (#9893)

closes #9892

commit sha: 1feb111ade0b8aa4ecbf3b0f5775d42a33b52927

push time in 3 days ago
Activity icon
delete

barisusakli in NodeBB/NodeBB delete branch language-build

deleted time in 3 days ago
pull request

barisusakli pull request NodeBB/NodeBB

barisusakli
barisusakli

perf: dont fs.open if plugin doesnt have language namespace

closes #9892

Previous