benasher44

benasher44

Member Since 10 years ago

@ashbyhq , San Francisco, CA

Experience Points
116
follower
Lessons Completed
1
follow
Lessons Completed
29
stars
Best Reply Awards
94
repos

103 contributions in the last year

Pinned
⚡ Kotlin Multiplatform UUID
⚡ A template repository for setting up a new Kotlin mulitplatform library for iOS and JVM
⚡ Sample project that shows how to use CocoaPods in a project with an app target and a framework target
⚡ With this plugin its possible to add a default version to a project.
⚡ AWS Cloudfront access log parsing for gathering analytic data, implemented in Kotlin
⚡ Swift Shapefile Parser
Activity
Jan
21
1 day ago
Activity icon
fork

benasher44 forked open-xml-templating/pizzip

⚡ A synchronous zip module
benasher44 Updated
fork time in 1 day ago
Jan
20
2 days ago
Activity icon
issue

benasher44 issue oozcitak/xmlbuilder2

benasher44
benasher44

Control characters not escaped when creating an xml document

Describe the bug We wound up with a control character in a document we intended to serialize to XML using xmlbuilder2, and we found that it doesn't end up escaping, throwing them out, or error.

To Reproduce The following results

create({ encoding: "utf-8", version: "1.0" },  test: { value: "\b" } }).end()

Expected behavior Ideally it would escape them (though not sure 1.0 allows this). If escaping isn't possible, ideally there would be an option to throw them out silently or error.

Version:

  • node.js: 16 LTS
  • xmlbuilder2: 3.0.2 (though tried 2.x as well)

Additional context Happy to provide more (though feel like repro case should capture it)! Thanks for your help!

Jan
15
1 week ago
started
started time in 6 days ago
push

benasher44 push benasher44/sequelize

benasher44
benasher44
benasher44
benasher44

test(integration): mark and fix flaky test (#13735)

benasher44
benasher44

feat(dialect): snowflake dialect support (#13406)

benasher44
benasher44

docs(snowflake): add snowflake description (#13740)

benasher44
benasher44

ci(beta): prepare beta builds

benasher44
benasher44

Merge branch 'sequelize:main' into main

benasher44
benasher44

feat(types): transition lib/errors (#13710)

  • feat(types): transition lib/errors

  • feat(types): importing model type from existing types

  • feat(types): don't export AsyncQueueError from lib/errors

  • feat(types): storing key not value of enum in class

  • feat(types): migrate async-queue to typescript

  • fix(tests): adjust tests for typescript migration

  • feat(types): using inline export for named exports

  • feat(types): rework type definitions

  • feat(types): export AsyncQueueError from errors/index

Co-authored-by: Sascha Depold [email protected]

benasher44
benasher44

chore: add package support info (#13721)

  • build: remove probot-stale (#13595)

  • Include package support json

  • Add support field

  • Add funding in package.json

  • Delete maintainers section

  • Update version and description

  • Update package.json

  • Update package.json

Co-authored-by: Sascha Depold [email protected]

benasher44
benasher44

feat(dialects): add experimental support for db2 (#13374)

  • Db2 support

  • Db2 support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • Db2 Support

  • feat(db2): db2 support

  • feat(db2): db2 support

  • feat(db2): db2 support

  • feat(db2): db2 support

  • feat(db2): db2 support

  • feat(db2): db2 support

  • feat(db2): db2 support

  • Update README.md

Add Db2 Support

  • Update CONTRIBUTING.md

Updated and cleaned Db2 related entries

  • Update start.sh

  • Update package.json

  • feat(New Feature): DB2 support

  • Update .gitignore

  • Update ProjectSettings.json

  • Update ProjectSettings.json

  • Update ProjectSettings.json

  • Delete ProjectSettings.json

  • Delete VSWorkspaceState.json

  • feat(new feature): db2 support

  • feat(new feature): db2 support

  • feat(new feature): db2 support

  • Update query.js

  • Update query.js

  • Update alias.test.js

  • Update alias.test.js

  • feat(new feature): db2 support

  • feat(new feature): db2 support

  • Update package.json

  • feat(new feature): db2 support

  • feat(new feature): db2 support

  • Update ci.yml

  • Update start.sh

  • Update start.sh

  • Update start.sh

  • Update start.sh

  • Update start.sh

  • Update start.sh

  • Update start.sh

  • Update ci.yml

  • Update .mocharc.jsonc

  • Update ci.yml

  • Update README.md

  • Update .mocharc.jsonc

  • Update .mocharc.jsonc

  • Update start.sh

Updated the latest Docker image for ibmdb/db2

  • Update ci.yml

updated to node 14

  • Update ci.yml

  • Update ci.yml

  • feat(new feature): db2 support

  • Disabling time taking Test Cases.

Have tested them locally and are working fine. Line 418. added DB2 condition along with Sqlite.

  • Disabling time taking changes

tested locally and working fine. Line 20 added Db2 condition.

  • disabling time taking test cases

Already tested locally and working fine. Line 157 added condition for db2

  • Update ci.yml

added node 14 support

  • fix(db2): fix 'should not contain views' failing

  • feat(new feature): db2 support

  • Update ci.yml

removed --ignore-engines as new dependencies introduced

  • Update ci.yml

Made consistent with other dialects

  • Update model.test.js

Additional Schemas in DB2

  • Update ci.yml

Removed --frozen-lockfile for all dialects

  • Update ci.yml

Added comment for local Db2 install

  • feat(db2): added db2 support in modified package.json

  • feat(new feature): changes for pull req review cmt

  • feat(new feature): changes for pull req review cmt

  • feat(new feature): changes for pull req review cmt

  • refactor: new test case handling

  • refactor: review comment handling

  • refactor: node16 support

  • refactor: mssql ci.yml entry was wrong on line 252

  • refactor: mssql ci.yml entry wrong at line 251

  • ci(yarn): improved yarn commands

  • feat(code merge): snowflake

  • feat(code merge): comment resolution

  • feat(code merge): Comment resolution

  • feat(code merge): comment and extra space resolution

  • feat(code merge): extra space resolution

  • feat(code merge): comment resolution

  • feat(code refactor): comment resolution

Co-authored-by: Binit Kumar [email protected] Co-authored-by: Binit Kumar [email protected] Co-authored-by: Rik Smale [email protected]

benasher44
benasher44

docs(typescript): add plugin to parse TS files (#13759)

Adds partial support for TS files in generated docs. This isn't the ideal solution but it unhides TS files from docs for now.

benasher44
benasher44

Merge branch 'sequelize:main' into main

benasher44
benasher44

added tests for getAttributes()

benasher44
benasher44

feat(model): complete getAttributes feature

benasher44
benasher44

Fix tests for getAttributes (#13761)

  • ci(db2): ignore errors of db2

  • fix(test): fix get-attributes data-type tests

benasher44
benasher44

Fix typing & export mismatch (#13751)

  • fix: add missing exports that were declared in TS typings

  • fix: add missing typings for existing exports

Co-authored-by: Sascha Depold [email protected]

benasher44
benasher44

feat(upsert): add conflictFields option (#13723)

  • feat(upsert): add conflictFields option

Adds support for the conflictFields option to Model.upsert. This is used for options.upsertKeys in QueryInterface.prototype.upsert if provided for specifying the fields used at ON CONFLICT({fields}) rather than relying on the default logic.

  • add conflictFields to the right type

Co-authored-by: Sascha Depold [email protected]

benasher44
benasher44

refactor(dialect): refactor dialect reserve words (#13757)

commit sha: e5d02ef7e62ff694a90a2fa2cae55de625a87239

push time in 1 week ago
Jan
14
1 week ago
open pull request

benasher44 wants to merge Autodesk/coroutineworker

benasher44
benasher44

Update to 1.6.10

benasher44
benasher44

Okay according to the ticket, we can just remove this. This was added in #56, which predates Kotlin 1.4 (autoreleasepools added to Worker in 1.4.30)

Jan
13
1 week ago
Activity icon
created tag
createdAt 1 week ago
Activity icon
published release 0.4.0

benasher44 in benasher44/uuid create published release 0.4.0

createdAt 1 week ago
Activity icon
delete

benasher44 in benasher44/uuid delete branch basher/1.6

deleted time in 1 week ago
pull request

benasher44 pull request benasher44/uuid

benasher44
benasher44

Upgrade to Kotlin 1.6.10

Fixes or Changes Proposed

  • Upgrade to Kotlin 1.6.10

PR Checklist

  • I have added a CHANGELOG.md entry for any noteable changes or fixes.
  • I have added test coverage for any new behavior or bug fixes.
pull request

benasher44 pull request benasher44/uuid

benasher44
benasher44

Upgrade to Kotlin 1.6.10

Fixes or Changes Proposed

  • My change (#issue-number-if-applicable)

PR Checklist

  • I have added a CHANGELOG.md entry for any noteable changes or fixes.
  • I have added test coverage for any new behavior or bug fixes.
Activity icon
created branch

benasher44 in benasher44/uuid create branch basher/1.6

createdAt 1 week ago
Activity icon
issue

benasher44 issue comment eta-dev/eta

benasher44
benasher44

Benchmarks should precompile templates

Is compilation a useful metric when thinking about the big picture? Most/all of these templating engines allow precompiling templates. Compiling and reusing the compiled result is best practice, well-documented, and results in better performance for all of the other engines.

It's great that eta has achieved such great compilation performance, but once you realize how these benchmarks work (compiling each time through the loop), it makes the benchmarks not that useful—kinda waters them down. I think most of the time you care about render performance. How and when you compile the template is a detail I think most can sort out, in order to get good render performance.

It'd be great to precompile for all of the templating engines for these benchmarks to align them with real-world usage, or at minimum include that as a supplementary benchmark to what you have now.

pull request

benasher44 pull request eta-dev/eta

benasher44
benasher44

Compile templates before render for benchmarks

Closes #153

push

benasher44 push benasher44/eta

benasher44
benasher44

Compile templates before render for benchmarks

commit sha: d469b4cd0fdce72a1d648e6ca60159b2519aeff2

push time in 1 week ago
Jan
11
1 week ago
Activity icon
issue

benasher44 issue comment ProseMirror/prosemirror

benasher44
benasher44

Prosemirrors Domserializer escapes `&` characters in URLs

I'm trying to deliver contents of a prosemirror document as HTML via API and came across this weird behavior when trying to serialize a link that contains ampersand characters:

Expected:

<p>
  <a href="https://blog.example.com/great-blog-post/?utm_source=test&utm_medium=cypress">a link</a>
</p>

Actual:

<p>
  <a href="https://blog.example.com/great-blog-post/?utm_source=test&amp;utm_medium=cypress">a link</a>
</p>

Usually, this doesn't seem to be an issue since browsers tend to correct that but when delivered via API my consumer struggles to render the links correctly due to this.

Reproduction: https://glitch.com/edit/#!/third-humorous-decade

benasher44
benasher44

Which part is being done by the browser's innerHTML, exactly?

Jan
10
1 week ago
Activity icon
issue

benasher44 issue comment eta-dev/eta

benasher44
benasher44

Benchmarks should precompile templates

Is compilation a useful metric when thinking about the big picture? Most/all of these templating engines allow precompiling templates. Compiling and reusing the compiled result is best practice, well-documented, and results in better performance for all of the other engines.

It's great that eta has achieved such great compilation performance, but once you realize how these benchmarks work (compiling each time through the loop), it makes the benchmarks not that useful—kinda waters them down. I think most of the time you care about render performance. How and when you compile the template is a detail I think most can sort out, in order to get good render performance.

It'd be great to precompile for all of the templating engines for these benchmarks to align them with real-world usage, or at minimum include that as a supplementary benchmark to what you have now.

benasher44
benasher44

@shadowtime2000 great thanks! Can I replace the current benchmarks? I think precompiled version is more practical. It will mean that benchmarks no longer show eta as "1st place", but I think it's a better north star, as it's more representative of real usage.

Jan
7
2 weeks ago
open pull request

benasher44 wants to merge Autodesk/coroutineworker

benasher44
benasher44

Update to 1.6.10

benasher44
benasher44

Ah! Can you put it back? I'd like to open a KT ticket with the failure. This is prob a K/N bug

Activity icon
fork

benasher44 forked DefinitelyTyped/DefinitelyTyped

⚡ The repository for high quality TypeScript type definitions.
benasher44 Updated
fork time in 2 weeks ago
open pull request

benasher44 wants to merge Autodesk/coroutineworker

benasher44
benasher44

Update to 1.6.10

benasher44
benasher44

did you mean to update to Kotlin 1.6.10?

open pull request

benasher44 wants to merge Autodesk/coroutineworker

benasher44
benasher44

Update to 1.6.10

benasher44
benasher44

@DanielRBaird actually can you make a test that reproduces it, possibly? I'm surprised all tests have passed.

Jan
6
2 weeks ago
open pull request

benasher44 wants to merge Autodesk/coroutineworker

benasher44
benasher44

Update to 1.6.10

benasher44
benasher44

Hmm I'll do some research and get back to you! We need an autoreleasepool since this is a thread managed by us (and not GCD, for example)—might just be some changes in 1.6.x that we need to take into account.

Previous