[ISSUE #173] fix the feedback problem.
Pinned
Activity
brotherlu-xcq push brotherlu-xcq/esa-restlight
commit sha: 306330419fe3106751e9dd02467ade06be0c77d3
push time in 1 day agobrotherlu-xcq push brotherlu-xcq/esa-restlight
commit sha: bfacdb677864b5361d067d49edcc71e58be6b794
push time in 1 day agobrotherlu-xcq pull request esastack/esa-restlight
rename the resolvers.
Motivation:
rename the resolvers.
Modification:
- remove the
Resolver
- rename
ResolverWrapper
toParamResolver
- rename
ParamResolverXxx
toHttpParamResolverXxx
Result:
Fixes #173
brotherlu-xcq push brotherlu-xcq/esa-restlight
commit sha: 70fa42f5b5676ef7b8011128d29b90084935f824
push time in 1 day agobrotherlu-xcq push brotherlu-xcq/esa-restlight
commit sha: 524c2532e553b3e610001f39a0175260ee960069
push time in 2 days agobrotherlu-xcq push brotherlu-xcq/esa-restlight
commit sha: 969c9db16c05928c759b230c7092dcde8f49bdcf
push time in 2 days agobrotherlu-xcq pull request esastack/esa-restlight
Redefine the resolvers in Restlight.
Motivation:
Redefine the resolvers in Restlight.
Modification:
- redefine the interface of Resolver.
- move the request entity resolver logic to ParamResolver.
Result:
Fixes #173
brotherlu-xcq push brotherlu-xcq/esa-restlight
commit sha: 2bb01b007999ad2f11fb60d581ac4f61bb51e3af
push time in 2 days agobrotherlu-xcq in brotherlu-xcq/esa-restlight create branch fix-#173-new
brotherlu-xcq push brotherlu-xcq/esa-restlight
commit sha: 75779a1b06028c1597b814b2d9c06316b4520dcb
push time in 1 week agobrotherlu-xcq push brotherlu-xcq/esa-restlight
commit sha: 1faeddc1095fd68533cb428184bcfe974abbfc04
push time in 1 week agobrotherlu-xcq push brotherlu-xcq/esa-restlight
commit sha: 4007fa2731968a2cd1197bd4fd031db96c6450ec
push time in 1 week agobrotherlu-xcq issue comment alibaba/nacos
缺少类
Describe the bug The following three classes are missing from the project:
import com.alibaba.nacos.consistency.entity.ReadRequest; import com.alibaba.nacos.consistency.entity.Response; import com.alibaba.nacos.consistency.entity.WriteRequest;
Desktop (please complete the following information):
- Version [e.g. nacos-server 2.0.4]
brotherlu-xcq issue alibaba/nacos
The wrong notes in nacos_grpc_service.proto
Describe the bug the wrong notes in https://github.com/alibaba/nacos/blob/a1c7715e16d73f17dfb3d9439be2b008f8f7fe81/api/src/main/proto/nacos_grpc_service.proto#L43-L46
Expected behavior
replace Sends a commonRequest
to Sends a biStream request
.
Acutally behavior wrong notes.
How to Reproduce see the codes
Desktop (please complete the following information):
- OS: [e.g. Centos]
- Version [e.g. nacos-server 1.3.1, nacos-client 1.3.1]
- Module [e.g. naming/config]
- SDK [e.g. original, spring-cloud-alibaba-nacos, dubbo]
Additional context NONE
brotherlu-xcq pull request esastack/esa-restlight
rename the resolvers.
Motivation:
rename the resolvers.
Modification:
- remove the
Resolver
- rename
ResolverWrapper
toParamResolver
- rename
ParamResolverXxx
toHttpParamResolverXxx
Result:
Fixes #173
brotherlu-xcq in brotherlu-xcq/esa-restlight create branch fix-#173
brotherlu-xcq issue esastack/esa-restlight
merge `io.esastack.restlight.core` and `io.esastack.restlight.server` packages
Expected behavior
io.esastack.restlight.core
and io.esastack.restlight.server
should be rearranged in one package.
Env
Restlight version: 1.0.0-SNAPSHOT
brotherlu-xcq issue esastack/esa-restlight
unclear package defination `io.esastack.restlight.server`
unclear package definitions in io.esastack.restlight.server
-
io.esastack.restlight.server.context
-
io.esastack.restlight.server.core
Interfaces for REQUEST
like ReqeustContext
, HttpRequest
, HttpResponse
should be declared together.
Need to re-examine the interface arrangement in this package
Env
Restlight version: 1.0.0-SNAPSHOT
brotherlu-xcq issue esastack/esa-restlight
unclear package defination: io.esastack.restlight.core.configure
unclear package definitions in io.esastack.restlight.core
-
io.esastack.restlight.core.config
-
io.esastack.restlight.core.configure
Env
Restlight version: 1.0.0-SNAPSHOT JVM version: 1.8 OS:Windows 10
brotherlu-xcq issue esastack/esa-restlight
`ResponseContent` should not be decalared in `io.esastack.restlight.server.bootstrap`
Expected behavior
ResponseContent
is declared for the end-user and make it has a clear package declaration to understand easily
Env
Restlight version: 1.0.0-SNAPSHOT
brotherlu-xcq push brotherlu-xcq/esa-restlight
commit sha: b2138d55761e8452237cb56c0e1fb512c3a03b9b
push time in 1 week agobrotherlu-xcq push esastack/esa-commons
commit sha: 748870bb99a1f3653f6bcac15e8666d235b626f6
push time in 1 week agobrotherlu-xcq push esastack/esa-commons
commit sha: 688fd9356a20cdade80d897ae72f6248431cdb06
push time in 1 week agobrotherlu-xcq push esastack/esa-commons
commit sha: 3eda7563e58dcd6e3fd4facfc5010e1dbef988a8
push time in 1 week agobrotherlu-xcq forked esastack/esa-commons-net
brotherlu-xcq forked esastack/esa-httpserver
brotherlu-xcq issue esastack/esa-restlight
`mvn clean package -Dmaven.test.skip=true` run failed in Github workflow.
Expected behavior
can work normal.
Actual behavior
failed
Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.0:testCompile (default-testCompile) on project restlight-test-starter: Compilation failure: Compilation failure:
Error: /home/runner/work/esa-restlight/esa-restlight/restlight-test/restlight-test-starter/src/test/java/io/esastack/restlight/test/bootstrap/MinorityMockMvcBuilderTest.java:[38,47] package org.springframework.web.bind.annotation does not exist
Error: /home/runner/work/esa-restlight/esa-restlight/restlight-test/restlight-test-starter/src/test/java/io/esastack/restlight/test/bootstrap/MinorityMockMvcBuilderTest.java:[61,6] cannot find symbol
Error: symbol: class ControllerAdvice
Error: location: class io.esastack.restlight.test.bootstrap.MinorityMockMvcBuilderTest
Error: /home/runner/work/esa-restlight/esa-restlight/restlight-test/restlight-test-starter/src/test/java/io/esastack/restlight/test/bootstrap/MinorityMockMvcBuilderTest.java:[66,6] cannot find symbol
Error: symbol: class ControllerAdvice
Error: location: class io.esastack.restlight.test.bootstrap.MinorityMockMvcBuilderTest
Error: -> [Help 1]
Steps to reproduce
see the PR on github.
Env
- Restlight version: 1.0.0-SNAPSHOT
- JVM version: 1.8
- OS:Windows 10
[ISSUE #173] remove the default ContextResolverContextImpl in ContextResolverContextImpl.