canvural

canvural

Member Since 9 years ago

Wroclaw, Poland

Experience Points
67
follower
Lessons Completed
76
follow
Lessons Completed
1.2k
stars
Best Reply Awards
37
repos

350 contributions in the last year

Pinned
⚡ Library to generate fake data for OpenAPI request/response/schemas
⚡ Extra strict and opinionated PHPStan rules for Laravel.
⚡ Set of routes to manage your data in E2E tests
⚡ ⚗️ Adds static analysis to Laravel improving developer productivity and code quality.
⚡ Sedat Abi bir gün herkes olacak
⚡ @sercaneralsan'ın Haller.js'inin Ruby portu
Activity
Oct
28
21 hours ago
pull request

canvural pull request nunomaduro/larastan

canvural
canvural

feat: adds new rule to check for relation existence

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Resolves #974

This PR adds a new rule to check for the existence of the relations. It also supports nested relations.

push

canvural push nunomaduro/larastan

canvural
canvural

feat: adds new rule to check for relation existence

commit sha: b3e52bafb3ac69debccaa7e6fe1b62bd9eb21ca2

push time in 11 hours ago
push

canvural push nunomaduro/larastan

canvural
canvural

feat: adds new rule to check for relation existence

commit sha: 1c22e11ad8070815a964e5d4fd08cfd3f82b2f09

push time in 11 hours ago
pull request

canvural pull request nunomaduro/larastan

canvural
canvural

Apply fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Activity icon
created branch

canvural in nunomaduro/larastan create branch relation-existence-rule

createdAt 11 hours ago
Oct
27
1 day ago
Activity icon
issue

canvural issue comment nunomaduro/larastan

canvural
canvural

Larastan wants to install composer/composer dev-main?

  • Larastan Version: v0.7.15
  • --level used: N/A
  • Pull request with failing test: N/A

Description

Installing Larastan in my new Laravel project causes Composer dev-main to be installed.

I have a proof-of-concept public repo that attempts to install Larastan in a fresh copy of Laravel 8. This shows the bug of installing composer/composer dev-main via the GitHub Action:

https://github.com/Jamesking56/larastan-bug/runs/4015436997?check_suite_focus=true

As you can see in the output:

- Downloading composer/composer (dev-main 135f806)
canvural
canvural

@Jamesking56 Can you try again with a fresh install of Laravel? I think I may have found the issue, and it should be fixed.

Activity icon
delete

canvural in nunomaduro/larastan delete branch 0.7.15

deleted time in 1 day ago
Activity icon
issue

canvural issue comment nunomaduro/larastan

canvural
canvural

Larastan wants to install composer/composer dev-main?

  • Larastan Version: v0.7.15
  • --level used: N/A
  • Pull request with failing test: N/A

Description

Installing Larastan in my new Laravel project causes Composer dev-main to be installed.

I have a proof-of-concept public repo that attempts to install Larastan in a fresh copy of Laravel 8. This shows the bug of installing composer/composer dev-main via the GitHub Action:

https://github.com/Jamesking56/larastan-bug/runs/4015436997?check_suite_focus=true

As you can see in the output:

- Downloading composer/composer (dev-main 135f806)
canvural
canvural

Hi,

This is weird. Nothing in composer.json changed for Larastan. Maybe something to do with this. Can you try stable?

Oct
26
2 days ago
push

canvural push nunomaduro/larastan

canvural
canvural

Revert "docs: prepare release 0.7.15"

This reverts commit b44999898ec74fdef214a0b2c7ea7cd86f15d287.

commit sha: ade264e136c1f1d052789ee17f7feb5a5faf50fe

push time in 2 days ago
Activity icon
issue

canvural issue comment nunomaduro/larastan

canvural
canvural

Adds dynamic method return type extension for `Enumerable::filter`

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Resolves #940

Changes

Breaking changes

canvural
canvural

Could laravel/lumen#162 fix this?

Definitely! Thank you.

push

canvural push nunomaduro/larastan

canvural
canvural

fix: removes tags from rules

This rules have conditional tags. So tagging them here enables them by default.

canvural
canvural

docs: prepare release 0.7.15

canvural
canvural

feat: adds new config file for e2e Laravel tests

commit sha: 1b04a192480ae940103854862081ac8dfdd34476

push time in 2 days ago
push

canvural push nunomaduro/larastan

canvural
canvural

feat: adds dynmaic method return type extension for Enumerable::filter

commit sha: a048ef26f35aae89cf1ca910aa6fc6b534d7655f

push time in 2 days ago
pull request

canvural pull request nunomaduro/larastan

canvural
canvural

Apply fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

push

canvural push nunomaduro/larastan

canvural
canvural

feat: adds dynmaic method return type extension for Enumerable::filter

commit sha: 2bd6167dfd5cbb4e92fe9612b8cdfcf067dd91b1

push time in 2 days ago
pull request

canvural pull request nunomaduro/larastan

canvural
canvural

feat: adds dynmaic method return type extension for `Enumerable::filter`

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Resolves #940

Changes

Breaking changes

push

canvural push nunomaduro/larastan

canvural
canvural

feat: adds dynmaic method return type extension for Enumerable::filter

commit sha: 6dc4d3e20e962f8b3480510fdd228d54499d1bfc

push time in 2 days ago
pull request

canvural pull request nunomaduro/larastan

canvural
canvural

Apply fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

Activity icon
created branch

canvural in nunomaduro/larastan create branch collection-filter-return-type

createdAt 2 days ago
Activity icon
issue

canvural issue nunomaduro/larastan

canvural
canvural

Default value of `checkOctaneCompatibility`

  • Larastan Version: 6.20.36
  • --level used: 8

Description

Upgrading from v0.7.13 to v0.7.14 produces:

Consider using bind method instead or pass a closure.            
 💡 See: https://laravel.com/docs/octane#dependency-injection-and-octane  

The default is supposed to be off. I suspect it's occurring due to changes to extension.neon in https://github.com/nunomaduro/larastan/commit/c7e41a88a0be45dfbc7814fd04123599ce645bbe

Activity icon
issue

canvural issue comment nunomaduro/larastan

canvural
canvural

Default value of `checkOctaneCompatibility`

  • Larastan Version: 6.20.36
  • --level used: 8

Description

Upgrading from v0.7.13 to v0.7.14 produces:

Consider using bind method instead or pass a closure.            
 💡 See: https://laravel.com/docs/octane#dependency-injection-and-octane  

The default is supposed to be off. I suspect it's occurring due to changes to extension.neon in https://github.com/nunomaduro/larastan/commit/c7e41a88a0be45dfbc7814fd04123599ce645bbe

Activity icon
created tag
createdAt 2 days ago
Activity icon
published release 0.7.15

canvural in nunomaduro/larastan create published release 0.7.15

createdAt 2 days ago
push

canvural push nunomaduro/larastan

canvural
canvural

fix: removes tags from rules

This rules have conditional tags. So tagging them here enables them by default.

commit sha: b78d7968bfa5abbecb129826bba552e273dcfc75

push time in 2 days ago
Activity icon
created branch

canvural in nunomaduro/larastan create branch 0.7.15

createdAt 2 days ago
Activity icon
issue

canvural issue comment nunomaduro/larastan

canvural
canvural

Default value of `checkOctaneCompatibility`

  • Larastan Version: 6.20.36
  • --level used: 8

Description

Upgrading from v0.7.13 to v0.7.14 produces:

Consider using bind method instead or pass a closure.            
 💡 See: https://laravel.com/docs/octane#dependency-injection-and-octane  

The default is supposed to be off. I suspect it's occurring due to changes to extension.neon in https://github.com/nunomaduro/larastan/commit/c7e41a88a0be45dfbc7814fd04123599ce645bbe

canvural
canvural

Oh I see the error. https://github.com/nunomaduro/larastan/commit/c7e41a88a0be45dfbc7814fd04123599ce645bbe added tags to rules in extension.neon

Fix is easy but how to release it? 😅 We have changes in master that shouldn't be in the release.

Creating new branch from the 0.7.14 tag and release on that branch?

Activity icon
issue

canvural issue comment nunomaduro/larastan

canvural
canvural

Default value of `checkOctaneCompatibility`

  • Larastan Version: 6.20.36
  • --level used: 8

Description

Upgrading from v0.7.13 to v0.7.14 produces:

Consider using bind method instead or pass a closure.            
 💡 See: https://laravel.com/docs/octane#dependency-injection-and-octane  

The default is supposed to be off. I suspect it's occurring due to changes to extension.neon in https://github.com/nunomaduro/larastan/commit/c7e41a88a0be45dfbc7814fd04123599ce645bbe

canvural
canvural

Hi,

Default value is still off. I tested in a couple of projects, and it seems fine.

Activity icon
issue

canvural issue nunomaduro/larastan

canvural
canvural

Default value of `checkOctaneCompatibility`

  • Larastan Version: 6.20.36
  • --level used: 8

Description

Upgrading from v0.7.13 to v0.7.14 produces:

Consider using bind method instead or pass a closure.            
 💡 See: https://laravel.com/docs/octane#dependency-injection-and-octane  

The default is supposed to be off. I suspect it's occurring due to changes to extension.neon in https://github.com/nunomaduro/larastan/commit/c7e41a88a0be45dfbc7814fd04123599ce645bbe

Activity icon
issue

canvural issue nunomaduro/larastan

canvural
canvural

Prepare for PHPStan 1.0

Hello everyone 👋

I announced today that PHPStan 1.0 is going to be released on November 1st 2021.

I'm approaching you as one of the most popular PHPStan extensions. I'd love if you could prepare your code for PHPStan 1.0 in advance so that it's ready to release on the same day.

Here's a brief guide how to approach the upgrade:

  1. Create a branch 🌴
  2. Update your composer.json to "phpstan/phpstan": "^1.0", add "minimum-stability": "dev" and "prefer-stable": true if necessary.
  3. Update your code with the BC breaks below in mind. 🔧
  4. Fix the code so that it passes PHPStan's analysis 🤓
  5. Wait for PHPStan 1.0 release on November 1st, merge your branch and tag the next major version 👍

Thank you!


Here are the BC breaks. The list is huge but most of those have very little impact.

BC breaks for end-users

The following are interesting only if you create a custom ruleset in your configuration file:

BC breaks for extension developers

Previous