ckadner

ckadner

Software Developer at IBM

Member Since 6 years ago

@IBM, Santa Cruz, CA

Experience Points
60
follower
Lessons Completed
22
follow
Lessons Completed
39
stars
Best Reply Awards
48
repos

371 contributions in the last year

ckadner Most Used Languages
ckadner GitHub Stats

48 Pinned

⚡ IBM's SystemML Machine Learning
⚡ Mirror of Apache Spark
⚡ Mirror of Apache Hive
⚡ Mirror of Apache Quarks site (Incubating)
⚡ Apache Bahir Website
⚡ Mirror of Apache Bahir Website
Sep
16
1 day ago
open pull request

ckadner wants to merge machine-learning-exchange/mlx

ckadner
ckadner

Move Copyright notice to bottom of page, Issue #215

https://github.com/machine-learning-exchange/mlx/issues/215

Moves the copyright notice to the bottom of the page by increasing container's top margin.

ckadner
ckadner

Thanks @BluThaitanium for diving right into the code. I think increasing the top margin, would increase the spacing between the Copyright text and the featured cards above them.

I was rather thinking that the entire Copyright notice text should align with the bottom of the screen. @drewbutlerbb4 maybe you can advise?

pull request

ckadner merge to machine-learning-exchange/mlx

ckadner
ckadner

Move Copyright notice to bottom of page, Issue #215

https://github.com/machine-learning-exchange/mlx/issues/215

Moves the copyright notice to the bottom of the page by increasing container's top margin.

pull request

ckadner merge to machine-learning-exchange/mlx

ckadner
ckadner

Move Copyright notice to bottom of page, Issue #215

https://github.com/machine-learning-exchange/mlx/issues/215

Moves the copyright notice to the bottom of the page by increasing container's top margin.

Sep
15
2 days ago
push

ckadner push ckadner/katalog

ckadner
ckadner

Update Python requirements

Signed-off-by: Christian Kadner ckadner@us.ibm.com

commit sha: 384dea36de2c53218f75ac197cc4964572733248

push time in 1 day ago
Activity icon
issue

ckadner issue comment machine-learning-exchange/mlx

ckadner
ckadner

Convert to SDPX license headers

Converting license header to SPDX format, as requested by @christo4ferris several weeks ago.

start using SPDX tokens to identify the license in source files. e.g.SPDX-License-Identifier: Apache-2.0 see https://github.com/hyperledger/fabric/blob/main/scripts/check_license.sh you can easily add a script such as the one referenced to ensure that a source file has a license header and it is likely that SPDX will be used to create SBOM (Software Bill of Materials) for OSS

Our source files, including code templates and YAML files visible in the MLX UI will no longer show the Apache License header, but the equivalent SPDX short form:

Before:

# Copyright 2021 IBM Corporation
# 
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
# 
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from kfp import dsl
from kfp_tekton.compiler import TektonCompiler
from kfp_tekton import TektonClient
...

After:

# Copyright 2021 IBM Corporation
# 
# SPDX-License-Identifier: Apache-2.0

from kfp import dsl
from kfp_tekton.compiler import TektonCompiler
from kfp_tekton import TektonClient
...

Related issues:

TODO:

  • Add similar scripts and checks for katalog repo
ckadner
ckadner

I will use:

Copyright 2021 The MLX Contributors.

Activity icon
issue

ckadner issue comment machine-learning-exchange/mlx

ckadner
ckadner

Convert to SDPX license headers

Converting license header to SPDX format, as requested by @christo4ferris several weeks ago.

start using SPDX tokens to identify the license in source files. e.g.SPDX-License-Identifier: Apache-2.0 see https://github.com/hyperledger/fabric/blob/main/scripts/check_license.sh you can easily add a script such as the one referenced to ensure that a source file has a license header and it is likely that SPDX will be used to create SBOM (Software Bill of Materials) for OSS

Our source files, including code templates and YAML files visible in the MLX UI will no longer show the Apache License header, but the equivalent SPDX short form:

Before:

# Copyright 2021 IBM Corporation
# 
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
# 
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from kfp import dsl
from kfp_tekton.compiler import TektonCompiler
from kfp_tekton import TektonClient
...

After:

# Copyright 2021 IBM Corporation
# 
# SPDX-License-Identifier: Apache-2.0

from kfp import dsl
from kfp_tekton.compiler import TektonCompiler
from kfp_tekton import TektonClient
...

Related issues:

TODO:

  • Add similar scripts and checks for katalog repo
ckadner
ckadner

https://www.linuxfoundation.org/blog/copyright-notices-in-open-source-software-projects/

Copyright Notices – Community Best Practice

Most LF project communities do not require or recommend that every contributor include their copyright notice in contributed files. See below for more details on why not.

Instead, many LF project communities recommend using a more general statement in a form similar to the following (where XYZ is the project’s name):

- Copyright The XYZ Authors.
- Copyright The XYZ Contributors.
- Copyright Contributors to the XYZ project.

These statements are intended to communicate the following:

- the work is copyrighted;
- the contributors of the code licensed it, but retain ownership of their copyrights; and
- it was licensed for distribution as part of the named project.

By using a common format, the project avoids having to maintain lists of names of the authors or copyright holders, years or ranges of years, and variations on the (c) symbol. This aims to minimize the burden on developers and maintainers as well as redistributors of the code, particularly where compliance with the license requires that further distributions retain or reproduce copyright notices.

push

ckadner push ckadner/katalog

ckadner
ckadner

Update Python requirements

Signed-off-by: Christian Kadner ckadner@us.ibm.com

commit sha: e9d005593fa4f1980e0b157da7ebbb43396d76d7

push time in 1 day ago
push

ckadner push ckadner/katalog

ckadner
ckadner

Update Python requirements

Signed-off-by: Christian Kadner ckadner@us.ibm.com

commit sha: 676f8918794618458099c01e64c0ee62121c7f4d

push time in 1 day ago
push

ckadner push ckadner/katalog

ckadner
ckadner

Update Python requirements

Signed-off-by: Christian Kadner ckadner@us.ibm.com

commit sha: 4c3532705b14b56d0cd9b55aecfe99f9fe83efc9

push time in 1 day ago
push

ckadner push ckadner/katalog

ckadner
ckadner

Update Python requirements

Signed-off-by: Christian Kadner ckadner@us.ibm.com

commit sha: 08634f109b93e77c8b5f253dcc9a544131d36bbc

push time in 1 day ago
push

ckadner push ckadner/katalog

ckadner
ckadner

Update Python requirements

Signed-off-by: Christian Kadner ckadner@us.ibm.com

commit sha: ef3cdf383c192c32332b8b629c8c2490b0fe97ed

push time in 1 day ago
Activity icon
issue

ckadner issue comment machine-learning-exchange/mlx

ckadner
ckadner

Convert to SDPX license headers

Converting license header to SPDX format, as requested by @christo4ferris several weeks ago.

start using SPDX tokens to identify the license in source files. e.g.SPDX-License-Identifier: Apache-2.0 see https://github.com/hyperledger/fabric/blob/main/scripts/check_license.sh you can easily add a script such as the one referenced to ensure that a source file has a license header and it is likely that SPDX will be used to create SBOM (Software Bill of Materials) for OSS

Our source files, including code templates and YAML files visible in the MLX UI will no longer show the Apache License header, but the equivalent SPDX short form:

Before:

# Copyright 2021 IBM Corporation
# 
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
# 
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from kfp import dsl
from kfp_tekton.compiler import TektonCompiler
from kfp_tekton import TektonClient
...

After:

# Copyright 2021 IBM Corporation
# 
# SPDX-License-Identifier: Apache-2.0

from kfp import dsl
from kfp_tekton.compiler import TektonCompiler
from kfp_tekton import TektonClient
...

Related issues:

TODO:

  • Add similar scripts and checks for katalog repo
ckadner
ckadner

Code wise it looks good to me. Not sure we want to keep Copyright 2021 IBM Corporation or make it as Copyright 2021 MLX contributors like what the KFP team did recently.

Good point.

@animeshsingh -- ?

Activity icon
issue

ckadner issue machine-learning-exchange/mlx

ckadner
ckadner

[UI] Move Copyright notice to bottom of page

Currently the copyright notice is hanging out in the middle of the screen under the featured assets cards.

It would look better if those 2 lines could hug the bottom of the frame.

Screen Shot 2021-09-15 at 2 15 38 PM
push

ckadner push ckadner/katalog

ckadner
ckadner

Update Python requirements

Signed-off-by: Christian Kadner ckadner@us.ibm.com

commit sha: 1fce8efaf043d018457d5057881f3979d32c14a6

push time in 1 day ago
Activity icon
issue

ckadner issue comment machine-learning-exchange/mlx

ckadner
ckadner

Convert to SDPX license headers

Converting license header to SPDX format, as requested by @christo4ferris several weeks ago.

start using SPDX tokens to identify the license in source files. e.g.SPDX-License-Identifier: Apache-2.0 see https://github.com/hyperledger/fabric/blob/main/scripts/check_license.sh you can easily add a script such as the one referenced to ensure that a source file has a license header and it is likely that SPDX will be used to create SBOM (Software Bill of Materials) for OSS

Our source files, including code templates and YAML files visible in the MLX UI will no longer show the Apache License header, but the equivalent SPDX short form:

Before:

# Copyright 2021 IBM Corporation
# 
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
# 
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from kfp import dsl
from kfp_tekton.compiler import TektonCompiler
from kfp_tekton import TektonClient
...

After:

# Copyright 2021 IBM Corporation
# 
# SPDX-License-Identifier: Apache-2.0

from kfp import dsl
from kfp_tekton.compiler import TektonCompiler
from kfp_tekton import TektonClient
...

Related issues:

TODO:

  • Add similar scripts and checks for katalog repo
ckadner
ckadner

@Tomcli @animeshsingh -- could you give this PR a look-over?

Activity icon
issue

ckadner issue comment machine-learning-exchange/mlx

ckadner
ckadner

[API] Don't cache KFServices

KFServices do not get updated via the API, so there will be no POST, PATCH, DELETE request to update the API cache.

Signed-off-by: Christian Kadner ckadner@us.ibm.com

ckadner
ckadner
Activity icon
fork

ckadner forked machine-learning-exchange/media

⚡ Repository to host large files like videos, GIFs, PDFs, etc that can be linked in external resources like Blog posts, Tweets, or other presentation materials
ckadner Apache License 2.0 Updated
fork time in 1 day ago
Activity icon
issue

ckadner issue comment machine-learning-exchange/mlx

ckadner
ckadner

Add server stand up test as part of MLX CI

Hi @ckadner sorry I didn't have time to recompile the server for every PR. Right now our CI is only catching build errors but we don't have any test to catch runtime errors. Maybe we can add a simple test just to start the server to make sure nothing is crashing the server startup? This way we don't accidentally merged critical bugs that crashes our server startup.

Originally posted by @Tomcli in https://github.com/machine-learning-exchange/mlx/issues/205#issuecomment-920338732

ckadner
ckadner

starting the image after building it should be a good start -- that does not need Minio or MySQL

Activity icon
issue

ckadner issue comment machine-learning-exchange/mlx

ckadner
ckadner

Add server stand up test as part of MLX CI

Hi @ckadner sorry I didn't have time to recompile the server for every PR. Right now our CI is only catching build errors but we don't have any test to catch runtime errors. Maybe we can add a simple test just to start the server to make sure nothing is crashing the server startup? This way we don't accidentally merged critical bugs that crashes our server startup.

Originally posted by @Tomcli in https://github.com/machine-learning-exchange/mlx/issues/205#issuecomment-920338732

ckadner
ckadner

@Tomcli -- so our PR builder could do this for API code changes:

  • build a new API docker image, push it
  • pull the new image image
  • start the new image
  • upload the catalog via curl, check response code
  • get the catalog, check response code, check number of assets is greater 0

Besides that, I still need to create unit tests from the examples I usually run as a manual test

Related: #116

Activity icon
created branch
createdAt 2 days ago
Sep
14
3 days ago
push

ckadner push ckadner/katalog

ckadner
ckadner

Add Qiskit notebooks

  • Neural Network Classifier and Regressor
  • Quantum Kernel Machine Learning

Closes #33

Signed-off-by: Christian Kadner ckadner@us.ibm.com

commit sha: 02f44b9fd8ee5cfd0ff20b4ed44b56a28677fb76

push time in 2 days ago
Activity icon
created branch

ckadner in ckadner/katalog create branch qiskit_notebook

createdAt 2 days ago
Activity icon
issue

ckadner issue machine-learning-exchange/mlx

ckadner
ckadner

Add `id` field to notebook YAML

Currently the notebook YAMLs do not have an id or notebook_identifier field. This makes it hard to reference a notebook as a related_asset from other assets, like datasets.

Related issues:

  • machine-learning-exchange/katalog#35
Activity icon
issue

ckadner issue machine-learning-exchange/katalog

ckadner
ckadner

Add `id` field to notebook YAML

Currently the notebook YAMLs do not have an id or notebook_identifier field. This makes it hard to reference a notebook as a related_asset from other assets, like datasets.

Activity icon
issue

ckadner issue machine-learning-exchange/mlx

ckadner
ckadner

Add ability to bookmark pipelines

We use IDs for direct access links to our assets. But pipeline IDs are generated by KFP (outside our control). So the URLs for the same pipeline on different MLX instances are different. And if on and the same pipeline gets deleted and re-uploaded, it will have a different ID. This presents a problem when users want to include links to pipelines on MLX in presentations, articles, blog posts, Github issues, etc.

The MLX API should be extended to add something like a "human_id" column in the pipeline extension table which will be used for the direct access links. I assume the KFP-generated ID may need to be retained in parallel to launch pipelines and retrieve pipeline run results (@drewbutlerbb4 ?)

FYI @Tomcli @animeshsingh