danrabbit

danrabbit

Founder at @elementary

Member Since 7 years ago

@elementary , Sacramento, Ca

Experience Points
708
follower
Lessons Completed
0
follow
Lessons Completed
28
stars
Best Reply Awards
43
repos

3870 contributions in the last year

Pinned
⚡ Personal Webpage
⚡ Assets I made for my Twitch channel
⚡ A minimal weather applet
⚡ an elementary theme for rEFInd
⚡ The hero that Gotham needs right now
⚡ Browse and find system icons
Activity
Jan
23
1 day ago
push

danrabbit push elementary/files

danrabbit
danrabbit

Add suggested-action class to accept button (#1993)

commit sha: d4ab00392fdc5b0d865cc1b8a54ceb3ee6a9e6a5

push time in 20 hours ago
pull request

danrabbit pull request elementary/files

danrabbit
danrabbit

Add suggested-action class to accept button

Fixes #1990

Bildschirmfoto von 2022-01-23 11 43 35

Activity icon
issue

danrabbit issue elementary/files

danrabbit
danrabbit

FileChooser: highlight accept action

Problem

Currently, there is no hierarchy to the buttons in the file chooser. I believe that the "accept" button (which can take the form of Open, Save, or others) should be highlighted. It is the primary action of the window, and according to the HIG, should be highlighted.

Further advantages: This would also make the dialog easier to parse, since the expected action to be performed is visually prominent. Also, since we use the Enter key as a mnemonic for the accept button, it should be given a visual indication.

Current state: non-highlighted-save

Proposal

Add the suggested-action style class to the accept button.

highlighted-save

Prior Art (Optional)

No response

If this is something you want, I will happily submit a quick PR. I just wanted to gauge whether this is desired by the design team beforehand.

pull request

danrabbit merge to elementary/files

danrabbit
danrabbit

Add suggested-action class to accept button

Fixes #1990

Bildschirmfoto von 2022-01-23 11 43 35

danrabbit
danrabbit

Looks good. Nice work!

Jan
22
2 days ago
Activity icon
issue

danrabbit issue comment elementary/music

danrabbit
danrabbit

Move metadata discovery to AudioObject

Fixes #693

  • Discover metadata whenever an AudioObject is created
  • PlaybackManager only handles playback now
  • When discoverer returns metadata, more easily check which object it's for
danrabbit
danrabbit

Getting a bug here with playback position. Probably because track length is being discovered after we clamp position

Jan
21
3 days ago
pull request

danrabbit pull request elementary/music

danrabbit
danrabbit

Move metadata discovery to AudioObject

Fixes #693

  • Discover metadata whenever an AudioObject is created
  • PlaybackManager only handles playback now
  • When discoverer returns metadata, more easily check which object it's for
Activity icon
created branch

danrabbit in elementary/music create branch audioobject-metadata

createdAt 2 days ago
push

danrabbit push elementary/music

danrabbit
danrabbit

AudioObject: construct from uri (#696)

commit sha: f9d018e398eaaa6419db6ed044e7f4f074ea0488

push time in 2 days ago
Activity icon
delete

danrabbit in elementary/music delete branch audioobject-fromuri

deleted time in 2 days ago
pull request

danrabbit pull request elementary/music

danrabbit
danrabbit

AudioObject: construct from uri

Just saves us a few steps here

pull request

danrabbit pull request elementary/music

danrabbit
danrabbit

AudioObject: construct from uri

Just saves us a few steps here

Activity icon
created branch

danrabbit in elementary/music create branch audioobject-fromuri

createdAt 2 days ago
Activity icon
delete

danrabbit in elementary/music delete branch playbackmanager-shuffle

deleted time in 2 days ago
pull request

danrabbit pull request elementary/music

danrabbit
danrabbit

PlaybackManager: shuffle

Fixes #687

Drafting because there's no "un-shuffle"

Activity icon
issue

danrabbit issue elementary/music

danrabbit
danrabbit

Shuffle Queue

Problem

There's currently no function to shuffle playback

Proposal

The queue should always reflect the playback order, so a shuffle mechanism would need to rearrange the list itself, not just select a random track when clicking next. This means we'll probably need to keep two lists, one shuffled and one un-shuffled

Prior Art (Optional)

No response

Activity icon
issue

danrabbit issue comment elementary/music

danrabbit
danrabbit

PlaybackManager: shuffle

Fixes #687

Drafting because there's no "un-shuffle"

danrabbit
danrabbit

It sounds like maybe we don't care much about "un-shuffle"? So hey let's go and we can always add that later if there's demand for it

Activity icon
issue

danrabbit issue elementary/stylesheet

danrabbit
danrabbit

Add underscroll shadow below flat titlebar

Problem

Hard cutoff of items

Proposal

.titlebar.flat + scrolledwindow undershoot.top {
    background:
        linear-gradient(
            @borders,
            alpha(black, 0.05) 1px,
            alpha(black, 0.0) 4px
        );
}

Prior Art (Optional)

No response

pull request

danrabbit pull request elementary/icons

danrabbit
danrabbit

Status: update shuffle and consecutive

Use new arrow shape and match size of repeat:

Screenshot from 2022-01-21 13 23 46

and in context:

Screenshot from 2022-01-21 13 27 19

Activity icon
created branch

danrabbit in elementary/icons create branch media-playlist-shuffle

createdAt 2 days ago
pull request

danrabbit pull request elementary/music

danrabbit
danrabbit

PlaybackManager: shuffle

Fixes #687

Drafting because there's no "un-shuffle"

Activity icon
created branch

danrabbit in elementary/music create branch playbackmanager-shuffle

createdAt 2 days ago
push

danrabbit push elementary/stylesheet

danrabbit
danrabbit

Translated using Weblate (Dutch)

Currently translated at 10.0% (1 of 10 strings)

Translation: Desktop/Stylesheet (Extra) Translate-URL: https://l10n.elementary.io/projects/desktop/stylesheet-extra/nl/

danrabbit
danrabbit

GTK4: add Granite.Placeholder (#1154)

  • GTK4: add Granite.Placeholder

  • Fix bugs

  • remove extends flat

Co-authored-by: Cassidy James Blaede [email protected]

danrabbit
danrabbit

Merge branch 'master' into gtk4-expanders

commit sha: fdc6d75d8e12edc594ea1eba0a1b4b15d459b166

push time in 2 days ago
Activity icon
delete

danrabbit in elementary/music delete branch queue-accept-drop

deleted time in 2 days ago
Activity icon
issue

danrabbit issue elementary/music

danrabbit
danrabbit

Drag and Drop files into Queue

What Happened?

Dragging and dropping files into the queue has no effect

Steps to Reproduce

  1. Drag some files
  2. Drop 'em

Expected Behavior

Should have same effect as opening from Files

OS Version

7.x (Early Access)

Software Version

Compiled from git

Log Output

No response

Hardware Info

No response

Previous