dapplion

submittedAt 18 minutes ago

dapplion

dapplion CONTRIBUTOR

createdAt 18 minutes ago

Ignore gossip AggregateAndProof if aggregate is seen

Motivation

Address this spec when validating beacon_aggregate_and_proof gossip message:

[IGNORE] The valid aggregate attestation defined by hash_tree_root(aggregate) has not already been seen (via aggregate gossip, within a verified block, or through the creation of an equivalent aggregate locally).

Description

Implement SeenAggregatedAttestations
Populate seen aggregated attestations from api / gossip / blocks
Check if the aggregated attestation is seen when validating gossip AggregateAndProof message

Closes #3794

TODO

Deploy and test in a node, make sure it takes less time to validate AggregateAndProof gossip messages

dapplion

dapplion MEMBER

Looks great!

push

dapplion push ChainSafe/lodestar

dapplion

Undo unnecessary diff

dapplion

Add comment on __dirname replacement

dapplion

Import type @chainsafe/bls/types

dapplion

Use lodestar path imports

dapplion

Revert multifork to lodestar package

dapplion

Format .mocharc.yaml

dapplion

Use same @chainsafe/as-sha256 version

commit sha： 2da1ff7624cfb9825d3a6a647b996387f61f7565

push time in 21 minutes ago

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

dapplion MEMBER

dapplion wants to merge ChainSafe/lodestar

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

Why the new line export * from "./types.js";?

dapplion wants to merge ChainSafe/lodestar

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

Why importing from lib and not src?

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

dapplion MEMBER

issue

dapplion issue comment ChainSafe/lodestar

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

Note: Multiple unit tests have been skipped, search for TODO remove stub and fix after merging with non-stubby tests

issue

dapplion issue comment ChainSafe/lodestar

dapplion

dapplion MEMBER

Add good full coverage beacon API tests

What is your question?

Current tests for the beacon API are of sub-optimal quality:

Very limited coverage
No assurance that all and future new endpoints are tested
Require import stubbing
Extensive use of brittle stubs: which require big diffs when modifying unrelated cost.

In my subjective opinion the current test suite has a very high cost of maintenance with very little return in ensuring the API is correct.

Proposed solution

Proper tests for a the beacon API should:

Have full coverage
Ensure programmatically that all endpoints current and future are tested
Be tested against a full BeaconChain instance without stubbing and with real data. We are already doing this for BeaconChain validation and such data is extremely fast to produce and to run tests against.

dapplion

https://github.com/ChainSafe/lodestar/blob/5d086b58a20f57c69f1d2cc90d5bf785f851f535/packages/lodestar/test/unit/api/impl/beacon/state/fork.test.ts#L9-L10

More disabled tests

https://github.com/ChainSafe/lodestar/blob/5d086b58a20f57c69f1d2cc90d5bf785f851f535/packages/lodestar/test/unit/api/impl/beacon/pool/pool.test.ts#L25-L26

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

dapplion MEMBER

dapplion wants to merge ChainSafe/lodestar

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

Can't use root exports? Why?

issue

dapplion issue comment ChainSafe/lodestar

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

https://github.com/ChainSafe/lodestar/blob/5d086b58a20f57c69f1d2cc90d5bf785f851f535/packages/lodestar/src/network/gossip/scoringParameters.ts#L4

Note, temp imports to change after gossipsub going ESM

https://github.com/ChainSafe/lodestar/blob/5d086b58a20f57c69f1d2cc90d5bf785f851f535/packages/lodestar/src/network/gossip/validation/index.ts#L1

dapplion wants to merge ChainSafe/lodestar

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

TEMP imports, change after gossipsub goes ESM

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

dapplion MEMBER

dapplion wants to merge ChainSafe/lodestar

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

Note to open an issue for this TODO

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

dapplion MEMBER

dapplion wants to merge ChainSafe/lodestar

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

getSignedBlockTypeFromBytes should be in util/multifork not lodestar-beacon-state-transition

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

dapplion MEMBER

dapplion wants to merge ChainSafe/lodestar

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

How is this metricsRegistry then connected to the metrics server?

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

dapplion MEMBER

dapplion wants to merge ChainSafe/lodestar

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

comment in 2 hours ago

Why is chain exported? How is using it directly?

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

dapplion MEMBER

submittedAt 2 hours ago

dapplion wants to merge ChainSafe/lodestar

dapplion

dapplion MEMBER

ESM Support

Use ESM (only) across all lodestar packages.

Fix linter errors
Fix check-types errors
Fix merge sim tests
Fix sim tests
Fix e2e tests
Fix spec tests
Fix typescript-docs-verifier - disabled for now
Fix merge conflicts

dapplion

comment in 2 hours ago

The point of this file was to import lockfile only when needed. lockfile library attaches listeners to the process, so I wanted that to only happen when necessary

dapplion

dapplion MEMBER