dapplion

dapplion

Eth2.0 core dev at Lodestar @chainsafe | og dev at @dappnode #Ethereum

Member Since 4 years ago

@dappnode , Barcelona

Experience Points
99
follower
Lessons Completed
2
follow
Best Reply Awards
77
repos
Activity
May
20
8 hours ago
Activity icon
issue

dapplion issue comment ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
dapplion
dapplion

@wemeetagain One issue I noticed is that if you import from a file without an extension there's no warning anywhere that it's not gonna work. You'll have to wait until running check-build to realize it's a bad import. Is there any lint rule or something that ensures correct imports at the IDE level while writing code? I think that's mandatory to ensure we don't go crazy after merging this :pray:

pull request

dapplion merge to ChainSafe/lodestar

dapplion
dapplion

Ignore gossip AggregateAndProof if aggregate is seen

Motivation

Address this spec when validating beacon_aggregate_and_proof gossip message:

[IGNORE] The valid aggregate attestation defined by hash_tree_root(aggregate) has not already been seen (via aggregate gossip, within a verified block, or through the creation of an equivalent aggregate locally).

Description

  • Implement SeenAggregatedAttestations
  • Populate seen aggregated attestations from api / gossip / blocks
  • Check if the aggregated attestation is seen when validating gossip AggregateAndProof message

Closes #3794

TODO

  • Deploy and test in a node, make sure it takes less time to validate AggregateAndProof gossip messages
push

dapplion push ChainSafe/lodestar

dapplion
dapplion

Add comment on __dirname replacement

dapplion
dapplion
dapplion
dapplion

Revert multifork to lodestar package

commit sha: 2da1ff7624cfb9825d3a6a647b996387f61f7565

push time in 21 minutes ago
pull request

dapplion merge to ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
open pull request

dapplion wants to merge ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
dapplion
dapplion

Why the new line export * from "./types.js";?

open pull request

dapplion wants to merge ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
dapplion
dapplion

Why importing from lib and not src?

pull request

dapplion merge to ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
Activity icon
issue

dapplion issue comment ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
dapplion
dapplion

Note: Multiple unit tests have been skipped, search for TODO remove stub and fix after merging with non-stubby tests

Activity icon
issue

dapplion issue comment ChainSafe/lodestar

dapplion
dapplion

Add good full coverage beacon API tests

What is your question?

Current tests for the beacon API are of sub-optimal quality:

  • Very limited coverage
  • No assurance that all and future new endpoints are tested
  • Require import stubbing
  • Extensive use of brittle stubs: which require big diffs when modifying unrelated cost.

In my subjective opinion the current test suite has a very high cost of maintenance with very little return in ensuring the API is correct.

Proposed solution

Proper tests for a the beacon API should:

  • Have full coverage
  • Ensure programmatically that all endpoints current and future are tested
  • Be tested against a full BeaconChain instance without stubbing and with real data. We are already doing this for BeaconChain validation and such data is extremely fast to produce and to run tests against.
pull request

dapplion merge to ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
open pull request

dapplion wants to merge ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
dapplion
dapplion

Can't use root exports? Why?

Activity icon
issue

dapplion issue comment ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
open pull request

dapplion wants to merge ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
dapplion
dapplion

TEMP imports, change after gossipsub goes ESM

pull request

dapplion merge to ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
open pull request

dapplion wants to merge ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
dapplion
dapplion

Note to open an issue for this TODO

pull request

dapplion merge to ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
open pull request

dapplion wants to merge ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
dapplion
dapplion

getSignedBlockTypeFromBytes should be in util/multifork not lodestar-beacon-state-transition

pull request

dapplion merge to ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
open pull request

dapplion wants to merge ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
dapplion
dapplion

How is this metricsRegistry then connected to the metrics server?

pull request

dapplion merge to ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
open pull request

dapplion wants to merge ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
dapplion
dapplion

Why is chain exported? How is using it directly?

pull request

dapplion merge to ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
open pull request

dapplion wants to merge ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
dapplion
dapplion

The point of this file was to import lockfile only when needed. lockfile library attaches listeners to the process, so I wanted that to only happen when necessary

pull request

dapplion merge to ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
pull request

dapplion merge to ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
open pull request

dapplion wants to merge ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
dapplion
dapplion

Why not lint test anymore?

open pull request

dapplion wants to merge ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
dapplion
dapplion

Yeah it looks nasty hahaha now I see why the test-utils package

pull request

dapplion merge to ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
open pull request

dapplion wants to merge ChainSafe/lodestar

dapplion
dapplion

ESM Support

Use ESM (only) across all lodestar packages.

  • Fix linter errors
  • Fix check-types errors
  • Fix merge sim tests
  • Fix sim tests
  • Fix e2e tests
  • Fix spec tests
  • Fix typescript-docs-verifier - disabled for now
  • Fix merge conflicts
dapplion
dapplion

What the reason for an async function that instantiates the ValidatorDir class? It turns a bunch of functions async downstream

Previous