darcys22

darcys22

Member Since 9 years ago

Darcy Financial, Australia

Experience Points
34
follower
Lessons Completed
13
follow
Lessons Completed
112
stars
Best Reply Awards
127
repos

516 contributions in the last year

Pinned
⚡ Accounting Software with GRPC endpoints and SQL Backends
Activity
Dec
4
2 days ago
started
started time in 1 day ago
Dec
2
4 days ago
open pull request

darcys22 wants to merge oxen-io/oxen-core

darcys22
darcys22

Calculate the fee based on the current pending transaction.

When building the pending transaction we can call GetFee() to calculate how much the transaction will cost. It takes a single parameter for the number of inputs because we will want to specify how many when estimating.

We then build a list of the potential fees for up to 300 inputs and pass that to our output selection function which will use it to determine if the outputs selected will be sufficient to cover the fees. This allows us to know in advance how much the fees will be rather than trial and error.

darcys22
darcys22

Yeah so the thought process behind the setter function for fee_per_byte member was to make it private eventually. Might be better just doing a public member and modifying it directly.

However the way the code is moving this fee_per_byte (Also fee_per_output) around feels a little off and wouldn't mind discussing it further.

The PendingTransaction class has a function GetFee() so you can call and know what the fee would be using the PendingTransactions current state. The transaction_constructor sets the fee parameters but it also defaults to some reasonable constants.

And the Transaction Constructor has something similar when it gets constructed. It immediately calls a daemon_comms function to get the fee parameters. The Daemon Comms class having a periodic rpc call with the daemon to keep these parameters up to date.

And all 3 - Pending Transaction, Transaction Constructor, Daemon Comms, have defaults pulled from oxen_config constants which have getters and setters to use. Which im not sure if there is a better way

pull request

darcys22 merge to oxen-io/oxen-core

darcys22
darcys22

Calculate the fee based on the current pending transaction.

When building the pending transaction we can call GetFee() to calculate how much the transaction will cost. It takes a single parameter for the number of inputs because we will want to specify how many when estimating.

We then build a list of the potential fees for up to 300 inputs and pass that to our output selection function which will use it to determine if the outputs selected will be sufficient to cover the fees. This allows us to know in advance how much the fees will be rather than trial and error.

push

darcys22 push darcys22/loki-core

darcys22
darcys22

default daemon comms to check for fee parameters and update transaction constructor accordingly

commit sha: 9ca32758a1c7da7bdb75bc0df0a7bd822f8b020a

push time in 4 days ago
Dec
1
5 days ago
pull request

darcys22 pull request oxen-io/oxen-core

darcys22
darcys22

Calculate the fee based on the current pending transaction.

When building the pending transaction we can call GetFee() to calculate how much the transaction will cost. It takes a single parameter for the number of inputs because we will want to specify how many when estimating.

We then build a list of the potential fees for up to 300 inputs and pass that to our output selection function which will use it to determine if the outputs selected will be sufficient to cover the fees. This allows us to know in advance how much the fees will be rather than trial and error.

Activity icon
created branch

darcys22 in darcys22/loki-core create branch transaction-creation

createdAt 4 days ago
Activity icon
delete

darcys22 in darcys22/loki-core delete branch transaction-creation

deleted time in 4 days ago
push

darcys22 push oxen-io/oxen-core

darcys22
darcys22

initial tx creation

The Transaction Constructor will be used to generate pending transactions, depending on the type of transaction the pending transaction class will allow the user to modify items such as tx type (ONS for example) add additional data to the tx extra field, modify burn amount etc before finalising the transaction which will select the necessary outputs, mixins and calculate fees and change amounts. Once finalised the pending transaction will be forwarded to a signing structure for further action.

darcys22
darcys22

Merge pull request #1499 from darcys22/transaction-creation

Transaction creation

commit sha: 089ddd0e72e48bd19326c0b4faaef8aa5a32d2d8

push time in 4 days ago
Nov
30
6 days ago
push

darcys22 push darcys22/godbledger-web

darcys22
darcys22

moved godbledger server settings to settings module

commit sha: c9d2438128235aa7b347e571f1d71e64b90f4fe4

push time in 5 days ago
push

darcys22 push darcys22/godbledger-web

darcys22
darcys22

setting contains database connection information

commit sha: 8fda057c905edba5181625d0430211e5618ed262

push time in 5 days ago
Nov
29
1 week ago
started
started time in 6 days ago
Nov
27
1 week ago
Activity icon
issue

darcys22 issue darcys22/godbledger-web

darcys22
darcys22

Change godbledger queries to use a proper sql connection

Currently uses a ledger object created using the default godbledger config file at .ledger/config.toml

this is giving issues with non default config files. So this should be built using passed in parameters

Nov
25
1 week ago
started
started time in 1 week ago
open pull request

darcys22 wants to merge oxen-io/oxen-core

darcys22
darcys22

Transaction creation

darcys22
darcys22

I'm bout to push an different selection algorithm that uses standard library distributions. Figured the algorithm will have to get smarter and bring in a fair bit of extra that sqlite cant do

push

darcys22 push darcys22/loki-core

darcys22
darcys22

move output selection to its own directory

commit sha: 5f3c5af25c893706e19d427d28c9353d85c08eec

push time in 1 week ago
Nov
24
1 week ago
started
started time in 1 week ago
Activity icon
created branch
createdAt 1 week ago
Activity icon
created repository
createdAt 1 week ago
started
started time in 1 week ago
Nov
23
1 week ago
Activity icon
issue

darcys22 issue comment EnterpriseQualityCoding/FizzBuzzEnterpriseEdition

darcys22
darcys22

No Blockchain.

No Blockchain in this repo pls add one so it makes it twice as fast.

Previous