davezuko

davezuko

✈️ 🔭 🏒 ⌨️ 📖 🎾

Member Since 7 years ago

Microsoft, Nashville, TN

Experience Points
497
follower
Lessons Completed
3
follow
Lessons Completed
238
stars
Best Reply Awards
21
repos

285 contributions in the last year

davezuko Most Used Languages
davezuko GitHub Stats

4 Pinned

⚡ Get started with React, Redux, and React-Router.
⚡ Make React forms simple again, see it here:
⚡ Everything you need to know about Shadow DOM
⚡ Tiny functional programming suite for JavaScript.
Sep
9
1 week ago
Activity icon
issue

davezuko issue comment evanw/esbuild

davezuko
davezuko

update minimum go version to 1.17

Since esbuild uses some newer Go API's it would be nice to accurately specify the minimum Go version for dependents. I ran into this while trying to upgrade esbuild to 0.12.26 while on Go 1.16, where Go would no longer compile with esbuild due to its math.MaxInt usage. I wish I could offer something more than this trivial change, but perhaps it will be helpful to others.

I'm far from a Go expert so if there are things to be careful with when updating this please let me know (i.e. I read through https://golang.org/doc/modules/gomod-ref and, weirdly, it sounds like Go should have caught this...).

Thanks!

davezuko
davezuko

Update the PR to just inline the math.MaxInt constants directly. That should be more palatable.

push

davezuko push davezuko/esbuild

davezuko
davezuko

replace math.MaxInt usage

This constant is only available in go >= 1.17, so I've inlined its value so dependents don't have to upgrade their go version.

reference implementation: https://cs.opensource.google/go/go/+/refs/tags/go1.17:src/math/const.go;l=38

commit sha: 6a927be4afa627117abfeaebe941254d025cb802

push time in 1 week ago
Activity icon
issue

davezuko issue comment evanw/esbuild

davezuko
davezuko

update minimum go version to 1.17

Since esbuild uses some newer Go API's it would be nice to accurately specify the minimum Go version for dependents. I ran into this while trying to upgrade esbuild to 0.12.26 while on Go 1.16, where Go would no longer compile with esbuild due to its math.MaxInt usage. I wish I could offer something more than this trivial change, but perhaps it will be helpful to others.

I'm far from a Go expert so if there are things to be careful with when updating this please let me know (i.e. I read through https://golang.org/doc/modules/gomod-ref and, weirdly, it sounds like Go should have caught this...).

Thanks!

davezuko
davezuko

@evanw absolutely, I thought about that as well. I proposed this change simply because I didn't know what else might be in esbuild that requires go > 1.13 and thought it might be worth the update regardless. The wise thing to do would probably be for me to downgrade go locally to 1.13 and see if any other issues crop up. I know that Go 1.16 was at least working until the addition of math.MaxInt.

pull request

davezuko pull request evanw/esbuild

davezuko
davezuko

update minimum go version to 1.17

Since esbuild uses some newer Go API's it would be nice to accurately specify the minimum Go version for dependents. I ran into this while trying to upgrade esbuild to 0.12.26 while on Go 1.16, where Go would no longer compile with esbuild due to its math.MaxInt usage. I wish I could offer something more than this trivial change, but perhaps it will be helpful to others.

I'm far from a Go expert so if there are things to be careful with when updating this please let me know (i.e. I read through https://golang.org/doc/modules/gomod-ref and, weirdly, it sounds like Go should have caught this...).

Thanks!

Activity icon
created branch

davezuko in davezuko/esbuild create branch go-1.17

createdAt 1 week ago
push

davezuko push davezuko/esbuild

davezuko
davezuko

fix #605: re-export of side-effect free cjs

davezuko
davezuko

tree shaking of side-effect free "export {} from"

davezuko
davezuko

remove unused argument from "installForTests"

davezuko
davezuko

Use env variable ESBUILD_BINARY_PATH to use different binary path (#597)

davezuko
davezuko

"ESBUILD_BINARY_PATH" release notes (#597)

davezuko
davezuko
davezuko
davezuko

fix yarn-specific perf regression (#590)

davezuko
davezuko

fix #611: source map size regression

davezuko
davezuko

remove test-only "js_printer.PrintExpr" function

davezuko
davezuko

optimize source map quoting

davezuko
davezuko
davezuko
davezuko

return an object from "flagsForBuildOptions"

davezuko
davezuko

unshare services with different cwd

davezuko
davezuko

avoid syntax error for newline in path or namespace

davezuko
davezuko

ignore all rimraf errors to fix windows flakes

davezuko
davezuko

add a warning about calling an import namespace

davezuko
davezuko

also warn about constructing import namespaces

davezuko
davezuko

fix #613: imported symbols are side-effect free

davezuko
davezuko
davezuko
davezuko

fix #626: "import.meta" is supported in node 10.4+

commit sha: 6a3d3a67661378c36ab0f8f450feffc191ec9b52

push time in 1 week ago
Activity icon
delete

davezuko in davezuko/esbuild delete branch cache

deleted time in 1 week ago
Sep
7
1 week ago
Activity icon
delete

davezuko in davezuko/umbrella delete branch davezuko/www

deleted time in 1 week ago
Aug
26
3 weeks ago
Aug
25
3 weeks ago
push

davezuko push davezuko/umbrella

davezuko
davezuko

follow prettier/eslint's required package naming conventions

commit sha: 35d8da0ac9fafbb870da76e73cd4c0213d4ba048

push time in 3 weeks ago
push

davezuko push davezuko/umbrella

davezuko
davezuko

follow prettier/eslint's required package naming conventions

commit sha: 7e88b82e2ef0310279457aaf49bf35f3a2b516bb

push time in 3 weeks ago
push

davezuko push davezuko/umbrella

davezuko
davezuko

follow prettier/eslint's required package naming conventions

commit sha: b323c76a7df383cc851b0472f2507026d450419f

push time in 3 weeks ago
Aug
22
3 weeks ago
Activity icon
issue

davezuko issue davezuko/.zuko

davezuko
davezuko

automate installation of python vim plugins

Activity icon
issue

davezuko issue davezuko/.zuko

davezuko
davezuko

separate vimrc and nvim config (or add x-compat)

Aug
21
3 weeks ago
push

davezuko push davezuko/.zuko

davezuko
davezuko

nvim: trying to get typescript/eslint/prettier to work together

commit sha: ffebe7da99adcb144757d8d69efd002a8de216f7

push time in 3 weeks ago
push

davezuko push davezuko/.zuko

davezuko
davezuko

nvim: trying to get typescript/eslint/prettier to work together

commit sha: 83f42607f56bc2e9290f27d1911f783e842be4c9

push time in 3 weeks ago
push

davezuko push davezuko/.zuko

davezuko
davezuko

nvim: telescope is awesomeeeeeee

commit sha: 1d81ac3cd45d149682d3a2139b9de48552c292a9

push time in 3 weeks ago
push

davezuko push davezuko/.zuko

davezuko
davezuko

nvim: figuring out native LSP

commit sha: 6a5475f955e909f07c1d90cd842f8f095d6e6f9a

push time in 3 weeks ago
Aug
20
4 weeks ago
push

davezuko push davezuko/.zuko

davezuko
davezuko

nvim: messing around with neovim 0.5

commit sha: 24d6525dd9e2ca80d1db2534990a22408e163095

push time in 3 weeks ago
started
started time in 4 weeks ago
push

davezuko push davezuko/.zuko

davezuko
davezuko

start porting nvim config to lua

commit sha: 10767b09bb2f665eb1d6db772883f9258a2ec13f

push time in 4 weeks ago