drew-usds

drew-usds

Member Since 1 year ago

U.S. Digital Service, Washington, DC

Experience Points
0
follower
Lessons Completed
0
follow
Lessons Completed
3
stars
Best Reply Awards
2
repos

519 contributions in the last year

Pinned
⚡ A simple Gulp 4.0 workflow for transforming USWDS Sass into browser-readable CSS.
Activity
Oct
7
1 week ago
Activity icon
issue

drew-usds issue comment CDCgov/prime-reportstream

drew-usds
drew-usds

Review current API mapping and identify any changes we will need for React migration

Although unlikely, we might need to change or update our current APIs to accommodate any work we're going to do during the React migration. @td-usds is building some API documentation for our current state, so it would be good to review that with him, and then discuss a migration plan.

drew-usds
drew-usds

@MauriceReeves-usds based on the last comment on this, seems like this is good to close?

Activity icon
issue

drew-usds issue comment CDCgov/prime-reportstream

drew-usds
drew-usds

React transition: loading times long (and sometimes infinite)

Describe the bug

  • It takes many, many seconds to log in or switch between report show pages.
  • Sometimes the loading spinner indefinitely runs.
  • Matt ID'd a possible 503 / Azure config problem.
  • Mo screenshotted an error (below)

Impact Please describe the impact this bug is causing to your program or organization.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots image.png

Logs If applicable, please attach logs to help describe your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

drew-usds
drew-usds

@sean-usds I'm not seeing any of these errors in the console anymore and I'm guessing a lot of our other bug fixes/move to fully being an SPA fixed this. Good to close?

Activity icon
issue

drew-usds issue comment CDCgov/prime-reportstream

drew-usds
drew-usds

Discuss transition with DevOps to identify any changes needed to CI/CD and/or Docker container

Acceptance criteria

  • Answer the following questions:
    • How do we build the React site
    • How do we serve the React site in Docker?
    • How do we run the React testing suite on the local dev environment?
    • How do we run integration testing locally?
    • How do we run dynamic testing and code coverage for React
    • How do we run the testing tools in GitHub actions on PR creation?
    • Can we build a set of testing scripts for automated testing with Node, Puppeteer, etc?
drew-usds
drew-usds

@sean-usds @ronaldheft-usds I know we've covered 99.9999% of this already, but just wanted to double check there weren't any outstanding items here we needed to resolve.

Activity icon
issue

drew-usds issue CDCgov/prime-reportstream

drew-usds
drew-usds

React launch QA: Part I

Epic capturing all bugs found during 9/15 team QA session.

Activity icon
issue

drew-usds issue comment CDCgov/prime-reportstream

drew-usds
drew-usds

React launch QA: Part I

Epic capturing all bugs found during 9/15 team QA session.

drew-usds
drew-usds
Activity icon
issue

drew-usds issue comment CDCgov/prime-reportstream

drew-usds
drew-usds

React transition: USWDS and custom styles not 1:1 with production

Describe the bug A host of styles aren't quite matching up with what's in production. Might need to double check everything is getting pulled in from USWDS/uswds-gulp and our custom stylesheets currently in prod.

Elements to check:

  • Fonts: switch out Source Sans Pro for Public Sans
  • Header styles off - missing bottom rule, active/hover states spacing off
  • Spacing off between navigation and body content
  • Index hero styles off
  • Remove icons on index
  • Index text/col spacing off
  • How it works nav dropdown sticks to the right of the element instead of the left

Impact Please describe the impact this bug is causing to your program or organization.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Logs If applicable, please attach logs to help describe your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

Activity icon
issue

drew-usds issue CDCgov/prime-reportstream

drew-usds
drew-usds

React transition: USWDS and custom styles not 1:1 with production

Describe the bug A host of styles aren't quite matching up with what's in production. Might need to double check everything is getting pulled in from USWDS/uswds-gulp and our custom stylesheets currently in prod.

Elements to check:

  • Fonts: switch out Source Sans Pro for Public Sans
  • Header styles off - missing bottom rule, active/hover states spacing off
  • Spacing off between navigation and body content
  • Index hero styles off
  • Remove icons on index
  • Index text/col spacing off
  • How it works nav dropdown sticks to the right of the element instead of the left

Impact Please describe the impact this bug is causing to your program or organization.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Logs If applicable, please attach logs to help describe your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

Activity icon
issue

drew-usds issue CDCgov/prime-reportstream

drew-usds
drew-usds

React: force overrides on remaining styling issues

For anything blocked by #2203, just force overrides for now. We'll incorporate Tom's improvements after release.

List of small changes to make:

  • bottom rule on Nav
  • font size on logo -> add back in uswds markup
  • <main> missing around body content
  • asst spacing
Oct
6
1 week ago
Activity icon
issue

drew-usds issue comment CDCgov/prime-reportstream

drew-usds
drew-usds

Update global.scss

USWDS has a variable to put the theme compiler into verbose mode. I had it set to true while doing scss work, but it can be false.

drew-usds
drew-usds

@TomNUSDS sorry for the confusing review, after I approved I noticed it was also being set to false in _uswds_settings.css. Made a commit to just have it set in _uswds_settings.css.

push

drew-usds push CDCgov/prime-reportstream

drew-usds
drew-usds

remove duplicate theme-show-notifications, was already in _uswds_settings.css

commit sha: a23d9bc2e1fd922f7ab2fa38bd06320c8db19976

push time in 1 week ago
pull request

drew-usds merge to CDCgov/prime-reportstream

drew-usds
drew-usds

Update global.scss

USWDS has a variable to put the theme compiler into verbose mode. I had it set to true while doing scss work, but it can be false.

drew-usds
drew-usds
Oct
5
1 week ago
Activity icon
created branch

drew-usds in CDCgov/prime-reportstream create branch dg/col-content-spacing

createdAt 1 week ago
Activity icon
issue

drew-usds issue comment CDCgov/prime-reportstream

drew-usds
drew-usds

React: force overrides on remaining styling issues

For anything blocked by #2203, just force overrides for now. We'll incorporate Tom's improvements after release.

List of small changes to make:

  • bottom rule on Nav
  • font size on logo -> add back in uswds markup
  • <main> missing around body content
  • asst spacing
pull request

drew-usds merge to CDCgov/prime-reportstream

drew-usds
drew-usds

Get uswds trussworks scss build working

In package.json

  • Reworked the build system to use craco (similar to what SimpleReport uses).
  • Removed unused gulp dependencies
  • Removed unused node-sass (to avoid confusion since it's no longer used)
  • uswds-gulp became uswds in package
  • react-scripts build -> craco build

The layout

|-- ./App.tsx
|-- ./global.scss
|-- ./index.tsx
`-- ./styles
    |-- ./styles/_print.scss
    |-- ./styles/_reportstream.scss
    |-- ./styles/_uswds_overrides.scss
    `-- ./styles/_uswds_settings.scss
File Description
global.scss Simply includes other resources in the correct order. ONLY referenced from index.tsx
_print.scss Styles related to printing pages to pdf.
_reportstream.scss Styles for Report Stream specific components/elements
_uswds_overrides.scss This is processed after USWDS libraries and Trusswork's React library. It can be use to override things from those libraries if they can't be controlled by a theme setting
_uswds_settings.scss USWDS theme specific variables

Note: theme/uswds-theme-general and the other "USWDS theme include" files are loaded directly from USWDS distribution. This is done for forward compatibility. When USWDS modifies these files, merging and maintaining them will be painful. Any variable that are changed should be copied out of these files and put into _uswds_overrides.scss

This approach also makes it trivial to see what's we've changed from the USWDS defaults.

TODO:

  • Need to add details about the system to a README or something.
drew-usds
drew-usds

👍 niiiice. Yarn worked without a hitch. I added a commit that tested out using uswds variables in other stylesheets ✔️ , and tested out changing _uswds_settings.scss ✔️. I also removed some duplicate styles for html, head, body, etc that were in both _reportstream.css and _uswds_overrides.scss since I was already poking around.

push

drew-usds push CDCgov/prime-reportstream

drew-usds
drew-usds

test color variables in scss, switch fonts to public-sans, remove duplicate html/body/etc styles

commit sha: 1dd1d75e57c918ca7a38502f008f652f07740a3b

push time in 1 week ago
Sep
30
2 weeks ago
Activity icon
issue

drew-usds issue CDCgov/prime-reportstream

drew-usds
drew-usds

React: force overrides on remaining styling issues

For anything blocked by #2203, just force overrides for now. We'll incorporate Tom's improvements after release.

List of small changes to make:

-[ ] bottom rule on Nav

Activity icon
issue

drew-usds issue CDCgov/prime-reportstream

drew-usds
drew-usds

React: fix routing for error pages

Problem

  • Bad URLs don't point to 404 page.
  • The 11ty site also had a page and stylse

To do

  • Copy 404 HTML from 11ty
  • Double check that supported browser page shows up if you're below IE 11. Copy existing html & CSS from 11ty
Sep
29
2 weeks ago
Activity icon
issue

drew-usds issue CDCgov/prime-reportstream

drew-usds
drew-usds

Sender content outline

Problem statement

Outline sender focused content based on current comms from Mike C.

What you need to know

[Links to documents, workflows, or list of key people and contact info]

Currently have:

  • Welcome email
  • One pager

Acceptance criteria

n/a

To do

  • ...
Sep
27
2 weeks ago
push

drew-usds push CDCgov/prime-reportstream

drew-usds
drew-usds

add react-markdown, add md to react TOS

drew-usds
drew-usds

remove markdown packages, add html for TOS to react

drew-usds
drew-usds

update IL on 11ty where we're live

drew-usds
drew-usds

update IL on react live json

drew-usds
drew-usds
drew-usds
drew-usds

update stlt map with AK and NH on 11ty and React

drew-usds
drew-usds

Merge pull request #2262 from CDCgov/dg/tos-update-0921

Update TOS on 11ty and React, add IL to live map on 11ty

commit sha: f7ce2d128539cf8a7c1c47f61a3a5c52e45c2123

push time in 2 weeks ago
Activity icon
delete

drew-usds in CDCgov/prime-reportstream delete branch dg/tos-update-0921

deleted time in 2 weeks ago
pull request

drew-usds pull request CDCgov/prime-reportstream

drew-usds
drew-usds

Update TOS on 11ty and React, add IL to live map on 11ty

This PR ...

  • Updates the Terms of Service
  • Adds AK, IL, NH to live map and list

Test Steps:

  1. Include steps to test these changes

Changes

  • Updates the Terms of Service
  • Adds AK, IL, NH to live map and list

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • Downloaded a file from http://localhost:7071/api/download?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Fixes

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?
Sep
24
3 weeks ago
Activity icon
issue

drew-usds issue CDCgov/prime-reportstream

drew-usds
drew-usds

React: page <title>s aren't the same as production

  • Every page on staging currently has the <title> set as "ReportStream Dashboard"
  • Titles should match what's on prod. In 11ty they are stored in front matter and slug-ified. There's also some logic to change some styling/pipes depending on the page (ex: index = PRIME ReportStream, ELR onboarding page = ELR onboarding | How it works | PRIME ReportStream
Sep
23
3 weeks ago
Activity icon
issue

drew-usds issue comment CDCgov/prime-reportstream

drew-usds
drew-usds

Update TOS on 11ty and React, add IL to live map on 11ty

This PR ...

  • Updates the Terms of Service
  • Adds IL to live map and list

Test Steps:

  1. Include steps to test these changes

Changes

  • Updates the Terms of Service
  • Adds IL to live map and list

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • Downloaded a file from http://localhost:7071/api/download?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Fixes

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?
drew-usds
drew-usds
push

drew-usds push CDCgov/prime-reportstream

drew-usds
drew-usds

update stlt map with AK and NH on 11ty and React

commit sha: 33c5cb995f87d868c4d39e01a1238f076925e1ea

push time in 3 weeks ago
Sep
22
3 weeks ago
Activity icon
issue

drew-usds issue comment CDCgov/prime-reportstream

drew-usds
drew-usds

React transition: USWDS and custom styles not 1:1 with production

Describe the bug A host of styles aren't quite matching up with what's in production. Might need to double check everything is getting pulled in from USWDS/uswds-gulp and our custom stylesheets currently in prod.

Elements to check:

  • Fonts: switch out Source Sans Pro for Public Sans
  • Header styles off - missing bottom rule, active/hover states spacing off
  • Spacing off between navigation and body content
  • Index hero styles off
  • Remove icons on index
  • Index text/col spacing off
  • How it works nav dropdown sticks to the right of the element instead of the left

Impact Please describe the impact this bug is causing to your program or organization.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Logs If applicable, please attach logs to help describe your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

drew-usds
drew-usds

Update from meeting with @TomNUSDS

  • Will look into what we can learn/copy form SR's build process. Maybe we can skip USWDS-gulp and build/watch with our own take on the uswds package.
Sep
21
3 weeks ago
Activity icon
issue

drew-usds issue comment CDCgov/prime-reportstream

drew-usds
drew-usds

Get the gulpfile.js to load

Followed instructions here: https://github.com/uswds/uswds-gulp and ran npm install autoprefixer gulp gulp-replace sass gulp-sass gulp-sourcemaps gulp-rename gulp-svg-sprite gulp-postcss postcss postcss-csso uswds [email protected]:uswds/uswds-gulp --save-dev

This moved a bunch of existing node modules into devDependencies from dependencies and added some missing modules (e.g. postscss-csso)

Test Steps:

  1. Load the gulpfile.js and try to run some of the tasks (e.g. build-sass)

Changes

drew-usds
drew-usds

Nice works for me too @TomNUSDS! I'll actually run gulp init on this branch and add a commit to fix #2203 while we're at it.

push

drew-usds push CDCgov/prime-reportstream

drew-usds
drew-usds
drew-usds
drew-usds

Gateway subnet is not needed

drew-usds
drew-usds

Use IP whitelist instead of VPN

drew-usds
drew-usds

Suppresses PID-13 and OBX-18

drew-usds
drew-usds

Added schema and generic quick tests

drew-usds
drew-usds

Added more information on quick test config file

drew-usds
drew-usds

added message to terms of service

drew-usds
drew-usds

Adds user password option for the two key file auths

drew-usds
drew-usds

Creating new gitleaks suppression

drew-usds
drew-usds

fixed 2178 - empty string is not valid json action_response

drew-usds
drew-usds

Simplified regex by only looking at filename for quick tests

drew-usds
drew-usds

Pass in file settings to ProcessData CLI class

drew-usds
drew-usds

Added function to check filename regex

drew-usds
drew-usds

Merge branch 'master' into cfelix/quick-test-migration

drew-usds
drew-usds

Added DHPrimeAdmins to PERMISSIONS enum

drew-usds
drew-usds

Fix for #2180 where exceptions in ReportFunction cause later BatchFunction failures

drew-usds
drew-usds

Merge branch 'ronheft/peering-fix' into ronheft/palo-alto-no-vpn

drew-usds
drew-usds

Revert "Remove vnet-peer"

This reverts commit 084927ef

commit sha: 3fb07fb1083945af3f0748803b81cd1c5405781f

push time in 3 weeks ago
pull request

drew-usds pull request CDCgov/prime-reportstream

drew-usds
drew-usds

Update TOS, add IL to live map

This PR ...

  • Updates the Terms of Service
  • Adds IL to live map and list

Test Steps:

  1. Include steps to test these changes

Changes

  • Updates the Terms of Service
  • Adds IL to live map and list

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • Downloaded a file from http://localhost:7071/api/download?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Fixes

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?
Previous