eps1lon

eps1lon

Programmer. I care about accessibility and testing.

Member Since 6 years ago

Dresden, Germany

Experience Points
468
follower
Lessons Completed
33
follow
Lessons Completed
255
stars
Best Reply Awards
256
repos

3890 contributions in the last year

Pinned
⚡ MUI (formerly Material-UI) is the React UI library you always wanted. Follow your own design system, or start with Material Design.
⚡ Implements https://w3c.github.io/accname/
⚡ Utilities to match the speech output of screen readers when replaying user interactions.
⚡ 🐐 Simple and complete React DOM testing utilities that encourage good testing practices.
⚡ The repository for high quality TypeScript type definitions.
⚡ 📦🐈 Active development trunk for Yarn ⚒
Activity
Dec
8
13 hours ago
push

eps1lon push mui-org/material-ui

eps1lon
eps1lon

[system] Don't transition when re-appearing (#30108)

commit sha: 69b7e4d911e8ff99d17a74330496ae69e7cc0ade

push time in 1 hour ago
Activity icon
delete

eps1lon in eps1lon/material-ui delete branch test/react-18

deleted time in 1 hour ago
pull request

eps1lon pull request mui-org/material-ui

eps1lon
eps1lon

[system] Don't transition when re-appearing

The previous implementation relied on the CSSProvider only appearing once. However, with a potential Offscreen API and Strict Effects in React 18 the test no longer passed since the second (simulated by Strict Effects) effect thought the component had already mounted.

The solution was to cleanup the effect: 70b320f (#30108) React 18 run: https://app.circleci.com/pipelines/github/mui-org/material-ui/59135/workflows/dfbccb41-e632-42c0-b2dd-ab642ff50178

push

eps1lon push eps1lon/material-ui

eps1lon
eps1lon

Revert "REVERT LATER Install React 18"

This reverts commit 2a709aa32f85ea86261eefa4fde7162357044c2d.

commit sha: d169e5b033df5edd51c8af94b1c3652f9b46ba4d

push time in 3 hours ago
pull request

eps1lon pull request mui-org/material-ui

eps1lon
eps1lon

[system] Don't transition when re-appearing

The previous implementation relied on the CSSProvider only appearing once. However, with a potential Offscreen API and Strict Effects in React 18 the test no longer passed since the second (simulated by Strict Effects) effect thought the component had already mounted.

The solution was to cleanup the effect:

Activity icon
created branch

eps1lon in eps1lon/material-ui create branch test/react-18

createdAt 3 hours ago
Activity icon
delete

eps1lon in eps1lon/DefinitelyTyped delete branch fix/implicit-children/brainhubeu__react-carousel

deleted time in 3 hours ago
push

eps1lon push eps1lon/DefinitelyTyped

eps1lon
eps1lon

🤖 Merge PR #57448 update(zingchart): Added missing attributes for scaleX and scaleY by @jeanettephung

  • Add types for zingchart

  • Adds content header to zingchart

  • Fixes typedef extends for lint

  • Fixes version, import, and empty jsdoc comments

  • Removes last empty jsdoc comment

  • Allows values and series types to be arrays

  • Fixes values type

  • ZingChart type updates

  • Added d.ts file for zingchart/es6 and applied fixes

  • Move definitions in es6/index and reference in index.d.ts

  • Update test to include added attributes

  • Add .d.ts for ZingChart NodeJS build

  • Apply fixes after running "npm test"

  • Add additional test using NodeJS d.ts

  • Included new files into in tsconfig

  • Fix JSON format for tsconfig

  • Rewrite .d.ts for NodeJS build and combine tests into one file

  • Only list one d.ts in tsconfig and reference NodeJS d.ts in test

  • Provide default exports

  • Update to include default exports

  • Update test to try default import

  • Allow default export and fix exports for each version (originally assumed exports were the same)

  • use nodejs version in test because required to use file

  • Fix whitespace error in test

  • Update test to include testing default import

  • Fixed zingchart/index.dts based on reviewers notes

  • Update tslint.json to remove rules no longer needed

  • Corrections to TDF relating to plot and legend

  • Asterisk fix

  • update(zingchart): Add def for plot.tooltip.text

  • create(zinggrid): add new typings

  • update(zingchart): Add missing types for plot and graphset

  • Remove redundant 'undefined' value and fix trailing whitespace

  • Updated definition author

  • Added camel-case version of attributes

  • refactor definitions

  • Update exec arg to be optional

  • Add missing properties: series.id series.type graphset.utc graphset.plot.selectedState.lineWidth graphset.plot.tooltip.textAlign graphset.plot.valueBox.fontSize (doesn't accept numbers, only string) graphset.maxTrackers graphset.legend.marker.borderRadius graphset.scaleX.maxItems graphset.scaleY.zooming

  • Fix alignment issues

  • Update/fix properties:

  • *.lineWidth
  • *.borderWidth
  • graphset.plot.dataAppendSelection
  • graphset.plot.dataIgnoreSelection
  • graphset.plot.selectionMode
  • graphset.scaleX.thousandsSeparator
  • graphset.scaleX.zooming
  • graphset.plot.highlight
  • graphset.timeZone
  • Add missing attributes:
  • graphset.legend.marker.borderRadius (type)
  • graphset.plot.highlight
  • graphset.zoomSnap
  • graphset.selectionTool
  • Added tests for previous commit

  • update(zingchart): add behavior.text and behavior.customFunction, and updated graphset.labels

  • Add definitions for palette (theme)

  • update(zingchart): Add missing transform definitions

  • remove consecutive blank lines

  • Add definitions for scaleX (minValue, step) and scaleY (step)

Co-authored-by: Mike Schultz [email protected] Co-authored-by: dannyjuergens [email protected] Co-authored-by: jphung [email protected]

eps1lon
eps1lon

🤖 Merge PR #57444 [color-string] Use more appropriate defs for nullish inputs by @ccjmne

  • Use more appropriate defs for nullish inputs

The previous definition would allow passing no value to the get.hsl, get.rwb and get.rgb functions, which, while effectively possible, was no sensible (as hinted by @BendingBender).

Merely accepting string | null for the three declinations of the get function simply works and does error out at a get.rgb() call without any argument.

  • Update types/color-string/index.d.ts

Co-authored-by: Dimitri B. [email protected]

  • Update types/color-string/color-string-tests.ts

Co-authored-by: Dimitri B. [email protected]

Co-authored-by: Dimitri B. [email protected]

eps1lon
eps1lon
eps1lon
eps1lon

Make leaflet-offline a non-npm package (#57414)

Its source npm package has been unpublished.

eps1lon
eps1lon

Remove ts3.7/ from string.prototype.matchall (#57450)

TS 3.8 is the lowest supported version.

eps1lon
eps1lon

Update README to remove 3.7 support (#57453)

eps1lon
eps1lon

[prosemirror-view] Improve the type definition of nodeViews property. (#57384)

  • [prosemirror-view] Improve the type definition of nodeViews property.

  • Update index.d.ts

eps1lon
eps1lon

🤖 Merge PR #57455 update(zingchart): Update step typing by @jeanettephung

  • Add types for zingchart

  • Adds content header to zingchart

  • Fixes typedef extends for lint

  • Fixes version, import, and empty jsdoc comments

  • Removes last empty jsdoc comment

  • Allows values and series types to be arrays

  • Fixes values type

  • ZingChart type updates

  • Added d.ts file for zingchart/es6 and applied fixes

  • Move definitions in es6/index and reference in index.d.ts

  • Update test to include added attributes

  • Add .d.ts for ZingChart NodeJS build

  • Apply fixes after running "npm test"

  • Add additional test using NodeJS d.ts

  • Included new files into in tsconfig

  • Fix JSON format for tsconfig

  • Rewrite .d.ts for NodeJS build and combine tests into one file

  • Only list one d.ts in tsconfig and reference NodeJS d.ts in test

  • Provide default exports

  • Update to include default exports

  • Update test to try default import

  • Allow default export and fix exports for each version (originally assumed exports were the same)

  • use nodejs version in test because required to use file

  • Fix whitespace error in test

  • Update test to include testing default import

  • Fixed zingchart/index.dts based on reviewers notes

  • Update tslint.json to remove rules no longer needed

  • Corrections to TDF relating to plot and legend

  • Asterisk fix

  • update(zingchart): Add def for plot.tooltip.text

  • create(zinggrid): add new typings

  • update(zingchart): Add missing types for plot and graphset

  • Remove redundant 'undefined' value and fix trailing whitespace

  • Updated definition author

  • Added camel-case version of attributes

  • refactor definitions

  • Update exec arg to be optional

  • Add missing properties: series.id series.type graphset.utc graphset.plot.selectedState.lineWidth graphset.plot.tooltip.textAlign graphset.plot.valueBox.fontSize (doesn't accept numbers, only string) graphset.maxTrackers graphset.legend.marker.borderRadius graphset.scaleX.maxItems graphset.scaleY.zooming

  • Fix alignment issues

  • Update/fix properties:

  • *.lineWidth
  • *.borderWidth
  • graphset.plot.dataAppendSelection
  • graphset.plot.dataIgnoreSelection
  • graphset.plot.selectionMode
  • graphset.scaleX.thousandsSeparator
  • graphset.scaleX.zooming
  • graphset.plot.highlight
  • graphset.timeZone
  • Add missing attributes:
  • graphset.legend.marker.borderRadius (type)
  • graphset.plot.highlight
  • graphset.zoomSnap
  • graphset.selectionTool
  • Added tests for previous commit

  • update(zingchart): add behavior.text and behavior.customFunction, and updated graphset.labels

  • Add definitions for palette (theme)

  • update(zingchart): Add missing transform definitions

  • remove consecutive blank lines

  • Add definitions for scaleX (minValue, step) and scaleY (step)

  • Updated the typing for scaleX/Y.step

  • mend

  • Update test

Co-authored-by: Mike Schultz [email protected] Co-authored-by: dannyjuergens [email protected] Co-authored-by: jphung [email protected]

eps1lon
eps1lon
eps1lon
eps1lon

Make PickFileOptions properties optional (#57423)

  • Add preventDefaultOnError

  • Make PickFileOptions properties optional

eps1lon
eps1lon
eps1lon
eps1lon

feat: add types for react-native-android-keyboard-adjust (#57431)

eps1lon
eps1lon

Add missing meta properties to consul Service.RegisterOptions (#57119)

eps1lon
eps1lon

🤖 Merge PR #57456 update(zingchart): add legendMarker.borderRadius* by @jeanettephung

  • Add types for zingchart

  • Adds content header to zingchart

  • Fixes typedef extends for lint

  • Fixes version, import, and empty jsdoc comments

  • Removes last empty jsdoc comment

  • Allows values and series types to be arrays

  • Fixes values type

  • ZingChart type updates

  • Added d.ts file for zingchart/es6 and applied fixes

  • Move definitions in es6/index and reference in index.d.ts

  • Update test to include added attributes

  • Add .d.ts for ZingChart NodeJS build

  • Apply fixes after running "npm test"

  • Add additional test using NodeJS d.ts

  • Included new files into in tsconfig

  • Fix JSON format for tsconfig

  • Rewrite .d.ts for NodeJS build and combine tests into one file

  • Only list one d.ts in tsconfig and reference NodeJS d.ts in test

  • Provide default exports

  • Update to include default exports

  • Update test to try default import

  • Allow default export and fix exports for each version (originally assumed exports were the same)

  • use nodejs version in test because required to use file

  • Fix whitespace error in test

  • Update test to include testing default import

  • Fixed zingchart/index.dts based on reviewers notes

  • Update tslint.json to remove rules no longer needed

  • Corrections to TDF relating to plot and legend

  • Asterisk fix

  • update(zingchart): Add def for plot.tooltip.text

  • create(zinggrid): add new typings

  • update(zingchart): Add missing types for plot and graphset

  • Remove redundant 'undefined' value and fix trailing whitespace

  • Updated definition author

  • Added camel-case version of attributes

  • refactor definitions

  • Update exec arg to be optional

  • Add missing properties: series.id series.type graphset.utc graphset.plot.selectedState.lineWidth graphset.plot.tooltip.textAlign graphset.plot.valueBox.fontSize (doesn't accept numbers, only string) graphset.maxTrackers graphset.legend.marker.borderRadius graphset.scaleX.maxItems graphset.scaleY.zooming

  • Fix alignment issues

  • Update/fix properties:

  • *.lineWidth
  • *.borderWidth
  • graphset.plot.dataAppendSelection
  • graphset.plot.dataIgnoreSelection
  • graphset.plot.selectionMode
  • graphset.scaleX.thousandsSeparator
  • graphset.scaleX.zooming
  • graphset.plot.highlight
  • graphset.timeZone
  • Add missing attributes:
  • graphset.legend.marker.borderRadius (type)
  • graphset.plot.highlight
  • graphset.zoomSnap
  • graphset.selectionTool
  • Added tests for previous commit

  • update(zingchart): add behavior.text and behavior.customFunction, and updated graphset.labels

  • Add definitions for palette (theme)

  • update(zingchart): Add missing transform definitions

  • remove consecutive blank lines

  • Add definitions for scaleX (minValue, step) and scaleY (step)

  • Updated the typing for scaleX/Y.step

  • mend

  • Update test

  • Add legendMarker.borderRadius and related attributes

Co-authored-by: Mike Schultz [email protected] Co-authored-by: dannyjuergens [email protected] Co-authored-by: jphung [email protected]

eps1lon
eps1lon

Add types for the @dhis2/ui-constants package (#57446)

  • Add @dhis2/ui-constants package

Signed-off-by: Alexis Rico [email protected]

  • Fix lint warnings

Signed-off-by: Alexis Rico [email protected]

  • Fix tests with path resolution

Signed-off-by: Alexis Rico [email protected]

eps1lon
eps1lon
eps1lon
eps1lon
eps1lon
eps1lon

🤖 Merge PR #57283 fix(koa__router): unify function overloads by @G-Rath

eps1lon
eps1lon

🤖 Merge PR #57281 [sharedb] Add receivePresence middleware hook by @alecgibson

eps1lon
eps1lon

🤖 Merge PR #56758 [rn-fetch-blob][react-native-fetch-blob] fixes FS.ds callback return type by @demedos

Co-authored-by: Alessandro Diez [email protected]

commit sha: 9760deae086eaeb147b8e5099220278c8092ccbd

push time in 3 hours ago
Dec
7
1 day ago
Activity icon
issue

eps1lon issue comment testing-library/dom-testing-library

eps1lon
eps1lon

`getByTitle` for SVGs canot find `title` if it's not a direct child of `svg`

  • @testing-library/react version: 11.2.7
  • Testing Framework and version: jest 26x || 27x
  • DOM Environment: 'jsdom' 16.x

Relevant code or config:

Source: https://testing-library.com/docs/queries/bytitle/

    const Test = () => (
        <>
            <span title="Delete" id="2"></span>
            <svg>
                <title>Close</title>
                <g><path /></g>
            </svg>
        </>
    );

VS

    const Test = () => (
        <>
            <span title="Delete" id="2"></span>
            <svg>
                <g>
                    <path>
                         <title>Close</title>
                    </path>
                </g>
            </svg>
       </>
    );

What you did:

render(<Test/>);

screen.getByTitle('Close');

What happened:

First Component - ✅ Second Component - ❌

TestingLibraryElementError: Unable to find an element with the title: Close.

Problem description:

Testing library cannot find Close because it's not a direct child of svg.

Suggested solution:

I should be able to find Close even if it's not a direct child of svg.

Activity icon
issue

eps1lon issue facebook/react

eps1lon
eps1lon

React 18

When using

    "react": "^0.0.0-experimental-12bffc78d-20211206",
    "react-dom": "^0.0.0-experimental-12bffc78d-20211206",

I can use SuspenseList successfully.

App.js

import React, { lazy, Suspense, SuspenseList } from "react";
import "./App.css";
import { createResource } from "./PersonApi";

const Upper = lazy(() => import("./upper"));
const Lower = lazy(() => import("./lower"));

function App() {
  return (
    <div
      style={{
        display: "flex",
        flex: "1",
        flexDirection: "column",
        height: "100vh",
      }}
    >
      <SuspenseList revealOrder="backwards" tail="collapsed">
        <Suspense fallback={<>Loading upper...</>}>
          <Upper />
        </Suspense>
        <Suspense fallback={<>Loading lower...</>}>
          <Lower resource={createResource()} />
        </Suspense>
      </SuspenseList>
    </div>
  );
}

export default App;

index.js

import React from "react";
import ReactDOM from "react-dom";
import "./index.css";
import App from "./App";
import reportWebVitals from "./reportWebVitals";

ReactDOM.createRoot(document.getElementById("root")).render(<App />);

reportWebVitals();

However, when I change to react 18 beta as below,

    "react": "^18.0.0-beta-c7917fe76-20211206",
    "react-dom": "^18.0.0-beta-c7917fe76-20211206",

receiving below error;

image

Activity icon
issue

eps1lon issue comment facebook/react

eps1lon
eps1lon

React 18

When using

    "react": "^0.0.0-experimental-12bffc78d-20211206",
    "react-dom": "^0.0.0-experimental-12bffc78d-20211206",

I can use SuspenseList successfully.

App.js

import React, { lazy, Suspense, SuspenseList } from "react";
import "./App.css";
import { createResource } from "./PersonApi";

const Upper = lazy(() => import("./upper"));
const Lower = lazy(() => import("./lower"));

function App() {
  return (
    <div
      style={{
        display: "flex",
        flex: "1",
        flexDirection: "column",
        height: "100vh",
      }}
    >
      <SuspenseList revealOrder="backwards" tail="collapsed">
        <Suspense fallback={<>Loading upper...</>}>
          <Upper />
        </Suspense>
        <Suspense fallback={<>Loading lower...</>}>
          <Lower resource={createResource()} />
        </Suspense>
      </SuspenseList>
    </div>
  );
}

export default App;

index.js

import React from "react";
import ReactDOM from "react-dom";
import "./index.css";
import App from "./App";
import reportWebVitals from "./reportWebVitals";

ReactDOM.createRoot(document.getElementById("root")).render(<App />);

reportWebVitals();

However, when I change to react 18 beta as below,

    "react": "^18.0.0-beta-c7917fe76-20211206",
    "react-dom": "^18.0.0-beta-c7917fe76-20211206",

receiving below error;

image

eps1lon
eps1lon

It's moved to @experimental npm tag because it likely won't make it into 18.0.0 and will follow in 18.x after.

https://github.com/facebook/react/issues/22771#issuecomment-969451702

open pull request

eps1lon wants to merge DefinitelyTyped/DefinitelyTyped

eps1lon
eps1lon

[react] Fix return value of convenience overload

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://reactjs.org/docs/hooks-reference.html#useref
  • [n/a] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

I'm open to discussing this change, but the previous behaviour didn't really make any sense to me. This is the note that was removed:

* Usage note: if you need the result of useRef to be directly mutable, include `| null` in the type
* of the generic argument.

This overload happens when doing e.g. this:

const ref = useRef<number>(null)

The returned ref is now immutable, but I don't see a use case for that at all. If it actually was immutable when starting with the null value, then it would never be mutated to hold anything other than null and thus it would be useless as each usage of it could just be replaced with null.


Another change was to make it so that useRef() and useRef(undefined) works exactly the same. React doesn't do any arity-checks, so the two calls are exactly identical. They both create a ref-object with the initial value of undefined.

eps1lon
eps1lon

Maybe this wasn't very clear: To me const numberRef = useRef<number>() might be a mistake (forgot to pass the initial value). That mistake is caught when trying to access numberRef.current and expecting a number. However, when numberRef is passed to a part of the codebase that is untyped e.g. adder(numberRef.current, 2) where adder(a: any, b: any): number then we'll never catch this mistake at the type level.

The unfortunate part is that we'll never know which scenario is more likely. But considering you can already get the desired behavior with useRef<number | undefined> I'm inclined to not merge this proposal.

My underlying principal is that I try to publish types that are strict by default. The library user can always loosen them up but rarely make them stricter. That's not matching the TypeScript mentality (pragmatically typed language) but I don't find this proposal convincing with regards to pragmatism.

Though the real problem is that we're just two people discussing this. I wouldn't block this proposal if another maintainer would vote for merging this proposal.

pull request

eps1lon merge to DefinitelyTyped/DefinitelyTyped

eps1lon
eps1lon

[react] Fix return value of convenience overload

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://reactjs.org/docs/hooks-reference.html#useref
  • [n/a] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

I'm open to discussing this change, but the previous behaviour didn't really make any sense to me. This is the note that was removed:

* Usage note: if you need the result of useRef to be directly mutable, include `| null` in the type
* of the generic argument.

This overload happens when doing e.g. this:

const ref = useRef<number>(null)

The returned ref is now immutable, but I don't see a use case for that at all. If it actually was immutable when starting with the null value, then it would never be mutated to hold anything other than null and thus it would be useless as each usage of it could just be replaced with null.


Another change was to make it so that useRef() and useRef(undefined) works exactly the same. React doesn't do any arity-checks, so the two calls are exactly identical. They both create a ref-object with the initial value of undefined.

open pull request

eps1lon wants to merge mui-org/material-ui

eps1lon
eps1lon

[core] Fixes error in changelog generator for item sorting/padding

just happened to notice this. consider if there were 10 items. That means Math.log10(10), will evaluate to 1. Then Math.ceil(1) evaluates to 1, then '9'.padStart(1, '0') evaluates to '9' when it is intended to evaluate to '09' because there are 10 items. This will then happen 10% of the time.

(not entirely sure what the right format for the PR title is for this)

eps1lon
eps1lon
      .padStart(Math.ceil(Math.log10(commitsItemsByDateDesc.length + 1)), '0')} -->`;

should work too and not add extraneous padding for the 11..99 case. Did I understand this correctly?

Or equivalent solution but more math-y (may not be robust depending on precision)

      .padStart(Math.ceil(Math.log10(commitsItemsByDateDesc.length) + Number.EPSILON), '0')} -->`;

Though

      .padStart(Math.floor(Math.log10(commitsItemsByDateDesc.length)) + 1, '0')} -->`;

probably makese the most "sense".

Comparison: https://docs.google.com/spreadsheets/d/1JMUhfYdB0oVYIQ6_UvejccboGlyacSmxSYDftyottag/edit#gid=0

pull request

eps1lon merge to mui-org/material-ui

eps1lon
eps1lon

[core] Fixes error in changelog generator for item sorting/padding

just happened to notice this. consider if there were 10 items. That means Math.log10(10), will evaluate to 1. Then Math.ceil(1) evaluates to 1, then '9'.padStart(1, '0') evaluates to '9' when it is intended to evaluate to '09' because there are 10 items. This will then happen 10% of the time.

(not entirely sure what the right format for the PR title is for this)

Dec
6
2 days ago
Activity icon
issue

eps1lon issue comment mui-org/material-ui

eps1lon
eps1lon

Snackbars not read by screen reader

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Snackbars are not being read by a screen reader in various scenarios but the majority of the issues are with Firefox...

  1. NVDA screen reader + Firefox: Screen reader is not reading the snackbar when triggering it with a button
  2. NVDA screen reader + Firefox: Screen reader is not reading the snackbar when triggering it with a menu
  3. NVDA screen reader + Firefox: Screen reader is not reading the snackbar when triggering it with a button within a dialog
  4. NVDA screen reader + Chrome: Screen reader is not reading the snackbar when triggering it with a button within a dialog

Expected Behavior 🤔

Snackbar should always be read by the screen reader no matter the scenario.

Steps to Reproduce 🕹

https://codesandbox.io/s/snackbar-accessibility-s58hj?file=/App.js

Context 🔦

We are trying to release a product that needs to be accessible and will not be able to release the product if this issue is not resolved. We are in the process of figuring out a work around. Our current solution is to not use the snackbars but to use alerts instead. We still need to do more testing but the alerts seem to function better. We have also done some testing with the Web version of the Material IO snackbar and it seems to function better. We have also tested many Google products that also function correctly.

eps1lon
eps1lon

@eps1lon Are the proposed fixes from #29975 also meant to address the dialog issues or should I open a new issue?

That'd be nice. It may be unrelated but even if it isn't it should be a separate issue.

Activity icon
issue

eps1lon issue comment mui-org/material-ui

eps1lon
eps1lon

[ci] Update CI bucket

We're closing the account under which the bucket was created and ownership of buckets can't be transferred. So we're recreating it.

On the new bucket I'm also using bucket policies to control object access instead of putting object ACL.

To Do after merging:

  • Update AWS_ACCESS_KEY_ID_ARTIFACTS and AWS_SECRET_ACCESS_KEY_ARTIFACTS in circle env vars to the new credentials for the circleci user
  • copy old bucket's files (aws s3 cp s3://mui-org-material-ui/artifacts/master/ s3://mui-org-ci/artifacts/master/ --recursive)
  • Open a follow up PR to replace the ..._TMP vars in the circleci config with the original ones and remove the _TMP vars from circleci and the bucket fallback
  • close the old account (how much will it cost to delete the bucket?)
eps1lon
eps1lon

I offered my help originally and asked multiple times if something was unclear. Then I did it myself because I got no response from leadership. At this point you're on your own.

open pull request

eps1lon wants to merge testing-library/react-testing-library

eps1lon
eps1lon

Make `@types/react-dom` a regular dependency

@types/react-dom is used in types/index.d.ts, which is an external interface, and thus needs to be declared as a regular rather than a dev dependency so that it is picked up by users of @testing-library/react.

What:

This fixes #1000.

Why:

@types/react-dom is used in types/index.d.ts, which is an external interface, and thus needs to be declared as a regular rather than a dev dependency so that it is picked up by users of @testing-library/react.

How:

Declare @types/react-dom as a regular rather than a dev dependency.

Checklist:

  • Documentation added to the docs site N/A
  • Tests N/A
  • TypeScript definitions updated N/A
  • Ready to be merged
eps1lon
eps1lon
    "@types/react-dom": "*"

This matches how @types/* packages declare their type dependencies. We definitely want to add16.9 here since this library can be used with 16.x. And 18.x will also work. But I'd just go with * for consistency.

pull request

eps1lon merge to testing-library/react-testing-library

eps1lon
eps1lon

Make `@types/react-dom` a regular dependency

@types/react-dom is used in types/index.d.ts, which is an external interface, and thus needs to be declared as a regular rather than a dev dependency so that it is picked up by users of @testing-library/react.

What:

This fixes #1000.

Why:

@types/react-dom is used in types/index.d.ts, which is an external interface, and thus needs to be declared as a regular rather than a dev dependency so that it is picked up by users of @testing-library/react.

How:

Declare @types/react-dom as a regular rather than a dev dependency.

Checklist:

  • Documentation added to the docs site N/A
  • Tests N/A
  • TypeScript definitions updated N/A
  • Ready to be merged
pull request

eps1lon merge to testing-library/react-testing-library

eps1lon
eps1lon

Make `@types/react-dom` a regular dependency

@types/react-dom is used in types/index.d.ts, which is an external interface, and thus needs to be declared as a regular rather than a dev dependency so that it is picked up by users of @testing-library/react.

What:

This fixes #1000.

Why:

@types/react-dom is used in types/index.d.ts, which is an external interface, and thus needs to be declared as a regular rather than a dev dependency so that it is picked up by users of @testing-library/react.

How:

Declare @types/react-dom as a regular rather than a dev dependency.

Checklist:

  • Documentation added to the docs site N/A
  • Tests N/A
  • TypeScript definitions updated N/A
  • Ready to be merged
Activity icon
issue

eps1lon issue comment DefinitelyTyped/DefinitelyTyped

eps1lon
eps1lon

[react] Upgrade useInsertionEffect to next

Closes https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/57554

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes:
  • ~[ ]~ If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
eps1lon
eps1lon

I think it could be merged since it's already published at the next tag on npm. @eps1lon WDYT?

Forgot to mark as ready for review. Can be approved now if you think this is fine.

Dec
5
3 days ago
pull request

eps1lon pull request mui-org/material-ui

eps1lon
eps1lon

[docs] Remove redundant grouping in /components/radio-buttons/

Pending screen reader review:

Previously the demos created the following a11y tree group[name="Gender"] > group[name="Gender"] > radio-button[name="female"] resulting in a redundant announcement in screen-readers. RadioGroup already handles the grouping so we don't need another fieldset.

Activity icon
created branch

eps1lon in eps1lon/material-ui create branch docs/RadioGroup/redundant-grouping

createdAt 3 days ago
push

eps1lon push mui-org/material-ui

eps1lon
eps1lon

Bump playwright to ^1.17.1 (#30058)

Co-authored-by: Renovate Bot [email protected]

commit sha: 0c73941d71d5314cd373bfe719dd1299dea64ab7

push time in 3 days ago
Activity icon
delete

eps1lon in mui-org/material-ui delete branch renovate/playwright-1.x

deleted time in 3 days ago
pull request

eps1lon pull request mui-org/material-ui

eps1lon
eps1lon

Bump playwright to ^1.17.1

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
playwright (source) ^1.16.3 -> ^1.17.1 age adoption passing confidence

Release Notes

Microsoft/playwright (playwright)

v1.17.1

Compare Source

Highlights

This patch includes bug fixes for the following issues:

https://github.com/microsoft/playwright/issues/10638 - [BUG] Locator.click -> subtree intercepts pointer events since version 1.17.0https://github.com/microsoft/playwright/issues/106322 - [BUG] Playwright 1.17.0 -> After clicking the element - I get an error that click action was failehttps://github.com/microsoft/playwright/issues/1062727 - [REGRESSION]: Can no longer click Material UI select bhttps://github.com/microsoft/playwright/issues/10620620 - [BUG] trailing zero width whitespace fails toHaveText

Browser Versions

  • Chromium 98.0.4695.0
  • Mozilla Firefox 94.0.1
  • WebKit 15.4

This version of Playwright was also tested against the following stable channels:

  • Google Chrome 96
  • Microsoft Edge 96

(1.17.1)

v1.17.0

Compare Source

Playwright v1.17

Frame Locators

Playwright 1.17 introduces frame locators - a locator to the iframe on the page. Frame locators capture the logic sufficient to retrieve the iframe and then locate elements in that iframe. Frame locators are strict by default, will wait for iframe to appear and can be used in Web-First assertions.

Graphics

Frame locators can be created with either [page.frameLocator(selector)][page.frameLocator(selector)] or [locator.frameLocator(selector)][locator.frameLocator(selector)] method.

const locator = page.frameLocator('#my-iframe').locator('text=Submit');
await locator.click();

Read more at our documentation.

Trace Viewer Update

Playwright Trace Viewer is now available online at https://trace.playwright.dev! Just drag-and-drop your trace.zip file to inspect its contents.

NOTE: trace files are not uploaded anywhere; trace.playwright.dev is a progressive web application that processes traces locally.

  • Playwright Test traces now include sources by default (these could be turned off with tracing option)
  • Trace Viewer now shows test name
  • New trace metadata tab with browser details
  • Snapshots now have URL bar

image

HTML Report Update

  • HTML report now supports dynamic filtering
  • Report is now a single static HTML file that could be sent by e-mail or as a slack attachment.

image

Ubuntu ARM64 support + more

  • Playwright now supports Ubuntu 20.04 ARM64. You can now run Playwright tests inside Docker on Apple M1 and on Raspberry Pi.
  • You can now use Playwright to install stable version of Edge on Linux:
    npx playwright install msedge
    

New APIs

Browser Versions

  • Chromium 98.0.4695.0
  • Mozilla Firefox 94.0.1
  • WebKit 15.4

This version was also tested against the following stable channels:

  • Google Chrome 96
  • Microsoft Edge 96

Microsoft/playwright (playwright)

Configuration

📅 Schedule: "on sunday before 6:00am" in timezone UTC.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

push

eps1lon push mui-org/material-ui

eps1lon
eps1lon

Remove legacy resolutions entry

commit sha: a829a0918dde3c6bc924f584929ccf9c917d59f9

push time in 3 days ago
Activity icon
delete

eps1lon in mui-org/material-ui delete branch renovate/major-typescript-eslint

deleted time in 3 days ago
Activity icon
delete

eps1lon in mui-org/material-ui delete branch renovate/eslint-config-airbnb-typescript-16.x

deleted time in 3 days ago
Previous