ethereum

ethereum

Member Since 8 years ago

Experience Points
0
follower
Lessons Completed
0
follow
Best Reply Awards
270
repos
Activity
May
12
1 week ago
open pull request

chriseth wants to merge ethereum/solidity

chriseth
chriseth

Adding event and error selector fields

closes #12581

chriseth
chriseth

I think the name of the test should include the word 'anonymous' since this is what is being tested.

Please also add more tests for different ways to access the selector of an anonymous event.

May
23
8 hours ago
open pull request

chriseth wants to merge ethereum/solidity

chriseth
chriseth

Adding event and error selector fields

closes #12581

chriseth
chriseth

I'll change this before merging.

pull request

chriseth merge to ethereum/solidity

chriseth
chriseth

Adding event and error selector fields

closes #12581

pull request

chriseth merge to ethereum/solidity

chriseth
chriseth

Adding event and error selector fields

closes #12581

pull request

Aniket-Engg pull request ethereum/remix-project

Aniket-Engg
Aniket-Engg

0xProject erc20 ws template added

Activity icon
created branch

Aniket-Engg in ethereum/remix-project create branch 0xProjecterc20

createdAt 5 minutes ago
push

chriseth push ethereum/solidity

chriseth
chriseth

ExpressionClasses performance optimization

chriseth
chriseth

Limit max chunk size in CommonSubexpressionEliminator::feedItems

chriseth
chriseth

fixup! Limit max chunk size in CommonSubexpressionEliminator::feedItems

chriseth
chriseth

Set CommonSubexpressionEliminator max chunk size to 2000

chriseth
chriseth
chriseth
chriseth

Add a require statement to the Ballot contract

chriseth
chriseth

Merge pull request #12950 from a3d4/refix-msvc-debug-stack-crash

Refix MSVC Debug crash

chriseth
chriseth

Merge pull request #12956 from nobutoba/fix-ballot-contract

Add a require statement to the Ballot contract

chriseth
chriseth
chriseth
chriseth

adjust for osx nondeterminism

chriseth
chriseth

Merge pull request #12974 from ethereum/smt_tests_z3_16

update smt tests z3 4.8.16

chriseth
chriseth

Merge pull request #12984 from ethereum/fix_smt

fix smt flaky test

chriseth
chriseth

Update version & distributions for static z3 script

chriseth
chriseth

Merge pull request #12981 from ethereum/update-static-z3

Update version & distributions for static z3 script

chriseth
chriseth

Recommend via-ir whenever a stack too deep error is encountered.

chriseth
chriseth

Improve wording on voting example

From a beginner perspective, it is the first time in the documentation that the term wallets is used. Other terms such as accounts or addresses are explained in the Introduction to smart contracts.

chriseth
chriseth

Merge pull request #12985 from sey/improve-wording-on-voting-example

Improve wording on voting example

chriseth
chriseth

[Circle CI] Adds LSP tests to Windows CI.

chriseth
chriseth

Always allow full filesystem access to LSP.

commit sha: 27bdc22c63863b71b7d2cd11f754ea82ef58a286

push time in 5 minutes ago
Activity icon
issue

chriseth issue comment ethereum/solidity

chriseth
chriseth

Moved operator precedence

#12934 Moved the operator precedence section from the cheatsheet to types > operators.

chriseth
chriseth

Sorry, but I fear it does not work this way. You moved it to the integer type, but operator precedence is unrelated to the type.

Activity icon
issue

chriseth issue comment ethereum/solidity

chriseth
chriseth

Feature: `print(...)`

Abstract

A variadic function print(...) that would emit a log* with abi encoded data of its arguments.

Motivation

It's typical for testing frameworks / debugging setups to have some way to print the value of variables.

For Hardhat, this is console.log. For dapptools and foundry, this is log_uint etc.

Specification

The (dapptools / foundry) implementation is fairly simple. print(a, b, c) is equivalent to emitting the following bytes: abi.encode(a, b, c). However, testing tools would want to know how to decode this. Therefore, the first (or perhaps the second?) topic should be a marker for the types. This can probably be emitted in the JSON output for ABI. The tool can then lookup the hash to understand the types and do a abi.decode to get back the data.

For hardhat implementation, it seems to do a staticcall to a magic address. This is an alternative to consider for implementation.

We should also consider introducing a --debug flag. Where compiler would warn about print if --debug flag is not set.

chriseth
chriseth

It can be solved in rust, so it should also be doable in solidity. Why would you like to have variadic args for print, but not for user defined functions?

open pull request

chriseth wants to merge ethereum/solidity

chriseth
chriseth

Display human readable type name in conversion error message

Closes #12896.

As discussed, I'm adding in string Type::humanReadableName(), which defaults to toString() and is overridden for error type.

chriseth
chriseth

If you look at the implementation of this function, there is no "parameter" to be found, yet it is in the name of the function. Maybe toStringInParentheses would be a better name?

pull request

chriseth merge to ethereum/solidity

chriseth
chriseth

Display human readable type name in conversion error message

Closes #12896.

As discussed, I'm adding in string Type::humanReadableName(), which defaults to toString() and is overridden for error type.

push

hwwhww push ethereum/staking-launchpad

hwwhww
hwwhww

Fix REACT_APP_ETH_REQUIREMENT

Co-authored-by: Carl Beekhuizen [email protected]

commit sha: e15cbfea3c34b9e237aaf40658abb2f1e5c6d688

push time in 17 minutes ago
open pull request

hwwhww wants to merge ethereum/staking-launchpad

hwwhww
hwwhww

Add Ropsten beacon chain

Address #484

TODOs:

  • Check envVar configuration
    • some external links are not ready yet (e.g., beacon explorer)
  • Port some "post-merge" context from bellatrix branch to Ropsten launchpad
  • The client tutorials are for Goerli. But Ropsten may have different instructions. We may want to hide the testnet tutorial or fix it.
pull request

hwwhww merge to ethereum/staking-launchpad

hwwhww
hwwhww

Add Ropsten beacon chain

Address #484

TODOs:

  • Check envVar configuration
    • some external links are not ready yet (e.g., beacon explorer)
  • Port some "post-merge" context from bellatrix branch to Ropsten launchpad
  • The client tutorials are for Goerli. But Ropsten may have different instructions. We may want to hide the testnet tutorial or fix it.
push

s1na push ethereum/go-ethereum

s1na
s1na

tracing: fix typo (#24923)

Update tracing.md

fix a small typo in this spec

commit sha: ccc5a919596e35991ed030dd75ea1b3d9a742b83

push time in 20 minutes ago
pull request

s1na pull request ethereum/go-ethereum

s1na
s1na

fix typo: Update tracing.md

fix a small typo in this spec

pull request

s1na merge to ethereum/go-ethereum

s1na
s1na

fix typo: Update tracing.md

fix a small typo in this spec

Activity icon
issue

rjl493456442 issue ethereum/go-ethereum

rjl493456442
rjl493456442

Native tracer on very old blocks

I am using debug_traceBlockByNumber and callTracer to trace very old blocks. It is super fast at chainhead. However, it took 30 seconds to trace an old block (blocks in 2017). Are there any tricks to speed up the native tracer?

Node storage has been upgraded to NVMe, but it did not boost the performance

Activity icon
issue

rwv issue ethereum/ethereum-org-website

rwv
rwv

Wrong i18n link for `page-find-wallet-new-to-wallets-link` in `/wallets/find-wallet/`

Describe the bug

In /wallets/find-wallet/ there's a link page-find-wallet-new-to-wallets-link navigate to /wallets. However, it use raw <a> tag instead of components/Link which cause i18n navigate fails:

/zh/wallets/find-wallet/ navigate to /wallets/ instead of /zh/wallets/

To Reproduce Steps to reproduce the behavior:

  1. Go to https://ethereum.org/zh/wallets/find-wallet/
  2. Click on 以太坊钱包

Expected behavior

Navigate to https://ethereum.org/zh/wallets/

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Chrome
  • Version: 100

Want to contribute?

I am working on a PR.

started
started time in 26 minutes ago
started
started time in 30 minutes ago
Activity icon
issue

rwv issue comment ethereum/ethereum-org-website

rwv
rwv

`/wallets/find-wallet`

Describe the bug

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '...'
  3. Scroll down to '...'
  4. See error

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser: [e.g. chrome, safari]
  • Version: [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser: [e.g. stock browser, safari]
  • Version: [e.g. 22]

Additional context

Want to contribute?

We love contributions from the Ethereum community! Please comment on an issue if you're interested in helping out with a PR.

Activity icon
issue

rwv issue ethereum/ethereum-org-website

rwv
rwv

`/wallets/find-wallet`

Describe the bug

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '...'
  3. Scroll down to '...'
  4. See error

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser: [e.g. chrome, safari]
  • Version: [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser: [e.g. stock browser, safari]
  • Version: [e.g. 22]

Additional context

Want to contribute?

We love contributions from the Ethereum community! Please comment on an issue if you're interested in helping out with a PR.

Activity icon
issue

rwv issue ethereum/ethereum-org-website

rwv
rwv

`/wallets/find-wallet`

Describe the bug

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '...'
  3. Scroll down to '...'
  4. See error

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser: [e.g. chrome, safari]
  • Version: [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser: [e.g. stock browser, safari]
  • Version: [e.g. 22]

Additional context

Want to contribute?

We love contributions from the Ethereum community! Please comment on an issue if you're interested in helping out with a PR.

push

fjl push ethereum/hive

fjl
fjl

hive: revert simulation API networking changes

This reverts commit 15794d9c711f536d4dbf5b1515280c576781962b. This reverts commit c634d551abeb53849b09655c97bfe1c0d31d4e19. This reverts commit 66f3cf3b765c3994942233a605018e2b0b153880.

commit sha: 38d346cfb3400de4691fe056897b5e94846d1f9e

push time in 38 minutes ago
open pull request

chriseth wants to merge ethereum/solidity

chriseth
chriseth

Bytes array to storage bug

Poor-man's-fix for the last cases in https://github.com/ethereum/solidity/issues/11602

This costs, but it's significantly easier than trying to rewrite the copy routine in low-level-style to account for this...

chriseth
chriseth

I think this was overlooked. But it seems like nobody cared anyway

pull request

chriseth merge to ethereum/solidity

chriseth
chriseth

Bytes array to storage bug

Poor-man's-fix for the last cases in https://github.com/ethereum/solidity/issues/11602

This costs, but it's significantly easier than trying to rewrite the copy routine in low-level-style to account for this...

Previous