ethereum

ethereum

Member Since 8 years ago

Experience Points
0
follower
Lessons Completed
0
follow
Best Reply Awards
265
repos
Activity
Jan
24
16 hours ago
push

leonardoalt push ethereum/solc-js

leonardoalt
leonardoalt

Fix smtchecker callback tests and add Eldarica

commit sha: 8ed25976411b514e7e90cb597dcb3266a572bdf6

push time in 5 minutes ago
Activity icon
issue

timbeiko issue comment ethereum/pm

timbeiko
timbeiko

Post-Merge testnets

On ACD130, we discussed what to do about current testnets so that we can set the community's expectations. We didn't reach a full consensus, but roughly agreed that we should have both testnets with public validator participation and testnets with a privately-controlled validator set, and that it makes sense to aim to deprecate some testnets over time as they become bloated.

Opening this issue to track conversations on concrete next steps. Thoughts from Péter: Screen Shot 2022-01-21 at 11 00 30 AM

timbeiko
timbeiko

@MicahZoltu but Goerli/Prater would have public validators. Doesn't it make sense to have one network with a smaller set of authorized ones?

Activity icon
issue

gatsby-cloud[bot] issue comment ethereum/ethereum-org-website

gatsby-cloud[bot]
gatsby-cloud[bot]

Remove Dharma wallet [Fixes #5178]

Description

Removes Dharma wallet from ethereum.org

Related Issue

#5178

gatsby-cloud[bot]
gatsby-cloud[bot]

Gatsby Cloud Build Report

ethereum-org-website-dev

:tada: Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

:clock1: Build time: 9m

push

kuzdogan push ethereum/sourcify

kuzdogan
kuzdogan

Fix infinite loop in Field,invalid checksum address

When submitting an address with valid characters but invalid checksum to Lookup, the useEffect in Field enters an infinite loop because of rerendering. Fix rerender by submittingin handleChange.

Handle server responding with 4xx 5xx responses but not showing errors. Throw at api.tsx.

Validate addresses client side with @ethers.js isAddress, instead of regex only.

kuzdogan
kuzdogan

Perfect/Partial badge&tooltip in Result

commit sha: f8e66f955a27a6f4a071dda60c22dfc95a366964

push time in 22 minutes ago
pull request

minimalsm pull request ethereum/ethereum-org-website

minimalsm
minimalsm

Remove Dharma wallet [Fixes #5178]

Description

Removes Dharma wallet from ethereum.org

Related Issue

#5178

push

minimalsm push ethereum/ethereum-org-website

minimalsm
minimalsm

docs: update README.md [skip ci]

minimalsm
minimalsm

docs: update .all-contributorsrc [skip ci]

minimalsm
minimalsm

Merge pull request #5200 from ethereum/all-contributors/add-Ej1seven

docs: add Ej1seven as a contributor for doc

commit sha: 35152459968481d4666f712f55beb183ff231823

push time in 27 minutes ago
pull request

minimalsm pull request ethereum/ethereum-org-website

minimalsm
minimalsm

docs: add Ej1seven as a contributor for doc

Add @Ej1seven as a contributor for doc.

This was requested by minimalsm in this comment

Activity icon
delete

minimalsm in ethereum/ethereum-org-website delete branch all-contributors/add-Ej1seven

deleted time in 27 minutes ago
Activity icon
issue

holiman issue comment ethereum/go-ethereum

holiman
holiman

Trace response of traceBlockByHash is non-deterministic and get "execution reverted" error

System information

Geth version: v1.10.2

Expected behaviour

  1. When getting block traces using traceBlockByHash, the response should be deterministic
  2. For a transaction with Success status, should not get "execution reverted" trace error

Actual behaviour

In Ethereum mainnet

  1. Run debug.traceBlockByHash("0x27049febec8fd16fb662d0d8c00f5ff7cec571b71585b18c30e0c6d2df93b4fe", {"tracer": "callTracer", "timeout": "60s"}) twice, get different trace result for the transaction 0x44de5f0ce469c09e4003f974e4ae119aea69ac461fdb0974fe410a1657284ce5

First time tx trace result:

    result: {
      calls: [{...}],
      from: "0x00000000c0293c8ca34dac9bcc0f953532d34e4d",
      gas: "0xa7ac",
      gasUsed: "0x6876",
      input: "0xca722cdc5ae6e1d89dcdb255d8851f3b47f374103d5022146b4e29a3bf4aea91993ae06fdd3d5766c2b7db16c171487fdb4800eaabf851f35488b76b33e53faa21b36588",
      output: "0x",
      time: "86.428742ms",
      to: "0xd1ceeeeee83f8bcf3bedad437202b6154e9f5405",
      type: "CALL",
      value: "0x0"
    }
}

Second time tx trace result:

{
    result: {
      error: "execution reverted",
      from: "0x00000000c0293c8ca34dac9bcc0f953532d34e4d",
      gas: "0xa7ac",
      gasUsed: "0xa8f",
      input: "0xca722cdc5ae6e1d89dcdb255d8851f3b47f374103d5022146b4e29a3bf4aea91993ae06fdd3d5766c2b7db16c171487fdb4800eaabf851f35488b76b33e53faa21b36588",
      time: "15.241119ms",
      to: "0xd1ceeeeee83f8bcf3bedad437202b6154e9f5405",
      type: "CALL",
      value: "0x0"
    }
}
  1. Why get "execution reverted" error for the successful transaction 0x44de5f0ce469c09e4003f974e4ae119aea69ac461fdb0974fe410a1657284ce5 at the second traceBlockByHash call
holiman
holiman

Out of 7 blockdumps, two are different from the other five. I set the node to archive-mode as it was processing that block, so this has nothing to do with any errors during the reexec-phase -- all the trie data is at hand. Very curious.

1733636 jan 24 16:42 out.1
1733636 jan 24 16:43 out.2
1738663 jan 24 16:43 out.3
1733636 jan 24 16:43 out.4
1733636 jan 24 16:43 out.5
1738663 jan 24 16:43 out.6
1733636 jan 24 16:43 out.7
Activity icon
issue

gatsby-cloud[bot] issue comment ethereum/ethereum-org-website

gatsby-cloud[bot]
gatsby-cloud[bot]

docs: add Ej1seven as a contributor for doc

Add @Ej1seven as a contributor for doc.

This was requested by minimalsm in this comment

gatsby-cloud[bot]
gatsby-cloud[bot]

Gatsby Cloud Build Report

ethereum-org-website-dev

:tada: Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

:clock1: Build time: 8m

started
started time in 36 minutes ago
push

pettinarip push ethereum/clrfund

pettinarip
pettinarip

Refactor: maxRecipients getter (#505) (#506)

  • fetch maci factory data and save it in the store

  • Refactor last maxRecipients getter

Co-authored-by: Sam Richards [email protected]

Co-authored-by: Sam Richards [email protected]

commit sha: 1911485ebf7c9c335ee4ee5bb4d4fc8e058a0396

push time in 39 minutes ago
Activity icon
delete

pettinarip in ethereum/clrfund delete branch maci-factory-maxrecipients

deleted time in 39 minutes ago
pull request

pettinarip pull request ethereum/clrfund

pettinarip
pettinarip

Refactor: pull maxRecipients from maci factory when there is no round

Merging this on develop https://github.com/ethereum/clrfund/pull/505

Activity icon
issue

holiman issue comment ethereum/go-ethereum

holiman
holiman

Trace response of traceBlockByHash is non-deterministic and get "execution reverted" error

System information

Geth version: v1.10.2

Expected behaviour

  1. When getting block traces using traceBlockByHash, the response should be deterministic
  2. For a transaction with Success status, should not get "execution reverted" trace error

Actual behaviour

In Ethereum mainnet

  1. Run debug.traceBlockByHash("0x27049febec8fd16fb662d0d8c00f5ff7cec571b71585b18c30e0c6d2df93b4fe", {"tracer": "callTracer", "timeout": "60s"}) twice, get different trace result for the transaction 0x44de5f0ce469c09e4003f974e4ae119aea69ac461fdb0974fe410a1657284ce5

First time tx trace result:

    result: {
      calls: [{...}],
      from: "0x00000000c0293c8ca34dac9bcc0f953532d34e4d",
      gas: "0xa7ac",
      gasUsed: "0x6876",
      input: "0xca722cdc5ae6e1d89dcdb255d8851f3b47f374103d5022146b4e29a3bf4aea91993ae06fdd3d5766c2b7db16c171487fdb4800eaabf851f35488b76b33e53faa21b36588",
      output: "0x",
      time: "86.428742ms",
      to: "0xd1ceeeeee83f8bcf3bedad437202b6154e9f5405",
      type: "CALL",
      value: "0x0"
    }
}

Second time tx trace result:

{
    result: {
      error: "execution reverted",
      from: "0x00000000c0293c8ca34dac9bcc0f953532d34e4d",
      gas: "0xa7ac",
      gasUsed: "0xa8f",
      input: "0xca722cdc5ae6e1d89dcdb255d8851f3b47f374103d5022146b4e29a3bf4aea91993ae06fdd3d5766c2b7db16c171487fdb4800eaabf851f35488b76b33e53faa21b36588",
      time: "15.241119ms",
      to: "0xd1ceeeeee83f8bcf3bedad437202b6154e9f5405",
      type: "CALL",
      value: "0x0"
    }
}
  1. Why get "execution reverted" error for the successful transaction 0x44de5f0ce469c09e4003f974e4ae119aea69ac461fdb0974fe410a1657284ce5 at the second traceBlockByHash call
holiman
holiman
push

pettinarip push ethereum/clrfund

pettinarip
pettinarip

fix transaction modal which now expects a promise of a tx (#507)

commit sha: 31f09d9cedca88ec89fa595af7a9b1acca69d517

push time in 39 minutes ago
Activity icon
delete

pettinarip in ethereum/clrfund delete branch fix-recipients-list-loading

deleted time in 39 minutes ago
Activity icon
issue

pettinarip issue ethereum/clrfund

pettinarip
pettinarip

Recipient list is not being updated

The recipients list in /recipients is not updating automatically when a request is accepted.

E.g. here, the first request in the list has already been accepted and the list keeps showing the previous state. 1

pull request

pettinarip pull request ethereum/clrfund

pettinarip
pettinarip

Fix recipients list loading

Fixes #468

When a request was approved or rejected, we were updating the list by calling the loadRequests() function, but we were calling it too early because we were not waiting for the tx to finish correctly.

Here, I'm fixing the TransactionModal to accept a Promise instead of a common fn, so that we can wait() for that tx to finish.

push

pettinarip push ethereum/clrfund

pettinarip
pettinarip

Fix about pages (#504)

  • get native token information from getters

  • fix getting native token information and remove unnecessary use of it

commit sha: c3690f4823913a072ec960cd1e1732c0bccdbd22

push time in 40 minutes ago
Activity icon
delete

pettinarip in ethereum/clrfund delete branch fix-about-pages

deleted time in 40 minutes ago
Activity icon
issue

pettinarip issue ethereum/clrfund

pettinarip
pettinarip

About pages are broken during Join Phase

https://eth2clrfund.netlify.app/#2

Console error:

TypeError: Cannot read properties of null (reading 'nativeTokenSymbol')

Our native token logic relies on a current round existing: https://github.com/ethereum/clrfund/blob/develop/vue-app/src/views/AboutLayer2.vue#L240

We need to provide a fallback.

pull request

allcontributors[bot] pull request ethereum/ethereum-org-website

allcontributors[bot]
allcontributors[bot]

docs: add Ej1seven as a contributor for doc

Add @Ej1seven as a contributor for doc.

This was requested by minimalsm in this comment

push

allcontributors[bot] push ethereum/ethereum-org-website

allcontributors[bot]
allcontributors[bot]

docs: update .all-contributorsrc [skip ci]

commit sha: 0db9abc5746df19acdbcdeb54f17ce2a82733fdd

push time in 40 minutes ago
Activity icon
created branch

allcontributors[bot] in ethereum/ethereum-org-website create branch all-contributors/add-Ej1seven

createdAt 40 minutes ago
Activity icon
issue

minimalsm issue comment ethereum/ethereum-org-website

minimalsm
minimalsm

changed execution client from 'Ergion' to 'Erigon'

Description

Related Issue

minimalsm
minimalsm

Thanks for fixing this @Ej1seven ✌️.

Be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And remember to claim your POAP also 🥳! We're currently working on our 2022 POAPs and they'll be released soon.

Previous