ethereum

ethereum

Member Since 8 years ago

Experience Points
0
follower
Lessons Completed
0
follow
Best Reply Awards
265
repos
Activity
Jan
24
16 hours ago
pull request

minimalsm merge to ethereum/ethereum-org-website

minimalsm
minimalsm

Add new wallets

Description

  • Add Loopring, Numio and AirGap
  • Update Bitcoin description

Related Issue

Fixes #3970 #4447 #4443 #4755

open pull request

axic wants to merge ethereum/solc-js

axic
axic

Rename solcjs to solc.js internally and apply lint changes

axic
axic

Would you suggest solc.js then in the file list?

pull request

axic merge to ethereum/solc-js

axic
axic

Rename solcjs to solc.js internally and apply lint changes

open pull request

stephensli wants to merge ethereum/solc-js

stephensli
stephensli

Rename solcjs to solc.js internally and apply lint changes

stephensli
stephensli

It would make sense that it pulls the bin in as well, probably worth being clear with the definition in the files section as well for clarity.

pull request

stephensli merge to ethereum/solc-js

stephensli
stephensli

Rename solcjs to solc.js internally and apply lint changes

Activity icon
fork

asset-project forked ethereum/blockies

⚡ <1k library that generates blocky identicons
asset-project Updated
fork time in 1 hour ago
push

minimalsm push ethereum/ethereum-org-website

minimalsm
minimalsm
minimalsm
minimalsm

docs: update README.md [skip ci]

minimalsm
minimalsm

docs: update .all-contributorsrc [skip ci]

minimalsm
minimalsm

Merge pull request #5196 from ethereum/fix404

Fix 404 links

minimalsm
minimalsm

Merge branch 'dev' into all-contributors/add-astutejoe

minimalsm
minimalsm

Merge pull request #5197 from ethereum/all-contributors/add-astutejoe

docs: add astutejoe as a contributor for doc

minimalsm
minimalsm

docs: update README.md [skip ci]

minimalsm
minimalsm

docs: update .all-contributorsrc [skip ci]

minimalsm
minimalsm

Merge pull request #5199 from ethereum/all-contributors/add-tiagoyonamine

docs: add tiagoyonamine as a contributor for doc

minimalsm
minimalsm

Merge branch 'dev' into addWallets

commit sha: d61347671af5c4b8dcdf0346b200dc150c36efe8

push time in 1 hour ago
pull request

axic merge to ethereum/solc-js

axic
axic

Rename solcjs to solc.js internally and apply lint changes

open pull request

axic wants to merge ethereum/solc-js

axic
axic

Rename solcjs to solc.js internally and apply lint changes

axic
axic

It seems both versions work as maybe it looks up the dependency. At least I got the same tarball files: [ .. "solcjs" .. ] and files: [ .. "solc.js" .. ].

Activity icon
created branch

yann300 in ethereum/remix-project create branch fix-source-highlight

createdAt 1 hour ago
Activity icon
issue

holiman issue comment ethereum/go-ethereum

holiman
holiman

Trace response of traceBlockByHash is non-deterministic and get "execution reverted" error

System information

Geth version: v1.10.2

Expected behaviour

  1. When getting block traces using traceBlockByHash, the response should be deterministic
  2. For a transaction with Success status, should not get "execution reverted" trace error

Actual behaviour

In Ethereum mainnet

  1. Run debug.traceBlockByHash("0x27049febec8fd16fb662d0d8c00f5ff7cec571b71585b18c30e0c6d2df93b4fe", {"tracer": "callTracer", "timeout": "60s"}) twice, get different trace result for the transaction 0x44de5f0ce469c09e4003f974e4ae119aea69ac461fdb0974fe410a1657284ce5

First time tx trace result:

    result: {
      calls: [{...}],
      from: "0x00000000c0293c8ca34dac9bcc0f953532d34e4d",
      gas: "0xa7ac",
      gasUsed: "0x6876",
      input: "0xca722cdc5ae6e1d89dcdb255d8851f3b47f374103d5022146b4e29a3bf4aea91993ae06fdd3d5766c2b7db16c171487fdb4800eaabf851f35488b76b33e53faa21b36588",
      output: "0x",
      time: "86.428742ms",
      to: "0xd1ceeeeee83f8bcf3bedad437202b6154e9f5405",
      type: "CALL",
      value: "0x0"
    }
}

Second time tx trace result:

{
    result: {
      error: "execution reverted",
      from: "0x00000000c0293c8ca34dac9bcc0f953532d34e4d",
      gas: "0xa7ac",
      gasUsed: "0xa8f",
      input: "0xca722cdc5ae6e1d89dcdb255d8851f3b47f374103d5022146b4e29a3bf4aea91993ae06fdd3d5766c2b7db16c171487fdb4800eaabf851f35488b76b33e53faa21b36588",
      time: "15.241119ms",
      to: "0xd1ceeeeee83f8bcf3bedad437202b6154e9f5405",
      type: "CALL",
      value: "0x0"
    }
}
  1. Why get "execution reverted" error for the successful transaction 0x44de5f0ce469c09e4003f974e4ae119aea69ac461fdb0974fe410a1657284ce5 at the second traceBlockByHash call
holiman
holiman

could you help take a look on this? Thanks

Yup, will do

started
started time in 1 hour ago
push

minimalsm push ethereum/ethereum-org-website

minimalsm
minimalsm

docs: update README.md [skip ci]

minimalsm
minimalsm

docs: update .all-contributorsrc [skip ci]

minimalsm
minimalsm

Merge pull request #5199 from ethereum/all-contributors/add-tiagoyonamine

docs: add tiagoyonamine as a contributor for doc

commit sha: 621d5ed46919c9ad48582ed8b7bb14c39adecec4

push time in 1 hour ago
Activity icon
delete

minimalsm in ethereum/ethereum-org-website delete branch all-contributors/add-tiagoyonamine

deleted time in 1 hour ago
pull request

minimalsm pull request ethereum/ethereum-org-website

minimalsm
minimalsm

docs: add tiagoyonamine as a contributor for doc

Add @tiagoyonamine as a contributor for doc.

This was requested by minimalsm in this comment

open pull request

stephensli wants to merge ethereum/solc-js

stephensli
stephensli

Rename solcjs to solc.js internally and apply lint changes

stephensli
stephensli

Yes I believe so,

This would be the file which will be in the release, you can run npm pack to simulate a release package and see the content. Make sure everything you are expecting to also be in that package.

https://docs.npmjs.com/cli/v7/commands/npm-pack

pull request

stephensli merge to ethereum/solc-js

stephensli
stephensli

Rename solcjs to solc.js internally and apply lint changes

Activity icon
issue

gatsby-cloud[bot] issue comment ethereum/ethereum-org-website

gatsby-cloud[bot]
gatsby-cloud[bot]

docs: add tiagoyonamine as a contributor for doc

Add @tiagoyonamine as a contributor for doc.

This was requested by minimalsm in this comment

gatsby-cloud[bot]
gatsby-cloud[bot]

Gatsby Cloud Build Report

ethereum-org-website-dev

:tada: Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

:clock1: Build time: 6m

Activity icon
fork

ITechNote forked ethereum/remix-project

⚡ Remix is a browser-based compiler and IDE that enables users to build Ethereum contracts with Solidity language and to debug transactions.
ITechNote MIT License Updated
fork time in 1 hour ago
Activity icon
issue

stephensli issue comment ethereum/solc-js

stephensli
stephensli

Typescript Base Support

Base Typescript Support #287

This pull request includes the base requirements and minor changes to keep the current application code, test code, and process while supporting Typescript, Typescript compiling, and future support for adding types.

Files

All files have been moved from .js to .ts. This includes providing an extension type for the binary file solcjs which is now solc.ts which will later be transpiled into solc.js. The required package.json references have been updated where applicable to ensure packaging and binary referencing when linking work as expected.

Linting

Linting has been directly upgraded from just standard/standard to use eslint which is directly supported within Typescript, allowing code style enforcement of standard/standard while also locating and flagging possible code errors. Linting has been run throughout to change var to cont where applicable.

Post Build Script

A new script file exists within the build folder for post-build. This correctly sets the required permissions on the solc.js command-line binary reference. Allowing testing to function correctly and direct execution to work as expected.

Testing

Testing is done against the transpiled code after running through the Typescript compiler. This is due to the usage of dynamic importing being performed to pull in different binary versions. Each time this is performed the typescript compiler will attempt to parse and validate the entire file every single time. This increases testing time 10 fold and should be avoided. Testing against the built code allows testing to work as it does now.

When running the test command, additional resource files are copied into the dist folder to allow testing to function correctly. This is due to Typescript not including those files in the build process.

Packaging

When publishing or packaging, the dist files are used instead of the source typescript files as expected. You can test the content of the deployment or release by running the following npm pack.

What's next?

Once merged, this allows the introduction of typing to reduce errors and improve code quality. This can go in hand with enabling typescript declaration and configuration of the package.json to use said built types. Allowing users of the application to gain access to these types after installing the package.

stephensli
stephensli

@axic i did not see anything regarding allowing maintainers but I have invited you to my fork, please rebase as much as you need.

Activity icon
issue

frangio issue comment ethereum/solidity

frangio
frangio

Fixed point types

https://www.pivotaltracker.com/story/show/81779716

TODO:

  • assignment (lvalue and rvalue)
  • conversion (between different fixed types)
  • conversion (between other types)
  • comparison operators (< > =)
  • unary operators (-, --, ++)
  • binary operators (+ - / * )
  • do-we-need-these? binary operators (% **)
frangio
frangio

With the introduction of user defined value types I no longer think it's necessary for Solidity to implement a fixed point type.

Standardization of this type could (should?) happen as an EIP.

Activity icon
issue

allcontributors[bot] issue comment ethereum/ethereum-org-website

allcontributors[bot]
allcontributors[bot]

Adding an Education PT-BR Community Resource

Description

Adding the Brazilian-Portuguese guide web3 starter pack to the Education section in the Community Resources.

Related Issue

pull request

allcontributors[bot] pull request ethereum/ethereum-org-website

allcontributors[bot]
allcontributors[bot]

docs: add tiagoyonamine as a contributor for doc

Add @tiagoyonamine as a contributor for doc.

This was requested by minimalsm in this comment

push

allcontributors[bot] push ethereum/ethereum-org-website

allcontributors[bot]
allcontributors[bot]

docs: update .all-contributorsrc [skip ci]

commit sha: eeafab0b5753a311dab33a6ca9243e000a5f1b23

push time in 1 hour ago
Activity icon
created branch

allcontributors[bot] in ethereum/ethereum-org-website create branch all-contributors/add-tiagoyonamine

createdAt 1 hour ago
Activity icon
issue

minimalsm issue comment ethereum/ethereum-org-website

minimalsm
minimalsm

Adding an Education PT-BR Community Resource

Description

Adding the Brazilian-Portuguese guide web3 starter pack to the Education section in the Community Resources.

Related Issue

push

minimalsm push ethereum/ethereum-org-website

minimalsm
minimalsm

docs: update README.md [skip ci]

minimalsm
minimalsm

docs: update .all-contributorsrc [skip ci]

minimalsm
minimalsm

Merge branch 'dev' into all-contributors/add-astutejoe

minimalsm
minimalsm

Merge pull request #5197 from ethereum/all-contributors/add-astutejoe

docs: add astutejoe as a contributor for doc

commit sha: 34f067f027bc4aa567c177d3fdb1c8d85d44a7db

push time in 1 hour ago
Activity icon
issue

stephensli issue comment ethereum/solc-js

stephensli
stephensli

Typescript Base Support

Base Typescript Support #287

This pull request includes the base requirements and minor changes to keep the current application code, test code, and process while supporting Typescript, Typescript compiling, and future support for adding types.

Files

All files have been moved from .js to .ts. This includes providing an extension type for the binary file solcjs which is now solc.ts which will later be transpiled into solc.js. The required package.json references have been updated where applicable to ensure packaging and binary referencing when linking work as expected.

Linting

Linting has been directly upgraded from just standard/standard to use eslint which is directly supported within Typescript, allowing code style enforcement of standard/standard while also locating and flagging possible code errors. Linting has been run throughout to change var to cont where applicable.

Post Build Script

A new script file exists within the build folder for post-build. This correctly sets the required permissions on the solc.js command-line binary reference. Allowing testing to function correctly and direct execution to work as expected.

Testing

Testing is done against the transpiled code after running through the Typescript compiler. This is due to the usage of dynamic importing being performed to pull in different binary versions. Each time this is performed the typescript compiler will attempt to parse and validate the entire file every single time. This increases testing time 10 fold and should be avoided. Testing against the built code allows testing to work as it does now.

When running the test command, additional resource files are copied into the dist folder to allow testing to function correctly. This is due to Typescript not including those files in the build process.

Packaging

When publishing or packaging, the dist files are used instead of the source typescript files as expected. You can test the content of the deployment or release by running the following npm pack.

What's next?

Once merged, this allows the introduction of typing to reduce errors and improve code quality. This can go in hand with enabling typescript declaration and configuration of the package.json to use said built types. Allowing users of the application to gain access to these types after installing the package.

stephensli
stephensli

@stephensli I've rebased this, do you mind if I push? Its coming from my fork, so not sure how that is going to work, I can rebase it now.

If you haven't disabled "allow commits from maintainers", then I can push to your branch. Happy to help with rebasing as I'm causing a lot of that for you with merging other PRs.

I would have to check that, but I have done the rebase.