fengzilong

fengzilong

:herb::sunny::maple_leaf::snowflake:

Member Since 7 years ago

Alibaba Inc, Hangzhou, China

Experience Points
142
follower
Lessons Completed
237
follow
Lessons Completed
4.5k
stars
Best Reply Awards
162
repos

603 contributions in the last year

Pinned
⚡ 🌰 A framework born for micro frontends
⚡ A webpack plugin to check all duplicated dependencies in your bundle
⚡ Good-lookin' ESLint formatter for delightful readability
⚡ Answer to "Why that package is in the bundle"
⚡ Like ESLint but focus on json lint, also with a smaller size
⚡ Compare two string and generate human-friendly output to stdout
Activity
Nov
30
2 hours ago
started
started time in 22 minutes ago
started
started time in 34 minutes ago
Nov
26
4 days ago
started
started time in 3 days ago
push

fengzilong push fengzilong/likes

fengzilong
fengzilong

New Link: B端产品中,Web端表单如何设计 | 人人都是产品经理

commit sha: 9468086ca1496217d56465737005cf99efb438e1

push time in 3 days ago
push

fengzilong push fengzilong/likes

fengzilong
fengzilong

New Link: B端可视化: 图表设计(2) | 人人都是产品经理

commit sha: 2458d8cd1c05536290a3d9e44a9b92a667394b64

push time in 3 days ago
push

fengzilong push fengzilong/likes

fengzilong
fengzilong

New Link: B端可视化:图表设计 | 人人都是产品经理

commit sha: 2316508b3de8cf973840c459538321173ab8db5b

push time in 3 days ago
push

fengzilong push fengzilong/likes

fengzilong
fengzilong

New Link: B端体验设计专题——表格篇 | 人人都是产品经理

commit sha: c7468e825e2cdcd6489644432e8d3ac87a30b115

push time in 3 days ago
push

fengzilong push fengzilong/likes

fengzilong
fengzilong

New Link: 数据表格应该这样设计 | 人人都是产品经理

commit sha: e4aa29ce6d59c61f788df1bbb344020b37c876d7

push time in 3 days ago
started
started time in 3 days ago
started
started time in 3 days ago
Nov
25
5 days ago
started
started time in 4 days ago
Nov
24
6 days ago
started
started time in 5 days ago
Nov
23
1 week ago
started
started time in 6 days ago
started
started time in 6 days ago
started
started time in 6 days ago
Activity icon
issue

fengzilong issue comment eslint/eslint

fengzilong
fengzilong

Change Request: Support async formatter

ESLint version

8.1.0

What problem do you want to solve?

Support async formatter

image

fengzilong/eslint-formatter-mo

I had wrote an eslint formatter with code highlight feature

But it seems the highlighter didn't highlight all tokens well

Recently I want to switch highlighter to shiki for a better highlighting result(maybe, I'm trying), but shiki has a async highlighter, which is not supported by ESLint currently

What do you think is the correct solution?

formatter can be async function

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response

fengzilong
fengzilong

It sounds like we now have agreement that this change doesn’t have to wait for a major release, so we can proceed.

That's great that it can be released soon 🎉

Activity icon
issue

fengzilong issue comment eslint/eslint

fengzilong
fengzilong

feat: support async formatter

closes #15242

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update [ ] Bug fix (template) [ ] New rule (template) [ ] Changes an existing rule (template) [ ] Add autofixing to a rule [ ] Add a CLI option [x] Add something to the core: support async formatter [ ] Other, please explain

What changes did you make? (Give an overview)

Added await ahead of formatter.format

Is there anything you'd like reviewers to focus on?

push

fengzilong push fengzilong/eslint

fengzilong
fengzilong

chore: format is not optional

Co-authored-by: Milos Djermanovic [email protected]

commit sha: 2bbf360f5b4b97b0a856216cde918ad04ba95754

push time in 6 days ago
push

fengzilong push fengzilong/eslint

fengzilong
fengzilong

docs: update ESLint version for async formatter

Co-authored-by: Milos Djermanovic [email protected]

commit sha: 945bfb7700a1adc17cdd791b61e6e9611754354f

push time in 6 days ago
started
started time in 6 days ago
Nov
21
1 week ago
started
started time in 1 week ago
Nov
20
1 week ago
push

fengzilong push raxjs/rax-hooks

fengzilong
fengzilong

feat: emit events from use-countdown

fengzilong
fengzilong

commit sha: 35f1269279eb7468b4d56e554455c9ed42df369b

push time in 1 week ago
Activity icon
issue

fengzilong issue comment eslint/eslint

fengzilong
fengzilong

Change Request: Support async formatter

ESLint version

8.1.0

What problem do you want to solve?

Support async formatter

image

fengzilong/eslint-formatter-mo

I had wrote an eslint formatter with code highlight feature

But it seems the highlighter didn't highlight all tokens well

Recently I want to switch highlighter to shiki for a better highlighting result(maybe, I'm trying), but shiki has a async highlighter, which is not supported by ESLint currently

What do you think is the correct solution?

formatter can be async function

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response

fengzilong
fengzilong

If there is an ESLint integration list, I can help send PRs to these repositories to add await

Nov
19
1 week ago
pull request

fengzilong pull request tabrindle/envinfo

fengzilong
fengzilong

feat: add preset for rax

This is a great tool to help people file issue with more details.

And I'd like to add this tool in rax cmmunity issue template to let people use envinfo to report env info.

It would be appreciated if you could accept this PR

And here is the introduction for Rax: Rax is a progressive framework for building universal applications

Activity icon
fork

fengzilong forked tabrindle/envinfo

⚡ Generate a report about your development environment for debugging and issue reporting
fengzilong MIT License Updated
fork time in 1 week ago
Previous