fkirc

fkirc

Cross-Platform App Developer https://gist.github.com/fkirc

Member Since 5 years ago

Graz, Austria

Experience Points
19
follower
Lessons Completed
2
follow
Lessons Completed
23
stars
Best Reply Awards
24
repos

1422 contributions in the last year

Pinned
⚡ Semi-automated Text Translator for Websites and Apps
⚡ Save time and cost when using GitHub Actions
⚡ Android app to securely store notes within an encrypted Zip file
⚡ Idempotent script to migrate Bitbucket issues to GitHub. Capable of patching issues even after the initial GitHub posts.
⚡ A simple double click listener for android
⚡ Protecting local networks via a TEE, providing security similar to a hardware firewall
Activity
Nov
23
1 week ago
Nov
9
3 weeks ago
Activity icon
issue

fkirc issue comment fkirc/skip-duplicate-actions

fkirc
fkirc

Underspecified behaviour of `concurrent_skipping: "always"`

I was wondering about the following situation. Given that concurrent_skipping is set to always. What if I quickly push 2 commits that build upon eachother to a branch, which emits two push events. Two workflow runs will be queued. Is it then guaranteed that only the newest commit will run, and that the older commit will be cancelled? Or is it possible that the older commit cancels the workflow run of the newer commit?

Unfortunately I am quite sure I need always, because of #157, but please correct me if I'm wrong.

It would be fine if the response to this question is, "no, please refrain from pushing commits that quickly", but it would be nice to know about this in advance. I also had a hard time replicating this in our own repo so that's why I'm asking here (sorry if I missed a link to a community chat).

fkirc
fkirc

I am not sure about your exact use case, but maybe you can use same_content_newer or do_not_skip. The cancel_others-features is intended to save resources, but it is not intended to be reliable. If you want something reliable, then I suggest skipping instead of cancellations.

Nov
7
3 weeks ago
Nov
1
1 month ago
Activity icon
delete

fkirc in fkirc/skip-duplicate-actions delete branch fkirc-patch-1

deleted time in 1 month ago
push

fkirc push fkirc/skip-duplicate-actions

fkirc
fkirc

Reduce download size (#156)

  • Reduce download size

  • Delete sourcemap-register.js

  • Update package.json

  • recompile

commit sha: 38c3738dcac87b41e2b7038775457756c793566e

push time in 1 month ago
push

fkirc push fkirc/skip-duplicate-actions

fkirc
fkirc

Enhance output of successful duplicate run (#153)

commit sha: b4ba461152d6801a328d2d997786ee7170db0218

push time in 1 month ago
pull request

fkirc pull request fkirc/skip-duplicate-actions

fkirc
fkirc

Enhance output of successful duplicate run

Already introduced in #146 but now return the full object instead of just the ID of the run and return this in every case when a run is recognized as skippable. Therefore the output has been renamed to be more generic (skipped_by instead of successful_duplicate).

To be merged after #152.

Closes #141.

Activity icon
issue

fkirc issue fkirc/skip-duplicate-actions

fkirc
fkirc

Export information about the run that skips the current run

Suggestion: Export information such as the build number, SHA hash, etc. of the run that superseded the current one that is being skipped. The run number is already logged out, eg. https://github.com/fkirc/skip-duplicate-actions/blob/master/src/index.ts#L205, but this isn't accessible as part of the workflow.

A common workflow involves building containers, testing those containers, then promoting those containers.

In the case of a merge commit with skip-duplicate-actions, we don't want to rebuild containers that have already been built/tested, so in the case of a shouldSkip: true we'd like to pull down the containers of the run that succeeded already, retag them with the SHA hash of the current workflow and push them, so it would be nice if skip-duplicate-actions could export information about the commit.

I did try to implement this myself so I could PR it, but I'm unfamiliar with TS and just end up with an uncomfortably large number of errors if I try to build :(

pull request

fkirc merge to fkirc/skip-duplicate-actions

fkirc
fkirc

Enhance output of successful duplicate run

Already introduced in #146 but now return the full object instead of just the ID of the run and return this in every case when a run is recognized as skippable. Therefore the output has been renamed to be more generic (skipped_by instead of successful_duplicate).

To be merged after #152.

Closes #141.

Activity icon
issue

fkirc issue comment fkirc/skip-duplicate-actions

fkirc
fkirc

Reduce download size

fkirc
fkirc

Do we want to adjust the ncc command to not generate those files?

Yes please, we want this build setup to be as lightweight as possible. Every additional kilobyte im this repo is just a slowdown for thousands or even millions of Action-runs.

Activity icon
created branch

fkirc in fkirc/skip-duplicate-actions create branch fkirc-patch-1

createdAt 1 month ago
Activity icon
delete

fkirc in fkirc/skip-duplicate-actions delete branch fkirc-patch-1

deleted time in 1 month ago
Activity icon
created branch

fkirc in fkirc/skip-duplicate-actions create branch fkirc-patch-1

createdAt 1 month ago
Activity icon
delete

fkirc in fkirc/skip-duplicate-actions delete branch fkirc-patch-1

deleted time in 1 month ago
push

fkirc push fkirc/skip-duplicate-actions

fkirc
fkirc

Fix broken CI (#154)

  • Fix broken CI

  • Update test.yml

commit sha: e86a884c50603f3a6969da876743d7fd602e7201

push time in 1 month ago
Activity icon
created branch

fkirc in fkirc/skip-duplicate-actions create branch fkirc-patch-1

createdAt 1 month ago
Activity icon
issue

fkirc issue comment fkirc/skip-duplicate-actions

fkirc
fkirc

Enhance output of successful duplicate run

Already introduced in #146 but now return the full object instead of just the ID of the run and return this in every case when a run is recognized as skippable. Therefore the output has been renamed to be more generic (skipped_by instead of successful_duplicate).

To be merged after #152.

Closes #141.

fkirc
fkirc

Thank you for the PR series, I think that this PR needs to be rebased

push

fkirc push fkirc/skip-duplicate-actions

fkirc
fkirc

Follow configuration from offical action template (#152)

  • Follow configuration from offical template

  • Try to reduce download size

Co-authored-by: Felix Kirchengast [email protected]

commit sha: 7652909626f7317b74ca2548b5fffb92c2b35d65

push time in 1 month ago
Previous