gjorgic

gjorgic

Member Since 8 years ago

@factoryhr, Osijek, Croatia

0 organizations

Experience Points
4
follower
Lessons Completed
1
follow
Lessons Completed
13
stars
Best Reply Awards
18
repos

9 contributions in the last year

gjorgic Most Used Languages
gjorgic GitHub Stats

18 Pinned

⚡ A simple facebook application with javascript sdk
⚡ Official repository of the AWS SDK for PHP (@awsforphp)
⚡ PHP package for integration with PromisePay API
⚡ A backbone based model for communicating with a MySQL database using felixge/node-mysql.
Jun
11
1 week ago
started
started time in 1 week ago
May
26
4 weeks ago
pull request

gjorgic pull request pimcore/pimcore

gjorgic
gjorgic

fix(assets): use Flysystem for size determination

This fix force download route to use Flysystem for file size determination instead of using native PHP function; On that way we will avoid issues on different disk adapters (e.g. aws (s3))

This was tested with local adapter and aws adapter

Case

  1. I change File storage for assets to use S3, and ACL visibility for files is private
services:
    assets_s3:
        class: 'Aws\S3\S3Client'
        arguments:
            -   endpoint: 'https://s3.eu-central-1.amazonaws.com'
                region: 'eu-central-1'
                version: 'latest'
                credentials:
                    key: '%aws_iam_key%'
                    secret: '%aws_iam_secret%'

flysystem:
    storages:
        pimcore.asset.storage:
            adapter: 'aws'
            options:
                client: 'assets_s3'
                bucket: '%aws_bucket%'
                prefix: '%assets_storage_path%'
  1. I'm in pimcore administration on asset single screen (asset type is JPEG image);
  2. When i try download image by click on "Original File" button (on right side), this ends with error screen;

fstat is not able to determine information about a file and return false which cause error

Activity icon
created branch

gjorgic in gjorgic/pimcore create branch fix-assets-download-for-none-local-adapters

createdAt 3 weeks ago
Activity icon
delete

gjorgic in gjorgic/pimcore delete branch fix-assets-download

deleted time in 3 weeks ago
pull request

gjorgic pull request pimcore/pimcore

gjorgic
gjorgic

Fix assets download

This fix force download route to use Flysystem for file size determination instead of using native PHP function; On that way we will avoid issues on different disk adapters (e.g. aws (s3))

This was tested with local adapter and aws adapter

Case

  1. I change File storage for assets to use S3, and ACL visibility for files is private
services:
    assets_s3:
        class: 'Aws\S3\S3Client'
        arguments:
            -   endpoint: 'https://s3.eu-central-1.amazonaws.com'
                region: 'eu-central-1'
                version: 'latest'
                credentials:
                    key: '%aws_iam_key%'
                    secret: '%aws_iam_secret%'

flysystem:
    storages:
        pimcore.asset.storage:
            adapter: 'aws'
            options:
                client: 'assets_s3'
                bucket: '%aws_bucket%'
                prefix: '%assets_storage_path%'
  1. I'm in pimcore administration on asset single screen (asset type is JPEG image);
  2. When i try download image by click on "Original File" button (on right side), this ends with error screen;

fstat is not able to determine information about a file and return false which cause error

pull request

gjorgic pull request pimcore/pimcore

gjorgic
gjorgic

Fix assets download

This fix force download route to use Flysystem for file size determination instead of using native PHP function; On that way we will avoid issues on different disk adapters (e.g. aws (s3))

This was tested with local adapter and aws adapter

Case

  1. I change File storage for assets to use S3, and ACL visibility for files is private
services:
    assets_s3:
        class: 'Aws\S3\S3Client'
        arguments:
            -   endpoint: 'https://s3.eu-central-1.amazonaws.com'
                region: 'eu-central-1'
                version: 'latest'
                credentials:
                    key: '%aws_iam_key%'
                    secret: '%aws_iam_secret%'

flysystem:
    storages:
        pimcore.asset.storage:
            adapter: 'aws'
            options:
                client: 'assets_s3'
                bucket: '%aws_bucket%'
                prefix: '%assets_storage_path%'
  1. I'm in pimcore administration on asset single screen (asset type is JPEG image);
  2. When i try download image by click on "Original File" button (on right side), this ends with error screen;

fstat is not able to determine information about a file and return false which cause error

push

gjorgic push gjorgic/pimcore

gjorgic
gjorgic

[Sitemaps] Revert public dir override, remove experimental notice in docs & drop 1.x support - resolves #9197

gjorgic
gjorgic

[Document] Fixed nested block editables - fixes #9131

gjorgic
gjorgic

[WebDAV] Fix child paths - resolves #9175

gjorgic
gjorgic

[Email] Fix debug params in email logs - resolves #9177

gjorgic
gjorgic

[Data Objects] Fix loading lazy loaded localized fields on save versio… (#9159)

  • [Data Objects] Fix loading lazy loaded localized fieldson save version - resolves #9136

  • [Data Objects] Fix loading lazy loaded localized fields on save version - resolves #9136

  • [Data Objects] Fix loading lazy loaded localized fields on save version - resolves #9136

  • [Data Objects] Fix loading lazy loaded localized fields on save version - resolves #9136

gjorgic
gjorgic

Merge remote-tracking branch 'origin/6.9' into 10.0

gjorgic
gjorgic

README.md: Pimcore X banner

gjorgic
gjorgic

README.md: Updated tech chart

gjorgic
gjorgic

[Commands] Parallelization trait - Add option to configure batch-size - resolves #8800

gjorgic
gjorgic

Pass parameters to post-add/update events

gjorgic
gjorgic

[Data Objects] introduce onContainerSaved method (#8972)

  • [Data Objects] introduce onContainerSaved method #5965

  • [Data Objects] introduce onContainerSaved method #5965

  • [Data Objects] introduce onContainerSaved method #5965

  • [Data Objects] introduce onContainerSaved method #5965

  • [Data Objects] introduce onContainerSaved method #5965

  • [Data Objects] introduce onContainerSaved method #5965

  • [Data Objects] introduce onContainerSaved method #5965

  • [Data Objects] introduce onContainerSaved method #5965

  • [Data Objects] introduce onContainerSaved method #5965

  • [Data Objects] introduce onContainerSaved method - code optimization #5965

Co-authored-by: Divesh divesh.pahuja@pimcore.com

gjorgic
gjorgic
gjorgic
gjorgic

Added Payone bundle by partner Asioso (#9149)

  • Added Payone bundle by partner Asioso

  • Update README.md

gjorgic
gjorgic

Set property in trait to public so that it can be loaded (#9200)

The property is currently protected which prevents that the value can be accessed from outside. If a class definition is loaded, the value is empty in the UI.

gjorgic
gjorgic

fix(assets): use Flysystem for size determination This will help avoid issues on different disk drivers e.g. S3

commit sha: 8d4595e06c1fff4cb818784daf6edfa0983647e8

push time in 3 weeks ago
Activity icon
created branch

gjorgic in gjorgic/pimcore create branch fix-assets-download

createdAt 3 weeks ago
Activity icon
fork

gjorgic forked pimcore/pimcore

⚡ Open Source Data & Experience Management Platform (PIM, MDM, CDP, DAM, DXP/CMS & Digital Commerce)
gjorgic Updated
fork time in 3 weeks ago