gustavonihei

gustavonihei

Member Since 3 years ago

@espressif, Florianópolis, SC, Brazil

Experience Points
10
follower
Lessons Completed
5
follow
Lessons Completed
12
stars
Best Reply Awards
7
repos

948 contributions in the last year

Pinned
⚡ Apache NuttX is a mature, real-time embedded operating system (RTOS)
⚡ Apache NuttX Apps is a collection of tools, shells, network utilities, libraries, interpreters and can be used with the NuttX RTOS
⚡ Secure boot for 32-bit Microcontrollers!
⚡ This repository provides 2nd stage bootloader and partition table binaries for NuttX users of ESP chips.
Activity
Jan
19
3 days ago
pull request

gustavonihei merge to apache/incubator-nuttx

gustavonihei
gustavonihei

sched: Define SMP_NCPUS to 1 in no SMP case

Summary

to simplify the SMP related code logic

Impact

SMP

Testing

Pass CI and ostest in sim:nsh/smp

Jan
18
4 days ago
open pull request

gustavonihei wants to merge apache/incubator-nuttx

gustavonihei
gustavonihei

sched: Define SMP_NCPUS to 1 in no SMP case

Summary

to simplify the SMP related code logic

Impact

SMP

Testing

Pass CI and ostest in sim:nsh/smp

gustavonihei
gustavonihei

For consistency to the adopted naming template, we should remove the SMP_ prefix, since it is strictly related to SMP.

We should rename the config to just NCPUS.

pull request

gustavonihei merge to apache/incubator-nuttx

gustavonihei
gustavonihei

sched: Define SMP_NCPUS to 1 in no SMP case

Summary

to simplify the SMP related code logic

Impact

SMP

Testing

Pass CI and ostest in sim:nsh/smp

open pull request

gustavonihei wants to merge apache/incubator-nuttx

gustavonihei
gustavonihei

sched: Define SMP_NCPUS to 1 in no SMP case

Summary

to simplify the SMP related code logic

Impact

SMP

Testing

Pass CI and ostest in sim:nsh/smp

gustavonihei
gustavonihei
  DEBUGASSERT(cpu >= 0 && cpu < CONFIG_SMP_NCPUS);

Not related to the change proposed in this PR, but since cpu is the CPU ID, it can't be equal to 1 in a single CPU scenario.

pull request

gustavonihei merge to apache/incubator-nuttx

gustavonihei
gustavonihei

sched: Define SMP_NCPUS to 1 in no SMP case

Summary

to simplify the SMP related code logic

Impact

SMP

Testing

Pass CI and ostest in sim:nsh/smp

open pull request

gustavonihei wants to merge apache/incubator-nuttx

gustavonihei
gustavonihei

xtensa: some fixes in interrupt handler

Summary

Five patches include:

xtensa: fix svccall enter error xtensa: add svcall handler xtensa: move a3 save in handler instead of _xtensa_context_save arch:xtensa_panic: use right interrupt pointer in xtensa_panic arch:xtensa:vectors:fix bugs in a0 save

Impac

No, bug fix.

Testing

Testing on xtensa EVB borad

gustavonihei
gustavonihei

Curious question: why do we need to save A3 here? It is already saved as part of _xtensa_context_save.

pull request

gustavonihei merge to apache/incubator-nuttx

gustavonihei
gustavonihei

xtensa: some fixes in interrupt handler

Summary

Five patches include:

xtensa: fix svccall enter error xtensa: add svcall handler xtensa: move a3 save in handler instead of _xtensa_context_save arch:xtensa_panic: use right interrupt pointer in xtensa_panic arch:xtensa:vectors:fix bugs in a0 save

Impac

No, bug fix.

Testing

Testing on xtensa EVB borad

open pull request

gustavonihei wants to merge apache/incubator-nuttx

gustavonihei
gustavonihei

xtensa: some fixes in interrupt handler

Summary

Five patches include:

xtensa: fix svccall enter error xtensa: add svcall handler xtensa: move a3 save in handler instead of _xtensa_context_save arch:xtensa_panic: use right interrupt pointer in xtensa_panic arch:xtensa:vectors:fix bugs in a0 save

Impac

No, bug fix.

Testing

Testing on xtensa EVB borad

gustavonihei
gustavonihei
	/* Dispatch the syscall as with other interrupts. */
pull request

gustavonihei merge to apache/incubator-nuttx

gustavonihei
gustavonihei

xtensa: some fixes in interrupt handler

Summary

Five patches include:

xtensa: fix svccall enter error xtensa: add svcall handler xtensa: move a3 save in handler instead of _xtensa_context_save arch:xtensa_panic: use right interrupt pointer in xtensa_panic arch:xtensa:vectors:fix bugs in a0 save

Impac

No, bug fix.

Testing

Testing on xtensa EVB borad

pull request

gustavonihei merge to apache/incubator-nuttx

gustavonihei
gustavonihei

xtensa: some fixes in interrupt handler

Summary

Five patches include:

xtensa: fix svccall enter error xtensa: add svcall handler xtensa: move a3 save in handler instead of _xtensa_context_save arch:xtensa_panic: use right interrupt pointer in xtensa_panic arch:xtensa:vectors:fix bugs in a0 save

Impac

No, bug fix.

Testing

Testing on xtensa EVB borad

open pull request

gustavonihei wants to merge apache/incubator-nuttx

gustavonihei
gustavonihei

xtensa: some fixes in interrupt handler

Summary

Five patches include:

xtensa: fix svccall enter error xtensa: add svcall handler xtensa: move a3 save in handler instead of _xtensa_context_save arch:xtensa_panic: use right interrupt pointer in xtensa_panic arch:xtensa:vectors:fix bugs in a0 save

Impac

No, bug fix.

Testing

Testing on xtensa EVB borad

gustavonihei
gustavonihei

By the way, since the SP regsiter is still unchanged at this point, isn't it more intuitive to use it as the base address?

pull request

gustavonihei merge to apache/incubator-nuttx

gustavonihei
gustavonihei

xtensa: some fixes in interrupt handler

Summary

Five patches include:

xtensa: fix svccall enter error xtensa: add svcall handler xtensa: move a3 save in handler instead of _xtensa_context_save arch:xtensa_panic: use right interrupt pointer in xtensa_panic arch:xtensa:vectors:fix bugs in a0 save

Impac

No, bug fix.

Testing

Testing on xtensa EVB borad

open pull request

gustavonihei wants to merge apache/incubator-nuttx

gustavonihei
gustavonihei

xtensa: some fixes in interrupt handler

Summary

Five patches include:

xtensa: fix svccall enter error xtensa: add svcall handler xtensa: move a3 save in handler instead of _xtensa_context_save arch:xtensa_panic: use right interrupt pointer in xtensa_panic arch:xtensa:vectors:fix bugs in a0 save

Impac

No, bug fix.

Testing

Testing on xtensa EVB borad

gustavonihei
gustavonihei
open pull request

gustavonihei wants to merge apache/incubator-nuttx

gustavonihei
gustavonihei

xtensa: some fixes in interrupt handler

Summary

Five patches include:

xtensa: fix svccall enter error xtensa: add svcall handler xtensa: move a3 save in handler instead of _xtensa_context_save arch:xtensa_panic: use right interrupt pointer in xtensa_panic arch:xtensa:vectors:fix bugs in a0 save

Impac

No, bug fix.

Testing

Testing on xtensa EVB borad

gustavonihei
gustavonihei
	s32i	a3, a2, (4 * REG_A3)

nit: double whitespace

pull request

gustavonihei merge to apache/incubator-nuttx

gustavonihei
gustavonihei

xtensa: some fixes in interrupt handler

Summary

Five patches include:

xtensa: fix svccall enter error xtensa: add svcall handler xtensa: move a3 save in handler instead of _xtensa_context_save arch:xtensa_panic: use right interrupt pointer in xtensa_panic arch:xtensa:vectors:fix bugs in a0 save

Impac

No, bug fix.

Testing

Testing on xtensa EVB borad

Activity icon
issue

gustavonihei issue comment apache/incubator-nuttx

gustavonihei
gustavonihei

net: unify FAR keyword usage for all net buffer memory mapped buffers

Summary

In some cases the FAR keyword is missing when working with network buffers and using memory mapped types. Restore consistency

Impact

No functional changes

Testing

Pass CI

gustavonihei
gustavonihei

FAR qualifier is only required for common code. Many (if not all, haven’t looked at all files) are restricted to chip implementation. Besides, FAR and CODE have already been removed previously from Xtensa and RISC-V. Adding them back would be a step back.

@gustavonihei I haven't added neither FAR nor CODE to Xtensa and RISC-V. For each file that I added I examined if FAR is already used in that file or not and if I found FAR then I added it as well.

I think that FAR and CODE keywords removal should be by code for each architecture step by step in all arch dependent places. I just try to keep consistency with existing code.

Sorry, @pkarashchenko. I had a quick look on the cellphone and misunderstood some bits of the PR. I'll drop the review for now.

Jan
17
5 days ago
pull request

gustavonihei merge to apache/incubator-nuttx

gustavonihei
gustavonihei

net: unify FAR keyword usage for all net buffer memory mapped buffers

Summary

In some cases the FAR keyword is missing when working with network buffers and using memory mapped types. Restore consistency

Impact

No functional changes

Testing

Pass CI

gustavonihei
gustavonihei

FAR qualifier is only required for common code. Many (if not all, haven’t looked at all files) are restricted to chip implementation. Besides, FAR and CODE have already been removed previously from Xtensa and RISC-V. Adding them back would be a step back.

pull request

gustavonihei merge to apache/incubator-nuttx

gustavonihei
gustavonihei

net: unify FAR keyword usage for all net buffer memory mapped buffers

Summary

In some cases the FAR keyword is missing when working with network buffers and using memory mapped types. Restore consistency

Impact

No functional changes

Testing

Pass CI

gustavonihei
gustavonihei

FAR qualifier is only required for common code. Many (if not all, haven’t looked at all files) are restricted to chip implementation. Besides, FAR and CODE have already been removed previously from Xtensa and RISC-V before. Adding them back would be a step back.

push

gustavonihei push gustavonihei/esp-nuttx-bootloader

gustavonihei
gustavonihei

idfboot: Add ESP32-S3 to the list of supported targets

Signed-off-by: Gustavo Henrique Nihei [email protected]

commit sha: 328595abbd93d9ac3d674840da6ecf777808b92d

push time in 4 days ago
open pull request

gustavonihei wants to merge mcu-tools/mcuboot

gustavonihei
gustavonihei

doc: fixed release-notes.md

Fixed typos and grammar mistakes. Rephrased slightly unclear sentences. Fixed punctuation. Unified spaces after periods. Unified tenses used in listed changes.

Signed-off-by: Francesco Domenico Servidio [email protected]

NOTE: No meaning changes were introduced.

gustavonihei
gustavonihei

Actually, the discussion is not between present or past tense, because that would assume that the verb goes in the Indicative mood, which should not be the case. A Release Notes (as well as Git commit messages) usually contains verbs in the Imperative mood, which are more suitable to point that things will change from this point forward.

pull request

gustavonihei merge to mcu-tools/mcuboot

gustavonihei
gustavonihei

doc: fixed release-notes.md

Fixed typos and grammar mistakes. Rephrased slightly unclear sentences. Fixed punctuation. Unified spaces after periods. Unified tenses used in listed changes.

Signed-off-by: Francesco Domenico Servidio [email protected]

NOTE: No meaning changes were introduced.

pull request

gustavonihei merge to mcu-tools/mcuboot

gustavonihei
gustavonihei

doc: fixed ecdsa.md

Rephrased a few sentences. Fixed a few typos. Fixed lists. Added additional small fixes.

Signed-off-by: Francesco Domenico Servidio [email protected]

gustavonihei
gustavonihei
pull request

gustavonihei pull request apache/incubator-nuttx

gustavonihei
gustavonihei

xtensa: Fix core voltage level when SPI Flash runs at 80Mhz

Summary

This PR intends to fix the core voltage level of both ESP32 and ESP32-S2 when their SPI Flash runs at 80 MHz.

Impact

Only for ESP32 and ESP32-S2 when their SPI Flash runs at 80 MHz. No impact if using default SPI Flash frequency of 40MHz.

Testing

esp32-devkitc:nsh and esp32s2-saola-1.

Activity icon
created branch

gustavonihei in gustavonihei/incubator-nuttx create branch bugfix/esp_soc_cleanup

createdAt 5 days ago
Jan
14
1 week ago
open pull request

gustavonihei wants to merge mcu-tools/mcuboot

gustavonihei
gustavonihei

doc: fixed ecdsa.md

Rephrased a few sentences. Fixed a few typos. Fixed lists. Added additional small fixes.

Signed-off-by: Francesco Domenico Servidio [email protected]

gustavonihei
gustavonihei
  3. An Mbed TLS implementation of EC256 can be added, but it will require
pull request

gustavonihei merge to mcu-tools/mcuboot

gustavonihei
gustavonihei

doc: fixed ecdsa.md

Rephrased a few sentences. Fixed a few typos. Fixed lists. Added additional small fixes.

Signed-off-by: Francesco Domenico Servidio [email protected]

Jan
13
1 week ago
pull request

gustavonihei pull request apache/incubator-nuttx

gustavonihei
gustavonihei

xtensa: Fix typo in xchal_cpX_store macros' invocation

Summary

This PR intends to fix a build issue due to a typo in the identifiers of some macros for saving the coprocessors' state on Xtensa chips.

Impact

Xtensa chips with more than 3 coprocessors and whose save area is greater than 0 (XCHAL_CP3_SA_SIZE > 0).

Testing

Tested with during development for ESP32-S3 chips.

Activity icon
created branch

gustavonihei in gustavonihei/incubator-nuttx create branch bugfix/xtensa_fix_cpstore

createdAt 1 week ago
Jan
12
1 week ago
pull request

gustavonihei pull request apache/incubator-nuttx

gustavonihei
gustavonihei

xtensa/esp32s2: Fix some wrong definitions related to IRQ management

Summary

This PR intends to provide some minor fixes to ESP32-S2 port, mainly on the identifiers of some definitions which were mentioning chips other than ESP32-S2.

Impact

Should have no impact.

Testing

CI build pass.

Activity icon
created branch

gustavonihei in gustavonihei/incubator-nuttx create branch bugfix/esp32s2_irq

createdAt 1 week ago
Previous