hi-rustin

hi-rustin

Focus on TiCDC and TiKV!

Member Since 4 years ago

@pingcap, China

Experience Points
275
follower
Lessons Completed
65
follow
Lessons Completed
772
stars
Best Reply Awards
96
repos

3334 contributions in the last year

Pinned
⚡ Change data capture for TiDB
⚡ Distributed transactional key-value database, originally created to complement TiDB
⚡ The Rust package manager
⚡ Empowering everyone to build reliable and efficient software.
Activity
Nov
28
14 hours ago
Activity icon
issue

hi-rustin issue comment rust-lang/rust

hi-rustin
hi-rustin

Add --out-dir flag for rustdoc

part of https://github.com/rust-lang/rust/issues/91260

Add --out-dir flag for rustdoc and change the -o option to point to out-dir.

I'm not quite sure if it should be stable, also I'm not sure if this parameter priority is appropriate? Or should I just refuse to pass both parameters at the same time?

r? @jyn514

hi-rustin
hi-rustin

@jyn514 Tests added!

Thanks for your review! 💚 💙 💜 💛 ❤️

push

hi-rustin push hi-rustin/rust

hi-rustin
hi-rustin

Better error message

Signed-off-by: hi-rustin [email protected]

commit sha: 40f8c48fdedb345cbd8b9451ceb7a3d0a5f9dd96

push time in 19 minutes ago
push

hi-rustin push hi-rustin/rust

hi-rustin
hi-rustin

Add tests for options

Signed-off-by: hi-rustin [email protected]

commit sha: 932a3394f87ca499f7497abae97bb3b553d0cfdb

push time in 22 minutes ago
push

hi-rustin push hi-rustin/rust

hi-rustin
hi-rustin

options 'out-dir' and 'output' can only specify one

Signed-off-by: hi-rustin [email protected]

commit sha: be30d6f83d2f3df0a32faf9d07e8cf87a63bcf3e

push time in 44 minutes ago
push

hi-rustin push hi-rustin/ticdc

hi-rustin
hi-rustin

deployments(ticdc): volume the logs

commit sha: 0a644699116873762cdf5ba39faea7152fa5e8c0

push time in 1 hour ago
push

hi-rustin push hi-rustin/ticdc

hi-rustin
hi-rustin

deployments(ticdc): do not exit after test finished

commit sha: 3ff9ddf5ad886c820d819a92465f2c8445457d64

push time in 2 hours ago
Activity icon
issue

hi-rustin issue comment pingcap/ticdc

hi-rustin
hi-rustin

deployments(ticdc): use service network instead of container network

What problem does this PR solve?

None

What is changed and how it works?

use service network instead of container network.

Otherwise it will ask to create the kafka container first.

Check List

Tests

  • No code

Code changes

None

Side effects

None

Related changes

None

Release note

None
hi-rustin
hi-rustin

/cc @asddongmen

Could you please take a look? Thanks! 💚 💙 💜 💛 ❤️

Can you help try it locally?

pull request

hi-rustin pull request pingcap/ticdc

hi-rustin
hi-rustin

deployments(ticdc): use service network instead of container network

What problem does this PR solve?

None

What is changed and how it works?

use service network instead of container network.

Otherwise it will ask to create the kafka container first.

Check List

Tests

  • No code

Code changes

None

Side effects

None

Related changes

None

Release note

None
Activity icon
created branch

hi-rustin in hi-rustin/ticdc create branch rustin-patch-deployments

createdAt 2 hours ago
Activity icon
issue

hi-rustin issue comment pingcap/ticdc

hi-rustin
hi-rustin

test: add new ci collation without old value test (#3114)

This is an automated cherry-pick of #3114

What problem does this PR solve?

Prepare for more old value tests.

What is changed and how it works?

rename new ci collation test to new ci collation with old value test.

Check List

Tests

  • Integration test

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

None
hi-rustin
hi-rustin

/assign @amyangfei

Could you please help me to trigger the merging process? Thanks /run-all-tests

push

hi-rustin push ti-chi-bot/ticdc

hi-rustin
hi-rustin

test(ticdc): separate statistics for unit tests and integration tests (#3570) (#3577)

  • This is an automated cherry-pick of #3570

Signed-off-by: ti-chi-bot [email protected]

  • makefile: resolve conflicts

Co-authored-by: 0xC3 [email protected]

hi-rustin
hi-rustin

owner: fix gc safepoint larger by one (#2639) (#2667)

hi-rustin
hi-rustin

processor,sink(cdc): let sink report resolved ts and do not skip buffer sink flush (#3540) (#3561)

hi-rustin
hi-rustin

cdc/sink: adjust kafka initialization logic (#3192) (#3565)

hi-rustin
hi-rustin

ticdc/metrics: fix processor checkpoint-ts lag expr (#3543) (#3557)

hi-rustin
hi-rustin

ticdc.rules: fix alertmanager rules (#3422) (#3593)

hi-rustin
hi-rustin

cdc/tests: adjust ddl_reentrant test case (#3614)

hi-rustin
hi-rustin

*: fix changefeed checkpoint lag negative value error (#3013) (#3532)

hi-rustin
hi-rustin

Merge branch 'release-4.0' into cherry-pick-3114-to-release-4.0

commit sha: 2b91cf9a926c44075a3b55ad401fa069ed918046

push time in 2 hours ago
Activity icon
issue

hi-rustin issue comment pingcap/ticdc

hi-rustin
hi-rustin

test: add new ci collation without old value test (#3114)

This is an automated cherry-pick of #3114

What problem does this PR solve?

Prepare for more old value tests.

What is changed and how it works?

rename new ci collation test to new ci collation with old value test.

Check List

Tests

  • Integration test

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

None
Activity icon
issue

hi-rustin issue comment pingcap/ticdc

hi-rustin
hi-rustin

test: add new ci collation without old value test (#3114)

This is an automated cherry-pick of #3114

What problem does this PR solve?

Prepare for more old value tests.

What is changed and how it works?

rename new ci collation test to new ci collation with old value test.

Check List

Tests

  • Integration test

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

None
hi-rustin
hi-rustin

/assign @amyangfei

Could you please help me to trigger the merging process? Thanks

push

hi-rustin push ti-chi-bot/ticdc

hi-rustin
hi-rustin

test(ticdc): separate statistics for unit tests and integration tests (#3570) (#3579)

hi-rustin
hi-rustin

ticdc/metrics: fix processor checkpoint-ts lag expr (#3543) (#3559)

hi-rustin
hi-rustin

Merge branch 'release-5.1' into cherry-pick-3114-to-release-5.1

commit sha: da30cdf21e7b912f26343088e68dc87e0dc45f00

push time in 2 hours ago
Activity icon
issue

hi-rustin issue comment pingcap/ticdc

hi-rustin
hi-rustin

test: add new ci collation without old value test (#3114)

This is an automated cherry-pick of #3114

What problem does this PR solve?

Prepare for more old value tests.

What is changed and how it works?

rename new ci collation test to new ci collation with old value test.

Check List

Tests

  • Integration test

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

None
push

hi-rustin push ti-chi-bot/ticdc

hi-rustin
hi-rustin

test(ticdc): separate statistics for unit tests and integration tests (#3570) (#3578)

hi-rustin
hi-rustin

ticdc/metrics: fix processor checkpoint-ts lag expr (#3543) (#3558)

hi-rustin
hi-rustin

Merge branch 'release-5.0' into cherry-pick-3114-to-release-5.0

commit sha: 257324ae5f1955365d66fb2239fdf947f8ed498f

push time in 2 hours ago
Activity icon
issue

hi-rustin issue comment pingcap/ticdc

hi-rustin
hi-rustin

test: add new ci collation without old value test (#3114)

This is an automated cherry-pick of #3114

What problem does this PR solve?

Prepare for more old value tests.

What is changed and how it works?

rename new ci collation test to new ci collation with old value test.

Check List

Tests

  • Integration test

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

None
hi-rustin
hi-rustin

/assign @amyangfei

Could you please help me to trigger the merging process? Thanks

Activity icon
issue

hi-rustin issue comment pingcap/ticdc

hi-rustin
hi-rustin

test: add new ci collation without old value test (#3114)

This is an automated cherry-pick of #3114

What problem does this PR solve?

Prepare for more old value tests.

What is changed and how it works?

rename new ci collation test to new ci collation with old value test.

Check List

Tests

  • Integration test

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

None
hi-rustin
hi-rustin

/assign @amyangfei

Could you please help me to trigger the merging process? Thanks

Activity icon
issue

hi-rustin issue comment pingcap/ticdc

hi-rustin
hi-rustin

test: add new ci collation without old value test (#3114)

This is an automated cherry-pick of #3114

What problem does this PR solve?

Prepare for more old value tests.

What is changed and how it works?

rename new ci collation test to new ci collation with old value test.

Check List

Tests

  • Integration test

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

None
push

hi-rustin push ti-chi-bot/ticdc

hi-rustin
hi-rustin

test(ticdc): separate statistics for unit tests and integration tests (#3570) (#3580)

hi-rustin
hi-rustin

ticdc/metrics: fix processor checkpoint-ts lag expr (#3543) (#3555)

hi-rustin
hi-rustin

Merge branch 'release-5.2' into cherry-pick-3114-to-release-5.2

commit sha: 218ceb2a103b51f88f0548cd8a9cd59b4c8a40f0

push time in 2 hours ago
pull request

hi-rustin pull request pingcap/ticdc

hi-rustin
hi-rustin

integration_tests(ticdc): move integration tests into integration_tests dir

What problem does this PR solve?

part of https://github.com/pingcap/ticdc/issues/2199

What is changed and how it works?

move integration tests into integration_tests dir. Other test-related files will be moved to this directory later.

Check List

Tests

  • Integration test

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

None
push

hi-rustin push hi-rustin/ticdc

hi-rustin
hi-rustin

integration_tests(ticdc): move integration_tests into tests

commit sha: d43ef99ec35eef3567d20b555753e7927b0a2948

push time in 2 hours ago
Activity icon
created branch

hi-rustin in hi-rustin/ticdc create branch rustin-patch-integration-tests

createdAt 3 hours ago
open pull request

hi-rustin wants to merge pingcap/ticdc

hi-rustin
hi-rustin

docs(both): update format of the commit message

What problem does this PR solve?

close https://github.com/pingcap/ticdc/issues/3195

What is changed and how it works?

update format of the commit message.

Check List

Tests

  • No code

Code changes

None

Side effects

None

Related changes

None

Release note

None
hi-rustin
hi-rustin

There seems to be some confusion between subsystem and area, would it be too long if we prefixed both with area? It seems that many git tools have a limit on the length of the first line (including GitHub).

pull request

hi-rustin merge to pingcap/ticdc

hi-rustin
hi-rustin

docs(both): update format of the commit message

What problem does this PR solve?

close https://github.com/pingcap/ticdc/issues/3195

What is changed and how it works?

update format of the commit message.

Check List

Tests

  • No code

Code changes

None

Side effects

None

Related changes

None

Release note

None
pull request

hi-rustin pull request rust-lang/rust

hi-rustin
hi-rustin

Add --out-dir flag for rustdoc

part of https://github.com/rust-lang/rust/issues/91260

Add --out-dir flag for rustdoc and change the -o option to point to out-dir.

I'm not quite sure if it should be stable, also I'm not sure if this parameter priority is appropriate? Or should I just refuse to pass both parameters at the same time?

r? @jyn514

push

hi-rustin push hi-rustin/rust

hi-rustin
hi-rustin

Weaken guarantee around advancing underlying iterators in zip

The current guarantee is too strong as it would prevent adapters from exploiting knowledge about the iterator length and using counted loops for example because they would stop calling next() before it ever returned None. Additionally several nested zip iterators already fail to uphold this.

This doesn't remove any of the specialization code that tries (and sometimes fails) to uphold the guarantee for next() because removing it would also affect next_back() in more surprising ways.

hi-rustin
hi-rustin

implement Termination for Result<Infallible, E>

hi-rustin
hi-rustin

simplify impl Termination for Result<Infallible, E>

Co-authored-by: Konrad Borowski [email protected]

hi-rustin
hi-rustin

Makes docs for references a little less confusing

  • Make clear that the Pointer trait is related to formatting
  • Make clear that &T (shared reference) implements Send (if T: Send + Sync)
hi-rustin
hi-rustin

Update library/std/src/primitive_docs.rs

Co-authored-by: fmease [email protected]

hi-rustin
hi-rustin

Update core primitives_docs.rs up to date with std

hi-rustin
hi-rustin

Mark Arc::from_inner / Rc::from_inner as unsafe

While it's an internal function, it is easy to create invalid Arc/Rcs to a dangling pointer with it.

Fixes https://github.com/rust-lang/rust/issues/89740

hi-rustin
hi-rustin

Make char conversion functions unstably const

hi-rustin
hi-rustin

Use "rustc" for testing Command args

"echo" is not an application on Windows so Command tests could fail even if that's not what's being tested for.

hi-rustin
hi-rustin

Improve display of enum variants

Use h3 and h4 for the variant name and the "Fields" subheading. Remove the "of T" part of the "Fields" subheading. Remove border-bottom from "Fields" subheading. Move docblock below "Fields" listing.

hi-rustin
hi-rustin

Windows: Resolve Command program without using the current directory

hi-rustin
hi-rustin

mention remove in swap_remove

hi-rustin
hi-rustin

Implement clone_from for State

Data flow engine uses clone_from for domain values. Providing an implementation of clone_from will avoid some intermediate memory allocations.

hi-rustin
hi-rustin

Optimize live point computation

This is just replicating the previous algorithm, but taking advantage of the bitset structures to optimize into tighter and better optimized loops. Particularly advantageous on enormous MIR blocks, which are relatively rare in practice.

hi-rustin
hi-rustin

Make RawVec private to alloc

RawVec was previously exposed for compiler-internal use (libarena specifically) in 1acbb0a9350560d951359cc359361b87992a6f2b

Since it is unstable, doc-hidden and has no associated tracking issue it was never meant for public use. And since it is no longer used outside alloc itself it can be made private again.

Also remove some functions that are dead due to lack of internal users.

hi-rustin
hi-rustin

Remove eval_always for inherent_impls.

hi-rustin
hi-rustin

Remove eval_always from upvars.

hi-rustin
hi-rustin

rustdoc: use Type::def_id() instead of Type::def_id_no_primitives()

Signed-off-by: Muhammad Falak R Wani [email protected]

hi-rustin
hi-rustin

Refactor single variant Candidate enum into a struct

Candidate enum has only a single Ref variant. Refactor it into a struct and reduce overall indentation of the code by two levels.

No functional changes.

hi-rustin
hi-rustin

Remove Candidate::source_info

commit sha: cf50def1f98040233c1f4ca8eca32bd623e556ac

push time in 6 hours ago
Activity icon
issue

hi-rustin issue comment rust-lang/cargo

hi-rustin
hi-rustin

Description of the targets that can be applied

close https://github.com/rust-lang/cargo/issues/9806

Adds a description of the targets to which the default profile can be applied.

hi-rustin
hi-rustin

@ehuss Done. Thanks for your review! 💚 💙 💜 💛 ❤️

push

hi-rustin push hi-rustin/cargo

hi-rustin
hi-rustin

cargo tree: Fix stack overflow on cyclic features.

hi-rustin
hi-rustin

Fix resolve error with cyclic dev-dependency features.

There is a convoluted situation where a cyclic dev-dependency attempts to enable a feature on its parent. It would result in a confusing error saying a package didn't have a feature.

This check was intended only for CLI features, not features passed through the dependency graph.

hi-rustin
hi-rustin

Add crate type flag to rustc command

Signed-off-by: hi-rustin [email protected]

hi-rustin
hi-rustin

re-enabled lto_build test on 32-bit MSVC

Signed-off-by: hi-rustin [email protected]

hi-rustin
hi-rustin

Auto merge of #10103 - ehuss:tree-cycle, r=alexcrichton

Fix a couple issues with cyclic features and dev-dependencies

This fixes two issues with cyclic features and dev-dependencies:

  • cargo tree would enter an infinite loop for cyclic features.
  • The resolver would return a confusing error if a cyclic dev-dependency attempted to enable a feature on its parent that resulted in a cycle. This fixes it to resolve correctly.

Fixes #10101

hi-rustin
hi-rustin

Auto merge of #10110 - hi-rustin:rustin-patch-build-test, r=alexcrichton

re-enable lto_build test on 32-bit MSVC

re-enable lto_build test on 32-bit MSVC. Because https://github.com/rust-lang/rust/pull/27224 landed.

hi-rustin
hi-rustin
hi-rustin
hi-rustin

Add crate-type unstable doc

Signed-off-by: hi-rustin [email protected]

hi-rustin
hi-rustin

Change test to not trigger emoji error

This change is needed to land rust-lang/rust#88781, as it changes the handling of emojis in source code to treat them as identifiers.

hi-rustin
hi-rustin

Auto merge of #10117 - estebank:update-test-for-emoji, r=ehuss

Change test to not trigger emoji error

This change is needed to land rust-lang/rust#88781, as it changes the handling of emojis in source code to treat them as identifiers.

hi-rustin
hi-rustin

Auto merge of #10093 - hi-rustin:rustin-patch-rustc, r=ehuss

Add crate type flag to rustc command

part of https://github.com/rust-lang/cargo/issues/10083

  • Add crate type flag to rustc command
  • Add tests
  • Update docs
hi-rustin
hi-rustin

Description of the targets that can be applied

Signed-off-by: hi-rustin [email protected]

commit sha: c066a2384ff54536d589f39c1c4e738b85fede54

push time in 8 hours ago
Activity icon
issue

hi-rustin issue comment rust-lang/rust

hi-rustin
hi-rustin

rustdoc: accept `--out-dir` and soft-deprecate `--output`

Rustc uses --out-dir, but rustdoc rejects it. This is an unnecessary incompatibility; rustdoc should accept --out-dir too. Accepting --output was a mistake, but it's stable and used in almost literally every run by cargo, so we realistically can't even warn on it. We should document that --out-dir is the recommended option, though.

Once --out-dir has been accepted for several releases, we could consider starting to warn on --output, but I don't suggest committing to that now.

Previous