Hotell

Hotell

I skate, surf, wake, snow and open source 🏄‍♂️ @Microsoft MVP, GDE

Member Since 9 years ago

@microsoft , Prague, Czech Republic

Experience Points
358
follower
Lessons Completed
16
follow
Lessons Completed
330
stars
Best Reply Awards
82
repos

444 contributions in the last year

Pinned
⚡ Angular 2 decorators and utils for Angular 1.x
⚡ Typescript library starter
⚡ Static analysis for Angular projects.
⚡ my blog posts published on medium + code samples
⚡ Type safe utils for redux actions, epics, effects, react/preact default props, various type guards and TypeScript utils, React util components
⚡ Dependency injection for React done right. Hierarchical injection on both component and service layer powered by injection-js (Angular DI framework) 🖖
Activity
Oct
22
2 days ago
Activity icon
issue

Hotell issue comment microsoft/fluentui

Hotell
Hotell

experiment(storybook): Version picker

Chromatic stores published storybooks with commits, we can simply build an azure function to keep the version -> commit mapping and integrate a picker into the docs page

image

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

Hotell
Hotell

I like the idea.

My suggestion would be to use standard storybook controls (their design system) and implement it so it aligns better with overall outcome (storybook design)

2021-10-22 at 15 46

  1. the select would render on the navbar right beyond search
  2. the select would render as another panel item

For both solution we should create a custom addon. I have created one back in August so it would be good opportunity to finish it and add this functionality as well.

btw: I saw you moved some quick n dirty addon outside this repo - I'd like us to mitigate that in the future so its all in one place

push

Hotell push Hotell/fluentui

Hotell
Hotell

react-image: Adding migration guide (#20028)

  • First iteration of migration guide

  • Updated readme: added link to migration

  • Added migration examples - not finalized

  • Fixed example for shouldStartVisible

  • Updated migration guide

  • Change files

  • Fixing wording and typo

  • Updated wording for fluid prop

Hotell
Hotell

Removed duplicate 'Avatar' from story names (#20264)

  • Removed duplicate 'Avatar' from story names

  • Change files

Hotell
Hotell

Removed duplicate 'Button' from story names (#20266)

  • Removed duplicate 'Button' from story names

  • Change files

Hotell
Hotell

Removed duplicate 'Label' from story names (#20269)

  • Removed duplicate 'Label' from story names

  • Change files

Hotell
Hotell

Removed duplicate 'Tooltip' from story names (#20271)

  • Removed duplicate 'Tooltip' from story names

  • Change files

Hotell
Hotell

Removed duplicate 'Badge' from story names (#20265)

  • Removed duplicate 'Badge' from story names

  • Change files

Hotell
Hotell

Removed duplicate 'Divider' from story names (#20267)

  • Removed duplicate 'Divider' from story names

  • Change files

Hotell
Hotell

Removed duplicate 'Image' from story names (#20268)

  • Removed duplicate 'Image' from story names

  • Change files

Hotell
Hotell

remove incorrect extension in splist, add .oft to email (#19982)

  • remove incorrect extension in splist, add .oft to email

  • Change files

Hotell
Hotell

Fix web-components storybook (#20281)

Hotell
Hotell
Hotell
Hotell

docs: improve DX when using new setup for docs with storybook (#20283)

  • chore: use explicit version of dedent which is used for custom logic

  • refactor(.storybook): normalize handling importing fs files and make preview-head explicit to not confuse with default sb behaviour when loading custom preview-head.html

  • feat(typings): improve addons types to get better DX for consumers

  • fix(tools): undo manually adding previewHead as that is already spread from root

Hotell
Hotell

docs(rfcs): add TS solution style config rfc (#19044)

  • docs(rfcs): add ts solution style config rfc

  • Update rfcs/build-system/02-solution-style-ts-configs.md

  • docs(rfcs): tweaks from PR suggestions

Co-authored-by: Elizabeth Craig [email protected]

Hotell
Hotell

fix(Dropdown): fix DropdownSearchInput aria-labelledby (#20312)

  • fix(Dropdown): fix DropdownSearchInput aria-labelledby

  • add changelog

  • add changelog

commit sha: 71da1bbb0f869b1e09adbd0a0aeeba7c1cd2a0ca

push time in 1 day ago
push

Hotell push microsoft/fluentui

Hotell
Hotell

docs(rfcs): add TS solution style config rfc (#19044)

  • docs(rfcs): add ts solution style config rfc

  • Update rfcs/build-system/02-solution-style-ts-configs.md

  • docs(rfcs): tweaks from PR suggestions

Co-authored-by: Elizabeth Craig [email protected]

commit sha: 5fcfc3b0a714a8a8265e2c88d842983021932adc

push time in 1 day ago
pull request

Hotell pull request microsoft/fluentui

Hotell
Hotell

docs(rfcs): add TS solution style config rfc

Pull request checklist

  • ~[ ] Addresses an existing issue:~
  • ~[ ] Include a change request file using $ yarn change~

Description of changes

Focus areas to test

(optional)

Activity icon
issue

Hotell issue comment microsoft/fluentui

Hotell
Hotell

minimize build output

review our current packages (react-components) and create a list of tasks + priorities for RC and after

Hotell
Hotell

insights from @layershifter :

Bundling to a single file will cause problems with tree-shaking rather than fix them 🙄 Files with components/utils could contain unintentional side-effects that cannot be minified by Terser. Currently they are in separate files and will affect bundle only when included, with a single file approach - they will be included anyway 😐 I have seen exactly this problem before in Downshift.

In our code for example, toObjectMap() that we have in fluentui/react-utilities has non-eliminable code after compiling TS to JS: 2021-10-22 at 13 59

(assignment is considered by Terser as not safe operation as I remember)

And these are many other examples. We have babel-plugin-annotate-pure-calls, but I am not sure that it helps with all cases and may require using #PURE in code by devs.


Anyway, we have bundle size tooling that can catch such issues when changes will be implemented.


P.S. I think that bundling to a single file is the right thing, but it could be tricky.

push

Hotell push Hotell/fluentui

Hotell
Hotell

text-field: start/end display flex (#18969)

  • text-field: start/end display flex

ref.: https://github.com/microsoft/fast/pull/4938/commits/ff37847687713b2507bf25bad6ea7aff4d570acb

  • Change files
Hotell
Hotell

Move useTimeout into react-utilities and add tests (#19023)

Move useTimeout from react-tooltip into react-utilities and add tests

Hotell
Hotell

Cherry pick from #18527 and replacing with for Azure Theme (#19006)

Hotell
Hotell

Autofill issues with IME characters (#19008)

Hotell
Hotell

feat(Tooltip): make tooltip subtle by default (#19024)

  • feat(Tooltip): make tooltip subtle by default

  • add changelog

  • Update packages/fluentui/react-northstar/src/components/Tooltip/Tooltip.tsx

Co-authored-by: Oleksandr Fediashov [email protected]

Co-authored-by: Oleksandr Fediashov [email protected]

Hotell
Hotell

react-card: Migrate to new DX (#19036)

Pull request checklist

  • Addresses an existing issue: Fixes partially #18579, fixes #19050
  • Include a change request file using $ yarn change

Description of changes

Migration to new DX for react-card

Hotell
Hotell

feat(react-theme): Update tokens (#19041)

  • rename strokeAccessible* to transparentStroke*

  • change values for neutralForeground4 and neutralForegroundInverted

  • rename neutralForegroundInvertedAccessible to neutralForegroundOnBrand

  • add neutralBackgroundInverted, neutralStencil1 and neutralStencil2 alias tokens

  • Change files

Hotell
Hotell
Hotell
Hotell

chore(react-theme): Add react-theme to CODEOWNERS (#19061)

Hotell
Hotell

bugfix(Button): Focus indicator jump (#19035)

  • Fix button jump effect on border disparities

  • Change files

Hotell
Hotell

fix(Skeleton): update color to proper token (#19057)

  • fix skeleton color

  • add changelog

Hotell
Hotell

Add TSconfigPaths plugin to vr-tests storybook (#19043)

Hotell
Hotell

Migrate storybook to 6.2.9 (#18693)

Pull request checklist

  • Addresses an existing issue: Fixes #18142
  • Include a change request file using $ yarn change

Description of changes

Hotell
Hotell

Use colorScheme for chat variables (#18963)

Hotell
Hotell

Update Tooltip API with visible controlled prop, and onVisibleChange event (#18610)

  • Add visible prop that can be used to control the tooltip's visibility programmatically.
  • Add onVisibleChange event to notify controlled and uncontrolled tooltips when the visibility should change.
  • Replace targetRef with target for specifying the target of the tooltip
  • If target is not specified, use a ref on the child element to determine the target automatically. This replaces the previous method of using the PointerEnter/Focus event's currentTarget prop to determine the target. This was required because now the tooltip can be made visible without a corresponding event.
  • Remove the onlyIfTruncated prop. The functionality can be implemented by using a controlled visible prop. There's an example in Tooltip.stories.tsx.
Hotell
Hotell

Calendar: add border to selected date to fix contrast ratio (#18580)

Pull request checklist

  • Addresses an existing issue: Fixes bug-11672
  • Include a change request file using $ yarn change

Description of changes

  • Add border to selected date in Calendar to fix contrast ratio

image

Hotell
Hotell

Change visuals for tooltip: subtle and noArrow are now the defaults (#19078)

Change visual defaults for tooltip: subtle and noArrow are now the defaults.

Replace subtle prop with inverted, and noArrow with pointing

Hotell
Hotell

Button: Handling children correctly and not as a slot. (#19085)

  • Button: Handling children correctly and not as a slot.

  • Change files

Hotell
Hotell

fix(DetailsList): switch checkbox role to radio for single selection (#18967)

Hotell
Hotell

(web-components) remove incorrectly added toolbar from component definitions (#19087)

  • remove incorrectly added component definition for toolbar

  • Change files

commit sha: 4fde9baa40d74151d8fd25579420910e47b229ce

push time in 2 days ago
push

Hotell push Hotell/fluentui

Hotell
Hotell

docs(rfcs): tweaks from PR suggestions

commit sha: edbc971b0b52e4a30a6946ca13b37857d6e3d368

push time in 2 days ago
open pull request

Hotell wants to merge microsoft/fluentui

Hotell
Hotell

docs(rfcs): add TS solution style config rfc

Pull request checklist

  • ~[ ] Addresses an existing issue:~
  • ~[ ] Include a change request file using $ yarn change~

Description of changes

Focus areas to test

(optional)

Hotell
Hotell

no question is stupid @ling1726 :)

there are no circular issues, this is by design from TS folks

pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

docs(rfcs): add TS solution style config rfc

Pull request checklist

  • ~[ ] Addresses an existing issue:~
  • ~[ ] Include a change request file using $ yarn change~

Description of changes

Focus areas to test

(optional)

open pull request

Hotell wants to merge microsoft/fluentui

Hotell
Hotell

docs(rfcs): add TS solution style config rfc

Pull request checklist

  • ~[ ] Addresses an existing issue:~
  • ~[ ] Include a change request file using $ yarn change~

Description of changes

Focus areas to test

(optional)

Hotell
Hotell

it should not be part of the proposal - rather future plans with proper post processing and autogenerating package.json when publishing via nx. I'll update it to mirror "current" setup.

pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

docs(rfcs): add TS solution style config rfc

Pull request checklist

  • ~[ ] Addresses an existing issue:~
  • ~[ ] Include a change request file using $ yarn change~

Description of changes

Focus areas to test

(optional)

open pull request

Hotell wants to merge microsoft/fluentui

Hotell
Hotell

docs(rfcs): add TS solution style config rfc

Pull request checklist

  • ~[ ] Addresses an existing issue:~
  • ~[ ] Include a change request file using $ yarn change~

Description of changes

Focus areas to test

(optional)

Hotell
Hotell

fixed by @ecraig12345 suggestion. thx folks

pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

docs(rfcs): add TS solution style config rfc

Pull request checklist

  • ~[ ] Addresses an existing issue:~
  • ~[ ] Include a change request file using $ yarn change~

Description of changes

Focus areas to test

(optional)

open pull request

Hotell wants to merge microsoft/fluentui

Hotell
Hotell

docs(rfcs): add TS solution style config rfc

Pull request checklist

  • ~[ ] Addresses an existing issue:~
  • ~[ ] Include a change request file using $ yarn change~

Description of changes

Focus areas to test

(optional)

Hotell
Hotell

what @ecraig12345 said. in future it will be revamped a bit as we might use TS solely for declaration types generation not compilation

pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

docs(rfcs): add TS solution style config rfc

Pull request checklist

  • ~[ ] Addresses an existing issue:~
  • ~[ ] Include a change request file using $ yarn change~

Description of changes

Focus areas to test

(optional)

open pull request

Hotell wants to merge microsoft/fluentui

Hotell
Hotell

docs(rfcs): add TS solution style config rfc

Pull request checklist

  • ~[ ] Addresses an existing issue:~
  • ~[ ] Include a change request file using $ yarn change~

Description of changes

Focus areas to test

(optional)

Hotell
Hotell

updated. ty (it is but this is not the proper solution - ignoring is temporary workaround)

pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

docs(rfcs): add TS solution style config rfc

Pull request checklist

  • ~[ ] Addresses an existing issue:~
  • ~[ ] Include a change request file using $ yarn change~

Description of changes

Focus areas to test

(optional)

push

Hotell push Hotell/fluentui

Hotell
Hotell

Update rfcs/build-system/02-solution-style-ts-configs.md

Co-authored-by: Elizabeth Craig [email protected]

commit sha: 36a14246c87ff0a2935fae1879da37c0ef236eaa

push time in 2 days ago
Activity icon
issue

Hotell issue microsoft/fluentui

Hotell
Hotell

root .storybook/babel.plugin.js deletion breaks VR tests

hmm looks like I'm running into same issue like Peter (https://github.com/microsoft/fluentui/pull/20126) - (VR tests are filing) when deleting the babel.plugin file, meaning it is still probably being used somehow. We'll need to do more investigation which is outside of scope of this PR - thus I'm gonna revert that commit.

2021-10-21 at 18 29

Originally posted by @Hotell in https://github.com/microsoft/fluentui/issues/20283#issuecomment-948781075

Activity icon
delete

Hotell in Hotell/fluentui delete branch hotell/build-system/tweak-sb-docs

deleted time in 2 days ago
Oct
21
3 days ago
push

Hotell push microsoft/fluentui

Hotell
Hotell

docs: improve DX when using new setup for docs with storybook (#20283)

  • chore: use explicit version of dedent which is used for custom logic

  • refactor(.storybook): normalize handling importing fs files and make preview-head explicit to not confuse with default sb behaviour when loading custom preview-head.html

  • feat(typings): improve addons types to get better DX for consumers

  • fix(tools): undo manually adding previewHead as that is already spread from root

commit sha: 1df00258679108cac8425f7832c57f18cfea352d

push time in 2 days ago
pull request

Hotell pull request microsoft/fluentui

Hotell
Hotell

docs: improve DX when using new setup for docs with storybook

Pull request checklist

Description of changes

Focus areas to test

(optional)

Activity icon
issue

Hotell issue comment microsoft/fluentui

Hotell
Hotell

docs: improve DX when using new setup for docs with storybook

Pull request checklist

Description of changes

Focus areas to test

(optional)

Hotell
Hotell

hmm looks like I'm running into same issue like Peter (https://github.com/microsoft/fluentui/pull/20126) when deleting the babel.plugin file, meaning it is still probably being used somehow. We'll need to do more investigation which is outside of scope of this PR - thus I'm gonna revert that commit.

Activity icon
issue

Hotell issue comment microsoft/fluentui

Hotell
Hotell

react-card - Move story into stories folder

Pull request checklist

  • Include a change request file using $ yarn change

Description of changes

Implementation of https://github.com/microsoft/fluentui/pull/19827

Hotell
Hotell

curios why are we doing this as that RFC was not merged ?

push

Hotell push Hotell/fluentui

Hotell
Hotell

chore(.storybook): remove obsolete/unused files

commit sha: a17e2a7f5a26b511568beabbbb3b1459ece3e0f7

push time in 2 days ago
open pull request

Hotell wants to merge microsoft/fluentui

Hotell
Hotell

docs: improve DX when using new setup for docs with storybook

Pull request checklist

Description of changes

Focus areas to test

(optional)

Hotell
Hotell

adding explicitly version which is used for custom logic ( removing hidden dependency )

open pull request

Hotell wants to merge microsoft/fluentui

Hotell
Hotell

docs: improve DX when using new setup for docs with storybook

Pull request checklist

Description of changes

Focus areas to test

(optional)

open pull request

Hotell wants to merge microsoft/fluentui

Hotell
Hotell

docs: improve DX when using new setup for docs with storybook

Pull request checklist

Description of changes

Focus areas to test

(optional)

Hotell
Hotell

this was TS error before ( we don't have synthetic default imports enabled )

pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

docs: improve DX when using new setup for docs with storybook

Pull request checklist

Description of changes

Focus areas to test

(optional)

Previous