Hotell

Hotell

I skate, surf, wake, snow and open source 🏄‍♂️ @Microsoft MVP, GDE

Member Since 10 years ago

@microsoft , Prague, Czech Republic

Experience Points
362
follower
Lessons Completed
16
follow
Lessons Completed
330
stars
Best Reply Awards
82
repos

507 contributions in the last year

Pinned
⚡ Angular 2 decorators and utils for Angular 1.x
⚡ Typescript library starter
⚡ Static analysis for Angular projects.
⚡ my blog posts published on medium + code samples
⚡ Type safe utils for redux actions, epics, effects, react/preact default props, various type guards and TypeScript utils, React util components
⚡ Dependency injection for React done right. Hierarchical injection on both component and service layer powered by injection-js (Angular DI framework) 🖖
Activity
Nov
26
3 days ago
pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

chore: migrate @fluentui/react-components

Pull request checklist

  • Addresses an existing issue: related to #20597
  • Include a change request file using $ yarn change

Description of changes

  • Ran generator
  • Restored change in package.json#scripts.storybook
  • Hacked generator to emit proper configs (#20748)
  • Restored changes in packages/react-components/.storybook/preview.js (#20750)
  • Restored changes and fixed packages/react-components/config/api-extractor.local.json
open pull request

Hotell wants to merge microsoft/fluentui

Hotell
Hotell

chore: migrate @fluentui/react-components

Pull request checklist

  • Addresses an existing issue: related to #20597
  • Include a change request file using $ yarn change

Description of changes

  • Ran generator
  • Restored change in package.json#scripts.storybook
  • Hacked generator to emit proper configs (#20748)
  • Restored changes in packages/react-components/.storybook/preview.js (#20750)
  • Restored changes and fixed packages/react-components/config/api-extractor.local.json
Hotell
Hotell

lets wait for https://github.com/microsoft/fluentui/pull/20797 . My bad I should explicitly mention that this package should be migrated after all dependant packages

pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

chore: migrate @fluentui/react-components

Pull request checklist

  • Addresses an existing issue: related to #20597
  • Include a change request file using $ yarn change

Description of changes

  • Ran generator
  • Restored change in package.json#scripts.storybook
  • Hacked generator to emit proper configs (#20748)
  • Restored changes in packages/react-components/.storybook/preview.js (#20750)
  • Restored changes and fixed packages/react-components/config/api-extractor.local.json
pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

chore: run migration for @fluentui/make-styles

Pull request checklist

  • Addresses an existing issue: related to #20597
  • Include a change request file using $ yarn change

Description of changes

  • Ran generator
  • Removed .storybook and related package.json#scripts (the same as #20724)
Activity icon
issue

Hotell issue comment microsoft/fluentui

Hotell
Hotell

chore: run migration for @fluentui/make-styles

Pull request checklist

  • Addresses an existing issue: related to #20597
  • Include a change request file using $ yarn change

Description of changes

  • Ran generator
  • Removed .storybook and related package.json#scripts (the same as #20724)
Hotell
Hotell

@Hotell should I also exclude it in tsconfig.lib.json? If so, common does not have much sense 🤔

yes pls, 2021-11-26 at 14 14

I'll update the generator so it will do it for you next time. thx!

pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

chore: Migrate package @fluentui/react-storybook-addon

Pull request checklist

  • Addresses an existing issue: #20597
  • ~Include a change request file using $ yarn change~

Description of changes

Ran migrate-converged-pkg for the @fluentui/react-storybook-addon package.

Activity icon
issue

Hotell issue comment microsoft/fluentui

Hotell
Hotell

fix(tools): add check for make-styles pkg name

Pull request checklist

  • Addresses an existing issue: Fixes #20743, #20727 ~- [ ] Include a change request file using $ yarn change~

Description of changes

  • whenever package name contains make-styles related dependencies and babel plugins wont be added
  • added a check so that it does not allow to add module:@fluentui/babel-make-styles if the package has the same name and test for it.
pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

Added check for make-styles pkg name

Pull request checklist

  • Addresses an existing issue: Fixes #20743, #20727 ~- [ ] Include a change request file using $ yarn change~

Description of changes

Added a check so that it does not allow to add module:@fluentui/babel-make-styles if the package has the same name and test for it.

Hotell
Hotell

great job TY!

open pull request

Hotell wants to merge microsoft/fluentui

Hotell
Hotell

chore: Migrate package @fluentui/react-storybook-addon

Pull request checklist

  • Addresses an existing issue: #20597
  • ~Include a change request file using $ yarn change~

Description of changes

Ran migrate-converged-pkg for the @fluentui/react-storybook-addon package.

Hotell
Hotell
  addons: ['../preset.js', ...rootMain.addons],
pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

chore: Migrate package @fluentui/react-storybook-addon

Pull request checklist

  • Addresses an existing issue: #20597
  • ~Include a change request file using $ yarn change~

Description of changes

Ran migrate-converged-pkg for the @fluentui/react-storybook-addon package.

Activity icon
issue

Hotell issue comment microsoft/fluentui

Hotell
Hotell

chore: run migration for @fluentui/make-styles

Pull request checklist

  • Addresses an existing issue: related to #20597
  • Include a change request file using $ yarn change

Description of changes

  • Ran generator
  • Removed .storybook and related package.json#scripts (the same as #20724)
Hotell
Hotell

updated original message ^ , thx!

Activity icon
issue

Hotell issue comment microsoft/fluentui

Hotell
Hotell

chore: run migration for @fluentui/make-styles

Pull request checklist

  • Addresses an existing issue: related to #20597
  • Include a change request file using $ yarn change

Description of changes

  • Ran generator
  • Removed .storybook and related package.json#scripts (the same as #20724)
Hotell
Hotell

to get a proper solution, can you give us context what's the purpose of this module ?

2021-11-26 at 12 41

I don't see it being used at all, nor exported

Activity icon
issue

Hotell issue comment microsoft/fluentui

Hotell
Hotell

Housekeeping workflow - Add labeler

Why

In an effort to start automating monotonous labeling and organizational tasks, I'm introducing a labeler check to automatically add the label Type: RFC for any PR that contains an .md file in the root rfcs folder. The plan is to later on extend this to automate all the things 🧹🙋.

How

This uses Github's labeler action to add the said label based on a glob defined in the labeler.yml on the root of the .github folder. pr-housekeeping.yml defines the Github check to be run when the PR is created. The pull_request_target trigger is a special trigger that allows for actions to have write permission on the issues, without compromising our workflows if changed by a PR. This special trigger always runs the code from the main branch and is therefore the reason the action is not run on this PR but will be for all future ones after merging. I go a little bit more in depth in PR #19185, in case you want to read more about it.

pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

chore: Migrate package @fluentui/react-storybook-addon

Pull request checklist

  • Addresses an existing issue: #20597
  • ~Include a change request file using $ yarn change~

Description of changes

Ran migrate-converged-pkg for the @fluentui/react-storybook-addon package.

open pull request

Hotell wants to merge microsoft/fluentui

Hotell
Hotell

chore: Migrate package @fluentui/react-storybook-addon

Pull request checklist

  • Addresses an existing issue: #20597
  • ~Include a change request file using $ yarn change~

Description of changes

Ran migrate-converged-pkg for the @fluentui/react-storybook-addon package.

Hotell
Hotell

pls add back '../preset.js', this is special setting for this package

pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

chore: Migrate package @fluentui/react-storybook-addon

Pull request checklist

  • Addresses an existing issue: #20597
  • ~Include a change request file using $ yarn change~

Description of changes

Ran migrate-converged-pkg for the @fluentui/react-storybook-addon package.

pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

chore: Migrate package @fluentui/react-storybook-addon

Pull request checklist

  • Addresses an existing issue: #20597
  • ~Include a change request file using $ yarn change~

Description of changes

Ran migrate-converged-pkg for the @fluentui/react-storybook-addon package.

Activity icon
issue

Hotell issue comment microsoft/fluentui

Hotell
Hotell

chore: Migrate package @fluentui/react-storybook-addon

Pull request checklist

  • Addresses an existing issue: #20597
  • ~Include a change request file using $ yarn change~

Description of changes

Ran migrate-converged-pkg for the @fluentui/react-storybook-addon package.

Hotell
Hotell

pipeline failing 2021-11-26 at 12 27

once fixed LGTM

Activity icon
issue

Hotell issue microsoft/fluentui

Hotell
Hotell

dependencies: use single version policy for axe-core

Hope you don't mind, I pushed an update merging with master and de-duping axe-core versions (and some other modified deps) as much as possible.

react-builder still references axe-core 3, and ideally that should be updated as well, but it looks like some additional work would be required.

Originally posted by @ecraig12345 in https://github.com/microsoft/fluentui/issues/20609#issuecomment-974473317

Nov
25
4 days ago
pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

migrate-package-generator - Don't add start scripts to node packages

Pull request checklist

  • Addresses an existing issue: Fixes #20745
  • ~Include a change request file using $ yarn change~

Description of changes

Moved helper function getScopedPkgName up in the hierarchy to reuse with my test. Added test and code to remove start scripts for node packages.

Focus areas to test

Migration on node packages

@fluentui/babel-make-styles image

@fluentui/jest-serializer-make-styles image

Migration on web packages

@fluentui/react-button image

pull request

Hotell merge to microsoft/fluentui

Hotell
Hotell

fix: Revert to node 12

Pull request checklist

  • Addresses an existing issue: Fixes #20774
  • Include a change request file using $ yarn change

Description of changes

Reverted CI node version back to 12. Version 14 errors when building @fluentui/react-icons-mdl2. Removed usage of the plugin @rnx-kit/eslint-plugin as it requires node v14.

Hotell
Hotell

great findings regarding v8! thx

can we create an issue to re-add this plugin as well?

push

Hotell push microsoft/fluentui

Hotell
Hotell

style(tools): remove console.log leftovers (#20778)

commit sha: 2d1fae300514ba6889c61fe1528640067bb581d8

push time in 3 days ago
Activity icon
delete

Hotell in Hotell/fluentui delete branch hotell/build-tools/remove-concsolelog-leftovers

deleted time in 3 days ago
pull request

Hotell pull request microsoft/fluentui

Hotell
Hotell

style(tools): remove console.log leftovers

Pull request checklist

  • ~[ ] Addresses an existing issue: Fixes ~
  • ~[ ] Include a change request file using $ yarn change~

Description of changes

Focus areas to test

(optional)

Activity icon
issue

Hotell issue comment microsoft/fluentui

Hotell
Hotell

"@rnx-kit/eslint-plugin" is breaking lint pipelines

Describe the issue:

yarn workspace nx-workspace-tools lint

throws error

2021-11-25 at 10 25

Caused by https://github.com/microsoft/fluentui/pull/20665/files#diff-691525462f8b4cac47c3c2e0e2668606f539ed0b3f62f8f6b79dffe7ef38bd9dR15

  • this is caused as that plugin ships non transpiled code -> optional chaining operator
pull request

Hotell pull request microsoft/fluentui

Hotell
Hotell

style(tools): remove console.log leftovers

Pull request checklist

  • ~[ ] Addresses an existing issue: Fixes ~
  • ~[ ] Include a change request file using $ yarn change~

Description of changes

Focus areas to test

(optional)

push

Hotell push Hotell/fluentui

Hotell
Hotell

style(tools): remove console.log leftovers

commit sha: 5bf30bca80feec59864b95d0c7837f9ffa599c71

push time in 3 days ago
Activity icon
created branch

Hotell in Hotell/fluentui create branch hotell/build-tools/remove-concsolelog-leftovers

createdAt 3 days ago
Activity icon
issue

Hotell issue microsoft/fluentui

Hotell
Hotell

"@rnx-kit/eslint-plugin" is breaking lint pipelines

Describe the issue:

yarn workspace nx-workspace-tools lint

throws error

2021-11-25 at 10 25

Caused by https://github.com/microsoft/fluentui/pull/20665/files#diff-691525462f8b4cac47c3c2e0e2668606f539ed0b3f62f8f6b79dffe7ef38bd9dR15

  • this is caused as that plugin ships non transpiled code -> optional chaining operator
Activity icon
delete

Hotell in Hotell/fluentui delete branch hotell/build-system/20748

deleted time in 3 days ago