julianlam

julianlam

Member Since 10 years ago

NodeBB Inc., Toronto, Ontario, Canada

Experience Points
180
follower
Lessons Completed
7
follow
Lessons Completed
83
stars
Best Reply Awards
143
repos

1331 contributions in the last year

Pinned
⚡ Javascript object that allows you to enhance a plain old textbox with "tab" behaviour.
⚡ NodeBB Plugin that allows users to login/register via any configured OAuth provider.
⚡ Allows login sessions from your app to persist in NodeBB
⚡ A Markdown parser for NodeBB
⚡ Single Sign-On Plugin for NodeBB
⚡ Full-text searching for NodeBB using Apache Solr
Activity
Oct
22
1 day ago
push

julianlam push NodeBB/NodeBB

julianlam
julianlam

refactor: simplified utilities API > login rout

Removed continueLogin override in favour of a simpler redirectAfterLogin override Use passport to authenticate username and password instead of duplicated logic.

julianlam
julianlam

test: fix broken openapi3 schema

commit sha: 7ef5214ef912bb9bd0eaead458d115ff497e3a84

push time in 1 day ago
push

julianlam push NodeBB/NodeBB

julianlam
julianlam

feat: utilities login API route now starts an actual login session, if requested

julianlam
julianlam

feat: new plugin hook to allow plugins to reject email address on new registration or email change

commit sha: 6b4f35c2fab7e64357db5220e73127bfe98a15f8

push time in 1 day ago
Activity icon
created branch

julianlam in NodeBB/NodeBB create branch session-on-api-login

createdAt 1 day ago
Oct
21
2 days ago
Activity icon
issue

julianlam issue julianlam/nodebb-plugin-session-sharing

julianlam
julianlam

Verify User throws error for Banned users

Now that banned users can still login and are just in a banned group (with reduced privileges) does the banned error need to be thrown?

https://github.com/julianlam/nodebb-plugin-session-sharing/blob/bf94e60d23c41f48c77980ced441d195e0b43824/library.js#L208-L222

Should the isBanned check be called still (to update banned status?) or just remove it all? Ive got a upcoming PR with this fix but not sure if isBanned should stay before submitting.

Activity icon
issue

julianlam issue julianlam/nodebb-plugin-session-sharing

julianlam
julianlam

Socket admin.user.search doesnt exist in 1.17.1

In Nodebb 1.17.1 the socket admin.user.search is no longer implemented so searching by usernames in session sharing admin field fails.

https://github.com/julianlam/nodebb-plugin-session-sharing/blob/bf94e60d23c41f48c77980ced441d195e0b43824/static/lib/admin.js#L38

In an upcoming PR I've replaced the socket call with xhr call to /api/admin/manage/users? which seems to work (coied from users admin page search. Is their another option to make this call which would be better?

Activity icon
issue

julianlam issue julianlam/nodebb-plugin-session-sharing

julianlam
julianlam

Update plugin to use async await

We use a slightly customized version of this plugin and since upgrading to 1.17.1, I've started to hate writing/seeing callback code 😆

I've updated our version to async await and have a PR waiting with those changes if you want them?

Oct
20
3 days ago
push

julianlam push NodeBB-Community/nodebb-plugin-codepen

julianlam
julianlam

refactor: fix regex not matching, updated embed code, updated script inclusion logic

commit sha: c53a9c7a334d01a08d6ed024995d2ee1fc9e597d

push time in 3 days ago
push

julianlam push NodeBB/docs

julianlam
julianlam

feat: new page on nodebb-plugin-quickstart, re-organized some pages a bit

commit sha: 371370b080acbc97b79782f1cb3062807554054a

push time in 3 days ago
push

julianlam push NodeBB/NodeBB

julianlam
julianlam

feat: additional quality options for jpeg uploads, added quality and compression settings for png uploads

commit sha: d22b076b2eeffd401cc6decb060f8eda8854562a

push time in 3 days ago
Oct
19
4 days ago
push

julianlam push NodeBB/NodeBB

julianlam
julianlam

test: restore commented-out i18n test

commit sha: fa1afbcf4a0c007473377b6d11409cbc47427555

push time in 4 days ago
push

julianlam push NodeBB/NodeBB

julianlam
julianlam

fix: restore plugin upgrade checking logic

unintended regression from ac86937c8879a20931db3e9a54d86a89ade566ec

commit sha: 44687394dc7c77bbe5ed1f48545aeb0adbbd1e6c

push time in 4 days ago
Oct
18
5 days ago
Activity icon
created tag
createdAt 5 days ago
Activity icon
issue

julianlam issue NodeBB/nodebb-theme-persona

julianlam
julianlam

Taskbar should line up icons on the right hand side of the screen

Makes more sense as it is dead space on wide-screen monitors.

It would intrude on text on narrower screens, but the same could already be said of the taskbar at current.

Activity icon
issue

julianlam issue NodeBB/nodebb-theme-persona

julianlam
julianlam

Taskbar appears above mobile composer

Looks like a regression from b306d27c1d72ea49ca4e311d702d2962c5b4e639

Activity icon
issue

julianlam issue NodeBB/nodebb-theme-persona

julianlam
julianlam

Taskbar should line up icons on the right hand side of the screen

Makes more sense as it is dead space on wide-screen monitors.

It would intrude on text on narrower screens, but the same could already be said of the taskbar at current.

Activity icon
issue

julianlam issue NodeBB/nodebb-theme-persona

julianlam
julianlam

Taskbar appears above mobile composer

Looks like a regression from b306d27c1d72ea49ca4e311d702d2962c5b4e639

Activity icon
issue

julianlam issue comment NodeBB/NodeBB

julianlam
julianlam

Run nodebb docker process under node user

Closes #9888

julianlam
julianlam

Thanks for the context @oplik0

Perhaps we can just keep on using the node user then

Previous