kirill-konshin

kirill-konshin

Member Since 9 years ago

RingCentral, Inc., San Mateo, California, US

Experience Points
87
follower
Lessons Completed
0
follow
Lessons Completed
40
stars
Best Reply Awards
84
repos

49 contributions in the last year

Pinned
⚡ Redux wrapper for Next.js
⚡ Server & middleware for React + Router + Redux with Server Side Rendering
⚡ A simple JS Mutex library that works both in browser and NodeJS.
⚡ Pure react with dynamic imports in the browser
⚡ Image Preloader for React & React Virtualized
⚡ React Server Side Rendering Playground
Activity
Dec
2
1 day ago
Activity icon
issue

kirill-konshin issue mui-org/material-ui

kirill-konshin
kirill-konshin

createGenerateClassName in Material UI v5

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

What's the proper alternative to legacy https://mui.com/styles/api/#creategenerateclassname-options-class-name-generator if @mui/styles package is not used, and all styles are created via MUI System (sx)?

By default all classes (even on production) are prefixed with Mui and css which may become a problem if multiple MUI apps are on the same page (Module Federation especially):

image

Expected behavior 🤔

Documentation is only available for legacy implementation, I've scanned the whole site, including migration instructions, and found no docs related to how to do it properly.

Steps to reproduce 🕹

Steps:

  1. Open https://codesandbox.io/s/material-ui-issue-latest-s2dsx
  2. Check the devtools:
<p class="MuiTypography-root MuiTypography-body1 css-ahj2mt-MuiTypography-root">MUI example. Please put the code to reproduce the issue in src/Demo.js</p>

Context 🔦

I need to have 2 (or more) Material-UI based apps (potentially with different versions) on the same page w/o clashing styles.

Your environment 🌎

`npx @mui/envinfo`
@emotion/react latest (11.7.0)
@emotion/styled latest (11.6.0)
@mui/material latest (5.2.2)
react latest (17.0.2)
react-dom latest (17.0.2)
Nov
30
3 days ago
Activity icon
issue

kirill-konshin issue comment mui-org/material-ui

kirill-konshin
kirill-konshin

Nested theme providers not working correctly when used with webpack module federation

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Two ThemeProviders are nested. One is the outer and spans the whole Application tree, setting primary color to green the other one is nested into it, setting primary color to hotpink. I also have two buttons - one inside the outer ThemeProvider, sibling to the inner ThemeProvider, the other inside the inner ThemeProvider.

A little like this:

<ThemeProvider theme={/* green primary */}>
  <Button color="primary">should always be green</Button>
  <ThemeProvider theme={/* hotpink primary */}>
    <Button color="primary">should always be hotpink</Button>
  </ThemeProvider>
</ThemeProvider>

However, the inner ThemeProvider is asynchronously loaded, using webpack module federation (not sure if this even matters, it's a rather basic React.lazy think, lazy loading a webpack chunk). However, it is coming from a different application - so there might be something about "seed" that i don't get here.

What happens ins that as long as only the outer ThemeProvider is rendered, the Button that should be green is green. Once the inner ThemeProvider is loaded and rendered aswell, the outer Button switches to hotpink and thus has the same color as the inner Button - which it shouldn't.

Expected Behavior 🤔

Outer Button stays green.

Steps to Reproduce 🕹

Not easily reproducible on codesandbox due to module federation.

This is the commit with the reproduction: https://github.com/codepunkt/react-microfrontend-eval/commit/b5e9284cadc9bf964442c0ed191530edc4dcca6c

Steps:

  1. Clone
  2. Switch to commit
  3. Run "yarn" in toplevel folder
  4. Change directory to "federation" folder
  5. Run "yarn start" in federation folder
  6. See problem in effect on localhost:3000

Your Environment 🌎

Tech Version
Material-UI v4.11.0
React v16.13.1
Browser Any
TypeScript v3.9.6, should not be related
kirill-konshin
kirill-konshin

I've spent some time playing around with two versions on the same page: https://codesandbox.io/s/material-ui-module-federation-5j8kp — it works, but I had to set requiredVersion: * for the remote app, otherwise hook warning was thrown despite React was installed with same versions on both host and remote.

Nov
29
4 days ago
Activity icon
issue

kirill-konshin issue comment mui-org/material-ui

kirill-konshin
kirill-konshin

Unable to find required version for "react" in description file

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Screen Shot 2020-12-14 at 5 19 19 AM

Expected Behavior 🤔

Should have any warnigns

Steps to Reproduce 🕹

Install latest webpack with recommended setup

"@material-ui/core": "5.0.0-alpha.19",
"webpack": "5.10.1"
 module: {
      rules: [
        {
          test: /\.m?js$/,
          type: 'javascript/auto',
          resolve: {
            fullySpecified: false,
          },
        },
}

Context 🔦

It seems that adding the package.json to the submodules cause some warnings with the latest Webpack

{
  "sideEffects": false,
  "module": "./index.js",
  "main": "../node/useTheme/index.js",
  "types": "./index.d.ts"
}
kirill-konshin
kirill-konshin

@oliviertassinari please help to solve this... getting Module Federation warnings while simply using MUI is a distraction for dev experience.

Nov
24
1 week ago
Activity icon
issue

kirill-konshin issue comment mui-org/material-ui

kirill-konshin
kirill-konshin

Nested theme providers not working correctly when used with webpack module federation

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Two ThemeProviders are nested. One is the outer and spans the whole Application tree, setting primary color to green the other one is nested into it, setting primary color to hotpink. I also have two buttons - one inside the outer ThemeProvider, sibling to the inner ThemeProvider, the other inside the inner ThemeProvider.

A little like this:

<ThemeProvider theme={/* green primary */}>
  <Button color="primary">should always be green</Button>
  <ThemeProvider theme={/* hotpink primary */}>
    <Button color="primary">should always be hotpink</Button>
  </ThemeProvider>
</ThemeProvider>

However, the inner ThemeProvider is asynchronously loaded, using webpack module federation (not sure if this even matters, it's a rather basic React.lazy think, lazy loading a webpack chunk). However, it is coming from a different application - so there might be something about "seed" that i don't get here.

What happens ins that as long as only the outer ThemeProvider is rendered, the Button that should be green is green. Once the inner ThemeProvider is loaded and rendered aswell, the outer Button switches to hotpink and thus has the same color as the inner Button - which it shouldn't.

Expected Behavior 🤔

Outer Button stays green.

Steps to Reproduce 🕹

Not easily reproducible on codesandbox due to module federation.

This is the commit with the reproduction: https://github.com/codepunkt/react-microfrontend-eval/commit/b5e9284cadc9bf964442c0ed191530edc4dcca6c

Steps:

  1. Clone
  2. Switch to commit
  3. Run "yarn" in toplevel folder
  4. Change directory to "federation" folder
  5. Run "yarn start" in federation folder
  6. See problem in effect on localhost:3000

Your Environment 🌎

Tech Version
Material-UI v4.11.0
React v16.13.1
Browser Any
TypeScript v3.9.6, should not be related
kirill-konshin
kirill-konshin

@oliviertassinari friendly reminder about the module federation and multiple versions of MUI on the same page. Is there a workaround?

Nov
22
1 week ago
Activity icon
issue

kirill-konshin issue comment webpack/webpack

kirill-konshin
kirill-konshin

Undetermined shared module version when importing a file from the module directly

Bug report

What is the current behavior?

When importing a file directly from a module (i.e. import "react-dom/test-utils") when it's configured to be shared via ModuleFedrationPlugin a warning with a nonsensical instruction may be emitted when running a build:

WARNING in shared module react-dom
No required version specified and unable to automatically determine one. Unable to find required version for "react-dom" in description file (/home/user/test/node_modules/react-dom/package.json). It need to be in dependencies, devDependencies or peerDependencies.

If the current behavior is a bug, please provide the steps to reproduce.

Using the following webpack config

"use strict";
const path = require("path");
const webpack = require("webpack");


module.exports = (env = {}) => ({
    entry: "./index.js",
    output: {
        publicPath: "auto",
        filename: "bundle.js",
        path: path.resolve(__dirname, "dist"),
    },
    mode: "production",
    plugins: [
        new webpack.container.ModuleFederationPlugin({
            name: "test",
            shared: {
                "react-dom": { singleton: true },
            },
        }),
    ],
});

And an index.js file with the content

import "react-dom/test-utils"

Along with a package.json file with the dependencies described in reproduces the behaviour. See the complete example in this repository.

What is the expected behavior?

I expect either the version of react-dom to be correctly deduced from package.json or a sensible warning/error message.

Other relevant information: webpack version: 5.37.1 Node.js version: 16.0.0 Operating System: Arch Linux Additional tools:

Nov
16
2 weeks ago
Activity icon
issue

kirill-konshin issue comment google/mediapipe

kirill-konshin
kirill-konshin

Is there any way to run MediaPipe in my own web app today?

Is there any way to run MediaPipe in my own web app today?

The primary MediaPipe GitHub page links to this page: MediaPipe on the Web, which, in turn, links to this page: MediaPipe graphs, which is broken.

Has anyone been able to successfully integrate MediaPipe into their own web app?

kirill-konshin
kirill-konshin

@sgowroji what about making custom builds/solutions, it still seems to be not impossible...

Nov
15
2 weeks ago
Activity icon
published release 0.8.9
createdAt 2 weeks ago
pull request

kirill-konshin pull request ringcentral/ringcentral-web-phone

kirill-konshin
kirill-konshin

Call Control Improvements

  1. Bug fixe - closes issue #339
  2. Configurations for enabling and adding support for turnServers
push

kirill-konshin push ringcentral/ringcentral-web-phone

kirill-konshin
kirill-konshin

Call Control Improvements (#340)

  • Modify SIP INFO response to only resolved with same command as the SIP INFO request
  • fix log issue
  • Bump WebPhone version to 0.8.9
  • Add optional turnServer support
  • bugfix - undefined
  • introduce IceCheckingTimeout config param
  • introduce iceTransportPolicy config param
  • Config to enable turn server

Co-authored-by: Jimmy Xu [email protected]

commit sha: ba97715ba555655bcb1efb2271aafbbc9bf7cac1

push time in 2 weeks ago
Nov
11
3 weeks ago
Activity icon
issue

kirill-konshin issue comment mui-org/material-ui

kirill-konshin
kirill-konshin

Nested theme providers not working correctly when used with webpack module federation

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Two ThemeProviders are nested. One is the outer and spans the whole Application tree, setting primary color to green the other one is nested into it, setting primary color to hotpink. I also have two buttons - one inside the outer ThemeProvider, sibling to the inner ThemeProvider, the other inside the inner ThemeProvider.

A little like this:

<ThemeProvider theme={/* green primary */}>
  <Button color="primary">should always be green</Button>
  <ThemeProvider theme={/* hotpink primary */}>
    <Button color="primary">should always be hotpink</Button>
  </ThemeProvider>
</ThemeProvider>

However, the inner ThemeProvider is asynchronously loaded, using webpack module federation (not sure if this even matters, it's a rather basic React.lazy think, lazy loading a webpack chunk). However, it is coming from a different application - so there might be something about "seed" that i don't get here.

What happens ins that as long as only the outer ThemeProvider is rendered, the Button that should be green is green. Once the inner ThemeProvider is loaded and rendered aswell, the outer Button switches to hotpink and thus has the same color as the inner Button - which it shouldn't.

Expected Behavior 🤔

Outer Button stays green.

Steps to Reproduce 🕹

Not easily reproducible on codesandbox due to module federation.

This is the commit with the reproduction: https://github.com/codepunkt/react-microfrontend-eval/commit/b5e9284cadc9bf964442c0ed191530edc4dcca6c

Steps:

  1. Clone
  2. Switch to commit
  3. Run "yarn" in toplevel folder
  4. Change directory to "federation" folder
  5. Run "yarn start" in federation folder
  6. See problem in effect on localhost:3000

Your Environment 🌎

Tech Version
Material-UI v4.11.0
React v16.13.1
Browser Any
TypeScript v3.9.6, should not be related
kirill-konshin
kirill-konshin

@oliviertassinari

I would also @emotion/core make a singleton. @material-ui/styles will hopefully soon be gone in v5. Regarding @material-ui/core, there are definitely a few singletons, like ModalManager, component context providers, e.g. TextField.

What's the recommended way in case I do want to have 2 different versions (and themes) in host and federated app? Looks like any time app calls MUI hooks, it fails with https://reactjs.org/warnings/invalid-hook-call-warning.html, if I make @material-ui/core singleton error is gone.

Activity icon
issue

kirill-konshin issue comment webmachinelearning/model-loader

kirill-konshin
kirill-konshin

Is there any code that can be downloaded/imported?

It does not seem that download links exist anywhere in the draft https://webmachinelearning.github.io/model-loader/ or in the repo. Where can I get the code to run the example?

kirill-konshin
kirill-konshin

I think discussion in this issue has been valuable, so thanks @kirill-konshin for your questions and feedback to date! We hope to get your further feedback when there’s soon running code to experiment with.

I'm happy to be useful.

Nov
9
3 weeks ago
Activity icon
issue

kirill-konshin issue comment fabricjs/fabric.js

kirill-konshin
kirill-konshin

Unable to get true coordinates / angle when objects are selected and modified

Version

3.6.0

Test Case

http://jsfiddle.net/9x7hrf2y/17/

Steps to reproduce

Use the code in JS Fiddle and rotate the selection.

Expected Behavior

Console logged angles should be the same

Actual Behavior

Since lines are part of activeSelection group, which has angle their own angles are 0.

As you can see in the fiddle, I tried to make JSON of the entire canvas and get position from there, it kinda works, but looks awkward because I have to find the needed object in the pile of JSON.

What is the reliable method to get true object position after modification but while selection is not cleared?

kirill-konshin
kirill-konshin

@asturur thank you! And in case of nested groups this has to be called recursively, I presume?

Nov
7
3 weeks ago
Activity icon
issue

kirill-konshin issue comment kirill-konshin/next-redux-wrapper

kirill-konshin
kirill-konshin

Client side state is not available in server side.

When the state is updated in getServerSideProps or in getStaticProps, the HYDRATE action is called on client side to sync it with server side state, however the opposite is not happening. The server instance of the store always gets the initial state, not the client side state. What should be done in order to access client side state in getServerSideProps to render the page based on that state ?

kirill-konshin
kirill-konshin

It is completely out of scope of this package. You can sync state back to server by doing API calls and or using something like Yjs. Server state is only a seed to speed up client side initial rendering, nothing more. Documentation refers only to that initial rendering on client side when client state is indeed the same as server had.

Activity icon
issue

kirill-konshin issue kirill-konshin/next-redux-wrapper

kirill-konshin
kirill-konshin

Client side state is not available in server side.

When the state is updated in getServerSideProps or in getStaticProps, the HYDRATE action is called on client side to sync it with server side state, however the opposite is not happening. The server instance of the store always gets the initial state, not the client side state. What should be done in order to access client side state in getServerSideProps to render the page based on that state ?

Activity icon
issue

kirill-konshin issue comment kirill-konshin/next-redux-wrapper

kirill-konshin
kirill-konshin

Client side state is not available in server side.

When the state is updated in getServerSideProps or in getStaticProps, the HYDRATE action is called on client side to sync it with server side state, however the opposite is not happening. The server instance of the store always gets the initial state, not the client side state. What should be done in order to access client side state in getServerSideProps to render the page based on that state ?

kirill-konshin
kirill-konshin

Not a big. Server side state is always initial, client side state is not synced back to server by design.

Activity icon
issue

kirill-konshin issue comment fabricjs/fabric.js

kirill-konshin
kirill-konshin

Unable to get true coordinates / angle when objects are selected and modified

Version

3.6.0

Test Case

http://jsfiddle.net/9x7hrf2y/17/

Steps to reproduce

Use the code in JS Fiddle and rotate the selection.

Expected Behavior

Console logged angles should be the same

Actual Behavior

Since lines are part of activeSelection group, which has angle their own angles are 0.

As you can see in the fiddle, I tried to make JSON of the entire canvas and get position from there, it kinda works, but looks awkward because I have to find the needed object in the pile of JSON.

What is the reliable method to get true object position after modification but while selection is not cleared?

kirill-konshin
kirill-konshin

Not stale! And still no resolution!

Nov
5
4 weeks ago
Activity icon
issue

kirill-konshin issue comment mui-org/material-ui

kirill-konshin
kirill-konshin

Unable to find required version for "react" in description file

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Screen Shot 2020-12-14 at 5 19 19 AM

Expected Behavior 🤔

Should have any warnigns

Steps to Reproduce 🕹

Install latest webpack with recommended setup

"@material-ui/core": "5.0.0-alpha.19",
"webpack": "5.10.1"
 module: {
      rules: [
        {
          test: /\.m?js$/,
          type: 'javascript/auto',
          resolve: {
            fullySpecified: false,
          },
        },
}

Context 🔦

It seems that adding the package.json to the submodules cause some warnings with the latest Webpack

{
  "sideEffects": false,
  "module": "./index.js",
  "main": "../node/useTheme/index.js",
  "types": "./index.d.ts"
}
kirill-konshin
kirill-konshin

@kirill-konshin that was actually my environment as well :D

https://github.com/straw-hat-team/react-admin looks like the link is dead, maybe it's worth to put it back, if @oliviertassinari will decide to reopen this ticket.

Activity icon
issue

kirill-konshin issue comment mui-org/material-ui

kirill-konshin
kirill-konshin

Unable to find required version for "react" in description file

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Screen Shot 2020-12-14 at 5 19 19 AM

Expected Behavior 🤔

Should have any warnigns

Steps to Reproduce 🕹

Install latest webpack with recommended setup

"@material-ui/core": "5.0.0-alpha.19",
"webpack": "5.10.1"
 module: {
      rules: [
        {
          test: /\.m?js$/,
          type: 'javascript/auto',
          resolve: {
            fullySpecified: false,
          },
        },
}

Context 🔦

It seems that adding the package.json to the submodules cause some warnings with the latest Webpack

{
  "sideEffects": false,
  "module": "./index.js",
  "main": "../node/useTheme/index.js",
  "types": "./index.d.ts"
}
kirill-konshin
kirill-konshin

I suggest to reopen because this issue emits a ton of errors and with [email protected] all of these errors are dumped to browser.

I've stumbled upon this issue when I was using Webpack Module Federation.

Activity icon
issue

kirill-konshin issue comment robdonn/storybook-module-federation

kirill-konshin
kirill-konshin

TypeError: Cannot read property 'map' of undefined

Hello o/

I'm trying to "module federationize" my Storybook. it uses Style9, which works normally, but I need a webpackFinal object in my config. If I remove that object from the storyBookConfig constant, the storybook app compiles, and the app importing the components is able to find them. But since Style9 is not compiling anything, nothing works. If i keep my webpackFinal object, then the storyapp doesn't compile, and I get this error:

ERR! TypeError: Cannot read property 'map' of undefined ERR! at Object.webpackFinal (/Users/camila.paschini/Developer/Platform-Phoenix-UI/node_modules/storybook-module-federation/dist/main.js:46:26)

Here's the constants i'm using:

const storybookConfig = {
  core: {
    builder: 'webpack5',
  },
  stories: [
    "../src/main/javascript/**/*.stories.mdx",
    "../src/main/javascript/**/*[email protected](js|jsx|ts|tsx)"
  ],
  addons: ["@storybook/addon-links", "@storybook/addon-essentials"],

  webpackFinal: async config => {
    config.resolve.modules = [
      ...(config.resolve.modules || []),
      path.resolve(__dirname, "../src/main/javascript"),
      "node_modules"
    ];

    config.module.rules.push({
      test: /\.tsx?$/,
      use: Style9Plugin.loader
    });

    config.plugins.push(new Style9Plugin());

    return config;
  }
};

const moduleFederationConfig = {
  name: "phoenixUI",
  filename: "remoteEntry.tsx",
  exposes: {
    "./Components/Button": path.resolve(
      __dirname,
      "../src/main/javascript/Button.tsx"
    )
  }
};

Style9 is a CSS compiler plugin. The config for Style9 works. As in, if i remove module federation from my .storybook/main.js, it works. I am using Storybook version 6.3.12 though, have not tried downgrading it.

Thx in advance!

kirill-konshin
kirill-konshin

webpackFinal could return a promise. That's exactly your case. Remove async and it will work.

But storybook-module-federation should check return type of webpackFinal internally, so it's still a bug.

Oct
21
1 month ago
push

kirill-konshin push ringcentral/ringcentral-javascript

kirill-konshin
kirill-konshin

Add brand isXXXXBrand() usage check and suggestion to use brandFeature (#33)

  • Add brand isXXXXBrand() usage check and suggestion to use brandFeature config. Co-authored-by: trump.wang [email protected]

commit sha: 099be046e28ec671ce00014c783d95699ed854a7

push time in 1 month ago
pull request

kirill-konshin pull request ringcentral/ringcentral-javascript

kirill-konshin
kirill-konshin

Add brand isXXXXBrand() usage check and suggestion to use brandFeature

…e config.

Oct
17
1 month ago
Activity icon
issue

kirill-konshin issue comment kirill-konshin/next-redux-wrapper

kirill-konshin
kirill-konshin

delete extra empty parts of the store

Hello! Using wrapper.getServerSideProps wrapper.getStaticProps, wrapper.getInitialPageProps on the page, we will always receive a new full state in the request. А client requesting json for a SSG page will receive a full store, even if we changed small part of him.

The store can be large and we just transfer the extra bytes from the server to the client each time we switch to a new page.

I think it would be convenient to indicate which parts of the store we want to receive from the server

For example We have this store

{
    users: { loading: false, data: [] },
    posts: { loading: false, data: [] },
    cities: { loading: false, data: [] },
}

getServerSideProps

export const getServerSideProps = wrapper.getServerSideProps((store) => async ({ req, res }) => {
    dispatch(getPosts())
    return { props: {} };
});

content in json for page

{
   pageProps: {
       initialState: {
          users: { loading: false, data: [] }, // extra data
          posts: { loading: false, data: [post1, post2, post3 ...] },
          cities: { loading: false, data: [] }, // extra data
      }
   
   }
}

as you can see, there can be a lot of extra empty parts of the store, although we know for sure that it is not by interacting with them

I suggest adding an additional function parameter that will indicate which parts of the store we need For example:

export const getServerSideProps = wrapper.getServerSideProps((store) => async ({ req, res }) => {
    dispatch(getPosts())
    return { props: {} };
}, ['posts']);



//result json
{
   pageProps: {
       initialState: {
          posts: { loading: false, data: [post1, post2, post3 ...] },
      }
   }
}

OR

export const getServerSideProps = wrapper.getServerSideProps((store) => async ({ req, res }) => {
    dispatch(getPosts())
    return { props: {} };
}, ['posts', 'users']);


//result json
{
   pageProps: {
       initialState: {
       users: { loading: false, data: [] },
          posts: { loading: false, data: [post1, post2, post3 ...] },
      }
   }
}
kirill-konshin
kirill-konshin

Like I said, you can use custom serialization logic, there you can delete any nodes and return plain json, nextjs will serialize it.

Oct
14
1 month ago
Activity icon
issue

kirill-konshin issue comment fabricjs/fabric.js

kirill-konshin
kirill-konshin

Unable to get true coordinates / angle when objects are selected and modified

Version

3.6.0

Test Case

http://jsfiddle.net/9x7hrf2y/17/

Steps to reproduce

Use the code in JS Fiddle and rotate the selection.

Expected Behavior

Console logged angles should be the same

Actual Behavior

Since lines are part of activeSelection group, which has angle their own angles are 0.

As you can see in the fiddle, I tried to make JSON of the entire canvas and get position from there, it kinda works, but looks awkward because I have to find the needed object in the pile of JSON.

What is the reliable method to get true object position after modification but while selection is not cleared?

Oct
13
1 month ago
Activity icon
issue

kirill-konshin issue comment kirill-konshin/next-redux-wrapper

kirill-konshin
kirill-konshin

Update README.md

After finding the repo and giving the redux toolkit example a try I noticed that there was inconsistencies with the code block provided in the main repo README such as referencing a variable that does not exist (subjectSlice).

I have copied in the store snippet from https://github.com/kirill-konshin/next-redux-wrapper/tree/master/packages/demo-redux-toolkit

pull request

kirill-konshin pull request kirill-konshin/next-redux-wrapper

kirill-konshin
kirill-konshin

Update README.md

After finding the repo and giving the redux toolkit example a try I noticed that there was inconsistencies with the code block provided in the main repo README such as referencing a variable that does not exist (subjectSlice).

I have copied in the store snippet from https://github.com/kirill-konshin/next-redux-wrapper/tree/master/packages/demo-redux-toolkit

Previous