knolleary

knolleary

OSS Developer - IoT Tinkerer - Creator of @node-red - CTO @FlowForge

Member Since 12 years ago

FlowForge Inc.,

Experience Points
933
follower
Lessons Completed
30
follow
Lessons Completed
42
stars
Best Reply Awards
82
repos

1370 contributions in the last year

Pinned
⚡ Low-code programming for event-driven applications
⚡ A client library for the Arduino Ethernet Shield that provides support for MQTT.
⚡ This workshop takes you through how to setup a Node-RED environment suitable for creating cloud-native applications. It was first delivered as a part of NodeConfEU 2019
⚡ A Todo-Backend implementation using Node-RED and CouchDB. A sample application for https://github.com/knolleary/node-red-in-production-workshop
Activity
Nov
22
1 week ago
Activity icon
issue

knolleary issue node-red/node-red

knolleary
knolleary

Status on Disabled Nodes

When I disable a node in the editor (eg MQTT In) the status indicator still shows the previous status which is confusing.

Screenshot 2021-11-08 at 10 54 47

Activity icon
delete

knolleary in node-red/node-red delete branch auth-id

deleted time in 1 week ago
push

knolleary push node-red/node-red

knolleary
knolleary

Include full user object on login audit events

knolleary
knolleary

Merge pull request #3269 from node-red/auth-id

Include full user object on login audit events

commit sha: 46b6b024b9635c088b36a920904061943c20af8a

push time in 1 week ago
pull request

knolleary pull request node-red/node-red

knolleary
knolleary

Include full user object on login audit events

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

The audit log events for when a user logs in to the editor included the username of the user, but not their full profile object - which other audit events have.

This brings these events into line with the others.

push

knolleary push node-red/node-red

knolleary
knolleary

fix 2nd output when in rate limit per topic modes

to fix issue found in #3260

knolleary
knolleary

Merge pull request #3261 from node-red/fix-delay-2nd-output-when-in-per-topic-mode

fix 2nd output when in rate limit per topic modes

commit sha: cb88cc35e5ed6ed68aa225924acaa1a85adb924e

push time in 1 week ago
pull request

knolleary pull request node-red/node-red

knolleary
knolleary

fix 2nd output when in rate limit per topic modes

  • [ x] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

to fix issue found in #3260 When in rate limit per topic mode nothing gets sent to the 2nd output if that is selected. The way those mode work is that if a new msg arrives on a topic then the new one replaces the old one in the queue (so only the most recent gets sent) - so the old one gets discarded... This fix sends the one that would have been be discarded to the 2nd output if that is enabled.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality
push

knolleary push node-red/node-red

knolleary
knolleary

Set dimension value for tour guide

knolleary
knolleary

Merge pull request #3265 from kazuhitoyokoi/master-fixtourguide

Set dimension value for tour guide

commit sha: 75c0c44809f40c68a3fe74d9497516dcaae75e3d

push time in 1 week ago
pull request

knolleary pull request node-red/node-red

knolleary
knolleary

Set dimension value for tour guide

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

I fixed #3255.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality
Activity icon
issue

knolleary issue node-red/node-red

knolleary
knolleary

Tour guide for the first flow doesn't work

Current Behavior

While translating the first flow guide, I found that users cannot add wire to connect nodes.

tourguide

As we can see on the console, dimension is not defined before the following code. https://github.com/node-red/node-red/blob/2.1.3/packages/node_modules/%40node-red/editor-client/src/js/ui/tour/tourGuide.js#L367-L370

Therefore, we need to use the code to set the value to dimension. After fixing the problem, the handling works correctly and users can add wire.

Expected Behavior

Users can connect the nodes by wire.

Steps To Reproduce

  1. Open Developer tool on Google Chrome.
  2. Enter "RED.tourGuide.run("./tours/first-flow.js")" on console.
  3. Create flow according to the tour guide.

Example flow

No response

Environment

  • Node-RED version: v2.1.3
  • Node.js version: v16.1.0
  • npm version: v7.18.1
  • Platform/OS: Ubuntu 20.04.2 LTS on WSL2 in Windows 10
  • Browser: Google Chrome 95.0.4638.69 (Official Build)(64 bit)
Activity icon
issue

knolleary issue comment node-red/node-red

knolleary
knolleary

Tour guide for the first flow doesn't work

Current Behavior

While translating the first flow guide, I found that users cannot add wire to connect nodes.

tourguide

As we can see on the console, dimension is not defined before the following code. https://github.com/node-red/node-red/blob/2.1.3/packages/node_modules/%40node-red/editor-client/src/js/ui/tour/tourGuide.js#L367-L370

Therefore, we need to use the code to set the value to dimension. After fixing the problem, the handling works correctly and users can add wire.

Expected Behavior

Users can connect the nodes by wire.

Steps To Reproduce

  1. Open Developer tool on Google Chrome.
  2. Enter "RED.tourGuide.run("./tours/first-flow.js")" on console.
  3. Create flow according to the tour guide.

Example flow

No response

Environment

  • Node-RED version: v2.1.3
  • Node.js version: v16.1.0
  • npm version: v7.18.1
  • Platform/OS: Ubuntu 20.04.2 LTS on WSL2 in Windows 10
  • Browser: Google Chrome 95.0.4638.69 (Official Build)(64 bit)
knolleary
knolleary

The 'first-flow' tour isn't one we expose to end users and was created as an experiment to help build the features and APIs of the tour-guide. As 2.1 got nearer, I focussed more on the Welcome Tour as that is the one we show users - and the first-flow tour was forgotten about.

Thanks for investigating and finding the fix.

Activity icon
delete

knolleary in node-red/node-red delete branch ti-fix

deleted time in 1 week ago
push

knolleary push node-red/node-red

knolleary
knolleary

Avoid redundant initialisation of TypedInput type

knolleary
knolleary

Merge pull request #3263 from node-red/ti-fix

Avoid redundant initialisation of TypedInput type

commit sha: a091b82ba97d1f552c8c949d9e1b846dfa2e8985

push time in 1 week ago
pull request

knolleary pull request node-red/node-red

knolleary
knolleary

Avoid redundant initialisation of TypedInput type

  • Bugfix (non-breaking change which fixes an issue)

Reported on the forum, if a TypedInput is initialised with a list of types where the first type in the list has no value (eg, timestamp), but the node property is a different type with value (eg str), then the TI gets the right type, but the value is blank.

This is happening because when the TI is initialised, it first sets the types, which causes the type to be primed as the first in the list (timestamp). It then applies the actual type (str), which is seen as a change in type from no-value to value - and it restores the 'old' value which is blank - overwriting the right value that was already there.

The fix is to not set the type when setting the types list if its part of the initialisation of the whole widget - because we know we'll be setting it to the right type a few lines later.

push

knolleary push node-red/node-red

knolleary
knolleary

Change flow port label CSS variable

knolleary
knolleary

Merge pull request #3270 from bonanitech/node-port-label-color

Don't let themes change flow port label color

commit sha: a3b8f022e6286e50233778bf55360f918c2689fb

push time in 1 week ago
pull request

knolleary pull request node-red/node-red

knolleary
knolleary

Don't let themes change flow port label color

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

The selector .red-ui-flow-port-label currently uses $secondary-text-color to define its text color, but that variable usually has its value changed by the themes.

I noticed this issue with the Dracula theme. Here's how it looks when using that variable.

Screen Shot 2021-11-22 at 4 35 04 PM

And here's how it looks with the proposed change.

Screen Shot 2021-11-22 at 4 33 43 PM

This uses the same color value defined for $secondary-text-color in the default vanilla theme.

It's like Nick said on Slack some time ago.

Screen Shot 2021-11-22 at 4 41 24 PM

This PR tries to fix that.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality
push

knolleary push node-red/node-red

knolleary
knolleary

fix to show link target when selected

knolleary
knolleary

Merge pull request #3267 from node-red-hitachi/fix-link-target-select

fix to show link target when selected

commit sha: 279fcb7c513838ab4f4e1de23aede0994ca324dc

push time in 1 week ago
pull request

knolleary pull request node-red/node-red

knolleary
knolleary

fix to show link target when selected

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

If the target of the Link node exists in another tab, selecting the virtual node will move to the tab of target node, but not the target node is not shown. This fix show the target node after moving tab if there is only one target node in target tab.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality
pull request

knolleary pull request node-red/node-red

knolleary
knolleary

Include full user object on login audit events

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

The audit log events for when a user logs in to the editor included the username of the user, but not their full profile object - which other audit events have.

This brings these events into line with the others.

Activity icon
created branch

knolleary in node-red/node-red create branch auth-id

createdAt 1 week ago
Nov
19
1 week ago
push

knolleary push node-red/node-red.github.io

knolleary
knolleary

update wording

updated to be in line with the checks in the scorecard

knolleary
knolleary

Merge pull request #251 from sammachin/patch-1

update wording

commit sha: e4f7cf86dd6e1f80c4a5205cf93b6987f079028b

push time in 1 week ago
pull request

knolleary pull request node-red/node-red.github.io

knolleary
knolleary

update wording

updated to be in line with the checks in the scorecard

Nov
16
2 weeks ago
push

knolleary push node-red/flow-library

knolleary
knolleary

Merge branch 'master' into production

commit sha: 88fcbec0809898584ebbecef8b4755f641d9db16

push time in 2 weeks ago
push

knolleary push node-red/flow-library

knolleary
knolleary

Correct port number

The docker build exposes port 8080

knolleary
knolleary

Use Cookie for rating

Ratings of nodes no longer requires a user to login via github, its now open to all and we just set a simple cookie with a uuid to reduce multiple ratings. The UUID becomes the new user id for all rating actions/logs

knolleary
knolleary

open rating for flows and collections

knolleary
knolleary

Implement vanilla-cookie-consent

knolleary
knolleary

Merge pull request #47 from sammachin/vanilla-cookie

Vanilla cookie

knolleary
knolleary

Merge pull request #46 from sammachin/patch-1

Correct port number

knolleary
knolleary

Merge pull request #48 from node-red/master

Deploy to production

commit sha: 171cc386f301b8e29ca4b306b5241a82e29569c6

push time in 2 weeks ago
push

knolleary push node-red/flow-library

knolleary
knolleary

Correct port number

The docker build exposes port 8080

knolleary
knolleary

Merge pull request #46 from sammachin/patch-1

Correct port number

commit sha: 95f9075d67b8121485f39a6ece2416865f72a942

push time in 2 weeks ago
pull request

knolleary pull request node-red/flow-library

knolleary
knolleary

Correct port number

The docker build exposes port 8080

push

knolleary push node-red/flow-library

knolleary
knolleary

Use Cookie for rating

Ratings of nodes no longer requires a user to login via github, its now open to all and we just set a simple cookie with a uuid to reduce multiple ratings. The UUID becomes the new user id for all rating actions/logs

knolleary
knolleary

open rating for flows and collections

knolleary
knolleary

Implement vanilla-cookie-consent

knolleary
knolleary

Merge pull request #47 from sammachin/vanilla-cookie

Vanilla cookie

commit sha: e9bdea355c5e52f632f4b6703cc4c7e83b790729

push time in 2 weeks ago
pull request

knolleary pull request node-red/flow-library

knolleary
knolleary

Vanilla cookie

Allow rating without login and add cookie consent using vanilla-cookie-consent