laravel

laravel

Member Since 9 years ago

Experience Points
0
follower
Lessons Completed
0
follow
Best Reply Awards
67
repos
Jun
23
9 hours ago
Activity icon
issue

archansel issue laravel/homestead

archansel
archansel

Folder being deleted while provisioning

Versions

  • Vagrant: 2.2.9
  • Provider: Virtualbox 6.1.16
  • Homestead: 11.3.0

Host operating system

MacOS

Homestead.yaml

---
ip: "192.168.10.10"
memory: 2048
cpus: 2
provider: virtualbox

authorize: ~/.ssh/id_rsa.pub

keys:
    - ~/.ssh/id_rsa

folders:
    - map: ~/Desktop/Repositories
      to: /home/vagrant/Repositories

sites:
    - map: rekreasi.test
      to: "/home/vagrant/Repositories/Projects/Rekreasi App"

databases:
    - rekreasi

features:
    - mysql: true
    - mariadb: false
    - postgresql: false
    - ohmyzsh: false
    - webdriver: false

#services:
#    - enabled:
#        - "postgresql@12-main"
#    - disabled:
#        - "postgresql@11-main"

# ports:
#     - send: 50000
#       to: 5000
#     - send: 7777
#       to: 777
#       protocol: udp

Vagrant destroy & up output

Nothing wrong here

Expected behavior

When provisioning, homestead should not delete user folder

Actual behavior

Notice that I point my site to "Rekreasi App" folder, in my finder I also have "Rekreasi" folder alongside it, so the structure looks like this

> Projects
>>> Rekreasi
>>> Rekreasi App
>>> ....many other folders

When you run vagrant up --provision, the folder "Rekreasi" will be deleted

Steps to reproduce

  1. Set up site with whitespace in its path
  2. Run provision
  3. Some folder will be deleted
Activity icon
issue

archansel issue comment laravel/homestead

archansel
archansel

Folder being deleted while provisioning

Versions

  • Vagrant: 2.2.9
  • Provider: Virtualbox 6.1.16
  • Homestead: 11.3.0

Host operating system

MacOS

Homestead.yaml

---
ip: "192.168.10.10"
memory: 2048
cpus: 2
provider: virtualbox

authorize: ~/.ssh/id_rsa.pub

keys:
    - ~/.ssh/id_rsa

folders:
    - map: ~/Desktop/Repositories
      to: /home/vagrant/Repositories

sites:
    - map: rekreasi.test
      to: "/home/vagrant/Repositories/Projects/Rekreasi App"

databases:
    - rekreasi

features:
    - mysql: true
    - mariadb: false
    - postgresql: false
    - ohmyzsh: false
    - webdriver: false

#services:
#    - enabled:
#        - "postgresql@12-main"
#    - disabled:
#        - "postgresql@11-main"

# ports:
#     - send: 50000
#       to: 5000
#     - send: 7777
#       to: 777
#       protocol: udp

Vagrant destroy & up output

Nothing wrong here

Expected behavior

When provisioning, homestead should not delete user folder

Actual behavior

Notice that I point my site to "Rekreasi App" folder, in my finder I also have "Rekreasi" folder alongside it, so the structure looks like this

> Projects
>>> Rekreasi
>>> Rekreasi App
>>> ....many other folders

When you run vagrant up --provision, the folder "Rekreasi" will be deleted

Steps to reproduce

  1. Set up site with whitespace in its path
  2. Run provision
  3. Some folder will be deleted
archansel
archansel

I follow your suggestion and it works. Although, I have to destroy the last VM using vagrant destroy first to make it work

Activity icon
fork

zf192 forked laravel/laravel

⚡ A PHP framework for web artisans.
zf192 Updated
fork time in 35 minutes ago
started
started time in 35 minutes ago
started
started time in 1 hour ago
Activity icon
issue

Fossil01 issue comment laravel/homestead

Fossil01
Fossil01

Apple Silicon Support

Is it possible to use Homestead with Apple Silicon already?

Fossil01
Fossil01

So since M1 won't be supported anytime soon and I want to get net next 16 inch M1/M2 Mac when it comes out... I am looking at alternatives already :-)

Has anyone come up with an alternative neat and clean solution yet? I thought about just setting up a VM on my server and then using something like VSCode's Remote Code Development plugin (maybe over a VPN even) but a local solution with most stuff pre-configured in Vagrant is still pretty damn nice :-)

I don't like running in Docker with something like Sail as I have some custom applications I need, which I currently install with an after.sh script.

Activity icon
issue

sharifzadesina issue comment laravel/framework

sharifzadesina
sharifzadesina

The dispatchSync method doesn't respect middleware

  • Laravel Version: ^8.0
  • PHP Version: ^7.3
  • Database Driver & Version: Doesn't Matter

Description:

Hello, If you remember issue #29917, people were asking sync jobs to respect the middleware option. So, thanks to Taylor, we got a new method called dispatchSync, which respects middleware for sync jobs. but there is a major problem with it, imagine we have these two jobs:

class OurMiddleware
{
}

class SyncJob
{
    public function middleware()
    {
        return [new OurMiddleware];
    }
}

class NormalJob implements ShouldQueue
{
    public function middleware()
    {
        return [new OurMiddleware];
    }
}

Obviously, the SyncJob class, doesn't implement the ShouldQueue interface, because it is a sync job, and we don't want it to be queued. so what will happen? Well! the middleware will run perfectly for the NormalJob, but when we will try to run SyncJob using dispatchSync, the middleware won't run, because it doesn't implement ShouldQueue interface. We wanted to solve this issue by adding the great dispatchSync method, but it is now just like dispatchNow.

Because of this problem, we can't use the OurMiddleware class for all jobs and we need to implement it the traditional way.

sharifzadesina
sharifzadesina

I think the non-breaking workaround for this, is to add middleware logic to the dispatchNow method, so the dispatchSync method will be able to respect middleware.

I personally prefer removing the if ($job instanceof ShouldQueen) condition, but the return value for async jobs is 0, and not the actual value of the job itself.

This is a bit confusing, you can change the return type of dispatchSync method, by simply adding ShouldQueen interface.

For example:

dispatchSync(new SyncJob())
// returns actual value

dispatchSync(new NormalJob())
// returns 0
started
started time in 1 hour ago
Activity icon
issue

chriischambers issue comment laravel/framework

chriischambers
chriischambers

[8.x] Order of Modifiers Amended

When unsigned() was added to a migration with an integer() or bigInteger(), the order of modifiers would result in a query like:

`field` int primary key unsigned not null

This is invalid SQL and therefore caused errors on the migrations.

Issue reported, with steps to replicate, here:

https://github.com/laravel/framework/issues/37781

chriischambers
chriischambers

This breaks our deployments so we have rolled back to 8.47 for now.

Activity icon
fork

yetimnew forked laravel/ui

⚡ Laravel UI utilities and presets.
yetimnew MIT License Updated
fork time in 1 hour ago
started
started time in 1 hour ago
started
started time in 1 hour ago
started
started time in 1 hour ago
started
started time in 1 hour ago
Activity icon
fork

NickKostin forked laravel/laravel

⚡ A PHP framework for web artisans.
NickKostin Updated
fork time in 1 hour ago
Activity icon
fork

alphaolomi forked laravel/cashier-stripe

⚡ Laravel Cashier provides an expressive, fluent interface to Stripe's subscription billing services.
alphaolomi MIT License Updated
fork time in 1 hour ago
Activity icon
fork

dudinsahidin forked laravel/laravel

⚡ A PHP framework for web artisans.
dudinsahidin Updated
fork time in 2 hours ago
Activity icon
issue

liamoreilly issue comment laravel/framework

liamoreilly
liamoreilly

Laravel Sail Share and URLs

Discussed in https://github.com/laravel/framework/discussions/36942

Originally posted by liamoreilly April 11, 2021 Hi,

When using sail share the web pages do not function correctly as the generated URLs for assets do not use the exposed hostname.

As an example, let's consider a run of sail share. This produces the output on the terminal:

Thank you for using expose.
Local-URL:		host.docker.internal:80
Dashboard-URL:		http://127.0.0.1:4040
Expose-URL:		http://ykn4nriozw.laravel-sail.site:8080

Navigating to http://ykn4nriozw.laravel-sail.site:8080 does yield the website, but with no Javascript nor CSS. An inspection of the page source shows the problem:

<link href="http://host.docker.internal/css/app.css" rel="stylesheet">
<script src="http://host.docker.internal/js/app.js" defer></script>

The URLs for CSS and Javascript are produced using the Local-URL which is not accessible for those accessing the site with the Expose-URL.

I would imagine the correct behaviour would be that the generated URLs should be

<link href="http://ykn4nriozw.laravel-sail.site:8080/css/app.css" rel="stylesheet">
<script src="http://ykn4nriozw.laravel-sail.site:8080js/app.js" defer></script>

That is, they are built with the Expose-URL.

Is there a flag or setting that enables this behaviour?

It seems the ability to share is more or less not functional with local assets. Anyone viewing the site with the Expose-URL only gets the HTML (and no assets).

The problem is actually a little worse, as all URLs are affected including those used anchor tags. Thus, page navigation also does not function.

Any ideas, hints, or tips are welcome.

Thanks, Liam

liamoreilly
liamoreilly

Thanks Mathias! I am really not sure at all how I missed this

Activity icon
fork

dudinsahidin forked laravel/docs

⚡ The Laravel documentation.
dudinsahidin MIT License Updated
fork time in 2 hours ago
Activity icon
issue

ekpono issue comment laravel/nova-issues

ekpono
ekpono

conditional actions

is it possible to make the actions depend on some conditions?

like show the action on detailpage only if the resource has a status like active or is there a workaround for this?

thanks Denis

ekpono
ekpono
 return [
        (new Actions\CancelTrial)->canSee(function ($request) {
            if ($request instanceof ActionRequest) {
                return true;  
            }

            return $this->resource instanceof Model && $this->resource->isOnTrial();
        }),
    ];

Thanks @crynobone

started
started time in 2 hours ago
Activity icon
fork

tuinhanne forked laravel/framework

⚡ The Laravel Framework.
tuinhanne MIT License Updated
fork time in 2 hours ago
started
started time in 3 hours ago
started
started time in 3 hours ago
started
started time in 3 hours ago
started
started time in 3 hours ago
pull request

seyed-me pull request laravel/octane

seyed-me
seyed-me

fix config key for roadrunner http.middlware

Activity icon
fork

seyed-me forked laravel/octane

⚡ Supercharge your Laravel application's performance.
seyed-me MIT License Updated
fork time in 3 hours ago
Activity icon
fork

shohag7462 forked laravel/laravel

⚡ A PHP framework for web artisans.
shohag7462 Updated
fork time in 4 hours ago
started
started time in 4 hours ago