leerob

leerob

Head of DevRel ▲ @vercel

Member Since 7 years ago

@Vercel, Des Moines, IA

Experience Points
4k
follower
Lessons Completed
0
follow
Lessons Completed
127
stars
Best Reply Awards
36
repos

2640 contributions in the last year

Pinned
⚡ The React Framework
⚡ ✨ My portfolio built with Next.js, Tailwind, Prisma, and Vercel.
⚡ ⚛️ Build applications from the the future, today.
⚡ Easily add user reviews, feedback, and comments to your website in one line of code.
⚡ A free video course for building static and server-side rendered applications with Next.js and React.
⚡ Example Next.js app to upload photos to an S3 bucket.
Activity
Nov
30
3 hours ago
push

leerob push vercel/next.js

leerob
leerob

Update next export documentation. (#31465)

commit sha: 6e6bd2158ffae0296b08e7c89928844fa9dd32b0

push time in 9 minutes ago
Activity icon
delete

leerob in vercel/next.js delete branch leerob-patch-1

deleted time in 9 minutes ago
pull request

leerob pull request vercel/next.js

leerob
leerob

Update `next export` documentation.

This more clearly lists what features are supported and not supported by next export.

Activity icon
issue

leerob issue comment vercel/next.js

leerob
leerob

Update `next export` documentation.

This more clearly lists what features are supported and not supported by next export.

leerob
leerob
push

leerob push vercel/next.js

leerob
leerob

docs(middleware): file extension consistency (#31879)

Almost every one of the examples for middleware specific a .ts file extension, this PR just makes it consistent.

leerob
leerob

Add port and hostname options to Next Server (#31858)

A middleware can work as a proxy intercepting requests and then performing a fetch to the destination adding headers to the request / response as a "man in the middle". When using fetch from a middleware we are not in the context of a browser so we can't really use relative URLs, they must be always absolute.

Now consider the previous case when middleware is running in server mode. Typically in order to know the host where we are fetching we can use the request.nextUrl which is given to the middleware but in this case the invoker (which is next-server) has no context of the hostname, nor the port. To solve this use case we must make the invoker of the middleware aware of the origin hostname and port.

This PR:

  • Introduces hostname and port as options for NextServer.
  • Refactors types in NextServer and NextDevServer moving type only imports to the top of the file.
  • Refactors startServer to do a best guess on the hostname and port, passing them down.
  • Exposes .port and .hostname to be retrieved from the app.

In an upcoming PR we will pass the host guess to the middleware to solve the relative URL issue.

leerob
leerob

Fix: Cannot assign to read only property 'children' (#31784)

Co-authored-by: Jesse Jafa [email protected]

leerob
leerob

docs(examples): add secure flag explanation to with-iron-session (#31896)

Following comment on the project here: https://github.com/vvo/iron-session/issues/425

leerob
leerob

Docs(React 18): add missing Suspense import (#31897)

This PR adds a missing import in React 18 documentation's sample code, where Suspense is used without being imported.

(edit: fix typo)

leerob
leerob

Docs(React 18): remove unnecessary React import (#31900)

In the Server Components APIs (Alpha) code sample, importing React is unnecessary. People may think that having react's default export imported is needed to use Suspense

leerob
leerob

Fix disabling of built-in CSS support if there is a custom loader (#31078)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Lee Robinson [email protected]

leerob
leerob

Remove unpurpose test (#31898)

The test from #31784 can pass with or without the source code change in that PR. I cannot repro it. The writable is true on build in the provided case

leerob
leerob

include no-document-import-in-page rule in plugin index (#31890)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

leerob
leerob

Improve Middleware Set Cookie API documentation (#31707)

leerob
leerob

Add tracing to with-sentry example for Next.js 11 (#30401)

leerob
leerob

Account for platform/arch not supported by napi (#31938)

leerob
leerob

Removng prop writable checking in prod (#31929)

x-ref: #28498, #31784

I can repro the issue #24783 with next-boost 0.10.1 and it was fixed in 0.10.2 (ref: https://github.com/rjyo/next-boost/commit/eba6d10aabb2470ec5d7bd48ac8fec4ea08e26c5). The actual case is missing setting node env to "production".

React freeze element props and element itself in dev mode (ref: https://github.com/facebook/react/blob/a724a3b578dce77d427bef313102a4d0e978d9b4/packages/react/src/ReactElement.js#L194-L196)

Then next.js will reassign props with react development bundle while next-boost is enabled. Those operations are only happened in non-dev mode so it's good to remove now.

This PR + #31898 == revert #31784

cc @styfle @awareness481

leerob
leerob

Merge branch 'canary' into leerob-patch-1

commit sha: 18638a46aa16098319c91f66c815832a33da26a2

push time in 11 minutes ago
push

leerob push vercel/next.js

leerob
leerob

Update docs/advanced-features/static-html-export.md

commit sha: 2ee90e44c9ec7dd3ee29515099edb33a3d70214a

push time in 12 minutes ago
pull request

leerob merge to vercel/next.js

leerob
leerob

Update `next export` documentation.

This more clearly lists what features are supported and not supported by next export.

open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Update `next export` documentation.

This more clearly lists what features are supported and not supported by next export.

Nov
29
1 day ago
open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob

Let's avoid foo/bar 🙏

open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob
The `props` object is a key-value pair, where each value is received by the page component. It should be a [serializable object](https://en.wikipedia.org/wiki/Serialization)
open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob

This comment still needs to be addressed 🙏

open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob

Same comment for version history - non blocking

open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob
The `notFound` boolean allows the page to return a `404` status and [404 Page](/docs/advanced-features/custom-error-page.md#404-page). With `notFound: true`, the page will return a `404` even if there was a successfully generated page before. This is meant to support use-cases like user-generated content getting removed by its author.
open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob
The `revalidate` property is the amount in seconds after which a page re-generation can occur (defaults to `false` or no revalidation).
open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob
Imports used will **not be bundled for the client-side**. This means you can write **server-side code directly in `getStaticProps`**, including fetching data from your database.
open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob
- If the page name uses [catch-all routes](/docs/routing/dynamic-routes.md#catch-all-routes) like `pages/[...slug]`, then `params` should contain `slug` (which is an array). If this array is `['hello', 'world']`, then Next.js will statically generate the page at `/hello/world`.
open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob

Follow up PR - let's add more updates here, we've definitely added more stuff between here and 9.5

open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob
When exporting an `async` function called `getStaticPaths` from a page that uses [Dynamic Routes](/docs/routing/dynamic-routes.md), Next.js will statically pre-render all the paths specified by `getStaticPaths`.
open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob
The value for each `params` object must match the parameters used in the page name:
open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob

How could we make this more clear? Could be a follow up PR

open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob
Then, Next.js will statically generate `/posts/1` and `/posts/2` during `next build` using the page component in `pages/posts/[id].js`.
open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob
description: Fetch data and generate static pages with `getStaticPaths`.
open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob
You can import modules in top-level scope for use in `getServerSideProps`. Imports used will **not be bundled for the client-side**. This means you can write **server-side code directly in `getServerSideProps`**, including fetching data from your database.
open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob
If `fallback` is `false`, then any paths not returned by `getStaticPaths` will result in a **404 page**. This is useful if you have a small number of paths to pre-render and want to statically generate them all during `next build`.
open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob
The `paths` key determines which paths will be pre-rendered. For example, suppose that you have a page that uses [Dynamic Routes](/docs/routing/dynamic-routes.md) named `pages/posts/[id].js`. If you export `getStaticPaths` from this page and return the following for `paths`:
open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob
- If the page uses an [optional catch-all route](/docs/routing/dynamic-routes.md#optional-catch-all-routes), use `null`, `[]`, `undefined` or `false` to render the root-most route. For example, if you supply `slug: false` for `pages/[[...slug]]`, Next.js will statically generate the page `/`.

What is "root most route"?

open pull request

leerob wants to merge vercel/next.js

leerob
leerob

Refactor data fetching API docs

New PR, same content. Refactor the Data fetching APIs so that they are logically split between API reference and concept info.

Depends on hash redirects PR: https://github.com/vercel/front/pull/11298

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
leerob
leerob
The `notFound` boolean allows the page to return a `404` status and [404 Page](/docs/advanced-features/custom-error-page.md#404-page). With `notFound: true`, the page will return a `404` even if there was a successfully generated page before. This is meant to support use-cases like user-generated content getting removed by its author.
Previous