locomike

locomike

Member Since 3 years ago

Experience Points
0
follower
Lessons Completed
0
follow
Lessons Completed
27
stars
Best Reply Awards
5
repos

15 contributions in the last year

Pinned
⚡ Gradle plugin for computing code coverage on modified code
⚡ ⚠️ Stop saying "you forgot to …" in code review
⚡ GitLab CI image for building Android apps
Activity
Nov
26
1 week ago
Activity icon
issue

locomike issue comment damian-burke/danger-plugin-lint-report

locomike
locomike

fix: fix file path logic for files with the same name and different path

554e0 added support for dynamically calculating the file paths (as the previous implementation assumed the root was the same in lint files and when we execute this plugin).

The logic is currently failing when we have 2 files with the same name in different paths. For instance:

  • Lint location file: /lintRoot/folderA/build.gradle (and lintRoot/build.gradle also exists)
  • Root: /dangerRoot
  • Resolved file: /dangerRoot/build.gradle (it should have been lintRoot/folderA/build.gradle
Nov
22
1 week ago
started
started time in 1 week ago
Nov
20
2 weeks ago
Nov
18
2 weeks ago
pull request

locomike pull request damian-burke/danger-plugin-lint-report

locomike
locomike

fix: fix file path logic for files with the same name and different path

554e0 added support for dynamically calculating the file paths (as the previous implementation assumed the root was the same in lint files and when we execute this plugin).

The logic is currently failing when we have 2 files with the same name in different paths. For instance:

  • Lint location file: /lintRoot/folderA/build.gradle (and lintRoot/build.gradle also exists)
  • Root: /dangerRoot
  • Resolved file: /dangerRoot/build.gradle (it should have been lintRoot/folderA/build.gradle
push

locomike push locomike/danger-plugin-lint-report

locomike
locomike

fix: fix file path logic for files with the same name and different path

commit sha: 9b255d679a7bdcdb7d22081cf47e6d0b3df4b4d4

push time in 2 weeks ago
Activity icon
fork

locomike forked damian-burke/danger-plugin-lint-report

locomike MIT License Updated
fork time in 2 weeks ago
push

locomike push locomike/danger-plugin-lint-report

locomike
locomike

fix: allow checkstyle files without messages

locomike
locomike
locomike
locomike
locomike
locomike

Merge branch 'damian-burke:main' into main

commit sha: d6a586041f12c7b9dd26fae6535fe1d1e312b0c7

push time in 2 weeks ago
Activity icon
issue

locomike issue Kotlin/dokka

locomike
locomike

Is it possible to include a markdown file in the MultiModule home page?

Question Is it possible to include a markdown file in the MultiModule home page?

I know it is possible to include markdown content in the individual module pages and as a description of every module in the modules page. See https://kotlinlang.org/docs/kotlin-doc.html#module-and-package-documentation

But is it possible to include some markdown content before the modules are listed in a multi module project?

Screenshots Screenshot 2021-11-17 at 16 31 21

Installation

  • N/A

Additional context Add any other context about the problem here

Activity icon
issue

locomike issue comment Kotlin/dokka

locomike
locomike

Is it possible to include a markdown file in the MultiModule home page?

Question Is it possible to include a markdown file in the MultiModule home page?

I know it is possible to include markdown content in the individual module pages and as a description of every module in the modules page. See https://kotlinlang.org/docs/kotlin-doc.html#module-and-package-documentation

But is it possible to include some markdown content before the modules are listed in a multi module project?

Screenshots Screenshot 2021-11-17 at 16 31 21

Installation

  • N/A

Additional context Add any other context about the problem here

locomike
locomike

Thank you, that works just fine!

Nov
17
2 weeks ago
Activity icon
issue

locomike issue Kotlin/dokka

locomike
locomike

Is it possible to include a markdown file in the MultiModule home page?

Question Is it possible to include a markdown file in the MultiModule home page?

I know it is possible to include markdown content in the individual module pages and as a description of every module in the modules page. See https://kotlinlang.org/docs/kotlin-doc.html#module-and-package-documentation

But is it possible to include some markdown content before the modules are listed in a multi module project?

Screenshots Screenshot 2021-11-17 at 16 31 21

Installation

  • N/A

Additional context Add any other context about the problem here

Nov
10
3 weeks ago
Oct
21
1 month ago
Activity icon
fork

locomike forked jangrewe/gitlab-ci-android

⚡ GitLab CI image for building Android apps
locomike MIT License Updated
fork time in 1 month ago
Oct
6
1 month ago
started
started time in 1 month ago
Oct
4
2 months ago
push

locomike push locomike/danger-plugin-lint-report

locomike
locomike

fix: support lint files calculated in a different machine/process (#31)

When building in CI it is common that a task is generating the lint file, while a different task runs dagger. These tasks don't need to run in the same machine. The current code assumes so when sanitizing absolute paths by replacing the root (pwd) with "". This does not work if the root is different.

Closes #29

Co-authored-by: Miguel Cohnen [email protected]

locomike
locomike
locomike
locomike
locomike
locomike

Merge branch 'damian-burke:main' into main

commit sha: f03c2858183402fe8f095c576f532e95aa617d5d

push time in 2 months ago
Sep
25
2 months ago
Activity icon
issue

locomike issue danger/danger-js

locomike
locomike

[BUG] Unable to use `got` or any `got` dependent libraries due to outdated https-proxy-agent

Describe the bug I discovered this bug when trying to integrate gitbeaker in my danger script. The error I get when trying to connect to Gitlab with gitbeaker is

Error:  RequestError: connect ECONNREFUSED 127.0.0.1:443
    at ClientRequest.<anonymous> (/Users/miguelcohnen/dev/ixigo/android/node_modules/got/dist/source/core/index.js:956:111)
    at Object.onceWrapper (events.js:520:26)
    at ClientRequest.emit (events.js:412:35)
    at ClientRequest.origin.emit (/Users/miguelcohnen/dev/ixigo/android/node_modules/@szmarczak/http-timer/dist/source/index.js:43:20)
    at TLSSocket.socketErrorListener (_http_client.js:475:9)
    at TLSSocket.emit (events.js:400:28)
    at emitErrorNT (internal/streams/destroy.js:106:8)
    at emitErrorCloseNT (internal/streams/destroy.js:74:3)
    at processTicksAndRejections (internal/process/task_queues.js:82:21)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1148:16) {
  code: 'ECONNREFUSED',
  timings: {
    start: 1632510293779,
    socket: 1632510293779,
    lookup: 1632510293780,
    connect: ,
    secureConnect: ,
    upload: undefined,
    response: undefined,
    end: undefined,
    error: 1632510293780,
    abort: undefined,
    phases: {
      wait: 0,
      dns: 1,
      tcp: undefined,
      tls: undefined,
      request: undefined,
      firstByte: undefined,
      download: undefined,
      total: 1
    }
  }
}

gitbeaker uses got package. According to this issue, the problem is an outdated version of https-proxy-agent that is incompatible with Node 10. See https://forums.meteor.com/t/solved-problems-with-using-the-got-http-package/54297 and https://github.com/sindresorhus/got/issues/876#issuecomment-573348808

My Gitlab instance is under a VPN proxy.

To Reproduce Steps to reproduce the behavior:

  1. Integrate got in a danger script.
  2. Try to connect to a Gitlab Service using got that is behind a proxy
  3. Verify an error is thrown RequestError: connect ECONNREFUSED 127.0.0.1:443

Expected behavior

  • After upgrading http(s)-proxu-agent packages, using got to connect to a Gitlab URL behind a VPN proxy works correctly.

** Your Environment**

software version
danger.js 10.6.6
node v14.17.6
npm 6.14.15
Operating System Mac OS

Additional context Add any other context about the problem here.

push

locomike push locomike/danger-js

locomike
locomike

Update http(s)-proxy-agent dependencies

commit sha: 0ab6d34a3fee5bfcaf6bb90e82121f296c2b2f44

push time in 2 months ago
Activity icon
fork

locomike forked danger/danger-js

⚡ ⚠️ Stop saying "you forgot to …" in code review
locomike MIT License Updated
fork time in 2 months ago
started
started time in 2 months ago
Sep
8
2 months ago
Activity icon
issue

locomike issue comment damian-burke/danger-plugin-lint-report

locomike
locomike

fix: support lint files calculated in a different machine/process

When building in CI it is common that a task is generating the lint file, while a different task runs dagger. These tasks don't need to run in the same machine. The current code assumes so when sanitizing absolute paths by replacing the root (pwd) with "". This does not work if the root is different.

fix #29

locomike
locomike

You're welcome! Thank you for creating it in the first place.

What is the release process for this library? Is it released on demand or constantly with any change to main?

Sep
7
2 months ago
started
started time in 2 months ago
Sep
6
2 months ago
open pull request

locomike wants to merge damian-burke/danger-plugin-lint-report

locomike
locomike

fix: support lint files calculated in a different machine/process

When building in CI it is common that a task is generating the lint file, while a different task runs dagger. These tasks don't need to run in the same machine. The current code assumes so when sanitizing absolute paths by replacing the root (pwd) with "". This does not work if the root is different.

fix #29

locomike
locomike

Makes sense. Will do the changes. Thanks!

pull request

locomike merge to damian-burke/danger-plugin-lint-report

locomike
locomike

fix: support lint files calculated in a different machine/process

When building in CI it is common that a task is generating the lint file, while a different task runs dagger. These tasks don't need to run in the same machine. The current code assumes so when sanitizing absolute paths by replacing the root (pwd) with "". This does not work if the root is different.

fix #29

open pull request

locomike wants to merge damian-burke/danger-plugin-lint-report

locomike
locomike

fix: support lint files calculated in a different machine/process

When building in CI it is common that a task is generating the lint file, while a different task runs dagger. These tasks don't need to run in the same machine. The current code assumes so when sanitizing absolute paths by replacing the root (pwd) with "". This does not work if the root is different.

fix #29

locomike
locomike

I could do that if you think that is better. I guess what you are suggesting is instead of keeping mockFiles around, I'd keep a variable for mockExistsSync that will be a jest.fn(), and then in the test do something like:

mockExistsSync.mockImplementation( path => path === "/otherRoot/feature/src/main/res/layout/fragment_password_reset.xml" )

I guess keeping the list of files around makes it easier to read when you have multiple files, or if you wanted to keep the state of which files are present or not across tests.

pull request

locomike merge to damian-burke/danger-plugin-lint-report

locomike
locomike

fix: support lint files calculated in a different machine/process

When building in CI it is common that a task is generating the lint file, while a different task runs dagger. These tasks don't need to run in the same machine. The current code assumes so when sanitizing absolute paths by replacing the root (pwd) with "". This does not work if the root is different.

fix #29

Previous