lucianoratamero

lucianoratamero

Member Since 10 years ago

@labcodes,

Experience Points
78
follower
Lessons Completed
2
follow
Lessons Completed
23
stars
Best Reply Awards
60
repos

945 contributions in the last year

Pinned
⚡ A set of tools to facilitate react-redux development and decouple logic from compontents
⚡ The relevant React Events Library.
⚡ Collection of svelte stores to manage and save promises.
Activity
Oct
13
2 days ago
Oct
12
3 days ago
push

lucianoratamero push lucianoratamero/pybr2022-svelte-kit

lucianoratamero
lucianoratamero
lucianoratamero
lucianoratamero
lucianoratamero
lucianoratamero
lucianoratamero
lucianoratamero

commit sha: 25bf267c6acc785afb08813fcd0b1bfab1c2f414

push time in 3 days ago
Oct
8
1 week ago
Activity icon
created branch
createdAt 1 week ago
Sep
30
2 weeks ago
Activity icon
delete

lucianoratamero in labcodes/django-react-boilerplate delete branch hotfix/fix-install-script

deleted time in 2 weeks ago
push

lucianoratamero push labcodes/django-react-boilerplate

lucianoratamero
lucianoratamero

Activate poetry shell after installing requirements

lucianoratamero
lucianoratamero

Merge pull request #61 from labcodes/hotfix/fix-install-script

Activate poetry shell after installing requirements

commit sha: 85e0df507ff6939ee833b535f3308ba88dbb8c25

push time in 2 weeks ago
pull request

lucianoratamero pull request labcodes/django-react-boilerplate

lucianoratamero
lucianoratamero

Activate poetry shell after installing requirements

Before submitting this pull request, make sure these boxes are checked. Thanks! This list for internal reference. You can delete it for your PR :relieved: .

  • Review your code and QA it as the user. Double check if it does everything that was asked on the task.
  • Merge the target branch into your branch and fix conflicts.
  • Look for forgotten comments, prints, console.log and typos.
  • DRY (Don’t repeat yourself).
  • KISS (Keep it simple).
  • YAGNI (You ain’t gonna need it) - Don’t do things that you don’t need yet.
  • Performance (check the queries you generated on backend).

Also provide the following information:

Link to task:

How to test:

Description of your solution:

Screenshots:

pull request

lucianoratamero pull request labcodes/django-react-boilerplate

lucianoratamero
lucianoratamero

Activate poetry shell after installing requirements

Before submitting this pull request, make sure these boxes are checked. Thanks! This list for internal reference. You can delete it for your PR :relieved: .

  • Review your code and QA it as the user. Double check if it does everything that was asked on the task.
  • Merge the target branch into your branch and fix conflicts.
  • Look for forgotten comments, prints, console.log and typos.
  • DRY (Don’t repeat yourself).
  • KISS (Keep it simple).
  • YAGNI (You ain’t gonna need it) - Don’t do things that you don’t need yet.
  • Performance (check the queries you generated on backend).

Also provide the following information:

Link to task:

How to test:

Description of your solution:

Screenshots:

push

lucianoratamero push labcodes/django-react-boilerplate

lucianoratamero
lucianoratamero

Activate poetry shell after installing requirements

commit sha: 94b0a30214b6d2026432215dc8594cd748a12176

push time in 2 weeks ago
Activity icon
created branch

lucianoratamero in labcodes/django-react-boilerplate create branch hotfix/fix-install-script

createdAt 2 weeks ago
push

lucianoratamero push labcodes/django-react-vite

lucianoratamero
lucianoratamero

Remove webpack from header and index.html

commit sha: a9dfaee0a2b84940730a471d6ca1ba0effccf1eb

push time in 2 weeks ago
Activity icon
delete

lucianoratamero in labcodes/django-react-webpack delete branch proposal-vite-migration

deleted time in 2 weeks ago
push

lucianoratamero push labcodes/django-react-webpack

lucianoratamero
lucianoratamero

Migrate app from react-app/src to react-app/

lucianoratamero
lucianoratamero

Add configurations for the vite app to work with django

lucianoratamero
lucianoratamero

Add app core with render_vite_bundle templatetag

lucianoratamero
lucianoratamero
lucianoratamero
lucianoratamero
lucianoratamero
lucianoratamero
lucianoratamero
lucianoratamero

Change mentions of webpack and yarn to vite/boilerplate

lucianoratamero
lucianoratamero

Remove django-webpack-loader from python dependencies

lucianoratamero
lucianoratamero

Remove mentions of webpack and useless files

lucianoratamero
lucianoratamero
lucianoratamero
lucianoratamero

Update package.json

Co-authored-by: Luan Fonseca [email protected]

lucianoratamero
lucianoratamero

Update templates/frontend/index.html

Co-authored-by: Luan Fonseca [email protected]

lucianoratamero
lucianoratamero

Merge pull request #60 from labcodes/proposal-vite-migration

Proposal: vite migration

commit sha: 03a19316f8a00e857c71508b27c7461fe242018d

push time in 2 weeks ago
pull request

lucianoratamero pull request labcodes/django-react-webpack

lucianoratamero
lucianoratamero

Proposal: vite migration

This PR implements a proposal to change from webpack to vite. We'll need to change the repo's name, though, since we won't be using webpack anymore. The proposal changes from django-react-webpack to django-react-boilerplate.

(This PR is based on two open PRs, #57 and #58 , so be sure to merge those before)

Link to task: fix #59

How to test:

  • go to this branch
  • reinstall all dependencies (make install_dependencies)
  • run the app and check it's working as intended
  • run the jest and cypress tests

Description of your solution: I've removed django-webpack-loader, together with webpack configs, and refactored the frontend app and dependencies to build using vite. All the details are described on my Using Vite with Django, the simple way gist, and this will need thorough code review, but it seems pretty straightforward.

Activity icon
issue

lucianoratamero issue labcodes/django-react-webpack

lucianoratamero
lucianoratamero

Proposal: migrate from wepback to vite

Vite is the next generation of tooling for modern frontend applications. It's faster than webpack, has less dependencies, and is easier to configure/maintain.

I'll create a proposal branch for the migration. (We would need to change the name of the project, though :laughing: )

pull request

lucianoratamero merge to labcodes/django-react-webpack

lucianoratamero
lucianoratamero

Update eslint rule for jsx-a11y/label-has-associated-control

Link to task: fixes #9

Sep
29
2 weeks ago
push

lucianoratamero push labcodes/django-react-webpack

lucianoratamero
lucianoratamero

Update templates/frontend/index.html

Co-authored-by: Luan Fonseca [email protected]

commit sha: c57d06b3923d484dac1b6dcc48dc6f003d664c61

push time in 2 weeks ago
Sep
26
2 weeks ago
Sep
23
3 weeks ago
Activity icon
delete

lucianoratamero in labcodes/django-react-webpack delete branch update-react-helmet

deleted time in 3 weeks ago
push

lucianoratamero push labcodes/django-react-webpack

lucianoratamero
lucianoratamero

Update react-helmet, removing deprecation warnings

lucianoratamero
lucianoratamero

Merge pull request #58 from labcodes/update-react-helmet

Update react helmet

commit sha: 63c2f8d3653e656de9da34e73f8e12ea186adfc5

push time in 3 weeks ago
pull request

lucianoratamero pull request labcodes/django-react-webpack

lucianoratamero
lucianoratamero

Update react helmet

Link to task: based on #57 , fix #56

How to test:

  • run the app
  • verify no deprecation warnings are logged to the console

Description of your solution: This PR upgrades react-helmet to v6. It's based on the react hooks PR, so be sure to review andmerge it before this one.

Activity icon
issue

lucianoratamero issue labcodes/django-react-webpack

lucianoratamero
lucianoratamero

Update react-helmet

Currently, react-helmet is giving us the following warining message:

image

Updating to v6 fixes the issue.

Previous