mrtuvn

mrtuvn

Full-time Front-end Engineer at @SmartOSC

Member Since 9 years ago

SmartOSC, skype:tunguyenanhvn

Experience Points
42
follower
Lessons Completed
98
follow
Lessons Completed
484
stars
Best Reply Awards
140
repos

273 contributions in the last year

Pinned
⚡ My personal home page by reactjs
⚡ My dotfiles configurations
⚡ Personal Project React based for my music collection
⚡ A place where Magento architectural discussions happen
Activity
Oct
16
2 hours ago
Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

Creditmemos: The store that was requested wasn't found. Verify the store and try again.

Preconditions (*)

  1. Magento 2.4.3

Steps to reproduce (*)

  1. Change website name + storename to something that has a number. Example: '2 Unlimited'
  2. Refund an order
  3. Tab: Credit Memos now gives an error The store that was requested wasn't found. Verify the store and try again. Exception in /data/web/magento2/vendor/magento/module-store/Model/StoreRepository.php:75
  4. Menu -> Sales -> Credit Memos gives an identical error

Expected result (*)

  1. Credit memo grid Shows

Actual result (*)

  1. Credit Memo Grid gives an error.

Workaround: Remove the numbers from the store name and website name

Tested it on an existing 2.4.3 installation + a fresh 2.4.3. installation. I have processed this through xdebug.

  1. It recursively loops trough components starting in: vendor/magento/framework/View/Element/UiComponent/Context.php:255, changing values by pass by reference.
  2. Eventually it will get to the store_id component. It will run the store ID parameter through the following function: vendor/magento/module-store/Ui/Component/Listing/Column/Store.php:93 -> PrepareItem().
  3. Since the functions are all passed by reference, the data changes. The store_id value changes from a simple integer to the following: "2unlimited.nl
       2unlimited
          unlimited
    " Note: the string contains nbsp and br tags
  4. Eventually it loops to the 'subtotal' component: vendor/magento/module-sales/Ui/Component/Listing/Column/Price.php The store_id value that was changed is being used there. Function: prepareDataSource();

$storeId = isset($item['store_id']) && (int)$item['store_id'] !== 0 ? $item['store_id'] : $this->context->getFilterParam('store_id', Store::DEFAULT_STORE_ID); $store = $this->storeManager->getStore( $storeId ); Normally it gives a true & false value on the check, which causes the store_id to be set back to 0. However because there is a number in the storename (see string above), the (int) cast sets the int to 2. It now gives a true & true, and the store_id stays the strange string. 5. In the storerepository it eventually gets to the get() function, where it fails and gives the error. vendor/magento/module-store/Model/StoreRepository.php: line 63, error on line 75.


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • [ X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
mrtuvn
mrtuvn

website/stores ids imho should be restrict and avoid delete. But i think core code not able handle that

Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

A technical problem with the server created an error. Try again to continue what you were doing

hi all i’m a new in magento after i setup ssl certificate let’encription i found this error i try all of this commands

sudo php bin/magento setup:upgrade sudo php bin/magento setup:di:compile sudo php bin/magento setup:static-content:deploy -f sudo php bin/magento indexer:reindex sudo php bin/magento cache:clean sudo php bin/magento cache:flush but still … i need help i use aws bitnami magento 2.4.3.17

Admin log also when i go to bulk log i found this error and bulk log not loading

bulk log

also when do any setting after i save this appear magento admin what can ido everything is stop @magento give me 2.4-develop instance

Summary (*)

Examples (*)

Proposed solution


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users with no workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
mrtuvn
mrtuvn

View log in var/log folder in your magento root may help for find out real problem or issue

Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

Resolve height modal issue on iOS

Description (*)

This problem can reproduce in case we have modal form with enough long content at mobile screen (iOS Devices) If we add action (cta) button at bottom/footer of the modal. User will not able to click to proceed to next step update/edit. Make shop become very bad UX and reduce conversion rate! Also this changes will work with android phones too

Before: (Can't scroll to bottom or click action at bottom) defect

After apply fix: (Now button can click and content form still able scroll) Footer/Header modal remain stay still. Content form can scrollable if content go longer than usually after-fix-modal

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
mrtuvn
mrtuvn

Manually test check for test regression

Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

Resolve height modal issue on iOS

Description (*)

This problem can reproduce in case we have modal form with enough long content at mobile screen (iOS Devices) If we add action (cta) button at bottom/footer of the modal. User will not able to click to proceed to next step update/edit. Make shop become very bad UX and reduce conversion rate! Also this changes will work with android phones too

Before: (Can't scroll to bottom or click action at bottom) defect

After apply fix: (Now button can click and content form still able scroll) Footer/Header modal remain stay still. Content form can scrollable if content go longer than usually after-fix-modal

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
mrtuvn
mrtuvn

@maegnto run WebAPI Tests, Unit Tests, Functional Tests EE, Functional Tests CE

Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

Bug when Creating a Mixin on Magento_GoogleTagManager with AdBlocker enabled

Preconditions Magento 2.4.2 commerce edition mysql 8.0 php 7.4

Steps to reproduce

  • Enable Google Analytics in Stores > Settings > Configuration > Sales >Google API
  • Create any mixins over Magento_GoogleTagManager/js/google-tag-manager-cart or Magento_GoogleTagManager/js/google-analytics-universal
  • Install AdBlocker Adblock Plus - free ad blocker and enable block tracking
  • Go to Checkout

Expected result

  • Checkout is working

Actual result Checkout is loading infinitely

Similar old issues https://github.com/magento/magento2/issues/12428

Technical Investigations This comment https://github.com/magento/magento2/issues/12428#issuecomment-416556613 is suggesting to replace with the old resolver, where the pending check was changed, while this seems to work but we believe it is not the best solution.

the problem is with isRejected function

    function isRejected(module) {
        return registry[module.id] && (registry[module.id].inited || registry[module.id].error);
    }

As we can see, it is checking the registry for the module id, when this condition is checked for the mixins, it is not returning true since .inited is always null, while for the original module it is returning true as expected.

for example when this condition is called for this module id ‘Magento_GoogleTagManager/js/google-tag-manager-cart’ it is returning true, while for the mixins ‘mixins!Magento_GoogleTagManager/js/google-tag-manager-cart’ it is returning false although we expect if the module is rejected the same should be for its mixins.

as a hotfix we tried the following and it worked:

   function isRejected(module) {
       return registry[module.id] && (registry[module.id].inited || registry[module.id].error || (registry[module.name] && registry[module.name].inited));
   }

this is because for mixins module.name is identical to the id of the parent module, similarly, we could just check for the module id after removing mixins! from the beginning.

Special thanks to omarmohssen for investigating.

mrtuvn
mrtuvn

Normal way magento define mixin in file requirejs-config https://devdocs.magento.com/guides/v2.4/javascript-dev-guide/javascript/js_mixins.html I'm not tested with the case enable plugin AdBlock but sometimes magento not call mixin correct as we expected. You also can call mixin like this

define([
    'mixins!ComponentJsPath'
], function () {
    'use strict';

    return function (originMethod) {
        //CODE HERE SOMETIMES NOT REACH
    };
});
Oct
14
2 days ago
Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

Resolve height modal issue on iOS

Description (*)

This problem can reproduce in case we have modal form with enough long content at mobile screen (iOS Devices) If we add action (cta) button at bottom/footer of the modal. User will not able to click to proceed to next step update/edit. Make shop become very bad UX and reduce conversion rate! Also this changes will work with android phones too

Before: (Can't scroll to bottom or click action at bottom) defect

After apply fix: (Now button can click and content form still able scroll) Footer/Header modal remain stay still. Content form can scrollable if content go longer than usually after-fix-modal

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
mrtuvn
mrtuvn

@maegnto run WebAPI Tests, Unit Tests, Functional Tests EE, Functional Tests CE

Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

Resolve height modal issue on iOS

Description (*)

This problem can reproduce in case we have modal form with enough long content at mobile screen (iOS Devices) If we add action (cta) button at bottom/footer of the modal. User will not able to click to proceed to next step update/edit. Make shop become very bad UX and reduce conversion rate! Also this changes will work with android phones too

Before: (Can't scroll to bottom or click action at bottom) defect

After apply fix: (Now button can click and content form still able scroll) Footer/Header modal remain stay still. Content form can scrollable if content go longer than usually after-fix-modal

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
Oct
13
3 days ago
Activity icon
created branch

mrtuvn in mrtuvn/magento2 create branch requirejs-resolve-unexecute-mixins-for-unbundle-case

createdAt 2 days ago
Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

jQuery Widget or UiComponent mixin don't loading or loading randomized

Maybe need additional fixes on #25587 request.

Preconditions (*)

  1. Magento 2.4.x
  2. Google Chrome 92 (cache disabled on devtools)

Steps to reproduce (*)

  1. Fresh install m2 2.4.4 (also problem with all 2.4.x)
  2. Dev mode on
  3. Cache settings (all on, except for layout, block_html, full_page)
  4. Create new theme (luma parent)

theme structure

requirejs-config.js

var config = {
    map: {
        '*': {
            myWidget: 'Magento_Theme/js/my-widget'
        }
   },
   config: {
        mixins: {
            'Magento_Theme/js/my-widget': {
                'Magento_Theme/js/my-widget-mixin': true
            }
        }
    }
};

my-widget.js

define([
    'jquery',
    'jquery-ui-modules/widget'
], function ($) {
    'use strict';

    $.widget('mage.myWidget', {
        options: {
            color: 'red'
        },
        _create: function () {
            $('body').css('background-color', this.options.color);
        }
    });

    return $.mage.myWidget;
});

my-widget-mixin.js

define([
    'jquery',
    'jquery-ui-modules/widget'
], function ($) {
    'use strict';

    return function (widget) {
        $.widget('mage.myWidget', widget, {
            options: {
                color: 'green'
            }
        });

        return $.mage.myWidget;
    }
});

Expected result (*)

Mixin load and background is GREEN 🟢

Actual result (*)

Results depend on cache, opened devtools.

  1. Init widget on js file – mixin don't load (or randomized loading, also loading when devtools opened) Background is RED 🔴 or GREEN 🟢
define([
    'jquery',
    'myWidget'
], function ($, myWidget) {
    'use strict';

    myWidget();
});
  1. Init widget on phtml file – mixin don't load (or randomized loading, also loading when devtools opened) Background is RED 🔴 or GREEN 🟢
require([
    'jquery',
    'myWidget'
], function ($, myWidget) {
    'use strict';

    myWidget();
});
  1. Init widget on js file (with mage) – mixin load (or randomized don't loading) Background is GREEN 🟢 or RED 🔴
require([
    'jquery',
    'mage/mage'
], function ($) {
    'use strict';

    $('body').mage('myWidget', {});
});
  1. Init widget on js file (without alias) – mixin load (or randomized don't loading when devtools opened) Background is GREEN 🟢 or RED 🔴
define([
    'jquery',
    'Magento_Theme/js/my-widget'
], function ($, myWidget) {
    'use strict';

    myWidget();
});
  1. ALSO, when widget don't load and when call widget again (click event, etc) – mixin load Background is RED 🔴, after event is GREEN 🟢
require([
    'jquery',
    'myWidget'
], function ($, myWidget) {
    'use strict';

    myWidget();

    $('.action.mixin').on('click', function () {
        myWidget();
    });
});
  1. Init widget on phtml file with data-mage-initmixin load (works perfectly, without background flashing and mixin preloading) Background is GREEN 🟢
<div data-mage-init='{"myWidget": {}}'></div>
  1. Init widget on phtml file with js x-magento-initmixin load (works perfectly, without background flashing and mixin preloading) Background is GREEN 🟢
<script type="text/x-magento-init">
    {
        "*": {
            "myWidget": {}
        }
    }
</script>
  1. Init widget on js file (with mixins!) – mixin load (works perfectly, without background flashing and mixin preloading) Background is GREEN 🟢
define([
    'jquery',
    'mixins!myWidget'
], function ($, myWidget) {
    'use strict';

    myWidget();
});

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Activity icon
created branch

mrtuvn in mrtuvn/magento2 create branch requirejs-resolver-mixins-patch

createdAt 2 days ago
push

mrtuvn push mrtuvn/magento2

mrtuvn
mrtuvn

PWA-2110: Making GraphQL scalar type definitions backwards-compatible

mrtuvn
mrtuvn

Fixing calls to parent::parseLiteral()

mrtuvn
mrtuvn

Moving override call upstream

mrtuvn
mrtuvn

Merge remote-tracking branch 'mainline/2.4-develop' into PWA-2137-graphql-scalar-typecast

mrtuvn
mrtuvn

Fixing static test failures

mrtuvn
mrtuvn

Fixing static test failures

mrtuvn
mrtuvn

PWA-2137: [GraphQL] Need to bypass webonyx type validation

  • tests
mrtuvn
mrtuvn

Merge remote-tracking branch 'mainline/2.4-develop' into PWA-2137-graphql-scalar-typecast

mrtuvn
mrtuvn

Fixing static test failures

mrtuvn
mrtuvn

B2B-1861: [Test] s3 - Refactor WebAPI tests to add support for Remote Storage

mrtuvn
mrtuvn

B2B-1861: [Test] s3 - Refactor WebAPI tests to add support for Remote Storage

  • fix configurable_products_with_two_attributes_combination.php fixture
mrtuvn
mrtuvn

B2B-1861: [Test] s3 - Refactor WebAPI tests to add support for Remote Storage

  • fix configurable_products_with_two_attributes_combination.php fixture
mrtuvn
mrtuvn

BUG#AC-1245:AdminCreateAndDeleteBackupsTest skipped as backup functionality in magento is deprecated

mrtuvn
mrtuvn

addProductToCompareList mutation for configurable products return items 0

mrtuvn
mrtuvn

MC-42853::Fixed currency conversion in email confirmation of bundle products

mrtuvn
mrtuvn

MC-42853::Added method comments to resolve static tests issues

mrtuvn
mrtuvn

AC-1240::Fix invoice PDF Printout Logo is not uploaded with S3 enabled

mrtuvn
mrtuvn

AC-1240::Fix pr review comments

mrtuvn
mrtuvn

AC-1240::Fix pr review comments

mrtuvn
mrtuvn

AC-1240::Resolve the pr comments

commit sha: e88d5bd6e1b581c56b975e3b8626f6d0b9a1e944

push time in 2 days ago
Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

Bug when Creating a Mixin on Magento_GoogleTagManager with AdBlocker enabled

Preconditions Magento 2.4.2 commerce edition mysql 8.0 php 7.4

Steps to reproduce

  • Enable Google Analytics in Stores > Settings > Configuration > Sales >Google API
  • Create any mixins over Magento_GoogleTagManager/js/google-tag-manager-cart or Magento_GoogleTagManager/js/google-analytics-universal
  • Install AdBlocker Adblock Plus - free ad blocker and enable block tracking
  • Go to Checkout

Expected result

  • Checkout is working

Actual result Checkout is loading infinitely

Similar old issues https://github.com/magento/magento2/issues/12428

Technical Investigations This comment https://github.com/magento/magento2/issues/12428#issuecomment-416556613 is suggesting to replace with the old resolver, where the pending check was changed, while this seems to work but we believe it is not the best solution.

the problem is with isRejected function

    function isRejected(module) {
        return registry[module.id] && (registry[module.id].inited || registry[module.id].error);
    }

As we can see, it is checking the registry for the module id, when this condition is checked for the mixins, it is not returning true since .inited is always null, while for the original module it is returning true as expected.

for example when this condition is called for this module id ‘Magento_GoogleTagManager/js/google-tag-manager-cart’ it is returning true, while for the mixins ‘mixins!Magento_GoogleTagManager/js/google-tag-manager-cart’ it is returning false although we expect if the module is rejected the same should be for its mixins.

as a hotfix we tried the following and it worked:

   function isRejected(module) {
       return registry[module.id] && (registry[module.id].inited || registry[module.id].error || (registry[module.name] && registry[module.name].inited));
   }

this is because for mixins module.name is identical to the id of the parent module, similarly, we could just check for the module id after removing mixins! from the beginning.

Special thanks to omarmohssen for investigating.

mrtuvn
mrtuvn

Do you check the case define mixin in requirejs-config ? Instead use mixins!Magento_GoogleTagManager/js/google-tag-manager-cart Does it work same

Oct
12
4 days ago
Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

Knockout not translateable with text contain single quote character

Summary (*)

Examples (*)

Example this text italiano se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato

As you can see text contain one single quote if we use translate attribute will not work. Same for data-bind

Change text (remove quote) will be workarounds but it's may not be option when sometimes we want keep remain text

Example

<span translate="'se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato'"></span>

or

<span data-bind="i18n: 'se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato'"></span>

Proposed solution


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users with no workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
mrtuvn
mrtuvn
"se hai scelto il ritiro dell\'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato","Test Text should be translated"
Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

Knockout not translateable with text contain single quote character

Summary (*)

Examples (*)

Example this text italiano se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato

As you can see text contain one single quote if we use translate attribute will not work. Same for data-bind

Change text (remove quote) will be workarounds but it's may not be option when sometimes we want keep remain text

Example

<span translate="'se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato'"></span>

or

<span data-bind="i18n: 'se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato'"></span>

Proposed solution


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users with no workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
mrtuvn
mrtuvn

i think this easy to reproduce add this text bind above + your escape in any html file . Example file onepage.html of checkout and reload. Also add text translate to csv too.

Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

Knockout not translateable with text contain single quote character

Summary (*)

Examples (*)

Example this text italiano se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato

As you can see text contain one single quote if we use translate attribute will not work. Same for data-bind

Change text (remove quote) will be workarounds but it's may not be option when sometimes we want keep remain text

Example

<span translate="'se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato'"></span>

or

<span data-bind="i18n: 'se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato'"></span>

Proposed solution


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users with no workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
mrtuvn
mrtuvn

Yes your way work but seem text still not able to translate

Before following ihor way Error visible ko-fail-bind-single-quote-text-contain

After apply escape Error gone but text still not able translate

Activity icon
issue

mrtuvn issue magento/magento2

mrtuvn
mrtuvn

Knockout not translateable with text content quote character

Summary (*)

Examples (*)

Example this text italiano se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato

As you can see text contain one single quote if we use translate attribute will not work. Same for data-bind

Proposed solution


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users with no workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Oct
11
5 days ago
Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

Session size of 276672 exceeded allowed session max size of 256000 - but in Magento 2.4.3 backend

After upgrading to Magento 2.4.3, when we log into backend (admin panel), everypage hangs/is loading about 30 seconds.

In logs we see exceptions: Session size of 276672 exceeded allowed session max size of 256000.

We are ursing Redis for sessions.

Does anybody else have similar issue after upgrading to Magento 2.4.3?

From redis-cli monitor we see that in each second is repeated: 1628681344.757076 [3 127.0.0.1:34310] "hincrby" "sess_1g2sgh25saul85a424puad785d" "lock" "1"

Steps to reproduce (*)

Upgrade Magento 2.4.2-p1 to 2.4.3 Configured Magento to use Redis for session storage Stores -> Configuration -> Advanced -> System -> Security - Max Session Size in Admin and Max Session Size in Storefront set to 100 and Saved Navigate to any page from Admin -

Expected result (*)

It should not break/impact any store functionality

Actual result (*)

Page load time is increased to more than 30 sec

mrtuvn
mrtuvn

Lol so basically no any fixes admin only have set value to 0 for bypass to disable or set value to very big int

Oct
10
6 days ago
started
started time in 5 days ago
pull request

mrtuvn pull request magento/magento2

mrtuvn
mrtuvn

Resolve height modal issue on iOS

Description (*)

This problem can reproduce in case we have modal form with enough long content at mobile screen (iOS Devices) If we add action (cta) button at bottom/footer of the modal. User will not able to click

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
Activity icon
created branch

mrtuvn in mrtuvn/magento2 create branch resolve-height-modal-scroll-inner-on-mobile

createdAt 6 days ago
push

mrtuvn push mrtuvn/magento2

mrtuvn
mrtuvn

github 32996 - create a Directory module region updater that relies on MySQL ordering of regions for the region drop down

mrtuvn
mrtuvn

github: 32996 Add RegionProvider to be responsible for region related directory data

mrtuvn
mrtuvn

Merge branch '2.4-develop' into region-updater-magento2-32996

mrtuvn
mrtuvn

github 32996 - code formatting and typecast region id to keep it compatible with previous regionUpdater implementation

mrtuvn
mrtuvn

Merge branch 'region-updater-magento2-32996' of github.com:magento-engcom/magento2ce into region-updater-magento2-32996

mrtuvn
mrtuvn
mrtuvn
mrtuvn

github 32996 - add region provider view model to multi-shipping address edit

mrtuvn
mrtuvn

Merge branch '2.4-develop' into region-updater-magento2-32996

mrtuvn
mrtuvn

Merge branch '2.4-develop' of github.com:magento-engcom/magento2ce into region-updater-magento2-32996

mrtuvn
mrtuvn

Merge branch '2.4-develop' of github.com:magento-engcom/magento2ce into region-updater-magento2-32996

mrtuvn
mrtuvn

Merge branch '2.4-develop' into region-updater-magento2-32996

mrtuvn
mrtuvn

Merge branch '2.4-develop' of github.com:magento-engcom/magento2ce into region-updater-magento2-32996

mrtuvn
mrtuvn

Merge branch 'region-updater-magento2-32996' of github.com:magento-engcom/magento2ce into region-updater-magento2-32996

mrtuvn
mrtuvn

Merge branch '2.4-develop' of github.com:magento-engcom/magento2ce into region-updater-magento2-32996

mrtuvn
mrtuvn
mrtuvn
mrtuvn
mrtuvn
mrtuvn
mrtuvn
mrtuvn
mrtuvn
mrtuvn
mrtuvn
mrtuvn

Merge pull request #33974 from eduard13/library-matchMedia-removal

Removing the matchMedia polyfill

commit sha: 207c9594132b609e2c2cfa5e765a8faf3d3dfb19

push time in 6 days ago
Oct
8
1 week ago
Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

Add event listeners passive for fotorama lib improves lighthouse metrics

Description (*)

Improve lighthouse metrics score for fotorama js lib

Screenshot from 2020-11-27 22-30-28

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves magento/magento2#31140: Add event listeners passive for fotorama lib improves lighthouse metrics
Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

Add event listeners passive for fotorama lib improves lighthouse metrics

Description (*)

Improve lighthouse metrics score for fotorama js lib

Screenshot from 2020-11-27 22-30-28

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves magento/magento2#31140: Add event listeners passive for fotorama lib improves lighthouse metrics
mrtuvn
mrtuvn

I think this may related with jquery too

Oct
7
1 week ago
Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

Improve template minifier

Description (*)

This PR aims to improve the template minifier by :

  • fixing a variety of cases that are currently handled incorrectly,
  • commenting on each step of the minification process to explain what it does,
  • increasing the exhaustiveness of the corresponding test.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#32153

Manual testing scenarios (*)

  1. See magento/magento2#32153 or the updated test

Questions or comments

It is very likely that there remains cases that are handled incorrectly, mostly in JS code now, but it also is probably impossible to make the process entirely safe as long as the minification happens on the templates, given the mix of PHP and HTML / CSS / JS code.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
mrtuvn
mrtuvn

Lol seem internal team changed something Can you check that @blmage

Oct
6
1 week ago
Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

_prepareLayout() is not able to read _data that you pass onto the block in a controller

Preconditions (*)

  1. Use Magento 2.4.3
  2. Create a controller
  3. create your PageResult, create a blog of your choice and add data via `->setData('my_key', 'my_value');
  4. in your block, create _prepareLayout()
  5. inside the method, do this: `$this->pageConfig->getTitle()->set(__('%1 - Test Title', $this->getData('my_key'));

Steps to reproduce (*)

  1. see preconditions

Expected result (*)

  1. The Title resolves to my_value - Test Title
  2. $this->getData('my_key') returns my_value

Actual result (*)

  1. The title resolves to - Test Title
  2. $this->getData('my_key') returns null in _prepareLayout()

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
mrtuvn
mrtuvn

Short Answer: limitation . I'm not sure why layout not able to access data. Maybe it's doesnt have to be able access to such data

Oct
5
1 week ago
Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

Theme CSS is not including to head on front-end PHP 7.4.24

Preconditions (*)

  1. Magento 2.4.3
  2. PHP 7.4.24

Steps to reproduce (*)

  1. Fresh Magento installation on nginx and php 7.4.23 and after that upgraded php to latest sub release 7.4.24 and head doesn't have any included css expect calender.css

image

  1. As per release note php7 - they have php7.4-xml has update and think it has something that is generating this issue. https://www.php.net/ChangeLog-7.php

Expected result (*)

Should show atleast styles-m.css in source

image

Actual result (*)

Not including any css expect calendar.css

image

mrtuvn
mrtuvn

never got this issue. I don't change any specific in php instance. So i can't reproduce from my end Just curiously is this config pcre.jit always enable (equal 1) ?

Activity icon
issue

mrtuvn issue comment magento/magento2

mrtuvn
mrtuvn

Theme CSS is not including to head on front-end PHP 7.4.24

Preconditions (*)

  1. Magento 2.4.3
  2. PHP 7.4.24

Steps to reproduce (*)

  1. Fresh Magento installation on nginx and php 7.4.23 and after that upgraded php to latest sub release 7.4.24 and head doesn't have any included css expect calender.css

image

  1. As per release note php7 - they have php7.4-xml has update and think it has something that is generating this issue. https://www.php.net/ChangeLog-7.php

Expected result (*)

Should show atleast styles-m.css in source

image

Actual result (*)

Not including any css expect calendar.css

image

mrtuvn
mrtuvn

I think issue may related with theme named "Magento/builtcon" ? Is this custom not from magento

Previous