nunnsy

nunnsy

Member Since 10 years ago

Experience Points
26
follower
Lessons Completed
24
follow
Lessons Completed
53
stars
Best Reply Awards
13
repos

55 contributions in the last year

Pinned
⚡ Simple parallax scrolling effect inspired by Spotify.com implemented as a jQuery plugin
⚡ My personal project for DECO1400 course
⚡ A simple HTML5/JS team score viewer
⚡ A Python Based Sudoku Solver
⚡ DNUI Project for the Smart Mirror
⚡ For touch lights!
Activity
Dec
26
4 weeks ago
started
started time in 4 weeks ago
Dec
18
1 month ago
started
started time in 1 month ago
Dec
6
1 month ago
Dec
5
1 month ago
started
started time in 1 month ago
started
started time in 1 month ago
started
started time in 1 month ago
Dec
3
1 month ago
started
started time in 1 month ago
Dec
2
1 month ago
started
started time in 1 month ago
started
started time in 1 month ago
Nov
29
1 month ago
started
started time in 1 month ago
Nov
28
1 month ago
started
started time in 1 month ago
Nov
20
2 months ago
started
started time in 2 months ago
Nov
19
2 months ago
Activity icon
issue

nunnsy issue comment ccxt/ccxt

nunnsy
nunnsy

New Exchange: Swyftx

Hi CCXT team, Can support for Swyftx exchange be added? - https://www.swyftx.com
API Details - https://docs.swyftx.com.au/
nunnsy
nunnsy

With reference to the sided OHLCV data and the asset IDs, respectively

are [sic] far as the side is concerned - that is correct as the buy and sell volume data will be useful for any analytics that you are looking to do here I'd expect. the ID was previously an integer based on the point at which an asset was added to our platform - however I believe we have since amended this to be the ticker strong, IE 'AUD' or 'BTC'.

It looks as though some items on their API docs need to be updated to correctly reflect their protocol. Will continue playing around with this, but this information may be useful for anyone else writing an implementation.

started
started time in 2 months ago
Nov
17
2 months ago
Activity icon
issue

nunnsy issue comment ccxt/ccxt

nunnsy
nunnsy

New Exchange: Swyftx

Hi CCXT team, Can support for Swyftx exchange be added? - https://www.swyftx.com
API Details - https://docs.swyftx.com.au/
nunnsy
nunnsy

I've contacted their support with a few questions about the API, inclucing some inconsistencies in the documentation. I'll respond here with anything relevant. I'm having a crack at implementing this too but no promises I'll be able to pull it off in a decent timeframe.

Nov
15
2 months ago
Activity icon
issue

nunnsy issue comment home-assistant/core

nunnsy
nunnsy

Add Goodwe solar inverter integration

Proposed change

This PR adds new integration for Goodwesolar inverters. It has been developed and successfully used by large community of users for more than a year as custom component via HACS repo, now it is mature and stable enough to be made part of the HA.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

nunnsy
nunnsy

@mletenay Makes complete sense 👍 - Thank you for including those required for the energy dashboard, that will be fantastic! 🥇

started
started time in 2 months ago
Activity icon
created branch

nunnsy in nunnsy/ccxt create branch swyftx

createdAt 2 months ago
Activity icon
fork

nunnsy forked ccxt/ccxt

⚡ A JavaScript / Python / PHP cryptocurrency trading API with support for more than 100 bitcoin/altcoin exchanges
nunnsy MIT License Updated
fork time in 2 months ago
Nov
13
2 months ago
Activity icon
issue

nunnsy issue comment home-assistant/core

nunnsy
nunnsy

Add Goodwe solar inverter integration

Proposed change

This PR adds new integration for Goodwesolar inverters. It has been developed and successfully used by large community of users for more than a year as custom component via HACS repo, now it is mature and stable enough to be made part of the HA.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

nunnsy
nunnsy

First of all, awesome work on this integration so far!

Couple of quick questions: Is there a reason you chose to use the local network interface rather than polling the SEMS Portal (apart from their questionable JSON keying)? Are you thinking a Cloud-based integration would be separate?

Furthermore, and I could be being naive here, but it seems as though only select fields are classified as "Sensors" whereas the rest are "Diagnostics"

image

To make use of the Energy dashboard, it would seem some more mapping is required to pull the relevant values for these fields as sensors?

image

Cheers!

Nov
12
2 months ago
started
started time in 2 months ago
Previous