oliviertassinari

oliviertassinari

CEO, co-founder at @mui• studied @TelecomPTech • ex @doctolib

Member Since 8 years ago

MUI, Paris, France

Experience Points
2.1k
follower
Lessons Completed
102
follow
Lessons Completed
1.1k
stars
Best Reply Awards
93
repos

3520 contributions in the last year

Pinned
⚡ MUI (formerly Material-UI) is the React UI library you always wanted. Follow your own design system, or start with Material Design.
⚡ MUI X: Build complex and data-rich applications using a growing list of advanced components. We're kicking it off with the most powerful Data Grid on the market.
⚡ Remove unnecessary React propTypes from the production build. :balloon:
⚡ A React component for swipeable views. :snowflake:
⚡ Gatsby plugin for Material-UI with built-in server-side rendering support
⚡ Babel plugin for removing React properties. :dash:
Activity
Dec
8
13 hours ago
open pull request

oliviertassinari wants to merge mui-org/material-ui

oliviertassinari
oliviertassinari

[docs] Add tip to help access the docs of a previous version when finding answers in StackOverflow

Tackles the problem reported at https://github.com/mui-org/material-ui/issues/29764.

This tip could be generally helpful, not only when in this StackOverflow use-case, so wondering if we should place it somewhere else. Open to suggestions :)

Deploy preview: https://deploy-preview-30101--material-ui.netlify.app/getting-started/support/#stackoverflow

oliviertassinari
oliviertassinari

Found it, never mind, my assumption was wrong.

pull request

oliviertassinari merge to mui-org/material-ui

oliviertassinari
oliviertassinari

[docs] Add tip to help access the docs of a previous version when finding answers in StackOverflow

Tackles the problem reported at https://github.com/mui-org/material-ui/issues/29764.

This tip could be generally helpful, not only when in this StackOverflow use-case, so wondering if we should place it somewhere else. Open to suggestions :)

Deploy preview: https://deploy-preview-30101--material-ui.netlify.app/getting-started/support/#stackoverflow

open pull request

oliviertassinari wants to merge mui-org/material-ui

oliviertassinari
oliviertassinari

[docs] Add tip to help access the docs of a previous version when finding answers in StackOverflow

Tackles the problem reported at https://github.com/mui-org/material-ui/issues/29764.

This tip could be generally helpful, not only when in this StackOverflow use-case, so wondering if we should place it somewhere else. Open to suggestions :)

Deploy preview: https://deploy-preview-30101--material-ui.netlify.app/getting-started/support/#stackoverflow

oliviertassinari
oliviertassinari

content that no longer exists in the latest version of the documentation

Do we have an example? I suspect that we could have a 301, without the need to update the docs.

pull request

oliviertassinari merge to mui-org/material-ui

oliviertassinari
oliviertassinari

[docs] Add tip to help access the docs of a previous version when finding answers in StackOverflow

Tackles the problem reported at https://github.com/mui-org/material-ui/issues/29764.

This tip could be generally helpful, not only when in this StackOverflow use-case, so wondering if we should place it somewhere else. Open to suggestions :)

Deploy preview: https://deploy-preview-30101--material-ui.netlify.app/getting-started/support/#stackoverflow

Activity icon
issue

oliviertassinari issue comment mui-org/mui-design-kits

oliviertassinari
oliviertassinari

[figma] Merge light and dark modes in one file

While the MUI Studio team was conducting interviews, a user mentioned that having one Figma file for light mode and another for dark is cumbersome as it demands a duplicated effort to update the other once one has been changed. I'm sure there are benefits to having them separated, especially related to performance given that the file could get considerably larger, but have we considered the option of merging it? I suppose it would be way easier to design with both modes at the same place.

oliviertassinari
oliviertassinari

Should we wait for others input before moving forward with this?

👍

Activity icon
fork

oliviertassinari forked mantinedev/mantine

⚡ React components and hooks library with native dark theme support focused on usability, accessibility and developer experience
oliviertassinari Updated
fork time in 2 hours ago
Dec
7
1 day ago
Activity icon
issue

oliviertassinari issue comment mui-org/material-ui

oliviertassinari
oliviertassinari
oliviertassinari
oliviertassinari

I have added new reviewers to act on the ownership of Docs infra :).

open pull request

oliviertassinari wants to merge mui-org/material-ui

oliviertassinari
oliviertassinari

[docs] Don't run nprogress on shallow routing

Don't show nprogress bar when page transition is instant

Fixes https://github.com/mui-org/material-ui/pull/30075#issuecomment-987268449

Preview: https://deploy-preview-30087--material-ui.netlify.app/

oliviertassinari
oliviertassinari

I have tried the UX, 300ms works for me. However, it seems that this 300ms only accounts for the time it takes to load the page over the network, it doesn't account for the JavaScript-blocking rendering time.

  1. Open https://deploy-preview-30087--material-ui.netlify.app/components/icons/ 2 Click on "Material Icons"
  2. See how it takes 800ms for the page to transition:
Screenshot 2021-12-07 at 13 19 00
  1. No progress bar

I'm not sure we can do much on our side.

open pull request

oliviertassinari wants to merge mui-org/material-ui

oliviertassinari
oliviertassinari

[docs] Don't run nprogress on shallow routing

Don't show nprogress bar when page transition is instant

Fixes https://github.com/mui-org/material-ui/pull/30075#issuecomment-987268449

Preview: https://deploy-preview-30087--material-ui.netlify.app/

oliviertassinari
oliviertassinari

@danilo-leal What do you think about 300ms for a UX/UI perspective? I proposed this value in #22486, based on theoretical values: https://mui.com/components/progress/#delaying-appearance. But I didn't try the experience.

Dec
6
2 days ago
open pull request

oliviertassinari wants to merge mui-org/material-ui

oliviertassinari
oliviertassinari

[icons] Sync icon search UI state with the url

This PR syncs the state of the icon search UI with the url of the page to make deep linking possible. Fixes: https://github.com/mui-org/material-ui/issues/25053 Demo: https://deploy-preview-30075--material-ui.netlify.app/components/material-icons/

To Do:

  • parameters seems to be reset when opening a url, but only in production.
oliviertassinari
oliviertassinari

Do we need the React.useCallback on this one? The prop seems to be provided to the component directly

  const handleQueryChange = 
open pull request

oliviertassinari wants to merge mui-org/material-ui

oliviertassinari
oliviertassinari

[icons] Sync icon search UI state with the url

This PR syncs the state of the icon search UI with the url of the page to make deep linking possible. Fixes: https://github.com/mui-org/material-ui/issues/25053 Demo: https://deploy-preview-30075--material-ui.netlify.app/components/material-icons/

To Do:

  • parameters seems to be reset when opening a url, but only in production.
oliviertassinari
oliviertassinari

lodash debounce has a debounced.cancel method (ours is clear). We could consider calling it to avoid URL search leaks when unmounting this component.

open pull request

oliviertassinari wants to merge mui-org/material-ui

oliviertassinari
oliviertassinari

[icons] Sync icon search UI state with the url

This PR syncs the state of the icon search UI with the url of the page to make deep linking possible. Fixes: https://github.com/mui-org/material-ui/issues/25053 Demo: https://deploy-preview-30075--material-ui.netlify.app/components/material-icons/

To Do:

  • parameters seems to be reset when opening a url, but only in production.
oliviertassinari
oliviertassinari

Not sure about having shared utils for this one yet (used once). The logic doesn't seem concurrent mode compatible 😁 (updating a ref in the render)

open pull request

oliviertassinari wants to merge mui-org/material-ui

oliviertassinari
oliviertassinari

[icons] Sync icon search UI state with the url

This PR syncs the state of the icon search UI with the url of the page to make deep linking possible. Fixes: https://github.com/mui-org/material-ui/issues/25053 Demo: https://deploy-preview-30075--material-ui.netlify.app/components/material-icons/

To Do:

  • parameters seems to be reset when opening a url, but only in production.
oliviertassinari
oliviertassinari

We know have our own debounce util from '@mui/utils', maybe we should use it here?

pull request

oliviertassinari merge to mui-org/material-ui

oliviertassinari
oliviertassinari

[icons] Sync icon search UI state with the url

This PR syncs the state of the icon search UI with the url of the page to make deep linking possible. Fixes: https://github.com/mui-org/material-ui/issues/25053 Demo: https://deploy-preview-30075--material-ui.netlify.app/components/material-icons/

To Do:

  • parameters seems to be reset when opening a url, but only in production.
oliviertassinari
oliviertassinari
pull request

oliviertassinari merge to mui-org/material-ui

oliviertassinari
oliviertassinari

[icons] Sync icon search UI state with the url

This PR syncs the state of the icon search UI with the url of the page to make deep linking possible. Fixes: https://github.com/mui-org/material-ui/issues/25053 Demo: https://deploy-preview-30075--material-ui.netlify.app/components/material-icons/

To Do:

  • parameters seems to be reset when opening a url, but only in production.
oliviertassinari
oliviertassinari
pull request

oliviertassinari merge to mui-org/material-ui

oliviertassinari
oliviertassinari

[docs] Don't run nprogress on shallow routing

Don't show nprogress bar when page transition is instant

Fixes https://github.com/mui-org/material-ui/pull/30075#issuecomment-987268449

oliviertassinari
oliviertassinari

Nice, makes a lot of sense! (We will still have to fix the fast route page transition, but this one is a good win)

pull request

oliviertassinari merge to mui-org/material-ui

oliviertassinari
oliviertassinari

[docs] Don't run nprogress on shallow routing

Don't show nprogress bar when page transition is instant

Fixes https://github.com/mui-org/material-ui/pull/30075#issuecomment-987268449

oliviertassinari
oliviertassinari

Nice, makes a lot of sense!

Activity icon
delete

oliviertassinari in oliviertassinari/material-ui delete branch batch-small-changes

deleted time in 1 day ago
Activity icon
issue

oliviertassinari issue comment mui-org/material-ui

oliviertassinari
oliviertassinari

[icons] Sync icon search UI state with the url

This PR syncs the state of the icon search UI with the url of the page to make deep linking possible. Fixes: https://github.com/mui-org/material-ui/issues/25053 Demo: https://deploy-preview-30075--material-ui.netlify.app/components/material-icons/

To Do:

  • parameters seems to be reset when opening a url, but only in production.
oliviertassinari
oliviertassinari

(The NProgress trigger bug seems expected, it's a bug we should fix at a different level. There is no need for it when the page transition is instant, it makes things worse in this context, not better.)

Activity icon
delete
deleted time in 1 day ago
push

oliviertassinari push mui-org/material-ui-x

oliviertassinari
oliviertassinari

[docs] Disable the ad when not MIT (#3334)

commit sha: 3eac4962ae947a7997029bd327729e14f87ef551

push time in 1 day ago
Activity icon
issue

oliviertassinari issue comment mui-org/material-ui-x

oliviertassinari
oliviertassinari

[docs] Disable the ad when not MIT

Take https://mui.com/components/data-grid/events/ as an example:

Screenshot 2021-12-05 at 00 09 46

We display an ad at the top and below the demos:

Screenshot 2021-12-05 at 00 10 48

This is not needed for commercial licensed software.

oliviertassinari
oliviertassinari

cc @mui-org/x for knowledge sharing (I'm not sure this is known to most)

pull request

oliviertassinari pull request mui-org/material-ui-x

oliviertassinari
oliviertassinari

[docs] Disable the ad when not MIT

Take https://mui.com/components/data-grid/events/ as an example:

Screenshot 2021-12-05 at 00 09 46

We display an ad at the top and below the demos:

Screenshot 2021-12-05 at 00 10 48

This is not needed for commercial licensed software.

Activity icon
issue

oliviertassinari issue mui-org/mui-design-kits

oliviertassinari
oliviertassinari

[sketch] Add Card component back?

We got this review:

The quality of the library is good but i must admit it was more easy to work with version 4. Within version 5 you are missing the cards. Are they comming back?

@software-vision.com

Should we do something about it?

Activity icon
delete
deleted time in 1 day ago
Previous