raix

raix

TypeScript/React developer Sunsetting Meteor packages, please use other packages/pin versions or clone

Member Since 10 years ago

Looking for new opportunities, Kingdom of Denmark

Experience Points
251
follower
Lessons Completed
15
follow
Lessons Completed
295
stars
Best Reply Awards
26
repos

48 contributions in the last year

Pinned
⚡ GroundDB is a thin layer providing Meteor offline database and methods
⚡ DEPRECATED: Push notifications for cordova (ios, android) browser (Chrome, Safari, Firefox)
⚡ DEPRECATED: Handy handlers for Meteor handlebars
⚡ Reactive file manager for Meteor
⚡ LOOKING FOR MAINTAINERS. Perl debugger extension for visual studio code
Activity
Jan
17
1 week ago
Activity icon
issue

raix issue comment facebook/create-react-app

raix
raix

Add swc transpilation behind a flag

This pr swaps out babel and use swc for transpiling code building/testing

Overview:

  • Make start/build/test work with swc
  • fix any broken tests
  • enable browserlists support
  • Remove support for Flow (currently not supported in swc)
  • load project tsconfig/jsconfig and map into swc config
  • ~use ts-jest for jest ts/tsx file transformation (keeping an eye on stc)~ (keeping the scope of the pr to swc)
  • QA if project browserslist config is working
  • QA project tsconfig mapping works
  • ~QA project tsconfig is loaded in ts-jest~
  • Add babel back
  • Move js/ts transformation out into separate files for swc and babel
  • Add and document SWC_TRANSFORM
  • QA both babel and swc configurations
  • Allow comments in jsconfig.json - we use this file to configure swc in non TypeScript projects
  • Cover by tests - reuse the kitchensink?

Notes:

  • Currently eslint use use babel parser (waiting for someone to write eslint in rust / swc ast or transform swc ast to espree ast?)

Dependency updates:

  • remove tar-pack seems to be unmaintained had a dependency on tar 2.x - we are now on tar 6.x
  • jest patch update to 27.4.4

BREAKING CHANGE:

raix
raix

Thanks @kdy1 this pr doesn't remove babel transform due to eslint, it sounds like it could be fairly trivial to create a swc-parser for eslint, if the espree ast is already in swc?

Dec
27
4 weeks ago
push

raix push raix/TypeScript

raix
raix

Update parseInt parameter name and jsdoc (#42756)

  • feat(lib): improve parseInt type definition and docstring

  • Accepted baselines

  • update tests

raix
raix
raix
raix

Remove undefined from optional properties when inferring to index signatures (#43086)

  • Remove undefined from optional properties when inferring to index signatures

  • Add tests

raix
raix

Exclude enum/number compatibility rule from comparable relation (#42472)

  • Exclude old number/enum literal compatibility rule from comparable relation

  • Add tests

  • Accept new baselines

raix
raix
raix
raix
raix
raix
raix
raix

fix(42380): include JSDoc comments in declarations for static/prototype methods (#42454)

raix
raix

Fix37991 (#43166)

  • Add failing test

  • Fix tslib check errors for commonjs imports

raix
raix

Don't inherit jsdoc tags from overloaded signatures (#43165)

Previously, when getting jsdoc for signatures, the services layer would get the jsdoc tags for the base symbol of a signature if it was present. This is fine except when the base was overloaded. In that case, the multiple signatures of the overload would all contribute jsdoc, which is not correct.

A more correct fix would be to resolve overloads to the base, but the compiler doesn't have this capability and adding it or jury-rigging it seems like it would be complex, inappropriate for a fix to ship in a patch version.

Co-authored-by: Orta Therox [email protected]

Co-authored-by: Orta Therox [email protected]

raix
raix

Clearifies protected error message (#42599)

raix
raix

Optimize the size for tsbuildinfo (#43155)

  • Baseline readable buildinfo

  • Use file names as index in file name list This is extension of the idea given by @sokra to optimize size of tsbuildinfo

  • Deduplicate reference map lists and use file name index to sort them Different implementation of #43079 based on idea suggested by @sokra

  • Minimal json.stringify for the tsbuildinfo Again implementaion of suggestion by @sokra

  • Update src/testRunner/unittests/tsbuild/helpers.ts

Co-authored-by: Tobias Koppers [email protected]

  • Readable version of buildinfo all the time

  • Some renames for readability as per feedback

Co-authored-by: Tobias Koppers [email protected]

raix
raix

Ensure that when new file affecting global scope is added, the signatures are updated (#43084)

  • Ensure that when new file affecting global scope is added, the signatures are updated

  • Update src/compiler/builder.ts

  • Better comment

raix
raix
raix
raix

fix(42265): Error accessing abstract property in constructor via destructuring (#42276)

raix
raix

Fix missing func modifier (#40379)

  • Fix missing function modifier

  • Update src/services/refactors/convertArrowFunctionOrFunctionExpression.ts

Co-authored-by: Ron Buckton [email protected]

Co-authored-by: Ron Buckton [email protected]

raix
raix

Add target: ES2021 (#41239)

  • Support target: es2020

  • use CRLF

  • update symbols

Co-authored-by: Nathan Shively-Sanders [email protected]

raix
raix
raix
raix

fix(41027): handle unused static members (#41103)

raix
raix

Don't crash when renaming a JS property declared via module.exports (#40297)

Fixes #38070

When the originating definition was of the form

module.exports.foo = expr

we were incorrectly trying to call resolveName on just the foo portion to get the "local" symbol, which simply failed to resolve (or would have resolved to the wrong thing), but for this form, the local symbol is just the containing property access expression

commit sha: ef9fd97e4dbcc0a26fa5bac7007e8bfa594ccccd

push time in 4 weeks ago
Dec
20
1 month ago
Activity icon
issue

raix issue comment facebook/create-react-app

raix
raix

WebSocket connection to 'ws://localhost:3000/ws' failed:

Basic React App doesn't work because the websocket connection appears to be hardcoded to port 3000. Part of this appears to be related to running in a container, but I've discovered additional issues even when running local.

Example project here - https://github.com/Fosol/bug-hot-reload

npm: 7.24.0 yarn: 1.22.5 node: v16.10.0 react-scripts: 5.0.0

I have cleared node_modules and performed all the mentioned steps.

Error message here.

WebSocket connection to 'ws://localhost:3000/ws' failed:

If I use port 3000 the error disappears, but nothing works.

Environment

System: OS: Windows 10 10.0.19044 CPU: (16) x64 AMD Ryzen 7 3700X 8-Core Processor Binaries: Node: 16.10.0 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD npm: 7.24.0 - C:\Program Files\nodejs\npm.CMD Browsers: Chrome: 96.0.4664.110 Edge: Spartan (44.19041.1266.0), Chromium (96.0.1054.57) Internet Explorer: 11.0.19041.1202 npmPackages: react: 17.0.2 => 17.0.2 react-dom: 17.0.2 => 17.0.2 react-scripts: 5.0.0 => 5.0.0 npmGlobalPackages: create-react-app: Not Found

Steps to reproduce

  1. Clone repo - https://github.com/Fosol/bug-hot-reload
  2. Run command docker-compose up -d
  3. Open browser http://localhost:5000

Expected behavior

Application should work and hot reload should work.

Actual behavior

Application doesn't work and hot reload doesn't work. Additionally, it requires rebuilding the image to get any changes. A refresh doesn't work.

Reproducible demo

Repo here - https://github.com/Fosol/bug-hot-reload

raix
raix

WDS_SOCKET_PORT=0 Will use window location, still think its a misconfig in CRA but I'll check history in wds server to look for other clues

Activity icon
issue

raix issue comment facebook/create-react-app

raix
raix

babel-preset-react-app dependency error - Yarn 3

Describe the bug

When attempting to use create-react-app with yarn 3, running the scripts returns the following error

Error: [BABEL] src/index.tsx: babel-preset-react-app tried to access @babel/plugin-proposal-private-property-in-object, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Did you try recovering your dependencies?

3.1.1

Which terms did you search for in User Guide?

N/A

Environment

  current version of create-react-app: 4.0.3
  running from /Users/mez/.npm/_npx/c67e74de0542c87c/node_modules/create-react-app

  System:
    OS: macOS 12.1
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 14.18.1 - ~/.nvm/versions/node/v14.18.1/bin/node
    Yarn: 3.1.1 - ~/.nvm/versions/node/v14.18.1/bin/yarn
    npm: 8.1.2 - ~/.nvm/versions/node/v14.18.1/bin/npm
  Browsers:
    Chrome: Not Found
    Edge: Not Found
    Firefox: Not Found
    Safari: 15.2
  npmPackages:
    react: Not Found
    react-dom: Not Found
    react-scripts: Not Found
  npmGlobalPackages:
    create-react-app: Not Found

Steps to reproduce

mkdir foo
cd foo
yarn set version berry
yarn create react-app . --template all
yarn start

Expected behavior

App would start

Actual behavior

Multitude of errors, including the above regarding issue with dependency (others are resolvable by adding the dependencies manually)

Reproducible demo

https://github.com/Mezzle/cra-yarn-bug-example

raix
raix

Thanks! #11751 is added to 5.0.1 milestone

Activity icon
issue

raix issue comment facebook/create-react-app

raix
raix

WebSocket connection to 'ws://localhost:3000/ws' failed:

Basic React App doesn't work because the websocket connection appears to be hardcoded to port 3000. Part of this appears to be related to running in a container, but I've discovered additional issues even when running local.

Example project here - https://github.com/Fosol/bug-hot-reload

npm: 7.24.0 yarn: 1.22.5 node: v16.10.0 react-scripts: 5.0.0

I have cleared node_modules and performed all the mentioned steps.

Error message here.

WebSocket connection to 'ws://localhost:3000/ws' failed:

If I use port 3000 the error disappears, but nothing works.

Environment

System: OS: Windows 10 10.0.19044 CPU: (16) x64 AMD Ryzen 7 3700X 8-Core Processor Binaries: Node: 16.10.0 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD npm: 7.24.0 - C:\Program Files\nodejs\npm.CMD Browsers: Chrome: 96.0.4664.110 Edge: Spartan (44.19041.1266.0), Chromium (96.0.1054.57) Internet Explorer: 11.0.19041.1202 npmPackages: react: 17.0.2 => 17.0.2 react-dom: 17.0.2 => 17.0.2 react-scripts: 5.0.0 => 5.0.0 npmGlobalPackages: create-react-app: Not Found

Steps to reproduce

  1. Clone repo - https://github.com/Fosol/bug-hot-reload
  2. Run command docker-compose up -d
  3. Open browser http://localhost:5000

Expected behavior

Application should work and hot reload should work.

Actual behavior

Application doesn't work and hot reload doesn't work. Additionally, it requires rebuilding the image to get any changes. A refresh doesn't work.

Reproducible demo

Repo here - https://github.com/Fosol/bug-hot-reload

raix
raix

Its a bug, not a breaking change (its a bug in the webpack or wds config in CRA - Its one config url we need to remove just need to remember which one...)

Dec
19
1 month ago
Activity icon
issue

raix issue comment facebook/create-react-app

raix
raix

WebSocket connection to 'ws://localhost:3000/ws' failed:

Basic React App doesn't work because the websocket connection appears to be hardcoded to port 3000. Part of this appears to be related to running in a container, but I've discovered additional issues even when running local.

Example project here - https://github.com/Fosol/bug-hot-reload

npm: 7.24.0 yarn: 1.22.5 node: v16.10.0 react-scripts: 5.0.0

I have cleared node_modules and performed all the mentioned steps.

Error message here.

WebSocket connection to 'ws://localhost:3000/ws' failed:

If I use port 3000 the error disappears, but nothing works.

Environment

System: OS: Windows 10 10.0.19044 CPU: (16) x64 AMD Ryzen 7 3700X 8-Core Processor Binaries: Node: 16.10.0 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD npm: 7.24.0 - C:\Program Files\nodejs\npm.CMD Browsers: Chrome: 96.0.4664.110 Edge: Spartan (44.19041.1266.0), Chromium (96.0.1054.57) Internet Explorer: 11.0.19041.1202 npmPackages: react: 17.0.2 => 17.0.2 react-dom: 17.0.2 => 17.0.2 react-scripts: 5.0.0 => 5.0.0 npmGlobalPackages: create-react-app: Not Found

Steps to reproduce

  1. Clone repo - https://github.com/Fosol/bug-hot-reload
  2. Run command docker-compose up -d
  3. Open browser http://localhost:5000

Expected behavior

Application should work and hot reload should work.

Actual behavior

Application doesn't work and hot reload doesn't work. Additionally, it requires rebuilding the image to get any changes. A refresh doesn't work.

Reproducible demo

Repo here - https://github.com/Fosol/bug-hot-reload

raix
raix

@Fosol If you set the environment variable WDS_SOCKET_PORT="location" does it then work as expected? (If so we might want to set default values for sockPort etc. in the webpackDevServer.config.js ref WDS docs)

Activity icon
issue

raix issue comment facebook/create-react-app

raix
raix

In v5 can't use import * as styles with css modules, bug?

Hello, after upgrading to v5 I can not use anymore named import such as

import * as styles from './Table.module.css';

This results in the following error

export 'table' (imported as 'styles') was not found in './Table.module.css' (possible exports: default)

Is this a bug? I can not find any workaround.

Thank you for any help.

raix
raix

Thanks for reporting @mikoleg - does import styles from './Table.module.css'; work?

Activity icon
issue

raix issue comment facebook/create-react-app

raix
raix

WebSocket connection to 'ws://localhost:3000/ws' failed:

Basic React App doesn't work because the websocket connection appears to be hardcoded to port 3000. Part of this appears to be related to running in a container, but I've discovered additional issues even when running local.

Example project here - https://github.com/Fosol/bug-hot-reload

npm: 7.24.0 yarn: 1.22.5 node: v16.10.0 react-scripts: 5.0.0

I have cleared node_modules and performed all the mentioned steps.

Error message here.

WebSocket connection to 'ws://localhost:3000/ws' failed:

If I use port 3000 the error disappears, but nothing works.

Environment

System: OS: Windows 10 10.0.19044 CPU: (16) x64 AMD Ryzen 7 3700X 8-Core Processor Binaries: Node: 16.10.0 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD npm: 7.24.0 - C:\Program Files\nodejs\npm.CMD Browsers: Chrome: 96.0.4664.110 Edge: Spartan (44.19041.1266.0), Chromium (96.0.1054.57) Internet Explorer: 11.0.19041.1202 npmPackages: react: 17.0.2 => 17.0.2 react-dom: 17.0.2 => 17.0.2 react-scripts: 5.0.0 => 5.0.0 npmGlobalPackages: create-react-app: Not Found

Steps to reproduce

  1. Clone repo - https://github.com/Fosol/bug-hot-reload
  2. Run command docker-compose up -d
  3. Open browser http://localhost:5000

Expected behavior

Application should work and hot reload should work.

Actual behavior

Application doesn't work and hot reload doesn't work. Additionally, it requires rebuilding the image to get any changes. A refresh doesn't work.

Reproducible demo

Repo here - https://github.com/Fosol/bug-hot-reload

raix
raix

@Fosol I took a quick look yesterday, but no luck - feel free to help debug etc. I'll post if I get closer to figuring it out - also looking at #11762 they could be related/or not. (I'm a bit on/off + holidays are getting closer so any help appreciated :christmas_tree: :gift:)

Will have to look into WDS changelog again (they have been changing the configuration schema quite a bit) - maybe have to dig into CRA v4 behavior before figuring out the root cause.

We could likely treat the symptom by setting the WDS_SOCKET_PORT=3000 but would expect that to be set automatically...(I vaugly remember :older_man: something about the client defaulting to window.location.href if some value was not set, should be in the wds source code - might be a value named something like "public" :thinking:)

Activity icon
issue

raix issue facebook/create-react-app

raix
raix

Vulnerabilities!?

Sorry for this but i created app from cli "npx create-react-app" so i got 6 moderate severity vulnerabilities but i don't know about it and one time more i created app from cli also i got that(second time).

image

Thank You For CLI...!

Activity icon
issue

raix issue comment facebook/create-react-app

raix
raix

Vulnerabilities!?

Sorry for this but i created app from cli "npx create-react-app" so i got 6 moderate severity vulnerabilities but i don't know about it and one time more i created app from cli also i got that(second time).

image

Thank You For CLI...!

raix
raix

Also please read the pinned issue: https://github.com/facebook/create-react-app/issues/11174

@HamidShaikh1499 when reading the text it seems like it want to install [email protected]:

fix available via `npm audit fix --force`
Will install [email protected], which is a breaking change
...

I'm closing this issue, we are tracking updating dependencies

Activity icon
issue

raix issue comment facebook/create-react-app

raix
raix

Vulnerabilities!?

Sorry for this but i created app from cli "npx create-react-app" so i got 6 moderate severity vulnerabilities but i don't know about it and one time more i created app from cli also i got that(second time).

image

Thank You For CLI...!

raix
raix

#11780 should update svgr #11739 removes tar-pack

Activity icon
issue

raix issue facebook/create-react-app

raix
raix

CRA not using yarn

Describe the bug

When creating a new app with CRA, CRA is not using yarn, but NPM.

(Write your answer here.)

Did you try recovering your dependencies?

(Write your answer here.)

No because this is related when creating a new CRA app.

Which terms did you search for in User Guide?

I didn't search in User Guide because formerly this behaviour wasn't here.

(Write your answer here if relevant.)

Environment

(paste the output of the command here.)


  Environment Info:
  current version of create-react-app: 5.0.0
  running from /home/k.fernando/.config/yarn/global/node_modules/create-react-app

  System:
    OS: Linux 5.10 Ubuntu 20.04 LTS (Focal Fossa)
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
  Binaries:
    Node: 16.13.1 - ~/.nvm/versions/node/v16.13.1/bin/node
    Yarn: 1.22.17 - /usr/bin/yarn
    npm: 8.1.2 - ~/.nvm/versions/node/v16.13.1/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
  npmPackages:
    react: Not Found
    react-dom: Not Found
    react-scripts: Not Found
  npmGlobalPackages:
    create-react-app: Not Found
  • WSL2

Steps to reproduce

(Write your steps here:)

  1. Use the last version of CRA
  2. If you have yarn, then create a new project with CRA
  3. Normally, CRA should use yarn instead of NPM, but in this bug, CRA is using NPM

Expected behavior

(Write what you thought would happen.)

Should use yarn.

Actual behavior

(Write what happened. Please add screenshots!)

Using NPM.

4

Reproducible demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

Activity icon
issue

raix issue comment facebook/create-react-app

raix
raix

CRA not using yarn

Describe the bug

When creating a new app with CRA, CRA is not using yarn, but NPM.

(Write your answer here.)

Did you try recovering your dependencies?

(Write your answer here.)

No because this is related when creating a new CRA app.

Which terms did you search for in User Guide?

I didn't search in User Guide because formerly this behaviour wasn't here.

(Write your answer here if relevant.)

Environment

(paste the output of the command here.)


  Environment Info:
  current version of create-react-app: 5.0.0
  running from /home/k.fernando/.config/yarn/global/node_modules/create-react-app

  System:
    OS: Linux 5.10 Ubuntu 20.04 LTS (Focal Fossa)
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
  Binaries:
    Node: 16.13.1 - ~/.nvm/versions/node/v16.13.1/bin/node
    Yarn: 1.22.17 - /usr/bin/yarn
    npm: 8.1.2 - ~/.nvm/versions/node/v16.13.1/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
  npmPackages:
    react: Not Found
    react-dom: Not Found
    react-scripts: Not Found
  npmGlobalPackages:
    create-react-app: Not Found
  • WSL2

Steps to reproduce

(Write your steps here:)

  1. Use the last version of CRA
  2. If you have yarn, then create a new project with CRA
  3. Normally, CRA should use yarn instead of NPM, but in this bug, CRA is using NPM

Expected behavior

(Write what you thought would happen.)

Should use yarn.

Actual behavior

(Write what happened. Please add screenshots!)

Using NPM.

4

Reproducible demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

raix
raix

@germanamz see https://github.com/facebook/create-react-app/issues/11778#issuecomment-996488034 - from my point of view is is as intended.

If installing globally on the system I don't think theres a safe way of detecting the intent when creating a new project to use either yarn or npm - therefor npm will be used as default. (@lukekarrys please correct me if I'm wrong) (global npm install of packages are generally not recommended)

I'll close the issue - let me know if you if yarn create react-app doesn't produce a yarn based project or if npx create-react-app doesn't produce a npm based project.

Activity icon
issue

raix issue comment facebook/create-react-app

raix
raix

Add swc transpilation behind a flag

This pr swaps out babel and use swc for transpiling code building/testing

Overview:

  • Make start/build/test work with swc
  • fix any broken tests
  • enable browserlists support
  • Remove support for Flow (currently not supported in swc)
  • load project tsconfig/jsconfig and map into swc config
  • ~use ts-jest for jest ts/tsx file transformation (keeping an eye on stc)~ (keeping the scope of the pr to swc)
  • QA if project browserslist config is working
  • QA project tsconfig mapping works
  • ~QA project tsconfig is loaded in ts-jest~
  • Add babel back
  • Move js/ts transformation out into separate files for swc and babel
  • Add and document SWC_TRANSFORM
  • QA both babel and swc configurations
  • Allow comments in jsconfig.json - we use this file to configure swc in non TypeScript projects
  • Cover by tests - reuse the kitchensink?

Notes:

  • Currently eslint use use babel parser (waiting for someone to write eslint in rust / swc ast or transform swc ast to espree ast?)

Dependency updates:

  • remove tar-pack seems to be unmaintained had a dependency on tar 2.x - we are now on tar 6.x
  • jest patch update to 27.4.4

BREAKING CHANGE:

raix
raix

@mrmckeb regarding #7426 this pr adds support for comments in jsconfig.json - the pr uses jsconfig.json to configure swc language features - a project could then use jsconfig.json for configuring the IDE and swc without using TypeScript. I went for JSON5 as npm why json5 showed usage in multiple dependencies already.

open pull request

raix wants to merge facebook/create-react-app

raix
raix

Add swc transpilation behind a flag

This pr swaps out babel and use swc for transpiling code building/testing

Overview:

  • Make start/build/test work with swc
  • fix any broken tests
  • enable browserlists support
  • Remove support for Flow (currently not supported in swc)
  • load project tsconfig/jsconfig and map into swc config
  • ~use ts-jest for jest ts/tsx file transformation (keeping an eye on stc)~ (keeping the scope of the pr to swc)
  • QA if project browserslist config is working
  • QA project tsconfig mapping works
  • ~QA project tsconfig is loaded in ts-jest~
  • Add babel back
  • Move js/ts transformation out into separate files for swc and babel
  • Add and document SWC_TRANSFORM
  • QA both babel and swc configurations
  • Allow comments in jsconfig.json - we use this file to configure swc in non TypeScript projects
  • Cover by tests - reuse the kitchensink?

Notes:

  • Currently eslint use use babel parser (waiting for someone to write eslint in rust / swc ast or transform swc ast to espree ast?)

Dependency updates:

  • remove tar-pack seems to be unmaintained had a dependency on tar 2.x - we are now on tar 6.x
  • jest patch update to 27.4.4

BREAKING CHANGE:

pull request

raix merge to facebook/create-react-app

raix
raix

Add swc transpilation behind a flag

This pr swaps out babel and use swc for transpiling code building/testing

Overview:

  • Make start/build/test work with swc
  • fix any broken tests
  • enable browserlists support
  • Remove support for Flow (currently not supported in swc)
  • load project tsconfig/jsconfig and map into swc config
  • ~use ts-jest for jest ts/tsx file transformation (keeping an eye on stc)~ (keeping the scope of the pr to swc)
  • QA if project browserslist config is working
  • QA project tsconfig mapping works
  • ~QA project tsconfig is loaded in ts-jest~
  • Add babel back
  • Move js/ts transformation out into separate files for swc and babel
  • Add and document SWC_TRANSFORM
  • QA both babel and swc configurations
  • Allow comments in jsconfig.json - we use this file to configure swc in non TypeScript projects
  • Cover by tests - reuse the kitchensink?

Notes:

  • Currently eslint use use babel parser (waiting for someone to write eslint in rust / swc ast or transform swc ast to espree ast?)

Dependency updates:

  • remove tar-pack seems to be unmaintained had a dependency on tar 2.x - we are now on tar 6.x
  • jest patch update to 27.4.4

BREAKING CHANGE:

push

raix push raix/create-react-app

raix
raix

Fix typo of runtime classic

raix
raix

Support comments in jsconfig.json

Using JSON5 as projects with jsconfig.json might not have TypeScript installed - eg. VS Code reads the config + SWC is also configured via jsconfig.json in projects without TypeScript.

commit sha: 6dab0986b3c3b2de058650e5749ad02870377914

push time in 1 month ago
open pull request

raix wants to merge facebook/create-react-app

raix
raix

V5 add back support for node builtins

Fixed #11756 by adding option to install nodeJS builtin fallbacks

  • Document the escape hatch and why not to use it
  • Improve the error message from Webpack 5 - make it more developer friendly pointing to the documentation
  • Maybe add an extra check of the package main fields (e.g. if the package has "browser" main field then advice to report an issue - it should not rely on nodejs built in modules)
pull request

raix merge to facebook/create-react-app

raix
raix

V5 add back support for node builtins

Fixed #11756 by adding option to install nodeJS builtin fallbacks

  • Document the escape hatch and why not to use it
  • Improve the error message from Webpack 5 - make it more developer friendly pointing to the documentation
  • Maybe add an extra check of the package main fields (e.g. if the package has "browser" main field then advice to report an issue - it should not rely on nodejs built in modules)
Activity icon
issue

raix issue comment facebook/create-react-app

raix
raix

After Uninstall create-react-app from global everytime start the development server always there is warning

When I'm wanna create react app there is warning that said i need to uninstall create-react-app globally so i did and its work but everytime im start the development server there is always assets is showing up and showing an warning that i dont know how to get rid of it ok ok1

raix
raix
Activity icon
issue

raix issue comment facebook/create-react-app

raix
raix

After Uninstall create-react-app from global everytime start the development server always there is warning

When I'm wanna create react app there is warning that said i need to uninstall create-react-app globally so i did and its work but everytime im start the development server there is always assets is showing up and showing an warning that i dont know how to get rid of it ok ok1

raix
raix

The output is expected in v5 - this issue is about a warning?

Dec
18
1 month ago
Activity icon
issue

raix issue comment facebook/create-react-app

raix
raix

fix: ignore webpack warnings by source-map-loader

Some third party packages may ship miss-configured sourcemaps, that interrupts the build See: https://github.com/facebook/create-react-app/discussions/11278#discussioncomment-1780169

To trigger the error, simply install "[email protected]" add import {} from "stylis-plugin-rtl" somewhere in the code

before: Screen Shot 2021-12-14 at 21 34 23

After: Screen Shot 2021-12-14 at 21 35 07

raix
raix

@Bnaya I've tried rerunning the tests, but seem to be an issue either with caching or lock file - When doing npm install in the create-react-app project does it generate a new package-lock.json?

Activity icon
issue

raix issue comment facebook/create-react-app

raix
raix

After Uninstall create-react-app from global everytime start the development server always there is warning

When I'm wanna create react app there is warning that said i need to uninstall create-react-app globally so i did and its work but everytime im start the development server there is always assets is showing up and showing an warning that i dont know how to get rid of it ok ok1

raix
raix

Theres a pull-request fixing this #11752 should get released in 5.0.1

Activity icon
issue

raix issue comment facebook/create-react-app

raix
raix

Is this the bug of react-error-overlay?

Describe the bug

When I change the code and emit the hot-reload, there is iframe cover the whole page and report Uncaught ReferenceError: process is not defined.

image

image

image

image

Did you try recovering your dependencies?

Yes. It wasn't happened before I recover my dependencies. After I recover my dependencies(remove node_module / package-lock.json and reinstall the dependencies), the problem has been there.

Which terms did you search for in User Guide?

Uncaught ReferenceError: process is not defined hot-reload webpackHotDevClient "win32"===process.platform

Environment

Environment Info:

current version of create-react-app: 4.0.3 running from /Users/xxx/.config/yarn/global/node_modules/create-react-app

System: OS: macOS Mojave 10.14.3 CPU: (8) x64 Intel(R) Core(TM) i7-4870HQ CPU @2.50GHz Binaries: Node: 11.6.0 - /usr/local/bin/node Yarn: 1.22.17 - /usr/local/bin/yarn npm: 6.5.0 - /usr/local/bin/npm Browsers: Chrome: 96.0.4664.110 Edge: Not Found Firefox: 94.0.2 Safari: 12.0.3 npmPackages: react: 16.12.0 => 16.12.0 react-dom: 16.12.0 => 16.12.0 react-scripts: ^4.0.3 => 4.0.3 npmGlobalPackages: create-react-app: Not Found

(paste the output of the command here.)

Steps to reproduce

  1. Reinstall the node_modules.
  2. npm start
  3. Change some code(maybe less) and error has been there.

Expected behavior

Console will not report the Uncaught ReferenceError: process is not defined and there is no iframe cover the page.

Actual behavior

Console reports the Uncaught ReferenceError: process is not defined and there is the iframe cover the page.

Reproducible demo

I will try to reproduce the demo later when I'm free, report the problem at first.

raix
raix

Theres a pull-request fixing this issue - will be released in 5.0.1 patch version

pull request

raix pull request facebook/create-react-app

raix
raix

V5 fix react error overlay build

Webpack 5 removes the automatic polyfill of NodeJS global "process", this pr adds process fallback as empty object.

Aditionally:

  • Updated Webpack
  • Updated react-error-overlay build script to use Webpack 5 compiler (in v5 the compiler needs to be closed)
  • Updated webpack configs for react-error-overlay

Fixes #11773

Previous