return

return

Member Since 7 years ago

London, UK

Experience Points
49
follower
Lessons Completed
18
follow
Lessons Completed
808
stars
Best Reply Awards
69
repos

6 contributions in the last year

Pinned
⚡ Authenticated and encrypted API tokens written in Rust. A secure JWT alternative.
⚡ My patches for the Swift Programming Language port to the Haiku Operating System (Now upstreamed)
⚡ Google Summer of Code repository for building Swift 3.1, 4.x and higher for Haiku.
⚡ Golang bootstrap compiler for the Haiku Operating System. For compiling, see the wiki
⚡ A Malbolge implementation and interpreter in Rust.
⚡ The Haiku operating system. (Pull requests will be ignored; patches may be sent to https://review.haiku-os.org).
Activity
Nov
8
4 weeks ago
push

return push golang-haiku/go

return
return

test/codegen: remove broken riscv64 test

This test is not executed by default (see #48247) and does not actually pass. It was added in CL 346689. The code generation changes made in that CL only change how instructions are assembled, they do not actually affect the output of the compiler. This test is unfortunately therefore invalid and will never pass.

Updates #48247.

Change-Id: I0c807e4a111336e5a097fe4e3af2805f9932a87f Reviewed-on: https://go-review.googlesource.com/c/go/+/348390 Trust: Michael Munday [email protected] Run-TryBot: Michael Munday [email protected] Reviewed-by: Cherry Mui [email protected] TryBot-Result: Go Bot [email protected]

return
return

test/codegen: fix compilation of bitfield tests

The codegen tests are currently skipped (see #48247) and the bitfield tests do not actually compile due to a duplicate function name (sbfiz5) added in CL 267602. Renaming the function fixes the issue.

Updates #48247.

Change-Id: I626fd5ef13732dc358e73ace9ddcc4cbb6ae5b21 Reviewed-on: https://go-review.googlesource.com/c/go/+/348391 Trust: Michael Munday [email protected] Run-TryBot: Michael Munday [email protected] TryBot-Result: Go Bot [email protected] Reviewed-by: Cherry Mui [email protected]

return
return

test/codegen: fix package name for test case

The codegen tests are currently skipped (see #48247). The test added in CL 346050 did not compile because it was in the main package but did not contain a main function. Changing the package to 'codegen' fixes the issue.

Updates #48247.

Change-Id: I0a0eaca8e6a7d7b335606d2c76a204ac0c12e6d5 Reviewed-on: https://go-review.googlesource.com/c/go/+/348392 Trust: Michael Munday [email protected] Run-TryBot: Michael Munday [email protected] Reviewed-by: Cherry Mui [email protected] TryBot-Result: Go Bot [email protected]

return
return

cmd/pprof: update vendored github.com/google/pprof

Pull in the latest published version of github.com/google/pprof that is available at this time in the Go 1.18 development cycle.

Done with:

go get -d github.com/google/[email protected]
go mod tidy
go mod vendor

For #36905.

Change-Id: Ib25aa38365ec70a0bed2a8a6527e5823ab9f9ded Reviewed-on: https://go-review.googlesource.com/c/go/+/348410 Trust: Dmitri Shuralyov [email protected] Run-TryBot: Dmitri Shuralyov [email protected] TryBot-Result: Go Bot [email protected] Reviewed-by: Michael Pratt [email protected]

return
return

cmd/compile/internal/types2: handle recursive type parameter constraints

Check type constraints after the respective type parameter list has been associated with a parameterized type so that recursive type parameter constraints "see" a parameterized type.

Fixes #45550. Fixes #47796.

Change-Id: Iac74610ca017a78013820624230c857395506aff Reviewed-on: https://go-review.googlesource.com/c/go/+/348090 Trust: Robert Griesemer [email protected] Reviewed-by: Robert Findley [email protected]

return
return

cmd/compile/internal/types2: reduce number of delayed functions (optimization)

Rather than create and delay execution of a closure for each type parameter in a type parameter list, just create one per type parameter list.

While at it, inline the small amount of code for getting the type constraint and remove the respective function.

Change-Id: I49a00ff0a7b7e43eb53992dd7dbfac25ff23b42c Reviewed-on: https://go-review.googlesource.com/c/go/+/348018 Trust: Robert Griesemer [email protected] Reviewed-by: Robert Findley [email protected]

return
return

cmd/go/internal/modload: scan dependencies of root paths when raising version limits in editRequirements

Fixes #47979

Change-Id: I1d9d854cda1378e20c70e6c6789b77e42e467ca7 Reviewed-on: https://go-review.googlesource.com/c/go/+/347290 Trust: Bryan C. Mills [email protected] Run-TryBot: Bryan C. Mills [email protected] TryBot-Result: Go Bot [email protected] Reviewed-by: Jay Conrod [email protected]

return
return

go/types: implement deduplication of instances using the Environment

Implement deduplication of type instances via the Environment by recording a map of unique IDs for *Named types. This avoids an issue with the existing type hash, where qualified names alone were not sufficient to differentiate two *Named types that have the same fully qualified name but which are distinct pointers. It also allows us to drop the scope accounting for local types.

A subtle bug is also fixed in subst.go, where the instance t was passed to typeHash rather than t.orig.

Change-Id: I85639ccc1c9bfee470babd2fc85375484c8ed0b9 Reviewed-on: https://go-review.googlesource.com/c/go/+/344390 Trust: Robert Findley [email protected] Run-TryBot: Robert Findley [email protected] TryBot-Result: Go Bot [email protected] Reviewed-by: Robert Griesemer [email protected]

return
return

go/types: move typeHash to environment.go

This is a pure code move, with no other changes.

Change-Id: Id31f1f960d3208dc614556de89bf39b7ca77df3a Reviewed-on: https://go-review.googlesource.com/c/go/+/347560 Trust: Robert Findley [email protected] Run-TryBot: Robert Findley [email protected] TryBot-Result: Go Bot [email protected] Reviewed-by: Robert Griesemer [email protected]

return
return

go/types: move NewTypeParam off of Checker

This aligns with the API proposal.

Change-Id: I9967a317196392ffa5ddbe5391d7aba5f6e7bad2 Reviewed-on: https://go-review.googlesource.com/c/go/+/347561 Trust: Robert Findley [email protected] Run-TryBot: Robert Findley [email protected] TryBot-Result: Go Bot [email protected] Reviewed-by: Robert Griesemer [email protected]

return
return

go/ast: rename TParams fields to TypeParams

As discussed in the ast proposal (#47781), there's not really a strong reason to avoid spelling out 'Type'.

Change-Id: I0ba1bf03b112ea60509a78a89a050a302779d9d0 Reviewed-on: https://go-review.googlesource.com/c/go/+/348375 Trust: Robert Findley [email protected] Run-TryBot: Robert Findley [email protected] Reviewed-by: Robert Griesemer [email protected] TryBot-Result: Go Bot [email protected]

return
return

go/types: spell out 'Type' in type parameter APIs

As discussed on the go/types proposal (#47916), we should spell out the word 'Type', rather than using 'T'.

Change-Id: I5f51255eedc07fea61f909b7ecb3093a7fab765e Reviewed-on: https://go-review.googlesource.com/c/go/+/348376 Trust: Robert Findley [email protected] Run-TryBot: Robert Findley [email protected] Reviewed-by: Robert Griesemer [email protected] TryBot-Result: Go Bot [email protected]

return
return

go/types: temporarily pin the Checker to Interface during checking

While type checking expressions involving interface types, it is possible that their type set is used before delayed actions are processed. As a result, computeInterfaceTypeSet is called with a nil checker, and errors in the interface type definition result in panics (see #48234).

To avoid the panics, store a *Checker on Interface for use in between checking of the interface type expression and processing of delayed actions.

Fixes #48234

Change-Id: I5509bc1c01b55edac52446b9e075fbe8fcc01874 Reviewed-on: https://go-review.googlesource.com/c/go/+/348371 Trust: Robert Findley [email protected] Run-TryBot: Robert Findley [email protected] TryBot-Result: Go Bot [email protected] Reviewed-by: Robert Griesemer [email protected]

return
return

cmd/go: improve the creation and editing of go.work files

This change changes go.work files so that directory paths are clearly distinguished from module paths by either being rooted absolute paths or starting with '.' or '..' path elements if they are relative paths. go mod initwork now checks that the go.work file doesn't already exist before creating it, and gomod initwork and gomod editwork look up the module path corresponding to a directory and write it to the directory directive's comment.

For #45713

Change-Id: I6983779059b7de6fc83d359280ceffb263f6b641 Reviewed-on: https://go-review.googlesource.com/c/go/+/347591 Trust: Michael Matloob [email protected] Run-TryBot: Michael Matloob [email protected] TryBot-Result: Go Bot [email protected] Reviewed-by: Jay Conrod [email protected]

return
return

cmd/go: print offending -mod value in workspace mode

Workspace mode only allows -mod to be set to 'readonly'. When returning the error for other values of -mod, specify the the value in the error so it's easier to see what's going on when the go command is invoked through another tool.

For #45713, #48186

Change-Id: I3ba206a71c7a20c18aeccfa48f3c9dc935a180a4 Reviewed-on: https://go-review.googlesource.com/c/go/+/347593 Trust: Michael Matloob [email protected] Trust: Daniel Martí [email protected] Run-TryBot: Michael Matloob [email protected] TryBot-Result: Go Bot [email protected] Reviewed-by: Jay Conrod [email protected] Reviewed-by: Daniel Martí [email protected] Reviewed-by: Bryan C. Mills [email protected]

return
return

[dev.fuzz] internal/fuzz: fix panic when marshaling data

The coordinator needs to marshal data that was provided via f.Add. However, it was also attempting to marshal data that was in testdata, which was not needed, and was causing a panic. This change fixes this.

Fixes golang/go#48228

Change-Id: I1256c5a287b5a09d2f8cca59beb0f0fc06cc3554 Reviewed-on: https://go-review.googlesource.com/c/go/+/348381 Trust: Katie Hockman [email protected] Run-TryBot: Katie Hockman [email protected] Reviewed-by: Jay Conrod [email protected]

return
return

[dev.fuzz] internal/fuzz: only reconstruct inputs when needed on RPC return

If the fuzz RPC finds no error and no new coverage, there's no point in reconstructing the last value.

If the minimize RPC does not succeed in minimizing, either because the error can't be reproduced, or new coverage can't be reproduced, or a new error is found with the input, don't marshal or unmarshal the input. Just use the original.

Change-Id: I3b0f89b8656a2b36066d82efefac0fff4a61fbee Reviewed-on: https://go-review.googlesource.com/c/go/+/347233 Trust: Jay Conrod [email protected] Trust: Katie Hockman [email protected] Run-TryBot: Jay Conrod [email protected] TryBot-Result: Go Bot [email protected] Reviewed-by: Katie Hockman [email protected]

return
return

go/ast: rename MultiIndexExpr to IndexListExpr

As discussed in #47781, IndexListExpr is one character shorter and has the advantage of being next to IndexExpr in documentation.

Updates #47781

Change-Id: I709d5c1a79b4f9aebcd6445e4ab0cd6dae45bab7 Reviewed-on: https://go-review.googlesource.com/c/go/+/348609 Trust: Robert Findley [email protected] Run-TryBot: Robert Findley [email protected] Reviewed-by: Robert Griesemer [email protected] TryBot-Result: Go Bot [email protected]

return
return

cmd/compile/internal/types2: implement deduplication of instances using the Environment

This is a port of CL 344390 with adjustments to names to make it work for types2.

Change-Id: I05c33d9858f973adfbf48d8a1faaf377280f6985 Reviewed-on: https://go-review.googlesource.com/c/go/+/348572 Trust: Robert Griesemer [email protected] Reviewed-by: Robert Findley [email protected]

return
return

cmd/compile/internal/types2: move typeHash to environment.go

This is a clean port of CL 347560.

Change-Id: I0d56f5a818df1a66e603415d5198d909b0aef228 Reviewed-on: https://go-review.googlesource.com/c/go/+/348573 Trust: Robert Griesemer [email protected] Reviewed-by: Robert Findley [email protected]

commit sha: 9e6ad46bccfa7a63e768236bcd1fd54dab38e4d1

push time in 4 weeks ago
push

return push return/malbolge

return
return

Merge pull request #1 from GrpeApple/master

Fix Markdown issues

commit sha: 8a3e8d8f6b43aeaa43250ad807a10de67d8f681d

push time in 4 weeks ago
pull request

return pull request return/malbolge

return
return

Fix Markdown issues

exactly what it says

Oct
16
1 month ago
started
started time in 1 month ago