rnnyrk

rnnyrk

Codesandbox: https://codesandbox.io/u/rnnyrk

Member Since 8 years ago

Label A, Amsterdam, The Netherlands

Experience Points
30
follower
Lessons Completed
34
follow
Lessons Completed
190
stars
Best Reply Awards
26
repos

825 contributions in the last year

Pinned
⚡ A starter kit to create comprehensive React apps with Redux and Styled-Components.
⚡ React Native boilerplate using TypeScript, Styled Components & React Navigation
⚡ Boilerplate for Gatsby websites with Typescript and Styled Components
Activity
Dec
1
2 days ago
push

rnnyrk push react-prime/react-prime

rnnyrk
rnnyrk

Add react-query to webpack core chunk

commit sha: 82c75527dcab67d9611e7ef8c27464b5cdf41d36

push time in 1 day ago
push

rnnyrk push react-prime/react-prime

rnnyrk
rnnyrk

Add notifyOnChangeProps to default query options

rnnyrk
rnnyrk

Add API example to README

commit sha: 35961e1d54848515cc152f075acaebcbf84350cb

push time in 1 day ago
push

rnnyrk push react-prime/react-prime

rnnyrk
rnnyrk

Remove fetcher and add Promise examples in queries

commit sha: a2757f16ff27f1807166bf452007aaa11581a713

push time in 1 day ago
open pull request

rnnyrk wants to merge react-prime/react-prime

rnnyrk
rnnyrk

Migrate to React query

rnnyrk
rnnyrk

What do you think of? staleTime: 30 * 1000, // 30 seconds

push

rnnyrk push react-prime/react-prime

rnnyrk
rnnyrk

Change queryClient staleTime value

commit sha: 68d9e1c988f08e48f1e57d1cdc8e1d54d3b1c87a

push time in 1 day ago
push

rnnyrk push react-prime/react-prime

rnnyrk
rnnyrk

Resolve merge conflicts with master

commit sha: 172dc1bc75f5d36ad25fb8e3665db31324865d29

push time in 1 day ago
push

rnnyrk push react-prime/react-prime

rnnyrk
rnnyrk

Resolve merge conflicts with master

commit sha: f64c4083f8a72f3516be32c82d511466b6627333

push time in 1 day ago
push

rnnyrk push react-prime/react-prime

rnnyrk
rnnyrk

Remove IE11 from browserslist

rnnyrk
rnnyrk
rnnyrk
rnnyrk

Replace deprecated loaders with asset modules

rnnyrk
rnnyrk

Only allow development or production NODE_ENV values

rnnyrk
rnnyrk

Update webpack with new defaults, improved code splitting

Updated the vendor chunk to no longer include literally everything from node_modules. This results in a chunk that is too big. Instead it will now generate a chunk for the essentials of our app that is required on every page: react, redux, styled-components. Everything else is dynamically sorted by Webpack instead.

rnnyrk
rnnyrk
rnnyrk
rnnyrk

Merge pull request #63 from react-prime/maintenance-update

Maintenance + chunks update

rnnyrk
rnnyrk

Update ESLint packages & apply patches

rnnyrk
rnnyrk

Disable 'explicit-module-boundary-types' rule

rnnyrk
rnnyrk

Merge pull request #64 from react-prime/eslint-update

Eslint update

commit sha: e636868a6741e7f760d0df9366ded5c7b55e70c0

push time in 1 day ago
Nov
29
4 days ago
started
started time in 3 days ago
Nov
25
1 week ago
Activity icon
issue

rnnyrk issue comment dividab/tsconfig-paths-webpack-plugin

rnnyrk
rnnyrk

Webpack 5 resolver and duplicate type errors?!

After updating to the latest version I got several errors regarding tsconfig-paths-webpack-plugin. I have no clue how to solve these or what's causing it. Any suggestions? My webpack config is also below

Type 'TsconfigPathsPlugin' is not assignable to type '"..." | ResolvePluginInstance'.
  Type 'TsconfigPathsPlugin' is not assignable to type 'ResolvePluginInstance'.
    Types of property 'apply' are incompatible.
      Type '(resolver: import("/Users/Developer/React/node_modules/tsconfig-paths-webpack-plugin/lib/plugin.temp.types").Resolver) => void' is not assignable to type '(resolver: Resolver) => void'.
        Types of parameters 'resolver' and 'resolver' are incompatible.
          Type 'Resolver' is not assignable to type 'import("/Users/Developer/React/node_modules/tsconfig-paths-webpack-plugin/lib/plugin.temp.types").Resolver'.
            The types of 'options.plugins' are incompatible between these types.
              Type 'Plugin[]' is not assignable to type 'Plugin[]'. Two different types with this name exist, but they are unrelated.
                Type 'Plugin' is not assignable to type 'Plugin'. Two different types with this name exist, but they are unrelated.
                  Type '{ apply: (arg0: Resolver) => void; }' is not assignable to type 'Plugin'.
                    Type '{ apply: (arg0: Resolver) => void; }' is not assignable to type '{ apply: (arg0: import("/Users/Developer/React/node_modules/tsconfig-paths-webpack-plugin/lib/plugin.temp.types").Resolver) => void; }'.
                      Types of property 'apply' are incompatible.
                        Type '(arg0: Resolver) => void' is not assignable to type '(arg0: import("/Users/Developer/React/node_modules/tsconfig-paths-webpack-plugin/lib/plugin.temp.types").Resolver) => void'.
                          Types of parameters 'arg0' and 'arg0' are incompatible.
                            Type 'import("/Users/Developer/React/node_modules/tsconfig-paths-webpack-plugin/lib/plugin.temp.types").Resolver' is not assignable to type 'Resolver'.
                              The types of 'options.plugins' are incompatible between these types.
                                Type 'Plugin[]' is not assignable to type 'Plugin[]'. Two different types with this name exist, but they are unrelated.
                                  Type 'Plugin' is not assignable to type 'Plugin'. Two different types with this name exist, but they are unrelated.
                                    Type '{ apply: (arg0: Resolver) => void; }' is not assignable to type 'Plugin'.

112       new TsconfigPathsPlugin(),
import path from 'path';
import * as webpack from 'webpack';
import * as devServer from 'webpack-dev-server';
import CopyPlugin from 'copy-webpack-plugin';
import webpackMerge from 'webpack-merge';
import HtmlWebpackPlugin from 'html-webpack-plugin';
import TsconfigPathsPlugin from 'tsconfig-paths-webpack-plugin';

const baseConfig: webpack.Configuration = {
  mode: 'production',
  target: 'browserslist',
  output: {
    filename: 'static/js/[name].[contenthash].js',
    path: path.resolve('dist'),
    publicPath: '/',
  },
  entry: path.resolve('src'),
  module: {
    rules: [
      {
        test: /\.tsx?$/,
        exclude: /node_modules/,
        use: 'babel-loader',
      },
      {
        test: /\.css$/,
        use: ['style-loader', 'css-loader'],
      },
    ],
  },
  ....
  resolve: {
    extensions: ['*', '.js', '.jsx', '.ts', '.tsx'],
    plugins: [
      new TsconfigPathsPlugin(),
    ],
  },
};

export default baseConfig;

export type WebpackConfig = webpack.Configuration & { devServer?: devServer.Configuration };
type WebpackMergeType = (...config: WebpackConfig[]) => WebpackConfig;

export const merge: WebpackMergeType = (...config) => webpackMerge(baseConfig, ...config);

rnnyrk
rnnyrk

Still having the same issue with the latest versions. I tried looking at the types, but I can't figure it out myself and create a PR unfortunately. @jonaskello @Brian-McBride any idea maybe?

Nov
24
1 week ago
pull request

rnnyrk pull request react-prime/react-prime-gatsby

rnnyrk
rnnyrk

Remove Gatsby clean from NPM scripts so cache is used

Activity icon
created branch

rnnyrk in react-prime/react-prime-gatsby create branch remove-clean

createdAt 1 week ago
Nov
23
1 week ago
started
started time in 1 week ago
started
started time in 1 week ago
Activity icon
issue

rnnyrk issue comment remix-run/remix

rnnyrk
rnnyrk

[Bug]: npm run dev does not seem to work

Which Remix packages are impacted?

  • remix (Remix core)
  • create-remix
  • @remix-run/architect
  • @remix-run/cloudflare-workers
  • @remix-run/dev
  • @remix-run/express
  • @remix-run/netlify
  • @remix-run/node
  • @remix-run/react
  • @remix-run/serve
  • @remix-run/server-runtime
  • @remix-run/vercel

What version of Remix are you using?

1.0.4

Steps to Reproduce

npx [email protected]

Expected Behavior

localhost:3000 to work

Actual Behavior

terminal shows the tis built successfully but when visiting the url it doesn't

rnnyrk
rnnyrk

Using the default Remix App config for now works indeed. Gonna look into Netlify setup later. Maybe good to somewhere show or link to the extra required step for a different hosting setup. I wasn't aware the default dev script wasn't working when choosing Netlify 😓

Activity icon
issue

rnnyrk issue comment remix-run/remix

rnnyrk
rnnyrk

[Bug]: npm run dev does not seem to work

Which Remix packages are impacted?

  • remix (Remix core)
  • create-remix
  • @remix-run/architect
  • @remix-run/cloudflare-workers
  • @remix-run/dev
  • @remix-run/express
  • @remix-run/netlify
  • @remix-run/node
  • @remix-run/react
  • @remix-run/serve
  • @remix-run/server-runtime
  • @remix-run/vercel

What version of Remix are you using?

1.0.4

Steps to Reproduce

npx [email protected]

Expected Behavior

localhost:3000 to work

Actual Behavior

terminal shows the tis built successfully but when visiting the url it doesn't

rnnyrk
rnnyrk

Same issue over here. Building the project does nothing. Chose Netlify and Typescript from the cli wizard if that helps in any way Screenshot 2021-11-23 at 10 24 31

started
started time in 1 week ago
started
started time in 1 week ago
Nov
15
2 weeks ago
open pull request

rnnyrk wants to merge react-prime/react-prime

rnnyrk
rnnyrk

Maintenance & Webpack loader deprecation fix

  • Updates to the Webpack config files. Maintenance, future deprecation changes and improvement to vendor chunk.
    • vendor chunk is now replaced with a core chunk. Vendor chunk included all node_modules; this is bad practice. This file would include all modules regardless if the page that loaded this chunk needed all modules. The Core chunk now only includes what is required on every page: react and react-related modules, redux and redux-related modules and styled-components. All other modules are now dynamically handled by Webpack.
  • Updated react-router to v6. This has a couple of design and API changes that the other devs will need to read about. The migration guide explains the changes and the thoughts behind the changes very well.
  • Improved NODE_ENV and APP_ENV handling
  • Updated all packages
rnnyrk
rnnyrk

Dat dacht ik al ja, maar was benieuwd naar jou argumentatie. Nice work!

pull request

rnnyrk merge to react-prime/react-prime

rnnyrk
rnnyrk

Maintenance & Webpack loader deprecation fix

  • Updates to the Webpack config files. Maintenance, future deprecation changes and improvement to vendor chunk.
    • vendor chunk is now replaced with a core chunk. Vendor chunk included all node_modules; this is bad practice. This file would include all modules regardless if the page that loaded this chunk needed all modules. The Core chunk now only includes what is required on every page: react and react-related modules, redux and redux-related modules and styled-components. All other modules are now dynamically handled by Webpack.
  • Updated react-router to v6. This has a couple of design and API changes that the other devs will need to read about. The migration guide explains the changes and the thoughts behind the changes very well.
  • Improved NODE_ENV and APP_ENV handling
  • Updated all packages
open pull request

rnnyrk wants to merge react-prime/react-prime

rnnyrk
rnnyrk

Maintenance & Webpack loader deprecation fix

  • Updates to the Webpack config files. Maintenance, future deprecation changes and improvement to vendor chunk.
    • vendor chunk is now replaced with a core chunk. Vendor chunk included all node_modules; this is bad practice. This file would include all modules regardless if the page that loaded this chunk needed all modules. The Core chunk now only includes what is required on every page: react and react-related modules, redux and redux-related modules and styled-components. All other modules are now dynamically handled by Webpack.
  • Updated react-router to v6. This has a couple of design and API changes that the other devs will need to read about. The migration guide explains the changes and the thoughts behind the changes very well.
  • Improved NODE_ENV and APP_ENV handling
  • Updated all packages
rnnyrk
rnnyrk

Ben wel benieuwd waarom je deze change hebt gedaan? Als ik het goed begrijp gaan React, Redux en SC nu in een bundle en komen alle andere packages in een andere chunk?

pull request

rnnyrk merge to react-prime/react-prime

rnnyrk
rnnyrk

Maintenance & Webpack loader deprecation fix

  • Updates to the Webpack config files. Maintenance, future deprecation changes and improvement to vendor chunk.
    • vendor chunk is now replaced with a core chunk. Vendor chunk included all node_modules; this is bad practice. This file would include all modules regardless if the page that loaded this chunk needed all modules. The Core chunk now only includes what is required on every page: react and react-related modules, redux and redux-related modules and styled-components. All other modules are now dynamically handled by Webpack.
  • Updated react-router to v6. This has a couple of design and API changes that the other devs will need to read about. The migration guide explains the changes and the thoughts behind the changes very well.
  • Improved NODE_ENV and APP_ENV handling
  • Updated all packages
Previous