rot1024

rot1024 issue comment reearth/reearth-web

rot1024

rot1024 MEMBER

createdAt 3 days ago

feat: multi widgets

Overview

Up until now, widgets could only have one instance. Also, we were unable to remove a widget (and its data) completely, only disable. This brings both.

What I've done

Added removeWidget mutation for widget deletion
Updated the UI
- Moved enabling toggle to the left panel (shows on hover or selection)
- Add delete button
- Add dropdown of available widgets (from installed plugins)

The dropdown showing installed widgets will grey out widgets that are single-use and already have a single instance. Trying to delete a selected widget will show a confirmation modal before deleting.

What I haven't done

I haven't fixed an issue with the LayerTreeView components where the whole tree will be re-rendered on ANY changes made within (this includes local state). This affects the toggle's transition so it doesn't smoothly move, as well as the widget dropdown is contained within the left panel (where it should come out slightly over Cesium. Also affects the left panel's help balloons) and it will be slightly clipped the first time opening the dropdown.

How I tested

Add/Delete widgets
Enable/disable widgets
Try to add a single-use widget(Storytelling) a second time (should be greyed out)

Screenshot

Which point I want you to review particularly

Memo

rot1024

comment in 3 days ago

This PR should be reviewed by me at least once. Please don't merge this PR until then.

Oct

5 days ago

rot1024

fix error

commit sha： 32f9a2a8a6ae680fd606962b9e24f9a4d5e8d3fe

push time in 4 days ago

rot1024 push rot1024/epubimg

rot1024

upgrade deps

rot1024

support dir

commit sha： e13eeeb6846b59161ee4260a0f191266f8700d20

push time in 4 days ago

rot1024

set default delay

commit sha： 549129c2d95c6ca356dbeacb65e2e1b34ad94a15

push time in 4 days ago

rot1024

add delay option

commit sha： a7c8eee59fedd4fedb94b9d86bb9864b8e87dc13

push time in 4 days ago

rot1024

update depes

rot1024

set up launch.json

rot1024

update api endpoint

rot1024

add indicatif

rot1024

show progress indicator

commit sha： dd1d981f4cd97b0af96145cf16ad822dbfdb604f

push time in 4 days ago

Oct

1 week ago

rot1024 push reearth/reearth

rot1024

add a comitter

commit sha： 4518f91bc39e1f2561b2ef3f046bff07655181fd

push time in 1 week ago

rot1024 merge to reearth/reearth-backend

rot1024

rot1024 MEMBER

feat: add singleOnly to extension

Overview

Added new field singleOnly to plugin extensions so that we can limit extension use when an extension will break with more than one instance (ie. builtin Storytelling or Splashscreen widgets).

rot1024

rot1024 MEMBER

submittedAt 1 week ago

rot1024 merge to reearth/resium

rot1024

rot1024 NONE

fix: EntityDescription is not displayed on the first time entity selection

HI Resium Team,

This is Ash. I enjoyed using Resium for a while and it is an amazing library. I found this bug (same with #512 ) that is affecting the display logic of EntityDescription ( It won't show when you click on the first clickable entity. Even in the examples you gave, you can easily notice this bug.). You can find the detailed explanation I gave in issue #512 . And I was just provided one approach for solving this bug. Feel free to reach out! I hope it helps!

Ash

rot1024

rot1024 MEMBER

submittedAt 1 week ago

Thank you for PR.

I tried your code at storybook (Entity/Description) but it doesn't seem to have necessarily been resolved the issue. It seems that there are cases where the infobox does not continue to appear.

open pull request

rot1024 wants to merge reearth/resium

rot1024

rot1024 NONE

fix: EntityDescription is not displayed on the first time entity selection

HI Resium Team,

Ash

rot1024

comment in 1 week ago

Follow Prettier:

          // remove cesium-infoBox-bodyless class
          viewer.infoBox.container
            .querySelector(".cesium-infoBox.cesium-infoBox-bodyless")
            ?.classList.remove("cesium-infoBox-bodyless");

rot1024 merge to reearth/resium

rot1024

rot1024 NONE

fix: EntityDescription is not displayed on the first time entity selection

HI Resium Team,

Ash

rot1024

rot1024 MEMBER

submittedAt 1 week ago

Thank you for PR.

I tried your code at storybook (Entity/Description) but it doesn't seem to have necessarily been resolved the issue. It seems that there are cases where the infobox does not continue to appear.

rot1024 issue reearth/resium

rot1024

rot1024 NONE

Example Codes not showing in resium gh-pages.

I was trying to learn resium from the example codes but they aren't showing anything.

rot1024 issue comment reearth/resium

rot1024

rot1024 NONE

https://resium.reearth.io/examples/

Example Codes not showing in resium gh-pages.

I was trying to learn resium from the example codes but they aren't showing anything.

rot1024

comment in 1 week ago

It works

rot1024 push reearth/reearth-web

rot1024

feat: add a fallback icon for extensions that do not have an icon (#98)

commit sha： 50de1f218c720ba86eaba84d2e7c1df8f94b2a20

push time in 1 week ago

delete

rot1024 in reearth/reearth-web delete branch feat/fallback-plugin-icon

deleted time in 1 week ago

rot1024 pull request reearth/reearth-web

rot1024

rot1024 MEMBER

feat: add a fallback icon for extensions that do not have an icon

Oct

1 week ago

rot1024 pull request reearth/reearth-web

rot1024

rot1024 MEMBER

feat: add a fallback icon for extensions that do not have an icon

created branch

rot1024 in reearth/reearth-web create branch feat/fallback-plugin-icon

createdAt 1 week ago

Oct

1 week ago

started

rot1024 started yomorun/yomo

started time in 1 week ago

started

rot1024 started second-state/rustwasmc

started time in 1 week ago

started

rot1024 started WasmEdge/WasmEdge

started time in 1 week ago

rot1024 issue comment reearth/quickjs-emscripten-sync

rot1024

rot1024 NONE

Support for async/Promises

Hey there,

I've had a blast using your library but noticed promises don't really work (resolving them inside QuickJS). Is there a limitation on this, or is it possible to use them?

Thanks

Error for reference: TypeError: Promise.prototype.then called on incompatible Proxy

rot1024

comment in 1 week ago

Promise is currently not supported; Promsie is a special object and needs to be verified to work well, including how asynchronous processing between different runtimes should be implemented.　

rot1024 push reearth/reearth-web

rot1024

fix: export pane is not displayed

commit sha： 58ceda411942e9ae82303cd3bdcf56a390c43016

push time in 1 week ago

rot1024 push reearth/reearth-web

rot1024