Note that ci prefix cannot be used for this PR
Pinned
Activity
rot1024 wants to merge reearth/reearth-web
feat: Add scene property overriding to Re:Earth API
Overview
closes reearth/reearth#276
To extend the abilities and possibilities of plugin development, the scene property is able to be overridden by a plugin (ex. for Cesium, skybox can be triggered, atmospheric conditions can be changed, etc by plugins).
What I've done
Added a overrideProperty
method to ReEarth API. This allows plugins to target specific scene property fields and modify them ephemerally (temporarily).
Now do a merge to sceneProperty. If no overriddenSceneProperty, will return the project's sceneProperty. If something is overridden, it'll merge into the project's.
How I tested
- Changed multiple scene property fields successfully from the api
a2,
Already cloned
rot1024 merge to reearth/reearth-web
feat: Add scene property overriding to Re:Earth API
Overview
closes reearth/reearth#276
To extend the abilities and possibilities of plugin development, the scene property is able to be overridden by a plugin (ex. for Cesium, skybox can be triggered, atmospheric conditions can be changed, etc by plugins).
What I've done
Added a overrideProperty
method to ReEarth API. This allows plugins to target specific scene property fields and modify them ephemerally (temporarily).
Now do a merge to sceneProperty. If no overriddenSceneProperty, will return the project's sceneProperty. If something is overridden, it'll merge into the project's.
How I tested
- Changed multiple scene property fields successfully from the api
Note that ci prefix cannot be used for this PR
rot1024 push reearth/reearth-web
commit sha: 7a11b30105c0cf695994a607fc7e870d003760bb
push time in 2 days agorot1024 pull request reearth/reearth-web
fix: plugin API cameramove event is not emitted in published pages
rot1024 issue reearth/reearth
cameramove plugin event does not emmit in published projects
Describe the bug cameramove plugin event does not emit in published projects
To Reproduce Steps to reproduce the behavior:
- Add
cameramove
event to a plugin - install the plugin to a new project
- publish the project
Expected behavior
cameramove
event does not emmit
rot1024 pull request reearth/reearth-web
fix: plugin API cameramove event is not emitted in published pages
rot1024 push reearth/reearth-web
commit sha: 61701bf1503502882dcb2a3ecd8d02f519d08fc8
push time in 3 days agorot1024 in reearth/reearth-web create branch fix-cameramove-event
rot1024 push reearth/reearth-cms
commit sha: d52e2bfd2479dc797523a31da3863d11f9fa3026
push time in 3 days agorot1024 push reearth/reearth-cms
commit sha: 5a403472229ddbe97cdb2134651e2c92b7e0f60c
push time in 3 days agorot1024 push reearth/reearth-cms
commit sha: 0938447c8e45f5cf0b8a47463951b9352125a739
push time in 3 days agorot1024 push reearth/reearth-cms
commit sha: 99778590bf006b826edcab9c152477e89a986df4
push time in 3 days agorot1024 issue reearth/reearth
Fix broken E2E test
Describe the bug
E2E test fails: https://github.com/reearth/reearth-web/actions/workflows/e2e.yml
To Reproduce
Run E2E test: https://github.com/reearth/reearth-web/actions/workflows/e2e.yml
Expected behavior
E2E test passes
Screenshots
rot1024 push reearth/docs.reearth.io
commit sha: 47c1e96248e01c66b25a3f584766ba6ebb704e41
push time in 6 days agorot1024 merge to reearth/reearth-backend
fix: createTagItem mutation
Overview
add new method "addItem" to tag group
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo
rot1024 merge to reearth/reearth-backend
chore: update go modules
Overview
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo
rot1024 merge to reearth/reearth-web
ci: Add scene property overriding to Re:Earth API
Overview
closes reearth/reearth#276
To extend the abilities and possibilities of plugin development, the scene property is able to be overridden by a plugin (ex. for Cesium, skybox can be triggered, atmospheric conditions can be changed, etc by plugins).
What I've done
Added a overrideProperty
method to ReEarth API. This allows plugins to target specific scene property fields and modify them ephemerally (temporarily).
Now do a merge to sceneProperty. If no overriddenSceneProperty, will return the project's sceneProperty. If something is overridden, it'll merge into the project's.
How I tested
- Changed multiple scene property fields successfully from the api
rot1024 wants to merge reearth/reearth-web
ci: Add scene property overriding to Re:Earth API
Overview
closes reearth/reearth#276
To extend the abilities and possibilities of plugin development, the scene property is able to be overridden by a plugin (ex. for Cesium, skybox can be triggered, atmospheric conditions can be changed, etc by plugins).
What I've done
Added a overrideProperty
method to ReEarth API. This allows plugins to target specific scene property fields and modify them ephemerally (temporarily).
Now do a merge to sceneProperty. If no overriddenSceneProperty, will return the project's sceneProperty. If something is overridden, it'll merge into the project's.
How I tested
- Changed multiple scene property fields successfully from the api
@KaWaite OK, It is better to keep the override property for each plugin and merge them in one batch.
const [overriddenSceneProperty, overrideSceneProperty] = useState({});
->
const [overriddenSceneProperty, overrideSceneProperty] = useState<{ [pluginId: string]: any }>({});
const handleScenePropertyOverride = useCallback((property: any) => {
overrideSceneProperty(property);
}, []);
->
const handleScenePropertyOverride = useCallback((pluginId: string, property: any) => {
overrideSceneProperty(p => (pluginId && property ? { ...p, [pluginId]: property } : omit(p, pluginId));
}, []);
omit is lodash function
const mergedSceneProperty = useMemo(() => {
return mergeProperty(sceneProperty, overriddenSceneProperty)
}, [sceneProperty, overriddenSceneProperty]);
->
const mergedSceneProperty = useMemo(() => {
return Object.values(overriddenSceneProperty).reduce((p, v) => mergeProperty(p, v), sceneProperty);
}, [sceneProperty, overriddenSceneProperty]);
rot1024 push reearth/reearth-web
commit sha: 06b563e926e8622f7f7b9871476d0ec192bcf62a
push time in 1 week agorot1024 pull request reearth/reearth-web
chore: update dependency cesium to ^1.93.0
This PR contains the following updates:
Package | Change | Age | Adoption | Passing | Confidence |
---|---|---|---|---|---|
cesium (source) | ^1.92.0 -> ^1.93.0 |
Configuration
📅 Schedule: "before 3:00 am on the 4th day of the month" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
- If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.
This PR has been generated by WhiteSource Renovate. View repository job log here.
rot1024 merge to reearth/reearth-web
ci: Add scene property overriding to Re:Earth API
Overview
closes reearth/reearth#276
To extend the abilities and possibilities of plugin development, the scene property is able to be overridden by a plugin (ex. for Cesium, skybox can be triggered, atmospheric conditions can be changed, etc by plugins).
What I've done
Added a overrideProperty
method to ReEarth API. This allows plugins to target specific scene property fields and modify them ephemerally (temporarily).
Now do a merge to sceneProperty. If no overriddenSceneProperty, will return the project's sceneProperty. If something is overridden, it'll merge into the project's.
How I tested
- Changed multiple scene property fields successfully from the api
- Define
mergeProperty
function atVIsualizer/util.ts
and then use it atVisualzier/hooks.ts
andVisualizer/Primitive/index.tsx
. Otherwise if we have to change multiple parts of the system when changes are needed, I'm sure we'll forget to fix one of them. -
overriddenSceneProperty
should just keep an object passed from plugins as is instead of the merged result to simplify implementation.
rot1024 merge to reearth/reearth-web
ci: Add scene property overriding to Re:Earth API
Overview
closes reearth/reearth#276
To extend the abilities and possibilities of plugin development, the scene property is able to be overridden by a plugin (ex. for Cesium, skybox can be triggered, atmospheric conditions can be changed, etc by plugins).
What I've done
Added a overrideProperty
method to ReEarth API. This allows plugins to target specific scene property fields and modify them ephemerally (temporarily).
Now do a merge to sceneProperty. If no overriddenSceneProperty, will return the project's sceneProperty. If something is overridden, it'll merge into the project's.
How I tested
- Changed multiple scene property fields successfully from the api
- Define
mergeProperty
function atVIsualizer/util.ts
and then use it atVisualzier/hooks.ts
andVisualizer/Primitive/index.tsx
-
overriddenSceneProperty
should just keep an object passed from plugins as is instead of the merged result to simplify implementation.
feat: Add scene property overriding to Re:Earth API
Overview
closes reearth/reearth#276
To extend the abilities and possibilities of plugin development, the scene property is able to be overridden by a plugin (ex. for Cesium, skybox can be triggered, atmospheric conditions can be changed, etc by plugins).
What I've done
Added a
overrideProperty
method to ReEarth API. This allows plugins to target specific scene property fields and modify them ephemerally (temporarily). Now do a merge to sceneProperty. If no overriddenSceneProperty, will return the project's sceneProperty. If something is overridden, it'll merge into the project's.How I tested