rot1024

rot1024

JavaScript / TypeScript / Node.js / Go / Rust

Member Since 8 years ago

Japan

Experience Points
46
follower
Lessons Completed
31
follow
Lessons Completed
1.8k
stars
Best Reply Awards
28
repos

1658 contributions in the last year

Pinned
⚡ Free, open, highly extensible WebGIS platform
⚡ React components for 🌏 Cesium
⚡ ニコニコ風実況アプリ(メンテナンス停止中)
Activity
Oct
12
4 days ago
Activity icon
issue

rot1024 issue comment reearth/reearth-web

rot1024
rot1024

feat: multi widgets

Overview

Up until now, widgets could only have one instance. Also, we were unable to remove a widget (and its data) completely, only disable. This brings both.

What I've done

  • Added removeWidget mutation for widget deletion
  • Updated the UI
    • Moved enabling toggle to the left panel (shows on hover or selection)
    • Add delete button
    • Add dropdown of available widgets (from installed plugins)

The dropdown showing installed widgets will grey out widgets that are single-use and already have a single instance. Trying to delete a selected widget will show a confirmation modal before deleting.

What I haven't done

I haven't fixed an issue with the LayerTreeView components where the whole tree will be re-rendered on ANY changes made within (this includes local state). This affects the toggle's transition so it doesn't smoothly move, as well as the widget dropdown is contained within the left panel (where it should come out slightly over Cesium. Also affects the left panel's help balloons) and it will be slightly clipped the first time opening the dropdown.

How I tested

  • Add/Delete widgets
  • Enable/disable widgets
  • Try to add a single-use widget(Storytelling) a second time (should be greyed out)

Screenshot

Screen Shot 2021-10-11 at 13 11 14 Screen Shot 2021-10-11 at 13 11 21 Screen Shot 2021-10-11 at 13 11 29

Which point I want you to review particularly

Memo

rot1024
rot1024

This PR should be reviewed by me at least once. Please don't merge this PR until then.

Oct
8
1 week ago
pull request

rot1024 merge to reearth/reearth-backend

rot1024
rot1024

feat: add singleOnly to extension

Overview

Added new field singleOnly to plugin extensions so that we can limit extension use when an extension will break with more than one instance (ie. builtin Storytelling or Splashscreen widgets).

pull request

rot1024 merge to reearth/resium

rot1024
rot1024

fix: EntityDescription is not displayed on the first time entity selection

HI Resium Team,

This is Ash. I enjoyed using Resium for a while and it is an amazing library. I found this bug (same with #512 ) that is affecting the display logic of EntityDescription ( It won't show when you click on the first clickable entity. Even in the examples you gave, you can easily notice this bug.). You can find the detailed explanation I gave in issue #512 . And I was just provided one approach for solving this bug. Feel free to reach out! I hope it helps!

Ash

rot1024
rot1024

Thank you for PR.

I tried your code at storybook (Entity/Description) but it doesn't seem to have necessarily been resolved the issue. It seems that there are cases where the infobox does not continue to appear.

image

open pull request

rot1024 wants to merge reearth/resium

rot1024
rot1024

fix: EntityDescription is not displayed on the first time entity selection

HI Resium Team,

This is Ash. I enjoyed using Resium for a while and it is an amazing library. I found this bug (same with #512 ) that is affecting the display logic of EntityDescription ( It won't show when you click on the first clickable entity. Even in the examples you gave, you can easily notice this bug.). You can find the detailed explanation I gave in issue #512 . And I was just provided one approach for solving this bug. Feel free to reach out! I hope it helps!

Ash

rot1024
rot1024

Follow Prettier:

          // remove cesium-infoBox-bodyless class
          viewer.infoBox.container
            .querySelector(".cesium-infoBox.cesium-infoBox-bodyless")
            ?.classList.remove("cesium-infoBox-bodyless");
pull request

rot1024 merge to reearth/resium

rot1024
rot1024

fix: EntityDescription is not displayed on the first time entity selection

HI Resium Team,

This is Ash. I enjoyed using Resium for a while and it is an amazing library. I found this bug (same with #512 ) that is affecting the display logic of EntityDescription ( It won't show when you click on the first clickable entity. Even in the examples you gave, you can easily notice this bug.). You can find the detailed explanation I gave in issue #512 . And I was just provided one approach for solving this bug. Feel free to reach out! I hope it helps!

Ash

rot1024
rot1024

Thank you for PR.

I tried your code at storybook (Entity/Description) but it doesn't seem to have necessarily been resolved the issue. It seems that there are cases where the infobox does not continue to appear.

image

Activity icon
issue

rot1024 issue reearth/resium

rot1024
rot1024

Example Codes not showing in resium gh-pages.

I was trying to learn resium from the example codes but they aren't showing anything.

Activity icon
issue

rot1024 issue comment reearth/resium

rot1024
rot1024

Example Codes not showing in resium gh-pages.

I was trying to learn resium from the example codes but they aren't showing anything.

push

rot1024 push reearth/reearth-web

rot1024
rot1024

feat: add a fallback icon for extensions that do not have an icon (#98)

commit sha: 50de1f218c720ba86eaba84d2e7c1df8f94b2a20

push time in 1 week ago
Activity icon
delete

rot1024 in reearth/reearth-web delete branch feat/fallback-plugin-icon

deleted time in 1 week ago
pull request

rot1024 pull request reearth/reearth-web

rot1024
rot1024

feat: add a fallback icon for extensions that do not have an icon

image image

Oct
7
1 week ago
pull request

rot1024 pull request reearth/reearth-web

rot1024
rot1024

feat: add a fallback icon for extensions that do not have an icon

image image

Activity icon
created branch

rot1024 in reearth/reearth-web create branch feat/fallback-plugin-icon

createdAt 1 week ago
Oct
6
1 week ago
started
started time in 1 week ago
started
started time in 1 week ago
started
started time in 1 week ago
Activity icon
issue

rot1024 issue comment reearth/quickjs-emscripten-sync

rot1024
rot1024

Support for async/Promises

Hey there,

I've had a blast using your library but noticed promises don't really work (resolving them inside QuickJS). Is there a limitation on this, or is it possible to use them?

Thanks

Error for reference: TypeError: Promise.prototype.then called on incompatible Proxy

rot1024
rot1024

Promise is currently not supported; Promsie is a special object and needs to be verified to work well, including how asynchronous processing between different runtimes should be implemented. 

push

rot1024 push reearth/reearth-web

rot1024
rot1024

fix: export pane is not displayed

commit sha: 58ceda411942e9ae82303cd3bdcf56a390c43016

push time in 1 week ago
push

rot1024 push reearth/reearth-web

rot1024
rot1024

fix: storytelling image crop does not work

commit sha: 9c23b3e735ca7dac2e30339aca38530898e516d1

push time in 1 week ago
Activity icon
delete

rot1024 in reearth/reearth-backend delete branch chore/golangcilint-action

deleted time in 1 week ago
pull request

rot1024 pull request reearth/reearth-backend

rot1024
rot1024

chore: use golangci-lint-action

Introduce golangci-lint-action to reduce the execution time of actions

Activity icon
issue

rot1024 issue comment reearth/reearth-backend

rot1024
rot1024

chore: use golangci-lint-action

Introduce golangci-lint-action to reduce the execution time of actions

rot1024
rot1024

golangci-lint-action doesn't seem to work...

pull request

rot1024 pull request reearth/reearth-backend

rot1024
rot1024

chore: use golangci-lint-action

Introduce golangci-lint-action to reduce the execution time of actions

Activity icon
created branch

rot1024 in reearth/reearth-backend create branch chore/golangcilint-action

createdAt 1 week ago
Previous