rot1024

rot1024

JavaScript / TypeScript / Node.js / Go / Rust

Member Since 9 years ago

Japan

Experience Points
52
follower
Lessons Completed
32
follow
Lessons Completed
1.9k
stars
Best Reply Awards
29
repos

1740 contributions in the last year

Pinned
⚡ A free, open and highly extensible WebGIS platform
⚡ React components for 🌏 Cesium
⚡ ニコニコ風実況アプリ(メンテナンス停止中)
Activity
May
23
7 hours ago
pull request

rot1024 merge to reearth/reearth-web

rot1024
rot1024

feat: Add scene property overriding to Re:Earth API

Overview

closes reearth/reearth#276

To extend the abilities and possibilities of plugin development, the scene property is able to be overridden by a plugin (ex. for Cesium, skybox can be triggered, atmospheric conditions can be changed, etc by plugins).

What I've done

Added a overrideProperty method to ReEarth API. This allows plugins to target specific scene property fields and modify them ephemerally (temporarily). Now do a merge to sceneProperty. If no overriddenSceneProperty, will return the project's sceneProperty. If something is overridden, it'll merge into the project's.

How I tested

  • Changed multiple scene property fields successfully from the api
rot1024
rot1024

Note that ci prefix cannot be used for this PR

open pull request

rot1024 wants to merge reearth/reearth-web

rot1024
rot1024

feat: Add scene property overriding to Re:Earth API

Overview

closes reearth/reearth#276

To extend the abilities and possibilities of plugin development, the scene property is able to be overridden by a plugin (ex. for Cesium, skybox can be triggered, atmospheric conditions can be changed, etc by plugins).

What I've done

Added a overrideProperty method to ReEarth API. This allows plugins to target specific scene property fields and modify them ephemerally (temporarily). Now do a merge to sceneProperty. If no overriddenSceneProperty, will return the project's sceneProperty. If something is overridden, it'll merge into the project's.

How I tested

  • Changed multiple scene property fields successfully from the api
rot1024
rot1024
pull request

rot1024 merge to reearth/reearth-web

rot1024
rot1024

feat: Add scene property overriding to Re:Earth API

Overview

closes reearth/reearth#276

To extend the abilities and possibilities of plugin development, the scene property is able to be overridden by a plugin (ex. for Cesium, skybox can be triggered, atmospheric conditions can be changed, etc by plugins).

What I've done

Added a overrideProperty method to ReEarth API. This allows plugins to target specific scene property fields and modify them ephemerally (temporarily). Now do a merge to sceneProperty. If no overriddenSceneProperty, will return the project's sceneProperty. If something is overridden, it'll merge into the project's.

How I tested

  • Changed multiple scene property fields successfully from the api
rot1024
rot1024

Note that ci prefix cannot be used for this PR

May
20
3 days ago
started
started time in 2 days ago
push

rot1024 push reearth/reearth-web

rot1024
rot1024

fix: plugin API cameramove event is not emitted in published pages (#227)

commit sha: 7a11b30105c0cf695994a607fc7e870d003760bb

push time in 2 days ago
Activity icon
delete

rot1024 in reearth/reearth-web delete branch fix-cameramove-event

deleted time in 2 days ago
pull request

rot1024 pull request reearth/reearth-web

rot1024
rot1024

fix: plugin API cameramove event is not emitted in published pages

close https://github.com/reearth/reearth/issues/297

Activity icon
issue

rot1024 issue reearth/reearth

rot1024
rot1024

cameramove plugin event does not emmit in published projects

Describe the bug cameramove plugin event does not emit in published projects

To Reproduce Steps to reproduce the behavior:

  1. Add cameramove event to a plugin
  2. install the plugin to a new project
  3. publish the project

Expected behavior cameramove event does not emmit

pull request

rot1024 pull request reearth/reearth-web

rot1024
rot1024

fix: plugin API cameramove event is not emitted in published pages

close https://github.com/reearth/reearth/issues/297

Activity icon
created branch

rot1024 in reearth/reearth-web create branch fix-cameramove-event

createdAt 3 days ago
pull request

rot1024 merge to reearth/reearth-cms

rot1024
rot1024

feat(server): implement memory and mongo infrastructure

May
19
4 days ago
push

rot1024 push reearth/reearth-cms

rot1024
rot1024

Update server/internal/infrastructure/mongo/workspace.go

commit sha: 0938447c8e45f5cf0b8a47463951b9352125a739

push time in 3 days ago
push

rot1024 push reearth/reearth-cms

rot1024
rot1024

Update server/internal/infrastructure/mongo/user.go

commit sha: 99778590bf006b826edcab9c152477e89a986df4

push time in 3 days ago
May
18
5 days ago
Activity icon
issue

rot1024 issue reearth/reearth

rot1024
rot1024

Fix broken E2E test

Describe the bug

E2E test fails: https://github.com/reearth/reearth-web/actions/workflows/e2e.yml

To Reproduce

Run E2E test: https://github.com/reearth/reearth-web/actions/workflows/e2e.yml

Expected behavior

E2E test passes

Screenshots

image

started
started time in 5 days ago
May
17
6 days ago
May
13
1 week ago
pull request

rot1024 merge to reearth/reearth-backend

rot1024
rot1024

fix: createTagItem mutation

Overview

add new method "addItem" to tag group

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

pull request

rot1024 merge to reearth/reearth-backend

rot1024
rot1024

chore: update go modules

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

pull request

rot1024 merge to reearth/reearth-web

rot1024
rot1024

ci: Add scene property overriding to Re:Earth API

Overview

closes reearth/reearth#276

To extend the abilities and possibilities of plugin development, the scene property is able to be overridden by a plugin (ex. for Cesium, skybox can be triggered, atmospheric conditions can be changed, etc by plugins).

What I've done

Added a overrideProperty method to ReEarth API. This allows plugins to target specific scene property fields and modify them ephemerally (temporarily). Now do a merge to sceneProperty. If no overriddenSceneProperty, will return the project's sceneProperty. If something is overridden, it'll merge into the project's.

How I tested

  • Changed multiple scene property fields successfully from the api
open pull request

rot1024 wants to merge reearth/reearth-web

rot1024
rot1024

ci: Add scene property overriding to Re:Earth API

Overview

closes reearth/reearth#276

To extend the abilities and possibilities of plugin development, the scene property is able to be overridden by a plugin (ex. for Cesium, skybox can be triggered, atmospheric conditions can be changed, etc by plugins).

What I've done

Added a overrideProperty method to ReEarth API. This allows plugins to target specific scene property fields and modify them ephemerally (temporarily). Now do a merge to sceneProperty. If no overriddenSceneProperty, will return the project's sceneProperty. If something is overridden, it'll merge into the project's.

How I tested

  • Changed multiple scene property fields successfully from the api
rot1024
rot1024

@KaWaite OK, It is better to keep the override property for each plugin and merge them in one batch.

const [overriddenSceneProperty, overrideSceneProperty] = useState({});

->

const [overriddenSceneProperty, overrideSceneProperty] = useState<{ [pluginId: string]: any }>({});

const handleScenePropertyOverride = useCallback((property: any) => {
  overrideSceneProperty(property);
}, []);

->

const handleScenePropertyOverride = useCallback((pluginId: string, property: any) => {
  overrideSceneProperty(p => (pluginId && property ? { ...p, [pluginId]: property } : omit(p, pluginId));
}, []);

omit is lodash function


const mergedSceneProperty = useMemo(() => {
    return mergeProperty(sceneProperty, overriddenSceneProperty)
  }, [sceneProperty, overriddenSceneProperty]);

->

const mergedSceneProperty = useMemo(() => {
    return Object.values(overriddenSceneProperty).reduce((p, v) => mergeProperty(p, v), sceneProperty);
  }, [sceneProperty, overriddenSceneProperty]);
push

rot1024 push reearth/reearth-web

rot1024
rot1024

chore: update dependency cesium to ^1.93.0 (#216)

Co-authored-by: Renovate Bot [email protected] Co-authored-by: KaWaite [email protected] Co-authored-by: rot1024 [email protected]

commit sha: 06b563e926e8622f7f7b9871476d0ec192bcf62a

push time in 1 week ago
Activity icon
delete

rot1024 in reearth/reearth-web delete branch renovate/cesium

deleted time in 1 week ago
pull request

rot1024 pull request reearth/reearth-web

rot1024
rot1024

chore: update dependency cesium to ^1.93.0

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
cesium (source) ^1.92.0 -> ^1.93.0 age adoption passing confidence

Configuration

📅 Schedule: "before 3:00 am on the 4th day of the month" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by WhiteSource Renovate. View repository job log here.

pull request

rot1024 merge to reearth/reearth-web

rot1024
rot1024

ci: Add scene property overriding to Re:Earth API

Overview

closes reearth/reearth#276

To extend the abilities and possibilities of plugin development, the scene property is able to be overridden by a plugin (ex. for Cesium, skybox can be triggered, atmospheric conditions can be changed, etc by plugins).

What I've done

Added a overrideProperty method to ReEarth API. This allows plugins to target specific scene property fields and modify them ephemerally (temporarily). Now do a merge to sceneProperty. If no overriddenSceneProperty, will return the project's sceneProperty. If something is overridden, it'll merge into the project's.

How I tested

  • Changed multiple scene property fields successfully from the api
rot1024
rot1024
  • Define mergeProperty function at VIsualizer/util.ts and then use it at Visualzier/hooks.ts and Visualizer/Primitive/index.tsx. Otherwise if we have to change multiple parts of the system when changes are needed, I'm sure we'll forget to fix one of them.
  • overriddenSceneProperty should just keep an object passed from plugins as is instead of the merged result to simplify implementation.
pull request

rot1024 merge to reearth/reearth-web

rot1024
rot1024

ci: Add scene property overriding to Re:Earth API

Overview

closes reearth/reearth#276

To extend the abilities and possibilities of plugin development, the scene property is able to be overridden by a plugin (ex. for Cesium, skybox can be triggered, atmospheric conditions can be changed, etc by plugins).

What I've done

Added a overrideProperty method to ReEarth API. This allows plugins to target specific scene property fields and modify them ephemerally (temporarily). Now do a merge to sceneProperty. If no overriddenSceneProperty, will return the project's sceneProperty. If something is overridden, it'll merge into the project's.

How I tested

  • Changed multiple scene property fields successfully from the api
rot1024
rot1024
  • Define mergeProperty function at VIsualizer/util.ts and then use it at Visualzier/hooks.ts and Visualizer/Primitive/index.tsx
  • overriddenSceneProperty should just keep an object passed from plugins as is instead of the merged result to simplify implementation.
Previous